You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/31 06:22:20 UTC
[PR] fix(pyamber): isolate tuple copy storage [texera]
carloea2 opened a new pull request, #8271:
URL: https://github.com/apache/texera/pull/8271
### What changes were proposed in this PR?
Give a tuple constructed from another tuple its own shallow field mapping. The initial field values remain the same, but later assignments no longer mutate the other tuple.
### Any related issues, documentation, discussions?
Closes #8270
### How was this PR tested?
The untouched live probe reported `original_x=2`, `derived_x=2`, and `same_storage=True` after editing only the derived tuple. After the fix, independent edits remain isolated and `same_storage=False`.
`C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import sys,pytest; sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\investigate-bug71\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python']; raise SystemExit(pytest.main([r'amber/src/test/python/core/models/test_tuple.py','-q','-k','not test_hash','-p','no:cacheprovider']))"`
Result: 102 passed and 2 deselected. The excluded upstream Windows timestamp hash tests are covered by PR #8174.
`C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe check amber/src/main/python amber/src/test/python`
`C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe format --check amber/src/main/python/core/models/tuple.py amber/src/test/python/core/models/test_tuple.py`
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): isolate tuple copy storage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8271:
URL: https://github.com/apache/texera/pull/8271#issuecomment-5474558449
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/python/core/models/tuple.py`, `amber/src/test/python/core/models/test_tuple.py`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33363927854)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): isolate tuple copy storage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8271:
URL: https://github.com/apache/texera/pull/8271#issuecomment-5474607651
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 4 better · 🔴 1 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `50321e4` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33363941663)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 443 | 0.27 | 22,152/29,495/29,495 us | 🟢 -23.1% / 🔴 +99.5% |
| 🟢 | bs=100 sw=10 sl=64 | 921 | 0.562 | 106,782/119,205/119,205 us | 🟢 -21.8% / 🔴 +18.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,065 | 0.65 | 937,693/1,018,121/1,018,121 us | ⚪ within ±5% / 🔴 +5.2% |
<details><summary>Baseline details</summary>
Latest main `50321e4` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 443 tuples/sec | 455 tuples/sec | 844.57 tuples/sec | -2.6% | -47.5% |
| bs=10 sw=10 sl=64 | MB/s | 0.27 MB/s | 0.277 MB/s | 0.515 MB/s | -2.5% | -47.6% |
| bs=10 sw=10 sl=64 | p50 | 22,152 us | 18,970 us | 11,837 us | +16.8% | +87.1% |
| bs=10 sw=10 sl=64 | p95 | 29,495 us | 38,380 us | 14,788 us | -23.1% | +99.5% |
| bs=10 sw=10 sl=64 | p99 | 29,495 us | 38,380 us | 17,651 us | -23.1% | +67.1% |
| bs=100 sw=10 sl=64 | throughput | 921 tuples/sec | 901 tuples/sec | 1,084 tuples/sec | +2.2% | -15.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.562 MB/s | 0.55 MB/s | 0.662 MB/s | +2.2% | -15.1% |
| bs=100 sw=10 sl=64 | p50 | 106,782 us | 105,690 us | 94,505 us | +1.0% | +13.0% |
| bs=100 sw=10 sl=64 | p95 | 119,205 us | 152,482 us | 100,941 us | -21.8% | +18.1% |
| bs=100 sw=10 sl=64 | p99 | 119,205 us | 152,482 us | 108,642 us | -21.8% | +9.7% |
| bs=1000 sw=10 sl=64 | throughput | 1,065 tuples/sec | 1,082 tuples/sec | 1,119 tuples/sec | -1.6% | -4.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.65 MB/s | 0.66 MB/s | 0.683 MB/s | -1.5% | -4.9% |
| bs=1000 sw=10 sl=64 | p50 | 937,693 us | 920,960 us | 924,404 us | +1.8% | +1.4% |
| bs=1000 sw=10 sl=64 | p95 | 1,018,121 us | 979,214 us | 967,785 us | +4.0% | +5.2% |
| bs=1000 sw=10 sl=64 | p99 | 1,018,121 us | 979,214 us | 995,630 us | +4.0% | +2.3% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,451.83,200,128000,443,0.270,22151.63,29495.42,29495.42
1,100,10,64,20,2171.88,2000,1280000,921,0.562,106781.73,119204.80,119204.80
2,1000,10,64,20,18781.79,20000,12800000,1065,0.650,937693.15,1018121.08,1018121.08
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): isolate tuple copy storage [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8271:
URL: https://github.com/apache/texera/pull/8271#issuecomment-5474586301
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8271?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.38%. Comparing base ([`50321e4`](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6f57e9e`](https://app.codecov.io/gh/apache/texera/commit/6f57e9e8853f8b70d0d4792f345a0742c1d63af9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8271 +/- ##
============================================
- Coverage 93.93% 93.38% -0.56%
Complexity 4761 4761
============================================
Files 1191 1189 -2
Lines 48308 47922 -386
Branches 5377 5377
============================================
- Hits 45378 44751 -627
- Misses 1495 1736 +241
Partials 1435 1435
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.02% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.41% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `93.07% <100.00%> (-5.80%)` | :arrow_down: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [50321e4](https://app.codecov.io/gh/apache/texera/commit/50321e403c82df299a13deb50a7f9849dd93bdba?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8271?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): isolate tuple copy storage [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8271:
URL: https://github.com/apache/texera/pull/8271#issuecomment-5474558447
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@eugenegujing`, `@aglinxinyuan`
You can notify them by mentioning `@eugenegujing`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org