[GitHub] [spark] itholic commented on a diff in pull request #40722: [SPARK-43076][PS][CONNECT] Removing the dependency on `grpcio` when remote session is not used.

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1168230741


##########
python/pyspark/pandas/data_type_ops/base.py:
##########
@@ -474,16 +473,26 @@ def eq(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:
         else:
             from pyspark.pandas.base import column_op
 
-            Column = ConnectColumn if is_remote() else PySparkColumn
-            return column_op(cast(Callable[..., GenericColumn], Column.__eq__))(left, right)
+            if is_remote():
+                from pyspark.sql.connect.column import Column as ConnectColumn
+
+                Column = ConnectColumn
+            else:
+                Column = PySparkColumn  # type: ignore[assignment]
+            return column_op(Column.__eq__)(left, right)  # type: ignore[arg-type]

Review Comment:
   Sure. Just created ticket for address this one: SPARK-43159



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org