You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "abh1sar (via GitHub)" <gi...@apache.org> on 2025/09/25 14:35:18 UTC
[PR] Shared Filesystem support on Config Drive Networks [cloudstack]
abh1sar opened a new pull request, #11726:
URL: https://github.com/apache/cloudstack/pull/11726
### Description
This PR fixes #10315
This will require a new systemvmtemplate.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Before fix on config drive :
<img width="734" height="416" alt="Screenshot 2025-09-25 at 8 01 45 PM" src="https://github.com/user-attachments/assets/8e240627-3127-4034-899f-66552ee91b60" />
After fix on config drive :
<img width="734" height="416" alt="Screenshot 2025-09-25 at 8 02 17 PM" src="https://github.com/user-attachments/assets/2b658dbe-8246-4a5a-a217-158608d8c0c1" />
<img width="734" height="416" alt="Screenshot 2025-09-25 at 8 03 15 PM" src="https://github.com/user-attachments/assets/856371c2-bfad-42b1-9fd2-436cd2d72f72" />
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 merged PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3356128486
> > lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.
>
> @vishesh92 thanks for the testing
> just to confirm, you tested with a new systemvm template, right ?
Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3335110108
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3356226546
> > > lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.
> >
> >
> > @vishesh92 thanks for the testing
> > just to confirm, you tested with a new systemvm template, right ?
>
> Yes. I used the template @abh1sar shared with me for this change. I verified the cloud init configuration changes as well in the sharedfs vm.
great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3334529202
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11726?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.61%. Comparing base ([`8eb6ddd`](https://app.codecov.io/gh/apache/cloudstack/commit/8eb6ddd920311cc152b591a2e1e16a7598656195?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`63aaf2b`](https://app.codecov.io/gh/apache/cloudstack/commit/63aaf2b5ec5a63548b2afd8d1864bf313ec3904c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 21 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (8eb6ddd) and HEAD (63aaf2b). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (8eb6ddd) | HEAD (63aaf2b) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11726 +/- ##
=============================================
- Coverage 17.39% 3.61% -13.79%
=============================================
Files 5889 442 -5447
Lines 526183 37259 -488924
Branches 64242 6838 -57404
=============================================
- Hits 91542 1347 -90195
+ Misses 424297 35748 -388549
+ Partials 10344 164 -10180
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11726/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.61% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11726/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11726?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3334597458
@abh1sar
are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3334715796
> > @abh1sar
> > are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?
>
> Yes, @weizhouapache
good @abh1sar
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3335107462
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3337722748
<b>[SF] Trillian test result (tid-14441)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11726-t14441-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3334677011
> @abh1sar
> are the 2nd and 3rd sceennshots the results of testing with the new systemvm template ?
Yes, @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3356249922
> great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?
Yes. We will need to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3335074305
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3334719953
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3356123343
> lgtm. tested with an isolated network which uses configdrive for userdata. I could see the mount point in the system VM. Works as expected after the change.
@vishesh92 thanks for the testing
just to confirm, you tested with a new systemvm template, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Shared Filesystem support on Config Drive Networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11726:
URL: https://github.com/apache/cloudstack/pull/11726#issuecomment-3356518707
> > great, do we need to (1) change the systemvm template version to 4.22.0.0 in pom.xml (2) upload systemvm template to https://download.cloudstack.org/systemvm/ (new 4.22 directory) ?
>
> Yes. We will need to do that.
maybe after merge of #11654 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org