[GitHub] [airflow] syedahsn commented on a diff in pull request #27276: Redshift Pause and Resume Operator Refactor

[GitBox <gi...@apache.org>]

syedahsn commented on code in PR #27276:
URL: https://github.com/apache/airflow/pull/27276#discussion_r1005996122


##########
airflow/providers/amazon/aws/hooks/redshift_cluster.py:
##########
@@ -157,7 +157,7 @@ def create_cluster_snapshot(
         )
         return response["Snapshot"] if response["Snapshot"] else None
 
-    def get_cluster_snapshot_status(self, snapshot_identifier: str, cluster_identifier: str):
+    def get_cluster_snapshot_status(self, snapshot_identifier: str):

Review Comment:
   Good point. The reason I removed the `cluster_identifier` is because the `describe_cluster_snapshots` function throws an `InvalidParameterCombination` when both the `cluster_identifier` and `snapshot_identifier` are provided. 
   ```
   botocore.exceptions.ClientError: An error occurred (InvalidParameterCombination) when calling the DescribeClusterSnapshots operation: Cannot specify both a Cluster identifier and a snapshot identifier.
   ```
   I'll add the `cluster_identifier` back to the function definition, and add a deprecation warning to it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org