You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/10/20 20:10:16 UTC
[PR] [SPARK-XXXXX][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
viirya opened a new pull request, #43467:
URL: https://github.com/apache/spark/pull/43467
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch upgrades Apache Commons Crypto to 1.2.0.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently used 1.1.0 is more than 3 years ago (2020-08-28 released).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367500821
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
In the release [notes](https://commons.apache.org/proper/commons-crypto/changes-report.html), it shows the release bumps jaxb-impl from 2.3.6 to 2.3.7. Not sure why jaxb-impl 2.3.6 is not shown before for Apache Commons Crypto 1.1.0 in this manifest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367498424
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
Let me check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367495402
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
Oh, may I ask why this is introduced at 1.2.0 newly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367498996
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
Ok, it is brought by this upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #43467: [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0
URL: https://github.com/apache/spark/pull/43467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367497710
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
I'm not sure if it is brought by Apache Commons Crypto 1.2.0 or it is just not updated. You know something this file is forgot to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773971446
Yes, it has never been supported. However, this does not prevent Apple Silicon from using `JavaCryptoRandom`. The original logic was that as long as either `OpenSslCryptoRandom` or `JavaCryptoRandom` initializes successfully, it would be acceptable. But in 1.2.0, if `OpenSslCryptoRandom` fails to initialize, it directly fails.
I suspect the change in behavior comes from this logic added in 1.2.0: https://github.com/apache/commons-crypto/blob/c5d19d017d96e34a4589736aeb48bc1d59e204a6/src/main/java/org/apache/commons/crypto/random/OpenSslCryptoRandom.java#L62-L72
<img width="633" alt="image" src="https://github.com/apache/spark/assets/1475305/e32602fc-061b-4123-a8e9-3fcc472a37c0">
The `initException` mechanism should be reused here instead of throwing an `RuntimeException`, because `RuntimeException` will also be wrapped into `ExceptionInInitializerError` by Java's own mechanism. This will cause the upper layer in 1.20 to be unable to handle this Error and continue to throw it up, which is the failure we are seeing now.
<img width="914" alt="image" src="https://github.com/apache/spark/assets/1475305/0ebfe296-841c-452c-8aa9-a83ee41775d6">
However, since the `commons-crypto` project cannot be compiled on Apple Silicon, and I currently only have Apple Silicon development machines at hand, I am temporarily unable to verify this guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367500821
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
In the release [notes](https://commons.apache.org/proper/commons-crypto/changes-report.html), it shows the release just bumps jaxb-impl from 2.3.6 to 2.3.7. So 1.1.0 already uses jaxb-impl 2.3.6. Not sure why jaxb-impl 2.3.6 is not shown before for Apache Commons Crypto 1.1.0 in this manifest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773896695
Interesting. According to the replies on [CRYPTO-169](https://issues.apache.org/jira/browse/CRYPTO-169), Commons Crypto has never supported Apple silicon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367500821
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
In the release [notes](https://commons.apache.org/proper/commons-crypto/changes-report.html), it shows the release bumps jaxb-impl from 2.3.6 to 2.3.7. Not sure why jaxb-impl 2.3.6 is not shown before for 1.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1774150288
Thanks. We can wait for 1.2.1 release then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43467:
URL: https://github.com/apache/spark/pull/43467#discussion_r1367500821
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -118,6 +119,7 @@ java-diff-utils/4.12//java-diff-utils-4.12.jar
javassist/3.29.2-GA//javassist-3.29.2-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-impl/2.3.7//jaxb-impl-2.3.7.jar
Review Comment:
In the release [notes](https://commons.apache.org/proper/commons-crypto/changes-report.html), it shows the release just bumps jaxb-impl from 2.3.6 to 2.3.7. Not sure why jaxb-impl 2.3.6 is not shown before for Apache Commons Crypto 1.1.0 in this manifest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773700065
I have tried again, using Crypto 1.2.0 in `RowQueueSuite` on Apple Silicon still results in a test failure:
```
[info] RowQueueSuite:
[info] - in-memory queue (25 milliseconds)
[info] - disk queue (encryption = off) (61 milliseconds)
[info] org.apache.spark.sql.execution.python.RowQueueSuite *** ABORTED *** (130 milliseconds)
[info] java.lang.ExceptionInInitializerError:
[info] at java.base/java.lang.Class.forName0(Native Method)
[info] at java.base/java.lang.Class.forName(Class.java:467)
[info] at org.apache.commons.crypto.utils.ReflectionUtils.getClassByNameOrNull(ReflectionUtils.java:93)
[info] at org.apache.commons.crypto.utils.ReflectionUtils.getClassByName(ReflectionUtils.java:64)
[info] at org.apache.commons.crypto.random.CryptoRandomFactory.getCryptoRandom(CryptoRandomFactory.java:189)
[info] at org.apache.spark.security.CryptoStreamUtils$.createInitializationVector(CryptoStreamUtils.scala:138)
[info] at org.apache.spark.security.CryptoStreamUtils$.createCryptoOutputStream(CryptoStreamUtils.scala:56)
[info] at org.apache.spark.serializer.SerializerManager.$anonfun$wrapForEncryption$3(SerializerManager.scala:151)
[info] at scala.Option.map(Option.scala:242)
[info] at org.apache.spark.serializer.SerializerManager.wrapForEncryption(SerializerManager.scala:151)
[info] at org.apache.spark.sql.execution.python.DiskRowQueue.<init>(RowQueue.scala:119)
[info] at org.apache.spark.sql.execution.python.RowQueueSuite.$anonfun$new$2(RowQueueSuite.scala:72)
[info] at org.apache.spark.sql.execution.python.RowQueueSuite.$anonfun$new$2$adapted(RowQueueSuite.scala:68)
[info] at org.apache.spark.security.EncryptionFunSuite.$anonfun$encryptionTest$2(EncryptionFunSuite.scala:32)
...
[info] Run completed in 1 second, 335 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 0, aborted 1
[info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
[info] *** 1 SUITE ABORTED ***
[error] Error during tests:
[error] org.apache.spark.sql.execution.python.RowQueueSuite
[error] (sql / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1774081676
> Interesting. According to the replies on [CRYPTO-169](https://issues.apache.org/jira/browse/CRYPTO-169), Commons Crypto has never supported Apple silicon.
Fixed: https://github.com/apache/commons-crypto/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1774150903
I discovered a reentrancy issue during the locally testing, I am trying to further fix it ...
https://github.com/apache/commons-crypto/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773710155
Oh, I see. `commons-crypto-1.2.0.jar` only contain x86_64 Mac native library, it doesn't provide pre-built native library for Apple Silicon.
Hmm, but I also checked `commons-crypto-1.1.0.jar` which Spark uses currently. It also doesn't provide native library for Apple Silicon..
But `RowQueueSuite` passes with `commons-crypto-1.1.0` on M1 Mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773713644
It's weird. I will go to open a JIRA ticket [CRYPTO-169](https://issues.apache.org/jira/browse/CRYPTO-169). Close this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45617][BUILD] Upgrade Apache Commons Crypto 1.2.0 [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43467:
URL: https://github.com/apache/spark/pull/43467#issuecomment-1773713705
Thanks @dongjoon-hyun @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org