You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/07/13 06:03:16 UTC
[GitHub] flink pull request #4315: [FLINK-5541] Missing null check for localJar in Fl...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4315
[FLINK-5541] Missing null check for localJar in FlinkSubmitter#submit…
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5541
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4315
----
commit 105ea265b9c565c8036b5a4de3b633885938aeff
Author: zhangminglei <zm...@163.com>
Date: 2017-07-13T06:01:33Z
[FLINK-5541] Missing null check for localJar in FlinkSubmitter#submitTopology
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4315: [FLINK-5541] Missing null check for localJar in Fl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4315
PR had been updated. Please helps to check again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4315
checkstyle violation: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project flink-storm_2.11: You have 1 Checkstyle violation. -> [Help 1]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4315
Oh my gosh, The newest checkstyle is very awesome, it can detect this kinda message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4315
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4315
@tedyu What do you think of this change ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4315
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---