[jira] [Comment Edited] (HBASE-18374) RegionServer Metrics improvements

["Abhishek Singh Chouhan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103389#comment-16103389 ] 

Abhishek Singh Chouhan edited comment on HBASE-18374 at 7/27/17 4:05 PM:
-------------------------------------------------------------------------

The test failures are unrelated. However it looks like we have unstable tests (i ran hadoop.hbase.security.access.TestAccessController3 on branch-1 and the failure is reproducible in a few runs). I'll create a jira for the flakyness if one's not already there. Might be related to HBASE-16488 that went in a couple o days ago from the first look at test failure logs. [~apurtell] Should i go ahead and commit this if there are no objections?


was (Author: abhishek.chouhan):
The test failures are unrelated. However it looks like we have unstable tests (i ran hadoop.hbase.security.access.TestAccessController3 on branch-1 and the failure is reproducible in a few runs). I'll create a jira for the flakyness if one's not already there. Looks to be related to HBASE-16488 that went in a couple o days ago from the first look at test failure logs. [~apurtell] Should i go ahead and commit this if there are no objections?

> RegionServer Metrics improvements
> ---------------------------------
>
>                 Key: HBASE-18374
>                 URL: https://issues.apache.org/jira/browse/HBASE-18374
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 3.0.0
>
>         Attachments: HBASE-18374.branch-1.001.patch, HBASE-18374.branch-1.001.patch, HBASE-18374.master.001.patch, HBASE-18374.master.002.patch, HBASE-18374.master.003.patch
>
>
> At the RS level we have latency metrics for mutate/puts and deletes that are updated per batch (ie. at the end of entire batchop if it contains put/delete update the respective metric) in contrast with append/increment/get metrics that are updated per op. This is a bit ambiguous since the delete and put metrics are updated for multi row mutations that happen to contain a put/delete. We should rename the metric(eg. delete_batch)/add better description. Also we should add metrics for single delete client operations that come through RSRpcServer.mutate path. We should also add metrics for checkAndPut and checkAndDelete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)