[GitHub] [cassandra] maedhroz commented on a diff in pull request #1756: CASSANDRA-17769 4.1 Remove usages of Path#toFile() in the snapshot apparatus

[GitBox <gi...@apache.org>]

maedhroz commented on code in PR #1756:
URL: https://github.com/apache/cassandra/pull/1756#discussion_r930632148


##########
src/java/org/apache/cassandra/io/sstable/SSTableHeaderFix.java:
##########
@@ -301,7 +301,7 @@ void processFileOrDirectory(Path path)
               .filter(p -> {
                   try
                   {
-                      return Descriptor.fromFilenameWithComponent(new File(p.toFile())).right.type == Component.Type.DATA;
+                      return Descriptor.fromFilenameWithComponent(new File(p.toFile())).right.type == Component.Type.DATA; // checkstyle: permit this invocation

Review Comment:
   That looks good. `SSTableHeaderFixTest` passes just fine w/ `new File(p)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org