[jira] [Commented] (MESOS-4981) Framework (re-)register metric counters broken for calls made via scheduler driver

["Fan Du (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221062#comment-15221062 ] 

Fan Du commented on MESOS-4981:
-------------------------------

[~bmahler] & [~vinodkone]

How about not to distinguish {{messages_register_framework}} with {{messages_reregister_framework}} in such strict manner?
Update flow of {{subscribe}} by:
{code}
  1. bump messages_register_framework
  2. Various of sanity check
  3. Newborn framework?
     3a. Add new framework
     3b. Return
  4. Add messages_reregister_framework
  5. Otherwise framework is reregistering
     5a. Updating the framework
     5b. Return
{code}

> Framework (re-)register metric counters broken for calls made via scheduler driver
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-4981
>                 URL: https://issues.apache.org/jira/browse/MESOS-4981
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>            Reporter: Anand Mazumdar
>            Assignee: Fan Du
>              Labels: mesosphere
>
> The counters {{master/messages_register_framework}} and {{master/messages_reregister_framework}} are no longer being incremented after the scheduler driver started sending {{Call}} messages to the master in Mesos 0.23. We should correctly be incrementing these counters for PID based frameworks as was the case previously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)