[jira] [Commented] (IMPALA-11126) impala-shell: Set reasonable timeout for http client

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516147#comment-17516147 ] 

ASF subversion and git services commented on IMPALA-11126:
----------------------------------------------------------

Commit 8e755e757101a85788f8c9dc8f292b471ba0752d in impala's branch refs/heads/master from Abhishek Rawat
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8e755e7 ]

IMPALA-11126: impala-shell: Support configurable socket timeout for http
client

In 'hs2-http' mode, the socket timeout is None, which could cause
hang like symptoms in case of a problematic remote server.

Added support for configurable socket timeout using the new impala-shell
config option '--http_socket_timeout_s'. If a reasonable timeout is
set, impala-shell client can retry in case of connection issues, when
possible. The default value of '--http_socket_timeout_s' is set to None,
to prevent behavior changes for existing clients.

More details on socket timeout here:
https://docs.python.org/3/library/socket.html#socket-timeouts

Testing:
- Added tests for various timeout values in test_shell_commandline.py
- Ran e2e shell tests.

Change-Id: I29fa4ff96cdcf154c3aac7e43340af60d7d61e94
Reviewed-on: http://gerrit.cloudera.org:8080/18336
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>


> impala-shell: Set reasonable timeout for http client
> ----------------------------------------------------
>
>                 Key: IMPALA-11126
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11126
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Abhishek Rawat
>            Assignee: Abhishek Rawat
>            Priority: Major
>
> The timeout for ImpalaHttpClient is 'None', which could result in hang or infinite timeout when SSL handshake fails. Set this timeout to a reasonable value so that in case of an error, the client can retry, when possible. Also, would be good to make this timeout a configurable option for tuning purposes.
> https://github.com/apache/impala/blob/master/shell/ImpalaHttpClient.py#L125



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org