You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Kristian Waagan <Kr...@Sun.COM> on 2006/01/03 16:19:49 UTC
[PATCH] (DERBY-746) NullPointerException when 'encryptionKey' length
is an odd number, or it contains invalid chars
Hello,
I just uploaded a patch for DERBY-746
(http://issues.apache.org/jira/browse/DERBY-746). It would be nice if
someone could spare the time to review it so it can be committed soon.
The patch fixes the problem of Derby failing with a NPE when the
encryption key specified in the connection URL has either an odd length
or contains invalid characters.
I asked about advice regarding addition of new SQLStates earlier, but
got little response. So, I did it my way, and added two new states, one
for each case. Only English messages are added.
I am open to reducing this to one if people think this is better. The
names and messages can also be changed, ofcourse...
This is my first patch, and I welcome any pieces of advice related to
the process of contributing :)
Thanks,
--
Kristian
Re: [PATCH] (DERBY-746) NullPointerException when 'encryptionKey'
length is an odd number, or it contains invalid chars
Posted by Daniel John Debrunner <dj...@apache.org>.
Kristian Waagan wrote:
> Hello,
>
> I just uploaded a patch for DERBY-746
> (http://issues.apache.org/jira/browse/DERBY-746). It would be nice if
> someone could spare the time to review it so it can be committed soon.
>
Patch applied to trunk, thanks for contributing!
Dan.
Re: [PATCH] (DERBY-746) NullPointerException when 'encryptionKey'
length is an odd number, or it contains invalid chars
Posted by Kristian Waagan <Kr...@Sun.COM>.
Kristian Waagan wrote:
> Sunitha Kambhampati wrote:
>
>> Kristian Waagan wrote:
>>
>>> Hello,
>>>
>>> I just uploaded a patch for DERBY-746
>>> (http://issues.apache.org/jira/browse/DERBY-746). It would be nice if
>>> someone could spare the time to review it so it can be committed soon.
>>>
>>> The patch fixes the problem of Derby failing with a NPE when the
>>> encryption key specified in the connection URL has either an odd
>>> length or contains invalid characters.
>>>
>> Thanks Kristian for the patch. It looks good. There is one minor typo
>> in the english message - hexedecimal instead of 'hexadecimal'.
>
>
> Auch, more proofreading next time... Thanks for catching the spelling
> error :)
>
>>
>> I noticed Dan has committed this patch. Maybe a committer can make
>> this correction instead of needing a separate patch (?)
>
>
> I have uploaded a new additional patch (derby-746a.diff). It fixes the
> spelling error in the message file and the test master file.
> If a committer corrects the error manually, don't forget to fix the
> master file as well!
>
>
>
> --
> Kristian
>
>>
>> Thanks,
>> Sunitha.
>
>
This is a friendly request for a committer to take care of the
additional patch for DERBY-746, so that it can be closed.
Although the additional patch only fixes a single misspelled word, it
would be nice to get it finished and closed. The only change required is
to replace the incorrect 'e' in "hexedecimal" with an 'a' in two files
'messages_en.properties' and 'master/encryptionKey.out'.
Thanks,
--
Kristian
Re: [PATCH] (DERBY-746) NullPointerException when 'encryptionKey'
length is an odd number, or it contains invalid chars
Posted by Kristian Waagan <Kr...@Sun.COM>.
Sunitha Kambhampati wrote:
> Kristian Waagan wrote:
>
>> Hello,
>>
>> I just uploaded a patch for DERBY-746
>> (http://issues.apache.org/jira/browse/DERBY-746). It would be nice if
>> someone could spare the time to review it so it can be committed soon.
>>
>> The patch fixes the problem of Derby failing with a NPE when the
>> encryption key specified in the connection URL has either an odd
>> length or contains invalid characters.
>>
> Thanks Kristian for the patch. It looks good. There is one minor typo
> in the english message - hexedecimal instead of 'hexadecimal'.
Auch, more proofreading next time... Thanks for catching the spelling
error :)
>
> I noticed Dan has committed this patch. Maybe a committer can make this
> correction instead of needing a separate patch (?)
I have uploaded a new additional patch (derby-746a.diff). It fixes the
spelling error in the message file and the test master file.
If a committer corrects the error manually, don't forget to fix the
master file as well!
--
Kristian
>
> Thanks,
> Sunitha.
Re: [PATCH] (DERBY-746) NullPointerException when 'encryptionKey'
length is an odd number, or it contains invalid chars
Posted by Sunitha Kambhampati <ks...@gmail.com>.
Kristian Waagan wrote:
> Hello,
>
> I just uploaded a patch for DERBY-746
> (http://issues.apache.org/jira/browse/DERBY-746). It would be nice if
> someone could spare the time to review it so it can be committed soon.
>
> The patch fixes the problem of Derby failing with a NPE when the
> encryption key specified in the connection URL has either an odd
> length or contains invalid characters.
>
Thanks Kristian for the patch. It looks good. There is one minor typo
in the english message - hexedecimal instead of 'hexadecimal'.
I noticed Dan has committed this patch. Maybe a committer can make this
correction instead of needing a separate patch (?)
Thanks,
Sunitha.