[GitHub] [pulsar] nodece commented on a diff in pull request #15252: [improve][broker] Tidy up the system topic.

[GitBox <gi...@apache.org>]

nodece commented on code in PR #15252:
URL: https://github.com/apache/pulsar/pull/15252#discussion_r857100495


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTestBase.java:
##########
@@ -123,7 +125,7 @@ protected void setUpBase(int numBroker,int numPartitionsOfTC, String topic, int
         admin.tenants().createTenant(NamespaceName.SYSTEM_NAMESPACE.getTenant(),
                 new TenantInfoImpl(Sets.newHashSet("appid1"), Sets.newHashSet(CLUSTER_NAME)));
         admin.namespaces().createNamespace(NamespaceName.SYSTEM_NAMESPACE.toString());
-        admin.topics().createPartitionedTopic(TopicName.TRANSACTION_COORDINATOR_ASSIGN.toString(), numPartitionsOfTC);
+        createTransactionCoordinatorAssign(numPartitionsOfTC);

Review Comment:
   I have a question why don't use `admin.topics().createPartitionedTopic(TopicName.TRANSACTION_COORDINATOR_ASSIGN.toString(), numPartitionsOfTC);` to create topic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org