You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/04 09:52:49 UTC
[GitHub] [incubator-mxnet] athewsey opened a new pull request #17758:
HybridBlock.export() to return created filenames (#17688)
athewsey opened a new pull request #17758: HybridBlock.export() to return created filenames (#17688)
URL: https://github.com/apache/incubator-mxnet/pull/17758
## Description ##
Minimum, non-breaking change to alleviate #17688
`HybridBlock.export()` to return tuple of stored filenames (rather than undefined), to expose this information to user code which would otherwise have to re-implement internal filename selection logic.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] ~The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)~ (No JIRA issue, to my knowledge)
- [X] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage: (Sort of? See Changes section below...)
- [X] Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- ~Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)~
- ~Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)~
- [X] Code is well-documented:
- [X] For user-facing API changes, API doc string has been updated.
- ~For new C++ functions in header files, their functionalities and arguments are documented.~
- ~For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable~
- ~Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html~
- [X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- Implementations for Python and Perl bindings
- Minor Python docstring update to document change
- Unit test for Python, but not for Perl because existing coverage wasn't there and my Perl is terrible
## Comments ##
- It would probably be preferable to make the output filenames overrideable by user code as well, but this would be a bigger change and add more complexity into the API.
- First-time contributor with a very small change, so sorry if I misunderstood or missed anything!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] athewsey commented on issue #17758:
HybridBlock.export() to return created filenames (#17688)
Posted by GitBox <gi...@apache.org>.
athewsey commented on issue #17758: HybridBlock.export() to return created filenames (#17688)
URL: https://github.com/apache/incubator-mxnet/pull/17758#issuecomment-599177087
Whoops, sorry! Should be there now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17758:
HybridBlock.export() to return created filenames (#17688)
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17758: HybridBlock.export() to return created filenames (#17688)
URL: https://github.com/apache/incubator-mxnet/pull/17758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17758:
HybridBlock.export() to return created filenames (#17688)
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17758: HybridBlock.export() to return created filenames (#17688)
URL: https://github.com/apache/incubator-mxnet/pull/17758#issuecomment-596637192
Friendly ping @athewsey regarding the linting issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17758:
HybridBlock.export() to return created filenames (#17688)
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17758: HybridBlock.export() to return created filenames (#17688)
URL: https://github.com/apache/incubator-mxnet/pull/17758#issuecomment-595371711
Please fix
```
[2020-03-04T09:57:51.222Z] ************* Module mxnet.gluon.block
[2020-03-04T09:57:51.222Z] python/mxnet/gluon/block.py:1120:0: C0303: Trailing whitespace (trailing-whitespace)
[2020-03-04T09:57:51.222Z]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services