You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/13 04:00:48 UTC
[GitHub] [tvm] emijiayw commented on a change in pull request #9265: [ONNX] [Relay] Resize Opset 13
emijiayw commented on a change in pull request #9265:
URL: https://github.com/apache/tvm/pull/9265#discussion_r727677663
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params):
@classmethod
def _impl_v11(cls, inputs, attr, params):
+ scale = inputs[2]
+ scale_shape = infer_shape(scale)
+ if len(inputs) == 4:
+ assert (
+ len(scale_shape) == 0 or scale_shape[0] == 0
+ ), "One of scale or size should be passed, not both."
+ size = inputs[3]
+ else:
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
+ size = _op.cast(shape_of(inputs[0]), infer_type(scale).checked_type.dtype) * scale
+ return cls.v11_13_common(inputs, size, attr, params)
+
+ @classmethod
+ def _impl_v13(cls, inputs, attr, params):
+ scale = inputs[2]
+ size = inputs[3]
+ if size is not None:
+ assert scale is None, "One of scale or size should be passed, not both."
+ else:
+ scale_type = infer_type(scale)
+ scale_shape = scale_type.checked_type.shape
+ scale_dtype = scale_type.checked_type.dtype
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
+ size = _op.cast(shape_of(inputs[0]), scale_dtype) * scale
+
+ return cls.v11_13_common(inputs, size, attr, params)
+
+ @classmethod
+ def v11_13_common(cls, inputs, size, attr, params):
+ """
+ Resize v11 and Resize v13 are identical except in how
Review comment:
Resize v11 and resize
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params):
@classmethod
def _impl_v11(cls, inputs, attr, params):
+ scale = inputs[2]
+ scale_shape = infer_shape(scale)
+ if len(inputs) == 4:
+ assert (
+ len(scale_shape) == 0 or scale_shape[0] == 0
+ ), "One of scale or size should be passed, not both."
+ size = inputs[3]
+ else:
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
+ size = _op.cast(shape_of(inputs[0]), infer_type(scale).checked_type.dtype) * scale
+ return cls.v11_13_common(inputs, size, attr, params)
+
+ @classmethod
+ def _impl_v13(cls, inputs, attr, params):
+ scale = inputs[2]
+ size = inputs[3]
+ if size is not None:
+ assert scale is None, "One of scale or size should be passed, not both."
Review comment:
One of the scales or sizes
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params):
@classmethod
def _impl_v11(cls, inputs, attr, params):
+ scale = inputs[2]
+ scale_shape = infer_shape(scale)
+ if len(inputs) == 4:
+ assert (
+ len(scale_shape) == 0 or scale_shape[0] == 0
+ ), "One of scale or size should be passed, not both."
+ size = inputs[3]
+ else:
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
+ size = _op.cast(shape_of(inputs[0]), infer_type(scale).checked_type.dtype) * scale
+ return cls.v11_13_common(inputs, size, attr, params)
+
+ @classmethod
+ def _impl_v13(cls, inputs, attr, params):
+ scale = inputs[2]
+ size = inputs[3]
+ if size is not None:
+ assert scale is None, "One of scale or size should be passed, not both."
+ else:
+ scale_type = infer_type(scale)
+ scale_shape = scale_type.checked_type.shape
+ scale_dtype = scale_type.checked_type.dtype
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
+ size = _op.cast(shape_of(inputs[0]), scale_dtype) * scale
+
+ return cls.v11_13_common(inputs, size, attr, params)
+
+ @classmethod
+ def v11_13_common(cls, inputs, size, attr, params):
+ """
+ Resize v11 and Resize v13 are identical except in how
+ they handle passing in scale and size. This utility
Review comment:
they handle the passing
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params):
@classmethod
def _impl_v11(cls, inputs, attr, params):
+ scale = inputs[2]
+ scale_shape = infer_shape(scale)
+ if len(inputs) == 4:
+ assert (
+ len(scale_shape) == 0 or scale_shape[0] == 0
+ ), "One of scale or size should be passed, not both."
+ size = inputs[3]
+ else:
+ assert len(scale_shape) != 0, "One of scale or size should be passed."
Review comment:
One of the scales or sizes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org