You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/02/20 17:25:06 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

MortalHappiness opened a new pull request #883:
URL: https://github.com/apache/submarine/pull/883


   ### What is this PR for?
   Currently, the administrator docs on the submarine website only contain Yarn-related docs. Therefore it can be removed.
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1196
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #883:
URL: https://github.com/apache/submarine/pull/883


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046313620


   oops, sorry. I didn't see that. 
   I think we can just remove Kaldi from the docs. we have those docs on the 0.6.0 [website](https://github.com/apache/submarine/tree/master/website/versioned_docs/version-0.6.0/ecosystem/kaldi).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046314660


   I think we could also remove the docs related to yarn under user docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046311303


   @pingsutw I found the build fail reason. I have already removed Administrator Docs from `sidebar.js`. The failed reason is that the following documentation references the `adminDocs`. Maybe this PR can be merged after those documentation re-written PRs are merged? Or should I push a new commit to remove those references in this PR?
   
   https://github.com/apache/submarine/blob/bc2452a0db5272208df600542fa7d233b6c69b0f/website/docs/ecosystem/kaldi/RunningDistributedThchs30KaldiJobs.md?plain=1#L103
   
   https://github.com/apache/submarine/blob/bc2452a0db5272208df600542fa7d233b6c69b0f/website/docs/userDocs/yarn/YARNRuntimeGuide.md?plain=1#L22


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw edited a comment on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
pingsutw edited a comment on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046313620


   oops, sorry. I didn't see that. 
   I think we can just remove Kaldi from the docs. we have those docs on the 0.6.0 [website](https://github.com/apache/submarine/tree/master/website/versioned_docs/version-0.6.0/ecosystem/kaldi), so people still can find it in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046523265


   @pingsutw I have pushed a new commit. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046305820


   Should remove Administrator Docs from sidebar.js. https://github.com/apache/submarine/blob/92e6fe88c5aa2131983d045b4dd35e8f2ed331d4/website/sidebars.js#L53-L57


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw edited a comment on pull request #883: SUBMARINE-1196. Remove administrator docs on the submarine website

Posted by GitBox <gi...@apache.org>.
pingsutw edited a comment on pull request #883:
URL: https://github.com/apache/submarine/pull/883#issuecomment-1046314660


   I think we could also remove the docs related to yarn under user docs.
   https://github.com/apache/submarine/tree/master/website/versioned_docs/version-0.6.0/userDocs/yarn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org