You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by James Dailey <ja...@gmail.com> on 2024/02/09 22:44:10 UTC
Docker help
I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
This ticket is to enable the build at DockerHUB to work. For the past two
years ++ the Build has failed.
https://hub.docker.com/r/apache/fineract
This docker account is held by Apache and the Fineract project is
responsible for the content.
The dockerHUB has an "auto build" concept so that every committed change on
Dev leads to a new deployment.
The build is actually failing or not running because we have removed the
dockerbuild file from the root. That is as far as I've gotten. I suspect
we had good reasons for that at the time.
Anyway, I would also say that if we cannot get the Docker build to work
THEN we should take this down. Our standard is to only support and
distribute publicly the last two releases. This build is really old, has
unfixed CVEs, and is being downloaded in large numbers. (no idea why)
Thanks
James
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Hello James et al,
This is the PR Github Action for DockerHub Publishing for your review:
https://github.com/apache/fineract/pull/3887/files
Regards
El mié, 8 may 2024 a las 19:53, VICTOR MANUEL ROMERO RODRIGUEZ (<
victor.romero@fintecheando.mx>) escribió:
> Keep Jib.
>
> Let me share one PR for discussion/review.
>
> The docker compose file can point to Docker Hub image. Of course not build
> from docker compose just download the latest version. (not building)
>
>
>
> El mié, 8 may 2024 a las 19:28, James Dailey (<ja...@gmail.com>)
> escribió:
>
>> Ok. So… Aleks - comment ?
>> Zoltan , Victor - can we come to a decision on this?
>>
>> Keep Jib
>> Add GitHub action
>> Yes?
>>
>>
>>
>>
>> On Mon, May 6, 2024 at 2:00 PM todd densmore <td...@gmail.com> wrote:
>>
>>> James,
>>>
>>> (adding comments as requested - but from here it looks like there is
>>> enough momentum from the team to resolve the core issue)
>>>
>>> Firstly, it looks like a custom role can be added to the repo to allow
>>> GitHub Actions (ie Jib) to push new images to DockerHub. Some new GitHub
>>> Action code will have to be added to do the "push", but that is trivial.
>>> Both of these tasks can be done quickly and easily, and solves the short
>>> term problem of getting current Fineract images to DockerHub. This is an
>>> immediate win and resolves the most immediate issue.
>>>
>>> The second issue that Fineract may wish to address is whether or not to
>>> include a Dockerfile in the public repo.
>>>
>>> The docker-compose file (pointing to DockerHub) that is currently
>>> included in the Fineract repo *will work*, allowing new users to get
>>> setup quickly. However users will have no way to create new local versions
>>> of the Fineract container image locally without installing the complete
>>> java (Jib) toolchain. This may not be an issue at all if most users already
>>> have a local java environment. For casual users looking to contribute to
>>> Fineract, this may present a bit of friction.
>>>
>>> Including a Dockerfile in the repo can be done *without replacing Jib*.
>>> However, having a visible Dockerfile that is NOT used with the non-visible
>>> Jib build process will be confusing. Keeping the Dockerfile up to date will
>>> also be harder, since the file will not be the single source of truth. This
>>> may or not be an issue for the team.
>>>
>>> Lastly (and probably the most contentious option) would be to replace
>>> the Jib image build tooling with the more common Dockerfile build
>>> mechanism. This represents more work from the team, but also increases the
>>> transparency from the outside user. This may not be an issue for the team
>>> (especially if the number of outside contributors is small).
>>>
>>> -Todd
>>>
>>> On Sun, May 5, 2024 at 1:51 PM James Dailey <ja...@gmail.com>
>>> wrote:
>>>
>>>> Victor - thank you for your PR and Zoltan for your comments.
>>>>
>>>> On Fri, May 3, 2024 at 10:31 AM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> victor.romero@fintecheando.mx> wrote:
>>>>
>>>>> James,
>>>>>
>>>>> I think that this option is also viable:
>>>>>
>>>>> "For Github Actions we can use a role account and attach the secrets
>>>>> to your repository"
>>>>>
>>>>> At this point there are two options
>>>>>
>>>>> 1. Apache Infra has to add the secrets to the Apache Fineract
>>>>> repository and then we can create/modify github actions for using the
>>>>> existing Jib library.
>>>>>
>>>> This approach maintains the same consistent build but is a bit
>>>> non-standard? The problem with option #2 is that there will be effectively
>>>> two "builds" from the same source, and they won't match because the Jib
>>>> library is in use by active dev teams on the project today.
>>>>
>>>>
>>>>> 2. Merge the https://github.com/apache/fineract/pull/3879 to the
>>>>> develop branch in order to allow Dockerhub to build/publish a new docker
>>>>> image.
>>>>>
>>>> This approach returns the project to a more standard approach? It
>>>> does not require special action by Infra but creates a separate and
>>>> potentially inconsistent build.
>>>>
>>>>>
>>>>> Any other option or discussion about the solution for having an
>>>>> updated Apache Fineract image published on Dockerhub is welcome.
>>>>>
>>>> agreed - last call for comments on which of these. I'm leaning toward
>>>> the second because it requires no action by Infra and is the shortest path
>>>> to getting a new image at DockerHUB.
>>>>
>>>> Todd- can you comment?
>>>>
>>>>
>>>>>
>>>>> Best regards
>>>>>
>>>>> Victor
>>>>>
>>>>> Regards
>>>>>
>>>>> Víctor Romero
>>>>>
>>>>> El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>)
>>>>> escribió:
>>>>>
>>>>>> As this relates to this thread but was over on infra users...
>>>>>>
>>>>>>
>>>>>> ---------- Forwarded message ---------
>>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>> Subject: Re: Docker help
>>>>>> To: James Dailey <jd...@apache.org>
>>>>>> Cc: Users <us...@infra.apache.org>
>>>>>>
>>>>>>
>>>>>> Hi James.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Infra -
>>>>>>>
>>>>>>> Can you confirm that we can use other processes to push to
>>>>>>> apache DockerHUB?
>>>>>>>
>>>>>>
>>>>>> Current supported methods are via Github Actions or Jenkins or
>>>>>> locally via your own credentials.
>>>>>>
>>>>>> For Github Actions we can use a role account and attach the secrets
>>>>>> to your repository, or you
>>>>>> can provide your own secrets for us to add to your repository
>>>>>>
>>>>>> For Jenkins we have a role account that we provide access to push to
>>>>>> your repository.
>>>>>>
>>>>>> Committers could also use a settings.xml with this plugin and use
>>>>>> their own credentials, we just need
>>>>>> to ensure they have push access to Dockerhub.
>>>>>>
>>>>>> There may also be other methods not explored.
>>>>>>
>>>>>> See also:
>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>
>>>>>> HTH
>>>>>>
>>>>>>>
>>>>>>> When I opened a ticket about this, I was told we need a dockerfile
>>>>>>> at the root.
>>>>>>>
>>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>>>> Can we get credentials ?
>>>>>>>
>>>>>>> James
>>>>>>>
>>>>>>>
>>>>>>> ---------- Forwarded message ---------
>>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>> Subject: Re: Docker help
>>>>>>> To: <de...@fineract.apache.org>
>>>>>>>
>>>>>>>
>>>>>>> James,
>>>>>>>
>>>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>>
>>>>>>> Best,
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>
>>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key
>>>>>>>> for IP address '140.82.114.4' to the list of known hosts.
>>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>>>> 'origin/develop'.
>>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>>
>>>>>>>>
>>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>>
>>>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>>>> working.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Zoltan, James,
>>>>>>>>>
>>>>>>>>> Just to reflect on your points:
>>>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>>
>>>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>>>> pipeline and that's all.
>>>>>>>>>
>>>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>>>> unnecessary change.
>>>>>>>>>
>>>>>>>>> Arnold
>>>>>>>>>
>>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Thanks Zoltan
>>>>>>>>>>
>>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I think the real issue here is that we use
>>>>>>>>>>> GoogleContainerTools's Jib as the build mechanism. It works entirely
>>>>>>>>>>> without a Dockerfile. And unfortunately Dockerhub's Automated Builds
>>>>>>>>>>> doesn't support building without a Dockerfile. :-(
>>>>>>>>>>>
>>>>>>>>>>> We have two ways to move forward:
>>>>>>>>>>>
>>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>>>> Dockerfile-based approach. This would be a quite large change of how
>>>>>>>>>>> Fineract is built and the consequences need to be explored - but it's
>>>>>>>>>>> definitely doable.
>>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>>>
>>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>>>
>>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>>>
>>>>>>>>>>> Kind regards,
>>>>>>>>>>> Zoltan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>>>
>>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>> James
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>>>
>>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
>>>>>>>>>>>>> the versions) on master branch
>>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
>>>>>>>>>>>>> the master branch
>>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>>>>>>>>>> master, so then it will push the changes to the master branch everytime the
>>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will publish it as
>>>>>>>>>>>>> the latest version.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>>>
>>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
>>>>>>>>>>>>> the master branch
>>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub
>>>>>>>>>>>>> will publish it as the latest/specific version.
>>>>>>>>>>>>>
>>>>>>>>>>>>> What do you think?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that
>>>>>>>>>>>>>> is the error thrown and the suggestion at DockerHUB. However, to add the
>>>>>>>>>>>>>> key to the git hub requires access and the git is controlled by Apache
>>>>>>>>>>>>>> Infra. I asked infra@a.o. about that since, again, that is
>>>>>>>>>>>>>> what DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ
>>>>>>>>>>>>>> <vi...@fintecheando.mx> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
>>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If they are set in the git repository, a github action can
>>>>>>>>>>>>>>> be enabled for this task.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>> *Gavin McDonald - *
>>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>> V.P Travel Assistance Committee
>>>>>>
>>>>>> https://tac.apache.org - Applications now open for Community Over
>>>>>> Code 2024
>>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>
>>>>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Keep Jib.
Let me share one PR for discussion/review.
The docker compose file can point to Docker Hub image. Of course not build
from docker compose just download the latest version. (not building)
El mié, 8 may 2024 a las 19:28, James Dailey (<ja...@gmail.com>)
escribió:
> Ok. So… Aleks - comment ?
> Zoltan , Victor - can we come to a decision on this?
>
> Keep Jib
> Add GitHub action
> Yes?
>
>
>
>
> On Mon, May 6, 2024 at 2:00 PM todd densmore <td...@gmail.com> wrote:
>
>> James,
>>
>> (adding comments as requested - but from here it looks like there is
>> enough momentum from the team to resolve the core issue)
>>
>> Firstly, it looks like a custom role can be added to the repo to allow
>> GitHub Actions (ie Jib) to push new images to DockerHub. Some new GitHub
>> Action code will have to be added to do the "push", but that is trivial.
>> Both of these tasks can be done quickly and easily, and solves the short
>> term problem of getting current Fineract images to DockerHub. This is an
>> immediate win and resolves the most immediate issue.
>>
>> The second issue that Fineract may wish to address is whether or not to
>> include a Dockerfile in the public repo.
>>
>> The docker-compose file (pointing to DockerHub) that is currently
>> included in the Fineract repo *will work*, allowing new users to get
>> setup quickly. However users will have no way to create new local versions
>> of the Fineract container image locally without installing the complete
>> java (Jib) toolchain. This may not be an issue at all if most users already
>> have a local java environment. For casual users looking to contribute to
>> Fineract, this may present a bit of friction.
>>
>> Including a Dockerfile in the repo can be done *without replacing Jib*.
>> However, having a visible Dockerfile that is NOT used with the non-visible
>> Jib build process will be confusing. Keeping the Dockerfile up to date will
>> also be harder, since the file will not be the single source of truth. This
>> may or not be an issue for the team.
>>
>> Lastly (and probably the most contentious option) would be to replace the
>> Jib image build tooling with the more common Dockerfile build mechanism.
>> This represents more work from the team, but also increases the
>> transparency from the outside user. This may not be an issue for the team
>> (especially if the number of outside contributors is small).
>>
>> -Todd
>>
>> On Sun, May 5, 2024 at 1:51 PM James Dailey <ja...@gmail.com>
>> wrote:
>>
>>> Victor - thank you for your PR and Zoltan for your comments.
>>>
>>> On Fri, May 3, 2024 at 10:31 AM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> James,
>>>>
>>>> I think that this option is also viable:
>>>>
>>>> "For Github Actions we can use a role account and attach the secrets to
>>>> your repository"
>>>>
>>>> At this point there are two options
>>>>
>>>> 1. Apache Infra has to add the secrets to the Apache Fineract
>>>> repository and then we can create/modify github actions for using the
>>>> existing Jib library.
>>>>
>>> This approach maintains the same consistent build but is a bit
>>> non-standard? The problem with option #2 is that there will be effectively
>>> two "builds" from the same source, and they won't match because the Jib
>>> library is in use by active dev teams on the project today.
>>>
>>>
>>>> 2. Merge the https://github.com/apache/fineract/pull/3879 to the
>>>> develop branch in order to allow Dockerhub to build/publish a new docker
>>>> image.
>>>>
>>> This approach returns the project to a more standard approach? It
>>> does not require special action by Infra but creates a separate and
>>> potentially inconsistent build.
>>>
>>>>
>>>> Any other option or discussion about the solution for having an updated
>>>> Apache Fineract image published on Dockerhub is welcome.
>>>>
>>> agreed - last call for comments on which of these. I'm leaning toward
>>> the second because it requires no action by Infra and is the shortest path
>>> to getting a new image at DockerHUB.
>>>
>>> Todd- can you comment?
>>>
>>>
>>>>
>>>> Best regards
>>>>
>>>> Victor
>>>>
>>>> Regards
>>>>
>>>> Víctor Romero
>>>>
>>>> El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>)
>>>> escribió:
>>>>
>>>>> As this relates to this thread but was over on infra users...
>>>>>
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>> Subject: Re: Docker help
>>>>> To: James Dailey <jd...@apache.org>
>>>>> Cc: Users <us...@infra.apache.org>
>>>>>
>>>>>
>>>>> Hi James.
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Infra -
>>>>>>
>>>>>> Can you confirm that we can use other processes to push to
>>>>>> apache DockerHUB?
>>>>>>
>>>>>
>>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>>> via your own credentials.
>>>>>
>>>>> For Github Actions we can use a role account and attach the secrets to
>>>>> your repository, or you
>>>>> can provide your own secrets for us to add to your repository
>>>>>
>>>>> For Jenkins we have a role account that we provide access to push to
>>>>> your repository.
>>>>>
>>>>> Committers could also use a settings.xml with this plugin and use
>>>>> their own credentials, we just need
>>>>> to ensure they have push access to Dockerhub.
>>>>>
>>>>> There may also be other methods not explored.
>>>>>
>>>>> See also:
>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>
>>>>> HTH
>>>>>
>>>>>>
>>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>>> the root.
>>>>>>
>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>>> Can we get credentials ?
>>>>>>
>>>>>> James
>>>>>>
>>>>>>
>>>>>> ---------- Forwarded message ---------
>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>> Subject: Re: Docker help
>>>>>> To: <de...@fineract.apache.org>
>>>>>>
>>>>>>
>>>>>> James,
>>>>>>
>>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>
>>>>>> Best,
>>>>>> Arnold
>>>>>>
>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>
>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>
>>>>>>>
>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>
>>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>>> working.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Zoltan, James,
>>>>>>>>
>>>>>>>> Just to reflect on your points:
>>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>
>>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>>> pipeline and that's all.
>>>>>>>>
>>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>>> unnecessary change.
>>>>>>>>
>>>>>>>> Arnold
>>>>>>>>
>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Thanks Zoltan
>>>>>>>>>
>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>>
>>>>>>>>>> We have two ways to move forward:
>>>>>>>>>>
>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>>> Dockerfile-based approach. This would be a quite large change of how
>>>>>>>>>> Fineract is built and the consequences need to be explored - but it's
>>>>>>>>>> definitely doable.
>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>>
>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>>
>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>>
>>>>>>>>>> Kind regards,
>>>>>>>>>> Zoltan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>>
>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>> James
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>>
>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
>>>>>>>>>>>> the versions) on master branch
>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>> master branch
>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>>>>>>>>> master, so then it will push the changes to the master branch everytime the
>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will publish it as
>>>>>>>>>>>> the latest version.
>>>>>>>>>>>>
>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>>
>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>> master branch
>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>>
>>>>>>>>>>>> What do you think?
>>>>>>>>>>>>
>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>>
>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>> *Gavin McDonald - *
>>>>> Systems Administrator, ASF Infrastructure Team
>>>>> V.P Travel Assistance Committee
>>>>>
>>>>> https://tac.apache.org - Applications now open for Community Over
>>>>> Code 2024
>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>
>>>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Ok. So… Aleks - comment ?
Zoltan , Victor - can we come to a decision on this?
Keep Jib
Add GitHub action
Yes?
On Mon, May 6, 2024 at 2:00 PM todd densmore <td...@gmail.com> wrote:
> James,
>
> (adding comments as requested - but from here it looks like there is
> enough momentum from the team to resolve the core issue)
>
> Firstly, it looks like a custom role can be added to the repo to allow
> GitHub Actions (ie Jib) to push new images to DockerHub. Some new GitHub
> Action code will have to be added to do the "push", but that is trivial.
> Both of these tasks can be done quickly and easily, and solves the short
> term problem of getting current Fineract images to DockerHub. This is an
> immediate win and resolves the most immediate issue.
>
> The second issue that Fineract may wish to address is whether or not to
> include a Dockerfile in the public repo.
>
> The docker-compose file (pointing to DockerHub) that is currently included
> in the Fineract repo *will work*, allowing new users to get setup
> quickly. However users will have no way to create new local versions of the
> Fineract container image locally without installing the complete java (Jib)
> toolchain. This may not be an issue at all if most users already have a
> local java environment. For casual users looking to contribute to Fineract,
> this may present a bit of friction.
>
> Including a Dockerfile in the repo can be done *without replacing Jib*.
> However, having a visible Dockerfile that is NOT used with the non-visible
> Jib build process will be confusing. Keeping the Dockerfile up to date will
> also be harder, since the file will not be the single source of truth. This
> may or not be an issue for the team.
>
> Lastly (and probably the most contentious option) would be to replace the
> Jib image build tooling with the more common Dockerfile build mechanism.
> This represents more work from the team, but also increases the
> transparency from the outside user. This may not be an issue for the team
> (especially if the number of outside contributors is small).
>
> -Todd
>
> On Sun, May 5, 2024 at 1:51 PM James Dailey <ja...@gmail.com>
> wrote:
>
>> Victor - thank you for your PR and Zoltan for your comments.
>>
>> On Fri, May 3, 2024 at 10:31 AM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> James,
>>>
>>> I think that this option is also viable:
>>>
>>> "For Github Actions we can use a role account and attach the secrets to
>>> your repository"
>>>
>>> At this point there are two options
>>>
>>> 1. Apache Infra has to add the secrets to the Apache Fineract repository
>>> and then we can create/modify github actions for using the existing Jib
>>> library.
>>>
>> This approach maintains the same consistent build but is a bit
>> non-standard? The problem with option #2 is that there will be effectively
>> two "builds" from the same source, and they won't match because the Jib
>> library is in use by active dev teams on the project today.
>>
>>
>>> 2. Merge the https://github.com/apache/fineract/pull/3879 to the
>>> develop branch in order to allow Dockerhub to build/publish a new docker
>>> image.
>>>
>> This approach returns the project to a more standard approach? It does
>> not require special action by Infra but creates a separate and potentially
>> inconsistent build.
>>
>>>
>>> Any other option or discussion about the solution for having an updated
>>> Apache Fineract image published on Dockerhub is welcome.
>>>
>> agreed - last call for comments on which of these. I'm leaning toward
>> the second because it requires no action by Infra and is the shortest path
>> to getting a new image at DockerHUB.
>>
>> Todd- can you comment?
>>
>>
>>>
>>> Best regards
>>>
>>> Victor
>>>
>>> Regards
>>>
>>> Víctor Romero
>>>
>>> El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>)
>>> escribió:
>>>
>>>> As this relates to this thread but was over on infra users...
>>>>
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Gavin McDonald <gm...@apache.org>
>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>> Subject: Re: Docker help
>>>> To: James Dailey <jd...@apache.org>
>>>> Cc: Users <us...@infra.apache.org>
>>>>
>>>>
>>>> Hi James.
>>>>
>>>>
>>>>
>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>> wrote:
>>>>
>>>>> Infra -
>>>>>
>>>>> Can you confirm that we can use other processes to push to
>>>>> apache DockerHUB?
>>>>>
>>>>
>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>> via your own credentials.
>>>>
>>>> For Github Actions we can use a role account and attach the secrets to
>>>> your repository, or you
>>>> can provide your own secrets for us to add to your repository
>>>>
>>>> For Jenkins we have a role account that we provide access to push to
>>>> your repository.
>>>>
>>>> Committers could also use a settings.xml with this plugin and use their
>>>> own credentials, we just need
>>>> to ensure they have push access to Dockerhub.
>>>>
>>>> There may also be other methods not explored.
>>>>
>>>> See also:
>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>
>>>> HTH
>>>>
>>>>>
>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>> the root.
>>>>>
>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>> Can we get credentials ?
>>>>>
>>>>> James
>>>>>
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>> Subject: Re: Docker help
>>>>> To: <de...@fineract.apache.org>
>>>>>
>>>>>
>>>>> James,
>>>>>
>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>> to build a docker image; as I stated in my previous email.
>>>>>
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>
>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>
>>>>>>
>>>>>> Let's discuss on slack and revert back here.
>>>>>>
>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>> working.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Zoltan, James,
>>>>>>>
>>>>>>> Just to reflect on your points:
>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>
>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>> pipeline and that's all.
>>>>>>>
>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>> unnecessary change.
>>>>>>>
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Thanks Zoltan
>>>>>>>>
>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>
>>>>>>>>> We have two ways to move forward:
>>>>>>>>>
>>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>
>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>
>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>
>>>>>>>>> Kind regards,
>>>>>>>>> Zoltan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>
>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> James
>>>>>>>>>>
>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>
>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>>> versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>>> version.
>>>>>>>>>>>
>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>
>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>
>>>>>>>>>>> What do you think?
>>>>>>>>>>>
>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> *Gavin McDonald - *
>>>> Systems Administrator, ASF Infrastructure Team
>>>> V.P Travel Assistance Committee
>>>>
>>>> https://tac.apache.org - Applications now open for Community Over Code
>>>> 2024
>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>
>>>>
Re: Docker help
Posted by todd densmore <td...@gmail.com>.
James,
(adding comments as requested - but from here it looks like there is enough
momentum from the team to resolve the core issue)
Firstly, it looks like a custom role can be added to the repo to allow
GitHub Actions (ie Jib) to push new images to DockerHub. Some new GitHub
Action code will have to be added to do the "push", but that is trivial.
Both of these tasks can be done quickly and easily, and solves the short
term problem of getting current Fineract images to DockerHub. This is an
immediate win and resolves the most immediate issue.
The second issue that Fineract may wish to address is whether or not to
include a Dockerfile in the public repo.
The docker-compose file (pointing to DockerHub) that is currently included
in the Fineract repo *will work*, allowing new users to get setup quickly.
However users will have no way to create new local versions of the Fineract
container image locally without installing the complete java (Jib)
toolchain. This may not be an issue at all if most users already have a
local java environment. For casual users looking to contribute to Fineract,
this may present a bit of friction.
Including a Dockerfile in the repo can be done *without replacing Jib*.
However, having a visible Dockerfile that is NOT used with the non-visible
Jib build process will be confusing. Keeping the Dockerfile up to date will
also be harder, since the file will not be the single source of truth. This
may or not be an issue for the team.
Lastly (and probably the most contentious option) would be to replace the
Jib image build tooling with the more common Dockerfile build mechanism.
This represents more work from the team, but also increases the
transparency from the outside user. This may not be an issue for the team
(especially if the number of outside contributors is small).
-Todd
On Sun, May 5, 2024 at 1:51 PM James Dailey <ja...@gmail.com> wrote:
> Victor - thank you for your PR and Zoltan for your comments.
>
> On Fri, May 3, 2024 at 10:31 AM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> James,
>>
>> I think that this option is also viable:
>>
>> "For Github Actions we can use a role account and attach the secrets to
>> your repository"
>>
>> At this point there are two options
>>
>> 1. Apache Infra has to add the secrets to the Apache Fineract repository
>> and then we can create/modify github actions for using the existing Jib
>> library.
>>
> This approach maintains the same consistent build but is a bit
> non-standard? The problem with option #2 is that there will be effectively
> two "builds" from the same source, and they won't match because the Jib
> library is in use by active dev teams on the project today.
>
>
>> 2. Merge the https://github.com/apache/fineract/pull/3879 to the develop
>> branch in order to allow Dockerhub to build/publish a new docker image.
>>
> This approach returns the project to a more standard approach? It does
> not require special action by Infra but creates a separate and potentially
> inconsistent build.
>
>>
>> Any other option or discussion about the solution for having an updated
>> Apache Fineract image published on Dockerhub is welcome.
>>
> agreed - last call for comments on which of these. I'm leaning toward the
> second because it requires no action by Infra and is the shortest path to
> getting a new image at DockerHUB.
>
> Todd- can you comment?
>
>
>>
>> Best regards
>>
>> Victor
>>
>> Regards
>>
>> Víctor Romero
>>
>> El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>)
>> escribió:
>>
>>> As this relates to this thread but was over on infra users...
>>>
>>>
>>> ---------- Forwarded message ---------
>>> From: Gavin McDonald <gm...@apache.org>
>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>> Subject: Re: Docker help
>>> To: James Dailey <jd...@apache.org>
>>> Cc: Users <us...@infra.apache.org>
>>>
>>>
>>> Hi James.
>>>
>>>
>>>
>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org> wrote:
>>>
>>>> Infra -
>>>>
>>>> Can you confirm that we can use other processes to push to
>>>> apache DockerHUB?
>>>>
>>>
>>> Current supported methods are via Github Actions or Jenkins or locally
>>> via your own credentials.
>>>
>>> For Github Actions we can use a role account and attach the secrets to
>>> your repository, or you
>>> can provide your own secrets for us to add to your repository
>>>
>>> For Jenkins we have a role account that we provide access to push to
>>> your repository.
>>>
>>> Committers could also use a settings.xml with this plugin and use their
>>> own credentials, we just need
>>> to ensure they have push access to Dockerhub.
>>>
>>> There may also be other methods not explored.
>>>
>>> See also:
>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>
>>> HTH
>>>
>>>>
>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>> the root.
>>>>
>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>> Can we get credentials ?
>>>>
>>>> James
>>>>
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Arnold Galovics <ar...@apache.org>
>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>> Subject: Re: Docker help
>>>> To: <de...@fineract.apache.org>
>>>>
>>>>
>>>> James,
>>>>
>>>> This is the out-of-the box solution from DockerHub which definitely
>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>> to build a docker image; as I stated in my previous email.
>>>>
>>>> Best,
>>>> Arnold
>>>>
>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>> wrote:
>>>>
>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>> https://hub.docker.com/r/apache/fineract
>>>>>
>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>
>>>>>
>>>>> Let's discuss on slack and revert back here.
>>>>>
>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>> working.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Hi Zoltan, James,
>>>>>>
>>>>>> Just to reflect on your points:
>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>
>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>> pipeline and that's all.
>>>>>>
>>>>>> If the only thing preventing us from doing this is to keep asking the
>>>>>> infra team for the creds, let's pursue them instead of making such an
>>>>>> unnecessary change.
>>>>>>
>>>>>> Arnold
>>>>>>
>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Thanks Zoltan
>>>>>>>
>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>> a Dockerfile. :-(
>>>>>>>>
>>>>>>>> We have two ways to move forward:
>>>>>>>>
>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>
>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>
>>>>>>>> Want me to try this approach next week?
>>>>>>>>
>>>>>>>> Kind regards,
>>>>>>>> Zoltan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>
>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>> James
>>>>>>>>>
>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>
>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>
>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>> versions) on master branch
>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>> master branch
>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>> version.
>>>>>>>>>>
>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>
>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>> master branch
>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>
>>>>>>>>>> What do you think?
>>>>>>>>>>
>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>
>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>
>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>>
>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>
>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>
>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>> This docker account is held by Apache and the Fineract project
>>>>>>>>>>>>> is responsible for the content.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>> why)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>> James
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>
>>> --
>>>
>>>
>>> *Gavin McDonald - *
>>> Systems Administrator, ASF Infrastructure Team
>>> V.P Travel Assistance Committee
>>>
>>> https://tac.apache.org - Applications now open for Community Over Code
>>> 2024
>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>
>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Victor - thank you for your PR and Zoltan for your comments.
On Fri, May 3, 2024 at 10:31 AM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> James,
>
> I think that this option is also viable:
>
> "For Github Actions we can use a role account and attach the secrets to
> your repository"
>
> At this point there are two options
>
> 1. Apache Infra has to add the secrets to the Apache Fineract repository
> and then we can create/modify github actions for using the existing Jib
> library.
>
This approach maintains the same consistent build but is a bit
non-standard? The problem with option #2 is that there will be effectively
two "builds" from the same source, and they won't match because the Jib
library is in use by active dev teams on the project today.
> 2. Merge the https://github.com/apache/fineract/pull/3879 to the develop
> branch in order to allow Dockerhub to build/publish a new docker image.
>
This approach returns the project to a more standard approach? It does
not require special action by Infra but creates a separate and potentially
inconsistent build.
>
> Any other option or discussion about the solution for having an updated
> Apache Fineract image published on Dockerhub is welcome.
>
agreed - last call for comments on which of these. I'm leaning toward the
second because it requires no action by Infra and is the shortest path to
getting a new image at DockerHUB.
Todd- can you comment?
>
> Best regards
>
> Victor
>
> Regards
>
> Víctor Romero
>
> El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>)
> escribió:
>
>> As this relates to this thread but was over on infra users...
>>
>>
>> ---------- Forwarded message ---------
>> From: Gavin McDonald <gm...@apache.org>
>> Date: Sun, Feb 18, 2024 at 12:24 AM
>> Subject: Re: Docker help
>> To: James Dailey <jd...@apache.org>
>> Cc: Users <us...@infra.apache.org>
>>
>>
>> Hi James.
>>
>>
>>
>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org> wrote:
>>
>>> Infra -
>>>
>>> Can you confirm that we can use other processes to push to
>>> apache DockerHUB?
>>>
>>
>> Current supported methods are via Github Actions or Jenkins or locally
>> via your own credentials.
>>
>> For Github Actions we can use a role account and attach the secrets to
>> your repository, or you
>> can provide your own secrets for us to add to your repository
>>
>> For Jenkins we have a role account that we provide access to push to your
>> repository.
>>
>> Committers could also use a settings.xml with this plugin and use their
>> own credentials, we just need
>> to ensure they have push access to Dockerhub.
>>
>> There may also be other methods not explored.
>>
>> See also:
>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>
>> HTH
>>
>>>
>>> When I opened a ticket about this, I was told we need a dockerfile at
>>> the root.
>>>
>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ? Can
>>> we get credentials ?
>>>
>>> James
>>>
>>>
>>> ---------- Forwarded message ---------
>>> From: Arnold Galovics <ar...@apache.org>
>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>> Subject: Re: Docker help
>>> To: <de...@fineract.apache.org>
>>>
>>>
>>> James,
>>>
>>> This is the out-of-the box solution from DockerHub which definitely
>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>> to build a docker image; as I stated in my previous email.
>>>
>>> Best,
>>> Arnold
>>>
>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>> wrote:
>>>
>>>> On DockerHUB the build fails because there is no dockerfile.
>>>> https://hub.docker.com/r/apache/fineract
>>>>
>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for IP
>>>> address '140.82.114.4' to the list of known hosts.
>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>
>>>>
>>>> Let's discuss on slack and revert back here.
>>>>
>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>> working.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>> wrote:
>>>>
>>>>> Hi Zoltan, James,
>>>>>
>>>>> Just to reflect on your points:
>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>> 2) I'm not sure what's the issue here, please explain. We already have
>>>>> docker builds in our pipeline via GitHub Actions (using their runners), the
>>>>> only missing piece is to do a docker push.
>>>>>
>>>>> We need the credentials to be able to do a docker push, alter the
>>>>> pipeline and that's all.
>>>>>
>>>>> If the only thing preventing us from doing this is to keep asking the
>>>>> infra team for the creds, let's pursue them instead of making such an
>>>>> unnecessary change.
>>>>>
>>>>> Arnold
>>>>>
>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Thanks Zoltan
>>>>>>
>>>>>> Micheal - can you please comment on this discussion? As this relates
>>>>>> to the Google deployment that you put in place? Question!
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>> a Dockerfile. :-(
>>>>>>>
>>>>>>> We have two ways to move forward:
>>>>>>>
>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>>>>>>> Builds, but some other build tools like jib-maven-plugin to publish the
>>>>>>> image to Dockerhub. This could also work, but it requires a build server
>>>>>>> that I'm not sure we have.
>>>>>>>
>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>
>>>>>>> Want me to try this approach next week?
>>>>>>>
>>>>>>> Kind regards,
>>>>>>> Zoltan
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>
>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>> James
>>>>>>>>
>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>
>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>
>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>> versions) on master branch
>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>> master branch
>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>> version.
>>>>>>>>>
>>>>>>>>> Or... we can be more standard
>>>>>>>>>
>>>>>>>>> 1. Rename develop to master
>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>> handling the versions) on master branch
>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>> master branch
>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>
>>>>>>>>> What do you think?
>>>>>>>>>
>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>
>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>
>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>
>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>>
>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>
>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>
>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>
>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>> This docker account is held by Apache and the Fineract project
>>>>>>>>>>>> is responsible for the content.
>>>>>>>>>>>>
>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>
>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>
>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker build
>>>>>>>>>>>> to work THEN we should take this down. Our standard is to only support and
>>>>>>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>> James
>>>>>>>>>>>>
>>>>>>>>>>>
>>
>> --
>>
>>
>> *Gavin McDonald - *
>> Systems Administrator, ASF Infrastructure Team
>> V.P Travel Assistance Committee
>>
>> https://tac.apache.org - Applications now open for Community Over Code
>> 2024
>> in Bratislava, Slovakia. Don't delay, apply today!
>>
>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
James,
I think that this option is also viable:
"For Github Actions we can use a role account and attach the secrets to
your repository"
At this point there are two options
1. Apache Infra has to add the secrets to the Apache Fineract repository
and then we can create/modify github actions for using the existing Jib
library.
2. Merge the https://github.com/apache/fineract/pull/3879 to the develop
branch in order to allow Dockerhub to build/publish a new docker image.
Any other option or discussion about the solution for having an updated
Apache Fineract image published on Dockerhub is welcome.
Best regards
Victor
Regards
Víctor Romero
El vie, 3 may 2024 a las 8:56, James Dailey (<jd...@apache.org>) escribió:
> As this relates to this thread but was over on infra users...
>
>
> ---------- Forwarded message ---------
> From: Gavin McDonald <gm...@apache.org>
> Date: Sun, Feb 18, 2024 at 12:24 AM
> Subject: Re: Docker help
> To: James Dailey <jd...@apache.org>
> Cc: Users <us...@infra.apache.org>
>
>
> Hi James.
>
>
>
> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org> wrote:
>
>> Infra -
>>
>> Can you confirm that we can use other processes to push to
>> apache DockerHUB?
>>
>
> Current supported methods are via Github Actions or Jenkins or locally via
> your own credentials.
>
> For Github Actions we can use a role account and attach the secrets to
> your repository, or you
> can provide your own secrets for us to add to your repository
>
> For Jenkins we have a role account that we provide access to push to your
> repository.
>
> Committers could also use a settings.xml with this plugin and use their
> own credentials, we just need
> to ensure they have push access to Dockerhub.
>
> There may also be other methods not explored.
>
> See also:
> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>
> HTH
>
>>
>> When I opened a ticket about this, I was told we need a dockerfile at the
>> root.
>>
>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ? Can
>> we get credentials ?
>>
>> James
>>
>>
>> ---------- Forwarded message ---------
>> From: Arnold Galovics <ar...@apache.org>
>> Date: Sun, Feb 11, 2024 at 10:45 PM
>> Subject: Re: Docker help
>> To: <de...@fineract.apache.org>
>>
>>
>> James,
>>
>> This is the out-of-the box solution from DockerHub which definitely won't
>> work without a Dockerfile. Though that doesn't mean it's the only way to
>> build a docker image; as I stated in my previous email.
>>
>> Best,
>> Arnold
>>
>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>> wrote:
>>
>>> On DockerHUB the build fails because there is no dockerfile.
>>> https://hub.docker.com/r/apache/fineract
>>>
>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for IP
>>> address '140.82.114.4' to the list of known hosts.
>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>
>>>
>>> Let's discuss on slack and revert back here.
>>>
>>> My intention is to either DELETE the DockerHUB repo or to get this
>>> working.
>>>
>>>
>>>
>>>
>>>
>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>> wrote:
>>>
>>>> Hi Zoltan, James,
>>>>
>>>> Just to reflect on your points:
>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>> 2) I'm not sure what's the issue here, please explain. We already have
>>>> docker builds in our pipeline via GitHub Actions (using their runners), the
>>>> only missing piece is to do a docker push.
>>>>
>>>> We need the credentials to be able to do a docker push, alter the
>>>> pipeline and that's all.
>>>>
>>>> If the only thing preventing us from doing this is to keep asking the
>>>> infra team for the creds, let's pursue them instead of making such an
>>>> unnecessary change.
>>>>
>>>> Arnold
>>>>
>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>> wrote:
>>>>
>>>>> Thanks Zoltan
>>>>>
>>>>> Micheal - can you please comment on this discussion? As this relates
>>>>> to the Google deployment that you put in place? Question!
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I think the real issue here is that we use GoogleContainerTools's Jib
>>>>>> as the build mechanism. It works entirely without a Dockerfile. And
>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>> a Dockerfile. :-(
>>>>>>
>>>>>> We have two ways to move forward:
>>>>>>
>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>>>>>> Builds, but some other build tools like jib-maven-plugin to publish the
>>>>>> image to Dockerhub. This could also work, but it requires a build server
>>>>>> that I'm not sure we have.
>>>>>>
>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>
>>>>>> Want me to try this approach next week?
>>>>>>
>>>>>> Kind regards,
>>>>>> Zoltan
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>> already there in dockerHUB for our project.
>>>>>>>
>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>
>>>>>>> Thanks
>>>>>>> James
>>>>>>>
>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>
>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>
>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>> versions) on master branch
>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>> master branch
>>>>>>>> 4. Create github action for keeping in sync develop with master, so
>>>>>>>> then it will push the changes to the master branch everytime the develop
>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>> version.
>>>>>>>>
>>>>>>>> Or... we can be more standard
>>>>>>>>
>>>>>>>> 1. Rename develop to master
>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for handling
>>>>>>>> the versions) on master branch
>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>> master branch
>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>> publish it as the latest/specific version.
>>>>>>>>
>>>>>>>> What do you think?
>>>>>>>>
>>>>>>>> Dockerhub automated builds info:
>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>
>>>>>>>>> Victor - I was trying to go down that path as well, as that is the
>>>>>>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>>>>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>>>>>>> asked infra@a.o. about that since, again, that is what
>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>
>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>
>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>> enabled for this task.
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>>
>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <ja...@gmail.com>
>>>>>>>>>> escribió:
>>>>>>>>>>
>>>>>>>>>>> I've re-opened
>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>
>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>
>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>> This docker account is held by Apache and the Fineract project
>>>>>>>>>>> is responsible for the content.
>>>>>>>>>>>
>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>
>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>
>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker build
>>>>>>>>>>> to work THEN we should take this down. Our standard is to only support and
>>>>>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>> James
>>>>>>>>>>>
>>>>>>>>>>
>
> --
>
>
> *Gavin McDonald - *
> Systems Administrator, ASF Infrastructure Team
> V.P Travel Assistance Committee
>
> https://tac.apache.org - Applications now open for Community Over Code
> 2024
> in Bratislava, Slovakia. Don't delay, apply today!
>
>
Fwd: Docker help
Posted by James Dailey <jd...@apache.org>.
As this relates to this thread but was over on infra users...
---------- Forwarded message ---------
From: Gavin McDonald <gm...@apache.org>
Date: Sun, Feb 18, 2024 at 12:24 AM
Subject: Re: Docker help
To: James Dailey <jd...@apache.org>
Cc: Users <us...@infra.apache.org>
Hi James.
On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org> wrote:
> Infra -
>
> Can you confirm that we can use other processes to push to
> apache DockerHUB?
>
Current supported methods are via Github Actions or Jenkins or locally via
your own credentials.
For Github Actions we can use a role account and attach the secrets to your
repository, or you
can provide your own secrets for us to add to your repository
For Jenkins we have a role account that we provide access to push to your
repository.
Committers could also use a settings.xml with this plugin and use their own
credentials, we just need
to ensure they have push access to Dockerhub.
There may also be other methods not explored.
See also:
https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
HTH
>
> When I opened a ticket about this, I was told we need a dockerfile at the
> root.
>
> Can we use "jib-maven-plugin to publish the image to Dockerhub". ? Can
> we get credentials ?
>
> James
>
>
> ---------- Forwarded message ---------
> From: Arnold Galovics <ar...@apache.org>
> Date: Sun, Feb 11, 2024 at 10:45 PM
> Subject: Re: Docker help
> To: <de...@fineract.apache.org>
>
>
> James,
>
> This is the out-of-the box solution from DockerHub which definitely won't
> work without a Dockerfile. Though that doesn't mean it's the only way to
> build a docker image; as I stated in my previous email.
>
> Best,
> Arnold
>
> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
> wrote:
>
>> On DockerHUB the build fails because there is no dockerfile.
>> https://hub.docker.com/r/apache/fineract
>>
>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>> 2024-02-08T13:12:28Z Cloning into '.'...
>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for IP
>> address '140.82.114.4' to the list of known hosts.
>> 2024-02-08T13:12:48Z Reset branch 'develop'
>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>
>>
>> Let's discuss on slack and revert back here.
>>
>> My intention is to either DELETE the DockerHUB repo or to get this
>> working.
>>
>>
>>
>>
>>
>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>> wrote:
>>
>>> Hi Zoltan, James,
>>>
>>> Just to reflect on your points:
>>> 1) Let's not do such a radical change unless we absolutely need to
>>> 2) I'm not sure what's the issue here, please explain. We already have
>>> docker builds in our pipeline via GitHub Actions (using their runners), the
>>> only missing piece is to do a docker push.
>>>
>>> We need the credentials to be able to do a docker push, alter the
>>> pipeline and that's all.
>>>
>>> If the only thing preventing us from doing this is to keep asking the
>>> infra team for the creds, let's pursue them instead of making such an
>>> unnecessary change.
>>>
>>> Arnold
>>>
>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>> wrote:
>>>
>>>> Thanks Zoltan
>>>>
>>>> Micheal - can you please comment on this discussion? As this relates
>>>> to the Google deployment that you put in place? Question!
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I think the real issue here is that we use GoogleContainerTools's Jib
>>>>> as the build mechanism. It works entirely without a Dockerfile. And
>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>> a Dockerfile. :-(
>>>>>
>>>>> We have two ways to move forward:
>>>>>
>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>> the consequences need to be explored - but it's definitely doable.
>>>>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>>>>> Builds, but some other build tools like jib-maven-plugin to publish the
>>>>> image to Dockerhub. This could also work, but it requires a build server
>>>>> that I'm not sure we have.
>>>>>
>>>>> I can try to create a traditional Dockerfile, but it will be different
>>>>> from what Jib can produce, so this might lead to regressions.
>>>>>
>>>>> Want me to try this approach next week?
>>>>>
>>>>> Kind regards,
>>>>> Zoltan
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Victor - my read of the docs is that the default “build rule “ points
>>>>>> to master or main but we can also use dev. In fact that’s what is already
>>>>>> there in dockerHUB for our project.
>>>>>>
>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>
>>>>>> Thanks
>>>>>> James
>>>>>>
>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>
>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>
>>>>>>> 1. Create a master branch from develop branch
>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>> versions) on master branch
>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>> master branch
>>>>>>> 4. Create github action for keeping in sync develop with master, so
>>>>>>> then it will push the changes to the master branch everytime the develop
>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>> version.
>>>>>>>
>>>>>>> Or... we can be more standard
>>>>>>>
>>>>>>> 1. Rename develop to master
>>>>>>> 2. Add a Dockerfile template (and some scripting on it for handling
>>>>>>> the versions) on master branch
>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>> master branch
>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>> publish it as the latest/specific version.
>>>>>>>
>>>>>>> What do you think?
>>>>>>>
>>>>>>> Dockerhub automated builds info:
>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>
>>>>>>>> Victor - I was trying to go down that path as well, as that is the
>>>>>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>>>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>>>>>> asked infra@a.o. about that since, again, that is what
>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>
>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>> docker hub account are requiered.
>>>>>>>>>
>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>> enabled for this task.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>>
>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <ja...@gmail.com>
>>>>>>>>> escribió:
>>>>>>>>>
>>>>>>>>>> I've re-opened
>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>
>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For the
>>>>>>>>>> past two years ++ the Build has failed.
>>>>>>>>>>
>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>> This docker account is held by Apache and the Fineract project is
>>>>>>>>>> responsible for the content.
>>>>>>>>>>
>>>>>>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>>>>>>> change on Dev leads to a new deployment.
>>>>>>>>>>
>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>
>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker build
>>>>>>>>>> to work THEN we should take this down. Our standard is to only support and
>>>>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> James
>>>>>>>>>>
>>>>>>>>>
--
*Gavin McDonald - *
Systems Administrator, ASF Infrastructure Team
V.P Travel Assistance Committee
https://tac.apache.org - Applications now open for Community Over Code 2024
in Bratislava, Slovakia. Don't delay, apply today!
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
*Arnold,*
Now the PR has your suggestion Arnold and it works. Thank you.
*James/Community,*
The PR is ready to be reviewed and merged if approved.
https://github.com/apache/fineract/pull/3887
It requires to have the following secrets set in the Apache Fineract
repository.
DOCKER_PASSWORD
DOCKER_USER
Regards
Victor Romero.
El lun, 27 may 2024 a las 13:12, Arnold Galovics (<ar...@apache.org>)
escribió:
> Good point Victor.
>
> Almost forgot about this error. I'd leave the original configuration in
> place.
>
> The reason you're getting this error is because the local Docker
> repository is not supporting multi-platform images (Win/Mac for sure, not
> sure about Linux). If you're pushing this to a remote repository that
> supports multi-platform images, the error is gone.
>
> Yet if somebody is building it locally with your updated configuration, it
> will be confusing for sure, so I don't recommend permanently changing it.
>
> However JIB config can be overridden from command line, here's how we
> solved it already on a project:
> ./gradlew :fineract-provider:jib -x test
> -Djib.from.platforms=linux/amd64,linux/arm64
>
> If you do this in the workflow, it'll correctly create the multi-platform
> image and users locally building won't be affected.
>
> Hope this helps.
> Best,
> Arnold
>
>
> On Mon, May 27, 2024 at 9:03 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> Hello Arnold,
>>
>> Currently we got this
>>
>> platforms {
>> platform {
>> architecture =
>> System.getProperty("os.arch").equals("aarch64")?"arm64":"amd64"
>> os = 'linux'
>> }
>> }
>>
>> If we set to this
>>
>> platform {
>> architecture = 'amd64'
>> os = 'linux'
>> }
>> platform {
>> architecture = 'arm64'
>> os = 'linux'
>> }
>>
>> People could have this kind of issues when building the docker image
>> locally using Jib
>>
>> *"... multi-platform image building not supported when pushing to Docker
>> engine"*
>>
>> That is the reason I was looking for a native Github Action Arm64 runner
>>
>> Any ideas are welcome.
>>
>> Regards
>>
>> El lun, 27 may 2024 a las 3:37, Arnold Galovics (<
>> galovicsarnold@gmail.com>) escribió:
>>
>>> Hi Victor,
>>>
>>> Alright.
>>>
>>> Note: probably JIB would be a better choice for the cross-platform
>>> building since it doesn't require an ARM emulator/ARM machine for building
>>> the Docker image.
>>>
>>> Best,
>>> Arnold
>>>
>>> On Mon, May 27, 2024 at 7:40 AM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> Hello James/Arnold/Community,
>>>>
>>>> There is not Arm64 Linux runner on GitHub Actions (at least not for the
>>>> free tier that I have access), there is a current Gihub discussion about
>>>> this topic https://github.com/orgs/community/discussions/19197
>>>>
>>>> With this limitation we cannot build a linux/arm for Docker image.
>>>>
>>>> I have tried to use QEMU and RunOnArchitecture Github Action but they
>>>> are very slow... and after 50 minutes they throw errors about Docker, due
>>>> to limitations of embedded virtualization.
>>>>
>>>> Now let's focus on the linux/amd... with the current runner I just want
>>>> to know if we can keep variables or use fixed values. This is because maybe
>>>> there are limitations about setting variables for the Github Actions.
>>>>
>>>> Also I have more questions, currently there is a docker tagged image as
>>>> "latest" on Docker Hub https://hub.docker.com/r/apache/fineract/tags ,
>>>> should we use "latest" tag? or should we use the branch name?
>>>>
>>>> I bring to the list the code that requires attention to my questions.
>>>>
>>>> - name: Image Tag
>>>> run: |
>>>> docker image tag ${{*vars.IMAGE_NAME*}} ${{
>>>> *vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
>>>> *steps.extract_branch.outputs.branch* }}
>>>> - name: Docker Push
>>>> run: |
>>>> docker push ${{*vars.DOCKER_HUB_REPO_NAME*}}/${{
>>>> *vars.IMAGE_NAME*}}:${{ *steps.extract_branch.outputs.branch* }}
>>>>
>>>> Regards
>>>>
>>>> Victor
>>>>
>>>>
>>>>
>>>> El dom, 26 may 2024 a las 11:48, VICTOR MANUEL ROMERO RODRIGUEZ (<
>>>> victor.romero@fintecheando.mx>) escribió:
>>>>
>>>>> The arm build is failing... I will try to change the GA Runner or the
>>>>> JVM distribution used by Jib for building the docker image.
>>>>>
>>>>> FYI of the GA (PR for now)
>>>>> https://github.com/apache/fineract/pull/3887/files
>>>>>
>>>>> * What went wrong:
>>>>> Execution failed for task ':fineract-provider:jibDockerBuild'.
>>>>> > Build to Docker daemon failed, perhaps you should make sure Docker
>>>>> is installed and you have correct privileges to run it
>>>>>
>>>>> El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
>>>>> victor.romero@fintecheando.mx>) escribió:
>>>>>
>>>>>> I have been working on this during this weekend, still pending the
>>>>>> linux/arm64. The linux/amd64 is ready.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> El sáb, 25 may 2024 a las 22:15, James Dailey (<
>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>
>>>>>>> Victor - what’s the update on this? Can we deploy now ?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Sent from Gmail Mobile
>>>>>>>
>>>>>>>
>>>>>>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>
>>>>>>>> Arnold,
>>>>>>>>
>>>>>>>> Suggestion welcome, let me add both platforms.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>>>>>>> galovicsarnold@gmail.com>) escribió:
>>>>>>>>
>>>>>>>>> Victor,
>>>>>>>>>
>>>>>>>>> I think we are missing one crucial thing in your PR, to build the
>>>>>>>>> image multi-platform, specifically for x86 and arm.
>>>>>>>>>
>>>>>>>>> Would it be possible for you to add it?
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>> Best,
>>>>>>>>> Arnold
>>>>>>>>>
>>>>>>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Sure thing... we are glad to help while you guys sort out the
>>>>>>>>>> kinks.
>>>>>>>>>>
>>>>>>>>>> Collins, please set up a separate thread or email me directly and
>>>>>>>>>> we will help you get set up.
>>>>>>>>>>
>>>>>>>>>> Campbell
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <
>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>> >(Collins & Campbell - please start new thread)
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <
>>>>>>>>>> collinschuwa@gmail.com> wrote:
>>>>>>>>>> >
>>>>>>>>>> >> Hi Campbell,
>>>>>>>>>> >>
>>>>>>>>>> >> Please would you be able to share the steps on how to get
>>>>>>>>>> Fineract 1.8
>>>>>>>>>> >> deployed with Docker?
>>>>>>>>>> >> I have tried, doing this and could not get it to work.
>>>>>>>>>> >>
>>>>>>>>>> >> Collins
>>>>>>>>>> >>
>>>>>>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com>
>>>>>>>>>> wrote:
>>>>>>>>>> >>
>>>>>>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>>>>>>> moment and
>>>>>>>>>> >>> is readying for 1.9.
>>>>>>>>>> >>>
>>>>>>>>>> >>> We would offer our help if needed.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Campbell
>>>>>>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here
>>>>>>>>>> - not on
>>>>>>>>>> >>> the project but willing to help out. He has offered some
>>>>>>>>>> advice for the
>>>>>>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>>>>>>> again. I would
>>>>>>>>>> >>> like to have either a push back or we should restore the
>>>>>>>>>> docker file asap.
>>>>>>>>>> >>>
>>>>>>>>>> >>> To recap:
>>>>>>>>>> >>> The DockerHub Image is two years old, and the process to
>>>>>>>>>> pull from our
>>>>>>>>>> >>> Dev branch has been broken that entire time. It broke when
>>>>>>>>>> we removed the
>>>>>>>>>> >>> docker-build file with this ticket
>>>>>>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>>>>>>> >>>
>>>>>>>>>> >>> With a Million downloads of fineract from DockerHUB, where
>>>>>>>>>> that version
>>>>>>>>>> >>> has multiple CVEs (security issues), we should not be
>>>>>>>>>> continuing to keep
>>>>>>>>>> >>> that there.
>>>>>>>>>> >>>
>>>>>>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>>>>>>> required
>>>>>>>>>> >>> from infra.
>>>>>>>>>> >>>
>>>>>>>>>> >>> Todd's comments:
>>>>>>>>>> >>>
>>>>>>>>>> >>> Extended Summary
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> The problem for the internal Fineract development pipeline
>>>>>>>>>> is that
>>>>>>>>>> >>>> changes were made to the build process that
>>>>>>>>>> >>>> removed the expected Dockerfile
>>>>>>>>>> >>>> added an external dependency to the code repo (mifos
>>>>>>>>>> community-app web
>>>>>>>>>> >>>> UI)
>>>>>>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> At first glance, the lack of a Dockerfile in the code might
>>>>>>>>>> seem to be
>>>>>>>>>> >>>> the reason that no containers have been pushed to Docker
>>>>>>>>>> Hub. A Dockerfile
>>>>>>>>>> >>>> is the standard way of creating images. This is very
>>>>>>>>>> confusing for many
>>>>>>>>>> >>>> people (including me), however this is not the actual
>>>>>>>>>> problem because JIB
>>>>>>>>>> >>>> (Java Image Builder) is set up to build the image during
>>>>>>>>>> testing directly
>>>>>>>>>> >>>> from java source code by Gradle in two places:
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> build-docker-postgresql.yml
>>>>>>>>>> >>>> build-docker-mariadb.yml
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>>>>>>> actually push
>>>>>>>>>> >>>> the container image to Docker Hub. It only seems to be
>>>>>>>>>> configured to build
>>>>>>>>>> >>>> the image for testing.
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> To solve this, two things need to be done:
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> - It needs to be decided when to push the image (and
>>>>>>>>>> possibly create
>>>>>>>>>> >>>> a new GitHub Action to do it)
>>>>>>>>>> >>>> - Code needs to be added to configure JIB to know where
>>>>>>>>>> to push the
>>>>>>>>>> >>>> image on Docker Hub (see this example)
>>>>>>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>>>>>>> allow it
>>>>>>>>>> >>>> actually push the image
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> Additional Open Source Observations (Optics)
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> Dockerfile
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>>>>>>> (especially
>>>>>>>>>> >>>> coupled with the existence of a docker-compose.yml file) and
>>>>>>>>>> also makes it
>>>>>>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>>>>>>> because now
>>>>>>>>>> >>>> dependencies need to be installed locally, rather than
>>>>>>>>>> running them all in
>>>>>>>>>> >>>> containers.
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard
>>>>>>>>>> from an Open
>>>>>>>>>> >>>> Source perspective. Regardless of whether it is needed by
>>>>>>>>>> the Fineract
>>>>>>>>>> >>>> build process or not, most open source projects include a
>>>>>>>>>> Dockerfile, and
>>>>>>>>>> >>>> most open source users expect one to exist in the repo so
>>>>>>>>>> they can easily
>>>>>>>>>> >>>> build / run / test the project locally. Adding the
>>>>>>>>>> Dockerfile back to the
>>>>>>>>>> >>>> repo should be trivial (and removes the need for JIB
>>>>>>>>>> entirely).
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> General Setup
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> The current Fineract process for building and running using
>>>>>>>>>> containers
>>>>>>>>>> >>>> makes it significantly harder for developers to get started
>>>>>>>>>> with Fineract
>>>>>>>>>> >>>> because a local Java environment needs to be installed. More
>>>>>>>>>> disappointing,
>>>>>>>>>> >>>> a completely different public set of instructions exist on
>>>>>>>>>> Docker Hub .
>>>>>>>>>> >>>> These instructions do not work because they are out of date,
>>>>>>>>>> but are
>>>>>>>>>> >>>> significantly easier for developers to use. Having two sets
>>>>>>>>>> of different
>>>>>>>>>> >>>> install instructions is confusing, but having the simpler
>>>>>>>>>> set of
>>>>>>>>>> >>>> instructions that do not work is a very bad developer
>>>>>>>>>> experience.
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>
>>>>>>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO
>>>>>>>>>> RODRIGUEZ <
>>>>>>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>> >>>>
>>>>>>>>>> >>>>> Hello,
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>> Another way to have the Docker Hub image published (just
>>>>>>>>>> like Apache
>>>>>>>>>> >>>>> Tomcat):
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>> https://github.com/docker-library/official-images
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>> Regards
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>>>>>>> jdailey@apache.org>)
>>>>>>>>>> >>>>> escribió:
>>>>>>>>>> >>>>>
>>>>>>>>>> >>>>>> Is there an easy thing to request?
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> ---------- Forwarded message ---------
>>>>>>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>>>>>> >>>>>> Subject: Re: Docker help
>>>>>>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>>>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> Hi James.
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>>>>>>> jdailey@apache.org>
>>>>>>>>>> >>>>>> wrote:
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>> Infra -
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>>>>>>> >>>>>>> apache DockerHUB?
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> Current supported methods are via Github Actions or
>>>>>>>>>> Jenkins or locally
>>>>>>>>>> >>>>>> via your own credentials.
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> For Github Actions we can use a role account and attach
>>>>>>>>>> the secrets to
>>>>>>>>>> >>>>>> your repository, or you
>>>>>>>>>> >>>>>> can provide your own secrets for us to add to your
>>>>>>>>>> repository
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> For Jenkins we have a role account that we provide access
>>>>>>>>>> to push to
>>>>>>>>>> >>>>>> your repository.
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> Committers could also use a settings.xml with this plugin
>>>>>>>>>> and use
>>>>>>>>>> >>>>>> their own credentials, we just need
>>>>>>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> There may also be other methods not explored.
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> See also:
>>>>>>>>>> >>>>>>
>>>>>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> HTH
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>>>>>>> dockerfile at
>>>>>>>>>> >>>>>>> the root.
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>>>>>>> Dockerhub". ?
>>>>>>>>>> >>>>>>> Can we get credentials ?
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> James
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>>>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>>>>> >>>>>>> Subject: Re: Docker help
>>>>>>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> James,
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>>>>>>> definitely
>>>>>>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean
>>>>>>>>>> it's the only way
>>>>>>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> Best,
>>>>>>>>>> >>>>>>> Arnold
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>>>>>>> jamespdailey@gmail.com>
>>>>>>>>>> >>>>>>> wrote:
>>>>>>>>>> >>>>>>>
>>>>>>>>>> >>>>>>>> On DockerHUB the build fails because there is no
>>>>>>>>>> dockerfile.
>>>>>>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>>>>>>> infrastructure...
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA
>>>>>>>>>> host key for
>>>>>>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>>>>>> 'origin/develop'.
>>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or
>>>>>>>>>> to get this
>>>>>>>>>> >>>>>>>> working.
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>>>>>>> arnold@apache.org>
>>>>>>>>>> >>>>>>>> wrote:
>>>>>>>>>> >>>>>>>>
>>>>>>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>> Just to reflect on your points:
>>>>>>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we
>>>>>>>>>> absolutely need to
>>>>>>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain.
>>>>>>>>>> We already
>>>>>>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions
>>>>>>>>>> (using their
>>>>>>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>>>>>>> alter the
>>>>>>>>>> >>>>>>>>> pipeline and that's all.
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>> If the only thing preventing us from doing this is to
>>>>>>>>>> keep asking
>>>>>>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead
>>>>>>>>>> of making such an
>>>>>>>>>> >>>>>>>>> unnecessary change.
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>> Arnold
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>> >>>>>>>>>
>>>>>>>>>> >>>>>>>>>> Thanks Zoltan
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion?
>>>>>>>>>> As this
>>>>>>>>>> >>>>>>>>>> relates to the Google deployment that you put in
>>>>>>>>>> place? Question!
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>>> >>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> Hi,
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>>>>>>> GoogleContainerTools's
>>>>>>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without
>>>>>>>>>> a Dockerfile. And
>>>>>>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't
>>>>>>>>>> support building without
>>>>>>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite
>>>>>>>>>> large change of how
>>>>>>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be
>>>>>>>>>> explored - but it's
>>>>>>>>>> >>>>>>>>>>> definitely doable.
>>>>>>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build
>>>>>>>>>> tools like
>>>>>>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub.
>>>>>>>>>> This could also work,
>>>>>>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we
>>>>>>>>>> have.
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it
>>>>>>>>>> will be
>>>>>>>>>> >>>>>>>>>>> different from what Jib can produce, so this might
>>>>>>>>>> lead to regressions.
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> Kind regards,
>>>>>>>>>> >>>>>>>>>>> Zoltan
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>> >>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default
>>>>>>>>>> “build rule “
>>>>>>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In
>>>>>>>>>> fact that’s what is
>>>>>>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be
>>>>>>>>>> fine.
>>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>> Thanks
>>>>>>>>>> >>>>>>>>>>>> James
>>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>>>>>>> RODRIGUEZ <
>>>>>>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>>>>>>> following:
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>>>>>>> handling
>>>>>>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>>>> scripts) from the
>>>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop
>>>>>>>>>> with
>>>>>>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the
>>>>>>>>>> master branch everytime the
>>>>>>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the
>>>>>>>>>> dockerhub will publish it as
>>>>>>>>>> >>>>>>>>>>>>> the latest version.
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on
>>>>>>>>>> it for
>>>>>>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>>>> scripts) from the
>>>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>>>>>>> dockerhub will
>>>>>>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> What do you think?
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> Regards
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as
>>>>>>>>>> well, as that is
>>>>>>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>>>>>>> However, to add the key
>>>>>>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>>>>>>> controlled by Apache Infra.
>>>>>>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that
>>>>>>>>>> is what
>>>>>>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think
>>>>>>>>>> infra has it setup a
>>>>>>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to
>>>>>>>>>> publish to the Apache
>>>>>>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL
>>>>>>>>>> ROMERO RODRIGUEZ <
>>>>>>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>>>>>>> credentials of
>>>>>>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github
>>>>>>>>>> action can be
>>>>>>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>> Regards
>>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB
>>>>>>>>>> to work.
>>>>>>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the
>>>>>>>>>> Fineract
>>>>>>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so
>>>>>>>>>> that every
>>>>>>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new
>>>>>>>>>> deployment.
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running
>>>>>>>>>> because we
>>>>>>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the
>>>>>>>>>> root. That is as far as I've
>>>>>>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that
>>>>>>>>>> at the time.
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get
>>>>>>>>>> the Docker
>>>>>>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down.
>>>>>>>>>> Our standard is to only
>>>>>>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>>>>>>> releases. This build is really
>>>>>>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded
>>>>>>>>>> in large numbers. (no idea
>>>>>>>>>> >>>>>>>>>>>>>>>> why)
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>>>>>>> >>>>>>>>>>>>>>>> James
>>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> --
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> *Gavin McDonald - *
>>>>>>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>>>>>> >>>>>> V.P Travel Assistance Committee
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> https://tac.apache.org - Applications now open for
>>>>>>>>>> Community Over
>>>>>>>>>> >>>>>> Code 2024
>>>>>>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>>>>> >>>>>>
>>>>>>>>>> >>>>>> --
>>>>>>>>>> >>>
>>>>>>>>>> >>> Herring BANCORP ®
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>>>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>>>>>>> >>>
>>>>>>>>>> >>> ccb@herringbancorp.com
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>> *Herring Bancorp*
>>>>>>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>>>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>>>>>>> >>> <
>>>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>>>> >
>>>>>>>>>> >>> Amarillo, TX 79109
>>>>>>>>>> >>> <
>>>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>>>> >
>>>>>>>>>> >>>
>>>>>>>>>> >>> www.herringbank.com
>>>>>>>>>> >>>
>>>>>>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the
>>>>>>>>>> use of the
>>>>>>>>>> >>> individual or entity to which it is addressed and may contain
>>>>>>>>>> information
>>>>>>>>>> >>> that is privileged, confidential and exempt from disclosure
>>>>>>>>>> under
>>>>>>>>>> >>> applicable law. If the reader of this e-mail message is not
>>>>>>>>>> the intended
>>>>>>>>>> >>> recipient, or the employee or agent responsible for delivery
>>>>>>>>>> of the message
>>>>>>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>>>>>>> dissemination,
>>>>>>>>>> >>> distribution or copying of this communication is prohibited.
>>>>>>>>>> If you have
>>>>>>>>>> >>> received this e-mail in error, please notify us immediately
>>>>>>>>>> by telephone at
>>>>>>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>>
>>>>>>>>>> >>
>>>>>>>>>>
>>>>>>>>>
Re: Docker help
Posted by Arnold Galovics <ar...@apache.org>.
Good point Victor.
Almost forgot about this error. I'd leave the original configuration in
place.
The reason you're getting this error is because the local Docker repository
is not supporting multi-platform images (Win/Mac for sure, not sure about
Linux). If you're pushing this to a remote repository that supports
multi-platform images, the error is gone.
Yet if somebody is building it locally with your updated configuration, it
will be confusing for sure, so I don't recommend permanently changing it.
However JIB config can be overridden from command line, here's how we
solved it already on a project:
./gradlew :fineract-provider:jib -x test
-Djib.from.platforms=linux/amd64,linux/arm64
If you do this in the workflow, it'll correctly create the multi-platform
image and users locally building won't be affected.
Hope this helps.
Best,
Arnold
On Mon, May 27, 2024 at 9:03 PM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> Hello Arnold,
>
> Currently we got this
>
> platforms {
> platform {
> architecture =
> System.getProperty("os.arch").equals("aarch64")?"arm64":"amd64"
> os = 'linux'
> }
> }
>
> If we set to this
>
> platform {
> architecture = 'amd64'
> os = 'linux'
> }
> platform {
> architecture = 'arm64'
> os = 'linux'
> }
>
> People could have this kind of issues when building the docker image
> locally using Jib
>
> *"... multi-platform image building not supported when pushing to Docker
> engine"*
>
> That is the reason I was looking for a native Github Action Arm64 runner
>
> Any ideas are welcome.
>
> Regards
>
> El lun, 27 may 2024 a las 3:37, Arnold Galovics (<ga...@gmail.com>)
> escribió:
>
>> Hi Victor,
>>
>> Alright.
>>
>> Note: probably JIB would be a better choice for the cross-platform
>> building since it doesn't require an ARM emulator/ARM machine for building
>> the Docker image.
>>
>> Best,
>> Arnold
>>
>> On Mon, May 27, 2024 at 7:40 AM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Hello James/Arnold/Community,
>>>
>>> There is not Arm64 Linux runner on GitHub Actions (at least not for the
>>> free tier that I have access), there is a current Gihub discussion about
>>> this topic https://github.com/orgs/community/discussions/19197
>>>
>>> With this limitation we cannot build a linux/arm for Docker image.
>>>
>>> I have tried to use QEMU and RunOnArchitecture Github Action but they
>>> are very slow... and after 50 minutes they throw errors about Docker, due
>>> to limitations of embedded virtualization.
>>>
>>> Now let's focus on the linux/amd... with the current runner I just want
>>> to know if we can keep variables or use fixed values. This is because maybe
>>> there are limitations about setting variables for the Github Actions.
>>>
>>> Also I have more questions, currently there is a docker tagged image as
>>> "latest" on Docker Hub https://hub.docker.com/r/apache/fineract/tags ,
>>> should we use "latest" tag? or should we use the branch name?
>>>
>>> I bring to the list the code that requires attention to my questions.
>>>
>>> - name: Image Tag
>>> run: |
>>> docker image tag ${{*vars.IMAGE_NAME*}} ${{
>>> *vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
>>> *steps.extract_branch.outputs.branch* }}
>>> - name: Docker Push
>>> run: |
>>> docker push ${{*vars.DOCKER_HUB_REPO_NAME*}}/${{
>>> *vars.IMAGE_NAME*}}:${{ *steps.extract_branch.outputs.branch* }}
>>>
>>> Regards
>>>
>>> Victor
>>>
>>>
>>>
>>> El dom, 26 may 2024 a las 11:48, VICTOR MANUEL ROMERO RODRIGUEZ (<
>>> victor.romero@fintecheando.mx>) escribió:
>>>
>>>> The arm build is failing... I will try to change the GA Runner or the
>>>> JVM distribution used by Jib for building the docker image.
>>>>
>>>> FYI of the GA (PR for now)
>>>> https://github.com/apache/fineract/pull/3887/files
>>>>
>>>> * What went wrong:
>>>> Execution failed for task ':fineract-provider:jibDockerBuild'.
>>>> > Build to Docker daemon failed, perhaps you should make sure Docker
>>>> is installed and you have correct privileges to run it
>>>>
>>>> El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
>>>> victor.romero@fintecheando.mx>) escribió:
>>>>
>>>>> I have been working on this during this weekend, still pending the
>>>>> linux/arm64. The linux/amd64 is ready.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
>>>>> escribió:
>>>>>
>>>>>> Victor - what’s the update on this? Can we deploy now ?
>>>>>>
>>>>>>
>>>>>>
>>>>>> Sent from Gmail Mobile
>>>>>>
>>>>>>
>>>>>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>
>>>>>>> Arnold,
>>>>>>>
>>>>>>> Suggestion welcome, let me add both platforms.
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>>>>>> galovicsarnold@gmail.com>) escribió:
>>>>>>>
>>>>>>>> Victor,
>>>>>>>>
>>>>>>>> I think we are missing one crucial thing in your PR, to build the
>>>>>>>> image multi-platform, specifically for x86 and arm.
>>>>>>>>
>>>>>>>> Would it be possible for you to add it?
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>> Best,
>>>>>>>> Arnold
>>>>>>>>
>>>>>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>>>>>>
>>>>>>>>> Sure thing... we are glad to help while you guys sort out the
>>>>>>>>> kinks.
>>>>>>>>>
>>>>>>>>> Collins, please set up a separate thread or email me directly and
>>>>>>>>> we will help you get set up.
>>>>>>>>>
>>>>>>>>> Campbell
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>> >(Collins & Campbell - please start new thread)
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <
>>>>>>>>> collinschuwa@gmail.com> wrote:
>>>>>>>>> >
>>>>>>>>> >> Hi Campbell,
>>>>>>>>> >>
>>>>>>>>> >> Please would you be able to share the steps on how to get
>>>>>>>>> Fineract 1.8
>>>>>>>>> >> deployed with Docker?
>>>>>>>>> >> I have tried, doing this and could not get it to work.
>>>>>>>>> >>
>>>>>>>>> >> Collins
>>>>>>>>> >>
>>>>>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com>
>>>>>>>>> wrote:
>>>>>>>>> >>
>>>>>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>>>>>> moment and
>>>>>>>>> >>> is readying for 1.9.
>>>>>>>>> >>>
>>>>>>>>> >>> We would offer our help if needed.
>>>>>>>>> >>>
>>>>>>>>> >>> Campbell
>>>>>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>>>>>> >>>
>>>>>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here
>>>>>>>>> - not on
>>>>>>>>> >>> the project but willing to help out. He has offered some
>>>>>>>>> advice for the
>>>>>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>>>>>> again. I would
>>>>>>>>> >>> like to have either a push back or we should restore the
>>>>>>>>> docker file asap.
>>>>>>>>> >>>
>>>>>>>>> >>> To recap:
>>>>>>>>> >>> The DockerHub Image is two years old, and the process to pull
>>>>>>>>> from our
>>>>>>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>>>>>>> removed the
>>>>>>>>> >>> docker-build file with this ticket
>>>>>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>>>>>> >>>
>>>>>>>>> >>> With a Million downloads of fineract from DockerHUB, where
>>>>>>>>> that version
>>>>>>>>> >>> has multiple CVEs (security issues), we should not be
>>>>>>>>> continuing to keep
>>>>>>>>> >>> that there.
>>>>>>>>> >>>
>>>>>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>>>>>> required
>>>>>>>>> >>> from infra.
>>>>>>>>> >>>
>>>>>>>>> >>> Todd's comments:
>>>>>>>>> >>>
>>>>>>>>> >>> Extended Summary
>>>>>>>>> >>>>
>>>>>>>>> >>>> The problem for the internal Fineract development pipeline is
>>>>>>>>> that
>>>>>>>>> >>>> changes were made to the build process that
>>>>>>>>> >>>> removed the expected Dockerfile
>>>>>>>>> >>>> added an external dependency to the code repo (mifos
>>>>>>>>> community-app web
>>>>>>>>> >>>> UI)
>>>>>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>>>>>> >>>>
>>>>>>>>> >>>> At first glance, the lack of a Dockerfile in the code might
>>>>>>>>> seem to be
>>>>>>>>> >>>> the reason that no containers have been pushed to Docker Hub.
>>>>>>>>> A Dockerfile
>>>>>>>>> >>>> is the standard way of creating images. This is very
>>>>>>>>> confusing for many
>>>>>>>>> >>>> people (including me), however this is not the actual problem
>>>>>>>>> because JIB
>>>>>>>>> >>>> (Java Image Builder) is set up to build the image during
>>>>>>>>> testing directly
>>>>>>>>> >>>> from java source code by Gradle in two places:
>>>>>>>>> >>>>
>>>>>>>>> >>>> build-docker-postgresql.yml
>>>>>>>>> >>>> build-docker-mariadb.yml
>>>>>>>>> >>>>
>>>>>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>>>>>> actually push
>>>>>>>>> >>>> the container image to Docker Hub. It only seems to be
>>>>>>>>> configured to build
>>>>>>>>> >>>> the image for testing.
>>>>>>>>> >>>>
>>>>>>>>> >>>> To solve this, two things need to be done:
>>>>>>>>> >>>>
>>>>>>>>> >>>>
>>>>>>>>> >>>> - It needs to be decided when to push the image (and
>>>>>>>>> possibly create
>>>>>>>>> >>>> a new GitHub Action to do it)
>>>>>>>>> >>>> - Code needs to be added to configure JIB to know where to
>>>>>>>>> push the
>>>>>>>>> >>>> image on Docker Hub (see this example)
>>>>>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>>>>>> allow it
>>>>>>>>> >>>> actually push the image
>>>>>>>>> >>>>
>>>>>>>>> >>>>
>>>>>>>>> >>>> Additional Open Source Observations (Optics)
>>>>>>>>> >>>>
>>>>>>>>> >>>> Dockerfile
>>>>>>>>> >>>>
>>>>>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>>>>>> (especially
>>>>>>>>> >>>> coupled with the existence of a docker-compose.yml file) and
>>>>>>>>> also makes it
>>>>>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>>>>>> because now
>>>>>>>>> >>>> dependencies need to be installed locally, rather than
>>>>>>>>> running them all in
>>>>>>>>> >>>> containers.
>>>>>>>>> >>>>
>>>>>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard
>>>>>>>>> from an Open
>>>>>>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>>>>>>> Fineract
>>>>>>>>> >>>> build process or not, most open source projects include a
>>>>>>>>> Dockerfile, and
>>>>>>>>> >>>> most open source users expect one to exist in the repo so
>>>>>>>>> they can easily
>>>>>>>>> >>>> build / run / test the project locally. Adding the
>>>>>>>>> Dockerfile back to the
>>>>>>>>> >>>> repo should be trivial (and removes the need for JIB
>>>>>>>>> entirely).
>>>>>>>>> >>>>
>>>>>>>>> >>>> General Setup
>>>>>>>>> >>>>
>>>>>>>>> >>>> The current Fineract process for building and running using
>>>>>>>>> containers
>>>>>>>>> >>>> makes it significantly harder for developers to get started
>>>>>>>>> with Fineract
>>>>>>>>> >>>> because a local Java environment needs to be installed. More
>>>>>>>>> disappointing,
>>>>>>>>> >>>> a completely different public set of instructions exist on
>>>>>>>>> Docker Hub .
>>>>>>>>> >>>> These instructions do not work because they are out of date,
>>>>>>>>> but are
>>>>>>>>> >>>> significantly easier for developers to use. Having two sets
>>>>>>>>> of different
>>>>>>>>> >>>> install instructions is confusing, but having the simpler set
>>>>>>>>> of
>>>>>>>>> >>>> instructions that do not work is a very bad developer
>>>>>>>>> experience.
>>>>>>>>> >>>>
>>>>>>>>> >>>>
>>>>>>>>> >>>>
>>>>>>>>> >>>>
>>>>>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO
>>>>>>>>> RODRIGUEZ <
>>>>>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>> >>>>
>>>>>>>>> >>>>> Hello,
>>>>>>>>> >>>>>
>>>>>>>>> >>>>> Another way to have the Docker Hub image published (just
>>>>>>>>> like Apache
>>>>>>>>> >>>>> Tomcat):
>>>>>>>>> >>>>>
>>>>>>>>> >>>>> https://github.com/docker-library/official-images
>>>>>>>>> >>>>>
>>>>>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>>>>>> >>>>>
>>>>>>>>> >>>>> Regards
>>>>>>>>> >>>>>
>>>>>>>>> >>>>>
>>>>>>>>> >>>>>
>>>>>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>>>>>> jdailey@apache.org>)
>>>>>>>>> >>>>> escribió:
>>>>>>>>> >>>>>
>>>>>>>>> >>>>>> Is there an easy thing to request?
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> ---------- Forwarded message ---------
>>>>>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>>>>> >>>>>> Subject: Re: Docker help
>>>>>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> Hi James.
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>>>>>> jdailey@apache.org>
>>>>>>>>> >>>>>> wrote:
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>> Infra -
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>>>>>> >>>>>>> apache DockerHUB?
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> Current supported methods are via Github Actions or Jenkins
>>>>>>>>> or locally
>>>>>>>>> >>>>>> via your own credentials.
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>>>>>>> secrets to
>>>>>>>>> >>>>>> your repository, or you
>>>>>>>>> >>>>>> can provide your own secrets for us to add to your
>>>>>>>>> repository
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> For Jenkins we have a role account that we provide access
>>>>>>>>> to push to
>>>>>>>>> >>>>>> your repository.
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> Committers could also use a settings.xml with this plugin
>>>>>>>>> and use
>>>>>>>>> >>>>>> their own credentials, we just need
>>>>>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> There may also be other methods not explored.
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> See also:
>>>>>>>>> >>>>>>
>>>>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> HTH
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>>>>>> dockerfile at
>>>>>>>>> >>>>>>> the root.
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>>>>>> Dockerhub". ?
>>>>>>>>> >>>>>>> Can we get credentials ?
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> James
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>>>> >>>>>>> Subject: Re: Docker help
>>>>>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> James,
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>>>>>> definitely
>>>>>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean
>>>>>>>>> it's the only way
>>>>>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> Best,
>>>>>>>>> >>>>>>> Arnold
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com>
>>>>>>>>> >>>>>>> wrote:
>>>>>>>>> >>>>>>>
>>>>>>>>> >>>>>>>> On DockerHUB the build fails because there is no
>>>>>>>>> dockerfile.
>>>>>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>>>>>> infrastructure...
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA
>>>>>>>>> host key for
>>>>>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>>>>> 'origin/develop'.
>>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to
>>>>>>>>> get this
>>>>>>>>> >>>>>>>> working.
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>>>>>> arnold@apache.org>
>>>>>>>>> >>>>>>>> wrote:
>>>>>>>>> >>>>>>>>
>>>>>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>> Just to reflect on your points:
>>>>>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we
>>>>>>>>> absolutely need to
>>>>>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain.
>>>>>>>>> We already
>>>>>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions
>>>>>>>>> (using their
>>>>>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>>>>>> alter the
>>>>>>>>> >>>>>>>>> pipeline and that's all.
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>> If the only thing preventing us from doing this is to
>>>>>>>>> keep asking
>>>>>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead
>>>>>>>>> of making such an
>>>>>>>>> >>>>>>>>> unnecessary change.
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>> Arnold
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>> >>>>>>>>>
>>>>>>>>> >>>>>>>>>> Thanks Zoltan
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion?
>>>>>>>>> As this
>>>>>>>>> >>>>>>>>>> relates to the Google deployment that you put in
>>>>>>>>> place? Question!
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>> >>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> Hi,
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>>>>>> GoogleContainerTools's
>>>>>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without
>>>>>>>>> a Dockerfile. And
>>>>>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't
>>>>>>>>> support building without
>>>>>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>>>>>>> change of how
>>>>>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be
>>>>>>>>> explored - but it's
>>>>>>>>> >>>>>>>>>>> definitely doable.
>>>>>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build
>>>>>>>>> tools like
>>>>>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub.
>>>>>>>>> This could also work,
>>>>>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we
>>>>>>>>> have.
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it
>>>>>>>>> will be
>>>>>>>>> >>>>>>>>>>> different from what Jib can produce, so this might
>>>>>>>>> lead to regressions.
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> Kind regards,
>>>>>>>>> >>>>>>>>>>> Zoltan
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>> >>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default
>>>>>>>>> “build rule “
>>>>>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In
>>>>>>>>> fact that’s what is
>>>>>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be
>>>>>>>>> fine.
>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>> Thanks
>>>>>>>>> >>>>>>>>>>>> James
>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>>>>>> RODRIGUEZ <
>>>>>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>> >>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>>>>>> following:
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>>>>>> handling
>>>>>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>>> scripts) from the
>>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop
>>>>>>>>> with
>>>>>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the
>>>>>>>>> master branch everytime the
>>>>>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the
>>>>>>>>> dockerhub will publish it as
>>>>>>>>> >>>>>>>>>>>>> the latest version.
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on
>>>>>>>>> it for
>>>>>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>>> scripts) from the
>>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>>>>>> dockerhub will
>>>>>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> What do you think?
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> Regards
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>> >>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well,
>>>>>>>>> as that is
>>>>>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>>>>>> However, to add the key
>>>>>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>>>>>> controlled by Apache Infra.
>>>>>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that
>>>>>>>>> is what
>>>>>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think
>>>>>>>>> infra has it setup a
>>>>>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to
>>>>>>>>> publish to the Apache
>>>>>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>>>>>>> RODRIGUEZ <
>>>>>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>>>>>> credentials of
>>>>>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github
>>>>>>>>> action can be
>>>>>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>> Regards
>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB
>>>>>>>>> to work.
>>>>>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the
>>>>>>>>> Fineract
>>>>>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that
>>>>>>>>> every
>>>>>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running
>>>>>>>>> because we
>>>>>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root.
>>>>>>>>> That is as far as I've
>>>>>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that
>>>>>>>>> at the time.
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get
>>>>>>>>> the Docker
>>>>>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>>>>>>> standard is to only
>>>>>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>>>>>> releases. This build is really
>>>>>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>>>>>>> large numbers. (no idea
>>>>>>>>> >>>>>>>>>>>>>>>> why)
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>>>>>> >>>>>>>>>>>>>>>> James
>>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> --
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> *Gavin McDonald - *
>>>>>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>>>>> >>>>>> V.P Travel Assistance Committee
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> https://tac.apache.org - Applications now open for
>>>>>>>>> Community Over
>>>>>>>>> >>>>>> Code 2024
>>>>>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>>>> >>>>>>
>>>>>>>>> >>>>>> --
>>>>>>>>> >>>
>>>>>>>>> >>> Herring BANCORP ®
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>>>>>> >>>
>>>>>>>>> >>> ccb@herringbancorp.com
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>> *Herring Bancorp*
>>>>>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>>>>>> >>> <
>>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>>> >
>>>>>>>>> >>> Amarillo, TX 79109
>>>>>>>>> >>> <
>>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>>> >
>>>>>>>>> >>>
>>>>>>>>> >>> www.herringbank.com
>>>>>>>>> >>>
>>>>>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use
>>>>>>>>> of the
>>>>>>>>> >>> individual or entity to which it is addressed and may contain
>>>>>>>>> information
>>>>>>>>> >>> that is privileged, confidential and exempt from disclosure
>>>>>>>>> under
>>>>>>>>> >>> applicable law. If the reader of this e-mail message is not
>>>>>>>>> the intended
>>>>>>>>> >>> recipient, or the employee or agent responsible for delivery
>>>>>>>>> of the message
>>>>>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>>>>>> dissemination,
>>>>>>>>> >>> distribution or copying of this communication is prohibited.
>>>>>>>>> If you have
>>>>>>>>> >>> received this e-mail in error, please notify us immediately by
>>>>>>>>> telephone at
>>>>>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>>
>>>>>>>>> >>
>>>>>>>>>
>>>>>>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Hello Arnold,
Currently we got this
platforms {
platform {
architecture =
System.getProperty("os.arch").equals("aarch64")?"arm64":"amd64"
os = 'linux'
}
}
If we set to this
platform {
architecture = 'amd64'
os = 'linux'
}
platform {
architecture = 'arm64'
os = 'linux'
}
People could have this kind of issues when building the docker image
locally using Jib
*"... multi-platform image building not supported when pushing to Docker
engine"*
That is the reason I was looking for a native Github Action Arm64 runner
Any ideas are welcome.
Regards
El lun, 27 may 2024 a las 3:37, Arnold Galovics (<ga...@gmail.com>)
escribió:
> Hi Victor,
>
> Alright.
>
> Note: probably JIB would be a better choice for the cross-platform
> building since it doesn't require an ARM emulator/ARM machine for building
> the Docker image.
>
> Best,
> Arnold
>
> On Mon, May 27, 2024 at 7:40 AM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> Hello James/Arnold/Community,
>>
>> There is not Arm64 Linux runner on GitHub Actions (at least not for the
>> free tier that I have access), there is a current Gihub discussion about
>> this topic https://github.com/orgs/community/discussions/19197
>>
>> With this limitation we cannot build a linux/arm for Docker image.
>>
>> I have tried to use QEMU and RunOnArchitecture Github Action but they are
>> very slow... and after 50 minutes they throw errors about Docker, due
>> to limitations of embedded virtualization.
>>
>> Now let's focus on the linux/amd... with the current runner I just want
>> to know if we can keep variables or use fixed values. This is because maybe
>> there are limitations about setting variables for the Github Actions.
>>
>> Also I have more questions, currently there is a docker tagged image as
>> "latest" on Docker Hub https://hub.docker.com/r/apache/fineract/tags ,
>> should we use "latest" tag? or should we use the branch name?
>>
>> I bring to the list the code that requires attention to my questions.
>>
>> - name: Image Tag
>> run: |
>> docker image tag ${{*vars.IMAGE_NAME*}} ${{
>> *vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
>> *steps.extract_branch.outputs.branch* }}
>> - name: Docker Push
>> run: |
>> docker push ${{*vars.DOCKER_HUB_REPO_NAME*}}/${{
>> *vars.IMAGE_NAME*}}:${{ *steps.extract_branch.outputs.branch* }}
>>
>> Regards
>>
>> Victor
>>
>>
>>
>> El dom, 26 may 2024 a las 11:48, VICTOR MANUEL ROMERO RODRIGUEZ (<
>> victor.romero@fintecheando.mx>) escribió:
>>
>>> The arm build is failing... I will try to change the GA Runner or the
>>> JVM distribution used by Jib for building the docker image.
>>>
>>> FYI of the GA (PR for now)
>>> https://github.com/apache/fineract/pull/3887/files
>>>
>>> * What went wrong:
>>> Execution failed for task ':fineract-provider:jibDockerBuild'.
>>> > Build to Docker daemon failed, perhaps you should make sure Docker
>>> is installed and you have correct privileges to run it
>>>
>>> El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
>>> victor.romero@fintecheando.mx>) escribió:
>>>
>>>> I have been working on this during this weekend, still pending the
>>>> linux/arm64. The linux/amd64 is ready.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
>>>> escribió:
>>>>
>>>>> Victor - what’s the update on this? Can we deploy now ?
>>>>>
>>>>>
>>>>>
>>>>> Sent from Gmail Mobile
>>>>>
>>>>>
>>>>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>
>>>>>> Arnold,
>>>>>>
>>>>>> Suggestion welcome, let me add both platforms.
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>>>>> galovicsarnold@gmail.com>) escribió:
>>>>>>
>>>>>>> Victor,
>>>>>>>
>>>>>>> I think we are missing one crucial thing in your PR, to build the
>>>>>>> image multi-platform, specifically for x86 and arm.
>>>>>>>
>>>>>>> Would it be possible for you to add it?
>>>>>>>
>>>>>>> Thanks.
>>>>>>> Best,
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>>>>>
>>>>>>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>>>>>>
>>>>>>>> Collins, please set up a separate thread or email me directly and
>>>>>>>> we will help you get set up.
>>>>>>>>
>>>>>>>> Campbell
>>>>>>>>
>>>>>>>>
>>>>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>>>>>>> wrote:
>>>>>>>> >(Collins & Campbell - please start new thread)
>>>>>>>> >
>>>>>>>> >
>>>>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <
>>>>>>>> collinschuwa@gmail.com> wrote:
>>>>>>>> >
>>>>>>>> >> Hi Campbell,
>>>>>>>> >>
>>>>>>>> >> Please would you be able to share the steps on how to get
>>>>>>>> Fineract 1.8
>>>>>>>> >> deployed with Docker?
>>>>>>>> >> I have tried, doing this and could not get it to work.
>>>>>>>> >>
>>>>>>>> >> Collins
>>>>>>>> >>
>>>>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com>
>>>>>>>> wrote:
>>>>>>>> >>
>>>>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>>>>> moment and
>>>>>>>> >>> is readying for 1.9.
>>>>>>>> >>>
>>>>>>>> >>> We would offer our help if needed.
>>>>>>>> >>>
>>>>>>>> >>> Campbell
>>>>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>>>>> >>>
>>>>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here -
>>>>>>>> not on
>>>>>>>> >>> the project but willing to help out. He has offered some
>>>>>>>> advice for the
>>>>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>>>>> again. I would
>>>>>>>> >>> like to have either a push back or we should restore the docker
>>>>>>>> file asap.
>>>>>>>> >>>
>>>>>>>> >>> To recap:
>>>>>>>> >>> The DockerHub Image is two years old, and the process to pull
>>>>>>>> from our
>>>>>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>>>>>> removed the
>>>>>>>> >>> docker-build file with this ticket
>>>>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>>>>> >>>
>>>>>>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>>>>>>> version
>>>>>>>> >>> has multiple CVEs (security issues), we should not be
>>>>>>>> continuing to keep
>>>>>>>> >>> that there.
>>>>>>>> >>>
>>>>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>>>>> required
>>>>>>>> >>> from infra.
>>>>>>>> >>>
>>>>>>>> >>> Todd's comments:
>>>>>>>> >>>
>>>>>>>> >>> Extended Summary
>>>>>>>> >>>>
>>>>>>>> >>>> The problem for the internal Fineract development pipeline is
>>>>>>>> that
>>>>>>>> >>>> changes were made to the build process that
>>>>>>>> >>>> removed the expected Dockerfile
>>>>>>>> >>>> added an external dependency to the code repo (mifos
>>>>>>>> community-app web
>>>>>>>> >>>> UI)
>>>>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>>>>> >>>>
>>>>>>>> >>>> At first glance, the lack of a Dockerfile in the code might
>>>>>>>> seem to be
>>>>>>>> >>>> the reason that no containers have been pushed to Docker Hub.
>>>>>>>> A Dockerfile
>>>>>>>> >>>> is the standard way of creating images. This is very confusing
>>>>>>>> for many
>>>>>>>> >>>> people (including me), however this is not the actual problem
>>>>>>>> because JIB
>>>>>>>> >>>> (Java Image Builder) is set up to build the image during
>>>>>>>> testing directly
>>>>>>>> >>>> from java source code by Gradle in two places:
>>>>>>>> >>>>
>>>>>>>> >>>> build-docker-postgresql.yml
>>>>>>>> >>>> build-docker-mariadb.yml
>>>>>>>> >>>>
>>>>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>>>>> actually push
>>>>>>>> >>>> the container image to Docker Hub. It only seems to be
>>>>>>>> configured to build
>>>>>>>> >>>> the image for testing.
>>>>>>>> >>>>
>>>>>>>> >>>> To solve this, two things need to be done:
>>>>>>>> >>>>
>>>>>>>> >>>>
>>>>>>>> >>>> - It needs to be decided when to push the image (and
>>>>>>>> possibly create
>>>>>>>> >>>> a new GitHub Action to do it)
>>>>>>>> >>>> - Code needs to be added to configure JIB to know where to
>>>>>>>> push the
>>>>>>>> >>>> image on Docker Hub (see this example)
>>>>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>>>>> allow it
>>>>>>>> >>>> actually push the image
>>>>>>>> >>>>
>>>>>>>> >>>>
>>>>>>>> >>>> Additional Open Source Observations (Optics)
>>>>>>>> >>>>
>>>>>>>> >>>> Dockerfile
>>>>>>>> >>>>
>>>>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>>>>> (especially
>>>>>>>> >>>> coupled with the existence of a docker-compose.yml file) and
>>>>>>>> also makes it
>>>>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>>>>> because now
>>>>>>>> >>>> dependencies need to be installed locally, rather than running
>>>>>>>> them all in
>>>>>>>> >>>> containers.
>>>>>>>> >>>>
>>>>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard from
>>>>>>>> an Open
>>>>>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>>>>>> Fineract
>>>>>>>> >>>> build process or not, most open source projects include a
>>>>>>>> Dockerfile, and
>>>>>>>> >>>> most open source users expect one to exist in the repo so they
>>>>>>>> can easily
>>>>>>>> >>>> build / run / test the project locally. Adding the Dockerfile
>>>>>>>> back to the
>>>>>>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>>>>>>> >>>>
>>>>>>>> >>>> General Setup
>>>>>>>> >>>>
>>>>>>>> >>>> The current Fineract process for building and running using
>>>>>>>> containers
>>>>>>>> >>>> makes it significantly harder for developers to get started
>>>>>>>> with Fineract
>>>>>>>> >>>> because a local Java environment needs to be installed. More
>>>>>>>> disappointing,
>>>>>>>> >>>> a completely different public set of instructions exist on
>>>>>>>> Docker Hub .
>>>>>>>> >>>> These instructions do not work because they are out of date,
>>>>>>>> but are
>>>>>>>> >>>> significantly easier for developers to use. Having two sets of
>>>>>>>> different
>>>>>>>> >>>> install instructions is confusing, but having the simpler set
>>>>>>>> of
>>>>>>>> >>>> instructions that do not work is a very bad developer
>>>>>>>> experience.
>>>>>>>> >>>>
>>>>>>>> >>>>
>>>>>>>> >>>>
>>>>>>>> >>>>
>>>>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ
>>>>>>>> <
>>>>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>> >>>>
>>>>>>>> >>>>> Hello,
>>>>>>>> >>>>>
>>>>>>>> >>>>> Another way to have the Docker Hub image published (just like
>>>>>>>> Apache
>>>>>>>> >>>>> Tomcat):
>>>>>>>> >>>>>
>>>>>>>> >>>>> https://github.com/docker-library/official-images
>>>>>>>> >>>>>
>>>>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>>>>> >>>>>
>>>>>>>> >>>>> Regards
>>>>>>>> >>>>>
>>>>>>>> >>>>>
>>>>>>>> >>>>>
>>>>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>>>>> jdailey@apache.org>)
>>>>>>>> >>>>> escribió:
>>>>>>>> >>>>>
>>>>>>>> >>>>>> Is there an easy thing to request?
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> ---------- Forwarded message ---------
>>>>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>>>> >>>>>> Subject: Re: Docker help
>>>>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> Hi James.
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>>>>> jdailey@apache.org>
>>>>>>>> >>>>>> wrote:
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>> Infra -
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>>>>> >>>>>>> apache DockerHUB?
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> Current supported methods are via Github Actions or Jenkins
>>>>>>>> or locally
>>>>>>>> >>>>>> via your own credentials.
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>>>>>> secrets to
>>>>>>>> >>>>>> your repository, or you
>>>>>>>> >>>>>> can provide your own secrets for us to add to your repository
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> For Jenkins we have a role account that we provide access to
>>>>>>>> push to
>>>>>>>> >>>>>> your repository.
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> Committers could also use a settings.xml with this plugin
>>>>>>>> and use
>>>>>>>> >>>>>> their own credentials, we just need
>>>>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> There may also be other methods not explored.
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> See also:
>>>>>>>> >>>>>>
>>>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> HTH
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>>>>> dockerfile at
>>>>>>>> >>>>>>> the root.
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>>>>> Dockerhub". ?
>>>>>>>> >>>>>>> Can we get credentials ?
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> James
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>>> >>>>>>> Subject: Re: Docker help
>>>>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> James,
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>>>>> definitely
>>>>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean
>>>>>>>> it's the only way
>>>>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> Best,
>>>>>>>> >>>>>>> Arnold
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>>>>> jamespdailey@gmail.com>
>>>>>>>> >>>>>>> wrote:
>>>>>>>> >>>>>>>
>>>>>>>> >>>>>>>> On DockerHUB the build fails because there is no
>>>>>>>> dockerfile.
>>>>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>>>>> infrastructure...
>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA
>>>>>>>> host key for
>>>>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>>>> 'origin/develop'.
>>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to
>>>>>>>> get this
>>>>>>>> >>>>>>>> working.
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>>>>> arnold@apache.org>
>>>>>>>> >>>>>>>> wrote:
>>>>>>>> >>>>>>>>
>>>>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>> Just to reflect on your points:
>>>>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we
>>>>>>>> absolutely need to
>>>>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>>>>>>> already
>>>>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions
>>>>>>>> (using their
>>>>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>>>>> alter the
>>>>>>>> >>>>>>>>> pipeline and that's all.
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>> If the only thing preventing us from doing this is to
>>>>>>>> keep asking
>>>>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead
>>>>>>>> of making such an
>>>>>>>> >>>>>>>>> unnecessary change.
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>> Arnold
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>> >>>>>>>>>
>>>>>>>> >>>>>>>>>> Thanks Zoltan
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As
>>>>>>>> this
>>>>>>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>>>>>>> Question!
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>> >>>>>>>>>>
>>>>>>>> >>>>>>>>>>> Hi,
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>>>>> GoogleContainerTools's
>>>>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>>>>>>> Dockerfile. And
>>>>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't
>>>>>>>> support building without
>>>>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>>>>>> change of how
>>>>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be
>>>>>>>> explored - but it's
>>>>>>>> >>>>>>>>>>> definitely doable.
>>>>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build
>>>>>>>> tools like
>>>>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub.
>>>>>>>> This could also work,
>>>>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we
>>>>>>>> have.
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it
>>>>>>>> will be
>>>>>>>> >>>>>>>>>>> different from what Jib can produce, so this might lead
>>>>>>>> to regressions.
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> Kind regards,
>>>>>>>> >>>>>>>>>>> Zoltan
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>> >>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default
>>>>>>>> “build rule “
>>>>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In
>>>>>>>> fact that’s what is
>>>>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>> >>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be
>>>>>>>> fine.
>>>>>>>> >>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>> Thanks
>>>>>>>> >>>>>>>>>>>> James
>>>>>>>> >>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>>>>> RODRIGUEZ <
>>>>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>> >>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>>>>> following:
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>>>>> handling
>>>>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>> scripts) from the
>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop
>>>>>>>> with
>>>>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the
>>>>>>>> master branch everytime the
>>>>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub
>>>>>>>> will publish it as
>>>>>>>> >>>>>>>>>>>>> the latest version.
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on
>>>>>>>> it for
>>>>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its
>>>>>>>> scripts) from the
>>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>>>>> dockerhub will
>>>>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> What do you think?
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> Regards
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>> >>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well,
>>>>>>>> as that is
>>>>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>>>>> However, to add the key
>>>>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>>>>> controlled by Apache Infra.
>>>>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is
>>>>>>>> what
>>>>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think
>>>>>>>> infra has it setup a
>>>>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish
>>>>>>>> to the Apache
>>>>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>>>>>> RODRIGUEZ <
>>>>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>> >>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>>>>> credentials of
>>>>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github
>>>>>>>> action can be
>>>>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>> Regards
>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to
>>>>>>>> work.
>>>>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the
>>>>>>>> Fineract
>>>>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that
>>>>>>>> every
>>>>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running
>>>>>>>> because we
>>>>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root.
>>>>>>>> That is as far as I've
>>>>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at
>>>>>>>> the time.
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>>>>>>> Docker
>>>>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>>>>>> standard is to only
>>>>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>>>>> releases. This build is really
>>>>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>>>>>> large numbers. (no idea
>>>>>>>> >>>>>>>>>>>>>>>> why)
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>>>>> >>>>>>>>>>>>>>>> James
>>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>>> >>>>>>>>>>>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> --
>>>>>>>> >>>>>>
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> *Gavin McDonald - *
>>>>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>>>> >>>>>> V.P Travel Assistance Committee
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> https://tac.apache.org - Applications now open for
>>>>>>>> Community Over
>>>>>>>> >>>>>> Code 2024
>>>>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>>> >>>>>>
>>>>>>>> >>>>>> --
>>>>>>>> >>>
>>>>>>>> >>> Herring BANCORP ®
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>>>>> >>>
>>>>>>>> >>> ccb@herringbancorp.com
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>> *Herring Bancorp*
>>>>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>>>>> >>> <
>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>> >
>>>>>>>> >>> Amarillo, TX 79109
>>>>>>>> >>> <
>>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>>> >
>>>>>>>> >>>
>>>>>>>> >>> www.herringbank.com
>>>>>>>> >>>
>>>>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use
>>>>>>>> of the
>>>>>>>> >>> individual or entity to which it is addressed and may contain
>>>>>>>> information
>>>>>>>> >>> that is privileged, confidential and exempt from disclosure
>>>>>>>> under
>>>>>>>> >>> applicable law. If the reader of this e-mail message is not the
>>>>>>>> intended
>>>>>>>> >>> recipient, or the employee or agent responsible for delivery of
>>>>>>>> the message
>>>>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>>>>> dissemination,
>>>>>>>> >>> distribution or copying of this communication is prohibited. If
>>>>>>>> you have
>>>>>>>> >>> received this e-mail in error, please notify us immediately by
>>>>>>>> telephone at
>>>>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>>
>>>>>>>> >>
>>>>>>>>
>>>>>>>
Re: Docker help
Posted by Arnold Galovics <ga...@gmail.com>.
Hi Victor,
Alright.
Note: probably JIB would be a better choice for the cross-platform building
since it doesn't require an ARM emulator/ARM machine for building the
Docker image.
Best,
Arnold
On Mon, May 27, 2024 at 7:40 AM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> Hello James/Arnold/Community,
>
> There is not Arm64 Linux runner on GitHub Actions (at least not for the
> free tier that I have access), there is a current Gihub discussion about
> this topic https://github.com/orgs/community/discussions/19197
>
> With this limitation we cannot build a linux/arm for Docker image.
>
> I have tried to use QEMU and RunOnArchitecture Github Action but they are
> very slow... and after 50 minutes they throw errors about Docker, due
> to limitations of embedded virtualization.
>
> Now let's focus on the linux/amd... with the current runner I just want to
> know if we can keep variables or use fixed values. This is because maybe
> there are limitations about setting variables for the Github Actions.
>
> Also I have more questions, currently there is a docker tagged image as
> "latest" on Docker Hub https://hub.docker.com/r/apache/fineract/tags ,
> should we use "latest" tag? or should we use the branch name?
>
> I bring to the list the code that requires attention to my questions.
>
> - name: Image Tag
> run: |
> docker image tag ${{*vars.IMAGE_NAME*}} ${{
> *vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
> *steps.extract_branch.outputs.branch* }}
> - name: Docker Push
> run: |
> docker push ${{*vars.DOCKER_HUB_REPO_NAME*}}/${{
> *vars.IMAGE_NAME*}}:${{ *steps.extract_branch.outputs.branch* }}
>
> Regards
>
> Victor
>
>
>
> El dom, 26 may 2024 a las 11:48, VICTOR MANUEL ROMERO RODRIGUEZ (<
> victor.romero@fintecheando.mx>) escribió:
>
>> The arm build is failing... I will try to change the GA Runner or the JVM
>> distribution used by Jib for building the docker image.
>>
>> FYI of the GA (PR for now)
>> https://github.com/apache/fineract/pull/3887/files
>>
>> * What went wrong:
>> Execution failed for task ':fineract-provider:jibDockerBuild'.
>> > Build to Docker daemon failed, perhaps you should make sure Docker is
>> installed and you have correct privileges to run it
>>
>> El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
>> victor.romero@fintecheando.mx>) escribió:
>>
>>> I have been working on this during this weekend, still pending the
>>> linux/arm64. The linux/amd64 is ready.
>>>
>>>
>>>
>>>
>>>
>>> El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
>>> escribió:
>>>
>>>> Victor - what’s the update on this? Can we deploy now ?
>>>>
>>>>
>>>>
>>>> Sent from Gmail Mobile
>>>>
>>>>
>>>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> victor.romero@fintecheando.mx> wrote:
>>>>
>>>>> Arnold,
>>>>>
>>>>> Suggestion welcome, let me add both platforms.
>>>>>
>>>>> Regards
>>>>>
>>>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>>>> galovicsarnold@gmail.com>) escribió:
>>>>>
>>>>>> Victor,
>>>>>>
>>>>>> I think we are missing one crucial thing in your PR, to build the
>>>>>> image multi-platform, specifically for x86 and arm.
>>>>>>
>>>>>> Would it be possible for you to add it?
>>>>>>
>>>>>> Thanks.
>>>>>> Best,
>>>>>> Arnold
>>>>>>
>>>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>>>>
>>>>>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>>>>>
>>>>>>> Collins, please set up a separate thread or email me directly and we
>>>>>>> will help you get set up.
>>>>>>>
>>>>>>> Campbell
>>>>>>>
>>>>>>>
>>>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>> >(Collins & Campbell - please start new thread)
>>>>>>> >
>>>>>>> >
>>>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <
>>>>>>> collinschuwa@gmail.com> wrote:
>>>>>>> >
>>>>>>> >> Hi Campbell,
>>>>>>> >>
>>>>>>> >> Please would you be able to share the steps on how to get
>>>>>>> Fineract 1.8
>>>>>>> >> deployed with Docker?
>>>>>>> >> I have tried, doing this and could not get it to work.
>>>>>>> >>
>>>>>>> >> Collins
>>>>>>> >>
>>>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com>
>>>>>>> wrote:
>>>>>>> >>
>>>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>>>> moment and
>>>>>>> >>> is readying for 1.9.
>>>>>>> >>>
>>>>>>> >>> We would offer our help if needed.
>>>>>>> >>>
>>>>>>> >>> Campbell
>>>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>>>> >>>
>>>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here -
>>>>>>> not on
>>>>>>> >>> the project but willing to help out. He has offered some advice
>>>>>>> for the
>>>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>>>> again. I would
>>>>>>> >>> like to have either a push back or we should restore the docker
>>>>>>> file asap.
>>>>>>> >>>
>>>>>>> >>> To recap:
>>>>>>> >>> The DockerHub Image is two years old, and the process to pull
>>>>>>> from our
>>>>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>>>>> removed the
>>>>>>> >>> docker-build file with this ticket
>>>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>>>> >>>
>>>>>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>>>>>> version
>>>>>>> >>> has multiple CVEs (security issues), we should not be continuing
>>>>>>> to keep
>>>>>>> >>> that there.
>>>>>>> >>>
>>>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>>>> required
>>>>>>> >>> from infra.
>>>>>>> >>>
>>>>>>> >>> Todd's comments:
>>>>>>> >>>
>>>>>>> >>> Extended Summary
>>>>>>> >>>>
>>>>>>> >>>> The problem for the internal Fineract development pipeline is
>>>>>>> that
>>>>>>> >>>> changes were made to the build process that
>>>>>>> >>>> removed the expected Dockerfile
>>>>>>> >>>> added an external dependency to the code repo (mifos
>>>>>>> community-app web
>>>>>>> >>>> UI)
>>>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>>>> >>>>
>>>>>>> >>>> At first glance, the lack of a Dockerfile in the code might
>>>>>>> seem to be
>>>>>>> >>>> the reason that no containers have been pushed to Docker Hub. A
>>>>>>> Dockerfile
>>>>>>> >>>> is the standard way of creating images. This is very confusing
>>>>>>> for many
>>>>>>> >>>> people (including me), however this is not the actual problem
>>>>>>> because JIB
>>>>>>> >>>> (Java Image Builder) is set up to build the image during
>>>>>>> testing directly
>>>>>>> >>>> from java source code by Gradle in two places:
>>>>>>> >>>>
>>>>>>> >>>> build-docker-postgresql.yml
>>>>>>> >>>> build-docker-mariadb.yml
>>>>>>> >>>>
>>>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>>>> actually push
>>>>>>> >>>> the container image to Docker Hub. It only seems to be
>>>>>>> configured to build
>>>>>>> >>>> the image for testing.
>>>>>>> >>>>
>>>>>>> >>>> To solve this, two things need to be done:
>>>>>>> >>>>
>>>>>>> >>>>
>>>>>>> >>>> - It needs to be decided when to push the image (and
>>>>>>> possibly create
>>>>>>> >>>> a new GitHub Action to do it)
>>>>>>> >>>> - Code needs to be added to configure JIB to know where to
>>>>>>> push the
>>>>>>> >>>> image on Docker Hub (see this example)
>>>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>>>> allow it
>>>>>>> >>>> actually push the image
>>>>>>> >>>>
>>>>>>> >>>>
>>>>>>> >>>> Additional Open Source Observations (Optics)
>>>>>>> >>>>
>>>>>>> >>>> Dockerfile
>>>>>>> >>>>
>>>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>>>> (especially
>>>>>>> >>>> coupled with the existence of a docker-compose.yml file) and
>>>>>>> also makes it
>>>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>>>> because now
>>>>>>> >>>> dependencies need to be installed locally, rather than running
>>>>>>> them all in
>>>>>>> >>>> containers.
>>>>>>> >>>>
>>>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard from
>>>>>>> an Open
>>>>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>>>>> Fineract
>>>>>>> >>>> build process or not, most open source projects include a
>>>>>>> Dockerfile, and
>>>>>>> >>>> most open source users expect one to exist in the repo so they
>>>>>>> can easily
>>>>>>> >>>> build / run / test the project locally. Adding the Dockerfile
>>>>>>> back to the
>>>>>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>>>>>> >>>>
>>>>>>> >>>> General Setup
>>>>>>> >>>>
>>>>>>> >>>> The current Fineract process for building and running using
>>>>>>> containers
>>>>>>> >>>> makes it significantly harder for developers to get started
>>>>>>> with Fineract
>>>>>>> >>>> because a local Java environment needs to be installed. More
>>>>>>> disappointing,
>>>>>>> >>>> a completely different public set of instructions exist on
>>>>>>> Docker Hub .
>>>>>>> >>>> These instructions do not work because they are out of date,
>>>>>>> but are
>>>>>>> >>>> significantly easier for developers to use. Having two sets of
>>>>>>> different
>>>>>>> >>>> install instructions is confusing, but having the simpler set of
>>>>>>> >>>> instructions that do not work is a very bad developer
>>>>>>> experience.
>>>>>>> >>>>
>>>>>>> >>>>
>>>>>>> >>>>
>>>>>>> >>>>
>>>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>>>> >>>>
>>>>>>> >>>>> Hello,
>>>>>>> >>>>>
>>>>>>> >>>>> Another way to have the Docker Hub image published (just like
>>>>>>> Apache
>>>>>>> >>>>> Tomcat):
>>>>>>> >>>>>
>>>>>>> >>>>> https://github.com/docker-library/official-images
>>>>>>> >>>>>
>>>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>>>> >>>>>
>>>>>>> >>>>> Regards
>>>>>>> >>>>>
>>>>>>> >>>>>
>>>>>>> >>>>>
>>>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>>>> jdailey@apache.org>)
>>>>>>> >>>>> escribió:
>>>>>>> >>>>>
>>>>>>> >>>>>> Is there an easy thing to request?
>>>>>>> >>>>>>
>>>>>>> >>>>>> ---------- Forwarded message ---------
>>>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>>> >>>>>> Subject: Re: Docker help
>>>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>>>> >>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>> Hi James.
>>>>>>> >>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>>>> jdailey@apache.org>
>>>>>>> >>>>>> wrote:
>>>>>>> >>>>>>
>>>>>>> >>>>>>> Infra -
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>>>> >>>>>>> apache DockerHUB?
>>>>>>> >>>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>> Current supported methods are via Github Actions or Jenkins
>>>>>>> or locally
>>>>>>> >>>>>> via your own credentials.
>>>>>>> >>>>>>
>>>>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>>>>> secrets to
>>>>>>> >>>>>> your repository, or you
>>>>>>> >>>>>> can provide your own secrets for us to add to your repository
>>>>>>> >>>>>>
>>>>>>> >>>>>> For Jenkins we have a role account that we provide access to
>>>>>>> push to
>>>>>>> >>>>>> your repository.
>>>>>>> >>>>>>
>>>>>>> >>>>>> Committers could also use a settings.xml with this plugin and
>>>>>>> use
>>>>>>> >>>>>> their own credentials, we just need
>>>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>>>> >>>>>>
>>>>>>> >>>>>> There may also be other methods not explored.
>>>>>>> >>>>>>
>>>>>>> >>>>>> See also:
>>>>>>> >>>>>>
>>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>> >>>>>>
>>>>>>> >>>>>> HTH
>>>>>>> >>>>>>
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>>>> dockerfile at
>>>>>>> >>>>>>> the root.
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>>>> Dockerhub". ?
>>>>>>> >>>>>>> Can we get credentials ?
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> James
>>>>>>> >>>>>>>
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>> >>>>>>> Subject: Re: Docker help
>>>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>>>> >>>>>>>
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> James,
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>>>> definitely
>>>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean
>>>>>>> it's the only way
>>>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> Best,
>>>>>>> >>>>>>> Arnold
>>>>>>> >>>>>>>
>>>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>>>> jamespdailey@gmail.com>
>>>>>>> >>>>>>> wrote:
>>>>>>> >>>>>>>
>>>>>>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>>>> infrastructure...
>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA
>>>>>>> host key for
>>>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>>> 'origin/develop'.
>>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to
>>>>>>> get this
>>>>>>> >>>>>>>> working.
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>>>> arnold@apache.org>
>>>>>>> >>>>>>>> wrote:
>>>>>>> >>>>>>>>
>>>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>> Just to reflect on your points:
>>>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely
>>>>>>> need to
>>>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>>>>>> already
>>>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions
>>>>>>> (using their
>>>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>>>> alter the
>>>>>>> >>>>>>>>> pipeline and that's all.
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>>>>>>> asking
>>>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>>>>>>> making such an
>>>>>>> >>>>>>>>> unnecessary change.
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>> Arnold
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>> >>>>>>>>>
>>>>>>> >>>>>>>>>> Thanks Zoltan
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As
>>>>>>> this
>>>>>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>>>>>> Question!
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>> >>>>>>>>>>
>>>>>>> >>>>>>>>>>> Hi,
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>>>> GoogleContainerTools's
>>>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>>>>>> Dockerfile. And
>>>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't
>>>>>>> support building without
>>>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>>>>> change of how
>>>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be
>>>>>>> explored - but it's
>>>>>>> >>>>>>>>>>> definitely doable.
>>>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools
>>>>>>> like
>>>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>>>>>>> could also work,
>>>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it
>>>>>>> will be
>>>>>>> >>>>>>>>>>> different from what Jib can produce, so this might lead
>>>>>>> to regressions.
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> Kind regards,
>>>>>>> >>>>>>>>>>> Zoltan
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>> >>>>>>>>>>>
>>>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build
>>>>>>> rule “
>>>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In
>>>>>>> fact that’s what is
>>>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>> >>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be
>>>>>>> fine.
>>>>>>> >>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>> Thanks
>>>>>>> >>>>>>>>>>>> James
>>>>>>> >>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>>>> RODRIGUEZ <
>>>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>> >>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>>>> following:
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>>>> handling
>>>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>>>> from the
>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop
>>>>>>> with
>>>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>>>>>>> branch everytime the
>>>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub
>>>>>>> will publish it as
>>>>>>> >>>>>>>>>>>>> the latest version.
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it
>>>>>>> for
>>>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>>>> from the
>>>>>>> >>>>>>>>>>>>> master branch
>>>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>>>> dockerhub will
>>>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> What do you think?
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> Regards
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>> >>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well,
>>>>>>> as that is
>>>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>>>> However, to add the key
>>>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>>>> controlled by Apache Infra.
>>>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is
>>>>>>> what
>>>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think
>>>>>>> infra has it setup a
>>>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish
>>>>>>> to the Apache
>>>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>> >>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>>>>> RODRIGUEZ <
>>>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>> >>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>>>> credentials of
>>>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>> >>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github
>>>>>>> action can be
>>>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>>>> >>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>> Regards
>>>>>>> >>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>> >>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>>>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to
>>>>>>> work.
>>>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the
>>>>>>> Fineract
>>>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that
>>>>>>> every
>>>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running
>>>>>>> because we
>>>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root.
>>>>>>> That is as far as I've
>>>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at
>>>>>>> the time.
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>>>>>> Docker
>>>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>>>>> standard is to only
>>>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>>>> releases. This build is really
>>>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>>>>> large numbers. (no idea
>>>>>>> >>>>>>>>>>>>>>>> why)
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>>>> >>>>>>>>>>>>>>>> James
>>>>>>> >>>>>>>>>>>>>>>>
>>>>>>> >>>>>>>>>>>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>> --
>>>>>>> >>>>>>
>>>>>>> >>>>>>
>>>>>>> >>>>>> *Gavin McDonald - *
>>>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>>> >>>>>> V.P Travel Assistance Committee
>>>>>>> >>>>>>
>>>>>>> >>>>>> https://tac.apache.org - Applications now open for Community
>>>>>>> Over
>>>>>>> >>>>>> Code 2024
>>>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>> >>>>>>
>>>>>>> >>>>>> --
>>>>>>> >>>
>>>>>>> >>> Herring BANCORP ®
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>>>> >>>
>>>>>>> >>> ccb@herringbancorp.com
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>> *Herring Bancorp*
>>>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>>>> >>> <
>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>> >
>>>>>>> >>> Amarillo, TX 79109
>>>>>>> >>> <
>>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>>> >
>>>>>>> >>>
>>>>>>> >>> www.herringbank.com
>>>>>>> >>>
>>>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use
>>>>>>> of the
>>>>>>> >>> individual or entity to which it is addressed and may contain
>>>>>>> information
>>>>>>> >>> that is privileged, confidential and exempt from disclosure under
>>>>>>> >>> applicable law. If the reader of this e-mail message is not the
>>>>>>> intended
>>>>>>> >>> recipient, or the employee or agent responsible for delivery of
>>>>>>> the message
>>>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>>>> dissemination,
>>>>>>> >>> distribution or copying of this communication is prohibited. If
>>>>>>> you have
>>>>>>> >>> received this e-mail in error, please notify us immediately by
>>>>>>> telephone at
>>>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>>
>>>>>>> >>
>>>>>>>
>>>>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Hello James/Arnold/Community,
There is not Arm64 Linux runner on GitHub Actions (at least not for the
free tier that I have access), there is a current Gihub discussion about
this topic https://github.com/orgs/community/discussions/19197
With this limitation we cannot build a linux/arm for Docker image.
I have tried to use QEMU and RunOnArchitecture Github Action but they are
very slow... and after 50 minutes they throw errors about Docker, due
to limitations of embedded virtualization.
Now let's focus on the linux/amd... with the current runner I just want to
know if we can keep variables or use fixed values. This is because maybe
there are limitations about setting variables for the Github Actions.
Also I have more questions, currently there is a docker tagged image as
"latest" on Docker Hub https://hub.docker.com/r/apache/fineract/tags ,
should we use "latest" tag? or should we use the branch name?
I bring to the list the code that requires attention to my questions.
- name: Image Tag
run: |
docker image tag ${{*vars.IMAGE_NAME*}} ${{
*vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
*steps.extract_branch.outputs.branch* }}
- name: Docker Push
run: |
docker push
${{*vars.DOCKER_HUB_REPO_NAME*}}/${{*vars.IMAGE_NAME*}}:${{
*steps.extract_branch.outputs.branch* }}
Regards
Victor
El dom, 26 may 2024 a las 11:48, VICTOR MANUEL ROMERO RODRIGUEZ (<
victor.romero@fintecheando.mx>) escribió:
> The arm build is failing... I will try to change the GA Runner or the JVM
> distribution used by Jib for building the docker image.
>
> FYI of the GA (PR for now)
> https://github.com/apache/fineract/pull/3887/files
>
> * What went wrong:
> Execution failed for task ':fineract-provider:jibDockerBuild'.
> > Build to Docker daemon failed, perhaps you should make sure Docker is
> installed and you have correct privileges to run it
>
> El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
> victor.romero@fintecheando.mx>) escribió:
>
>> I have been working on this during this weekend, still pending the
>> linux/arm64. The linux/amd64 is ready.
>>
>>
>>
>>
>>
>> El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
>> escribió:
>>
>>> Victor - what’s the update on this? Can we deploy now ?
>>>
>>>
>>>
>>> Sent from Gmail Mobile
>>>
>>>
>>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> Arnold,
>>>>
>>>> Suggestion welcome, let me add both platforms.
>>>>
>>>> Regards
>>>>
>>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>>> galovicsarnold@gmail.com>) escribió:
>>>>
>>>>> Victor,
>>>>>
>>>>> I think we are missing one crucial thing in your PR, to build the
>>>>> image multi-platform, specifically for x86 and arm.
>>>>>
>>>>> Would it be possible for you to add it?
>>>>>
>>>>> Thanks.
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>>>
>>>>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>>>>
>>>>>> Collins, please set up a separate thread or email me directly and we
>>>>>> will help you get set up.
>>>>>>
>>>>>> Campbell
>>>>>>
>>>>>>
>>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>> >(Collins & Campbell - please start new thread)
>>>>>> >
>>>>>> >
>>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
>>>>>> wrote:
>>>>>> >
>>>>>> >> Hi Campbell,
>>>>>> >>
>>>>>> >> Please would you be able to share the steps on how to get Fineract
>>>>>> 1.8
>>>>>> >> deployed with Docker?
>>>>>> >> I have tried, doing this and could not get it to work.
>>>>>> >>
>>>>>> >> Collins
>>>>>> >>
>>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>>>>>> >>
>>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>>> moment and
>>>>>> >>> is readying for 1.9.
>>>>>> >>>
>>>>>> >>> We would offer our help if needed.
>>>>>> >>>
>>>>>> >>> Campbell
>>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>>> >>>
>>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here -
>>>>>> not on
>>>>>> >>> the project but willing to help out. He has offered some advice
>>>>>> for the
>>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>>> again. I would
>>>>>> >>> like to have either a push back or we should restore the docker
>>>>>> file asap.
>>>>>> >>>
>>>>>> >>> To recap:
>>>>>> >>> The DockerHub Image is two years old, and the process to pull
>>>>>> from our
>>>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>>>> removed the
>>>>>> >>> docker-build file with this ticket
>>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>>> >>>
>>>>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>>>>> version
>>>>>> >>> has multiple CVEs (security issues), we should not be continuing
>>>>>> to keep
>>>>>> >>> that there.
>>>>>> >>>
>>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>>> required
>>>>>> >>> from infra.
>>>>>> >>>
>>>>>> >>> Todd's comments:
>>>>>> >>>
>>>>>> >>> Extended Summary
>>>>>> >>>>
>>>>>> >>>> The problem for the internal Fineract development pipeline is
>>>>>> that
>>>>>> >>>> changes were made to the build process that
>>>>>> >>>> removed the expected Dockerfile
>>>>>> >>>> added an external dependency to the code repo (mifos
>>>>>> community-app web
>>>>>> >>>> UI)
>>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>>> >>>>
>>>>>> >>>> At first glance, the lack of a Dockerfile in the code might seem
>>>>>> to be
>>>>>> >>>> the reason that no containers have been pushed to Docker Hub. A
>>>>>> Dockerfile
>>>>>> >>>> is the standard way of creating images. This is very confusing
>>>>>> for many
>>>>>> >>>> people (including me), however this is not the actual problem
>>>>>> because JIB
>>>>>> >>>> (Java Image Builder) is set up to build the image during testing
>>>>>> directly
>>>>>> >>>> from java source code by Gradle in two places:
>>>>>> >>>>
>>>>>> >>>> build-docker-postgresql.yml
>>>>>> >>>> build-docker-mariadb.yml
>>>>>> >>>>
>>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>>> actually push
>>>>>> >>>> the container image to Docker Hub. It only seems to be
>>>>>> configured to build
>>>>>> >>>> the image for testing.
>>>>>> >>>>
>>>>>> >>>> To solve this, two things need to be done:
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> - It needs to be decided when to push the image (and possibly
>>>>>> create
>>>>>> >>>> a new GitHub Action to do it)
>>>>>> >>>> - Code needs to be added to configure JIB to know where to
>>>>>> push the
>>>>>> >>>> image on Docker Hub (see this example)
>>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>>> allow it
>>>>>> >>>> actually push the image
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> Additional Open Source Observations (Optics)
>>>>>> >>>>
>>>>>> >>>> Dockerfile
>>>>>> >>>>
>>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>>> (especially
>>>>>> >>>> coupled with the existence of a docker-compose.yml file) and
>>>>>> also makes it
>>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>>> because now
>>>>>> >>>> dependencies need to be installed locally, rather than running
>>>>>> them all in
>>>>>> >>>> containers.
>>>>>> >>>>
>>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard from
>>>>>> an Open
>>>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>>>> Fineract
>>>>>> >>>> build process or not, most open source projects include a
>>>>>> Dockerfile, and
>>>>>> >>>> most open source users expect one to exist in the repo so they
>>>>>> can easily
>>>>>> >>>> build / run / test the project locally. Adding the Dockerfile
>>>>>> back to the
>>>>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>>>>> >>>>
>>>>>> >>>> General Setup
>>>>>> >>>>
>>>>>> >>>> The current Fineract process for building and running using
>>>>>> containers
>>>>>> >>>> makes it significantly harder for developers to get started with
>>>>>> Fineract
>>>>>> >>>> because a local Java environment needs to be installed. More
>>>>>> disappointing,
>>>>>> >>>> a completely different public set of instructions exist on
>>>>>> Docker Hub .
>>>>>> >>>> These instructions do not work because they are out of date, but
>>>>>> are
>>>>>> >>>> significantly easier for developers to use. Having two sets of
>>>>>> different
>>>>>> >>>> install instructions is confusing, but having the simpler set of
>>>>>> >>>> instructions that do not work is a very bad developer experience.
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>>
>>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>>> >>>>
>>>>>> >>>>> Hello,
>>>>>> >>>>>
>>>>>> >>>>> Another way to have the Docker Hub image published (just like
>>>>>> Apache
>>>>>> >>>>> Tomcat):
>>>>>> >>>>>
>>>>>> >>>>> https://github.com/docker-library/official-images
>>>>>> >>>>>
>>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>>> >>>>>
>>>>>> >>>>> Regards
>>>>>> >>>>>
>>>>>> >>>>>
>>>>>> >>>>>
>>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>>> jdailey@apache.org>)
>>>>>> >>>>> escribió:
>>>>>> >>>>>
>>>>>> >>>>>> Is there an easy thing to request?
>>>>>> >>>>>>
>>>>>> >>>>>> ---------- Forwarded message ---------
>>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>> >>>>>> Subject: Re: Docker help
>>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> Hi James.
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>>> jdailey@apache.org>
>>>>>> >>>>>> wrote:
>>>>>> >>>>>>
>>>>>> >>>>>>> Infra -
>>>>>> >>>>>>>
>>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>>> >>>>>>> apache DockerHUB?
>>>>>> >>>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> Current supported methods are via Github Actions or Jenkins or
>>>>>> locally
>>>>>> >>>>>> via your own credentials.
>>>>>> >>>>>>
>>>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>>>> secrets to
>>>>>> >>>>>> your repository, or you
>>>>>> >>>>>> can provide your own secrets for us to add to your repository
>>>>>> >>>>>>
>>>>>> >>>>>> For Jenkins we have a role account that we provide access to
>>>>>> push to
>>>>>> >>>>>> your repository.
>>>>>> >>>>>>
>>>>>> >>>>>> Committers could also use a settings.xml with this plugin and
>>>>>> use
>>>>>> >>>>>> their own credentials, we just need
>>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>>> >>>>>>
>>>>>> >>>>>> There may also be other methods not explored.
>>>>>> >>>>>>
>>>>>> >>>>>> See also:
>>>>>> >>>>>>
>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>> >>>>>>
>>>>>> >>>>>> HTH
>>>>>> >>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>>> dockerfile at
>>>>>> >>>>>>> the root.
>>>>>> >>>>>>>
>>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>>> Dockerhub". ?
>>>>>> >>>>>>> Can we get credentials ?
>>>>>> >>>>>>>
>>>>>> >>>>>>> James
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>> >>>>>>> Subject: Re: Docker help
>>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>>> >>>>>>>
>>>>>> >>>>>>>
>>>>>> >>>>>>> James,
>>>>>> >>>>>>>
>>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>>> definitely
>>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean
>>>>>> it's the only way
>>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>>> >>>>>>>
>>>>>> >>>>>>> Best,
>>>>>> >>>>>>> Arnold
>>>>>> >>>>>>>
>>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>>> jamespdailey@gmail.com>
>>>>>> >>>>>>> wrote:
>>>>>> >>>>>>>
>>>>>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>>> infrastructure...
>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host
>>>>>> key for
>>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>>> 'origin/develop'.
>>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to
>>>>>> get this
>>>>>> >>>>>>>> working.
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>
>>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>>> arnold@apache.org>
>>>>>> >>>>>>>> wrote:
>>>>>> >>>>>>>>
>>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> Just to reflect on your points:
>>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely
>>>>>> need to
>>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>>>>> already
>>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions
>>>>>> (using their
>>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>>> alter the
>>>>>> >>>>>>>>> pipeline and that's all.
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>>>>>> asking
>>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>>>>>> making such an
>>>>>> >>>>>>>>> unnecessary change.
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> Arnold
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>> >>>>>>>>>
>>>>>> >>>>>>>>>> Thanks Zoltan
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As
>>>>>> this
>>>>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>>>>> Question!
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>> >>>>>>>>>>
>>>>>> >>>>>>>>>>> Hi,
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>>> GoogleContainerTools's
>>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>>>>> Dockerfile. And
>>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't
>>>>>> support building without
>>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>>>> change of how
>>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be
>>>>>> explored - but it's
>>>>>> >>>>>>>>>>> definitely doable.
>>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools
>>>>>> like
>>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>>>>>> could also work,
>>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will
>>>>>> be
>>>>>> >>>>>>>>>>> different from what Jib can produce, so this might lead
>>>>>> to regressions.
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> Kind regards,
>>>>>> >>>>>>>>>>> Zoltan
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>> >>>>>>>>>>>
>>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build
>>>>>> rule “
>>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In
>>>>>> fact that’s what is
>>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>> >>>>>>>>>>>>
>>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>> >>>>>>>>>>>>
>>>>>> >>>>>>>>>>>> Thanks
>>>>>> >>>>>>>>>>>> James
>>>>>> >>>>>>>>>>>>
>>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>>> RODRIGUEZ <
>>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>> >>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>>> following:
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>>> handling
>>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>>> from the
>>>>>> >>>>>>>>>>>>> master branch
>>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>>>>>> branch everytime the
>>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub
>>>>>> will publish it as
>>>>>> >>>>>>>>>>>>> the latest version.
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it
>>>>>> for
>>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>>> from the
>>>>>> >>>>>>>>>>>>> master branch
>>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>>> dockerhub will
>>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> What do you think?
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> Regards
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>> >>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as
>>>>>> that is
>>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>>> However, to add the key
>>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>>> controlled by Apache Infra.
>>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is
>>>>>> what
>>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think
>>>>>> infra has it setup a
>>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish
>>>>>> to the Apache
>>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>> >>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>>>> RODRIGUEZ <
>>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>> >>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>>> credentials of
>>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>> >>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github
>>>>>> action can be
>>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>>> >>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>> Regards
>>>>>> >>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>> >>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to
>>>>>> work.
>>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the
>>>>>> Fineract
>>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that
>>>>>> every
>>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running because
>>>>>> we
>>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root.
>>>>>> That is as far as I've
>>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at
>>>>>> the time.
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>>>>> Docker
>>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>>>> standard is to only
>>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>>> releases. This build is really
>>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>>>> large numbers. (no idea
>>>>>> >>>>>>>>>>>>>>>> why)
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>>> >>>>>>>>>>>>>>>> James
>>>>>> >>>>>>>>>>>>>>>>
>>>>>> >>>>>>>>>>>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> --
>>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> *Gavin McDonald - *
>>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>> >>>>>> V.P Travel Assistance Committee
>>>>>> >>>>>>
>>>>>> >>>>>> https://tac.apache.org - Applications now open for Community
>>>>>> Over
>>>>>> >>>>>> Code 2024
>>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>> >>>>>>
>>>>>> >>>>>> --
>>>>>> >>>
>>>>>> >>> Herring BANCORP ®
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>>> >>>
>>>>>> >>> ccb@herringbancorp.com
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> *Herring Bancorp*
>>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>>> >>> <
>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>> >
>>>>>> >>> Amarillo, TX 79109
>>>>>> >>> <
>>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>>> >
>>>>>> >>>
>>>>>> >>> www.herringbank.com
>>>>>> >>>
>>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of
>>>>>> the
>>>>>> >>> individual or entity to which it is addressed and may contain
>>>>>> information
>>>>>> >>> that is privileged, confidential and exempt from disclosure under
>>>>>> >>> applicable law. If the reader of this e-mail message is not the
>>>>>> intended
>>>>>> >>> recipient, or the employee or agent responsible for delivery of
>>>>>> the message
>>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>>> dissemination,
>>>>>> >>> distribution or copying of this communication is prohibited. If
>>>>>> you have
>>>>>> >>> received this e-mail in error, please notify us immediately by
>>>>>> telephone at
>>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>>
>>>>>> >>
>>>>>>
>>>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
The arm build is failing... I will try to change the GA Runner or the JVM
distribution used by Jib for building the docker image.
FYI of the GA (PR for now)
https://github.com/apache/fineract/pull/3887/files
* What went wrong:
Execution failed for task ':fineract-provider:jibDockerBuild'.
> Build to Docker daemon failed, perhaps you should make sure Docker is
installed and you have correct privileges to run it
El sáb, 25 may 2024 a las 23:18, VICTOR MANUEL ROMERO RODRIGUEZ (<
victor.romero@fintecheando.mx>) escribió:
> I have been working on this during this weekend, still pending the
> linux/arm64. The linux/amd64 is ready.
>
>
>
>
>
> El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
> escribió:
>
>> Victor - what’s the update on this? Can we deploy now ?
>>
>>
>>
>> Sent from Gmail Mobile
>>
>>
>> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Arnold,
>>>
>>> Suggestion welcome, let me add both platforms.
>>>
>>> Regards
>>>
>>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>>> galovicsarnold@gmail.com>) escribió:
>>>
>>>> Victor,
>>>>
>>>> I think we are missing one crucial thing in your PR, to build the image
>>>> multi-platform, specifically for x86 and arm.
>>>>
>>>> Would it be possible for you to add it?
>>>>
>>>> Thanks.
>>>> Best,
>>>> Arnold
>>>>
>>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>>
>>>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>>>
>>>>> Collins, please set up a separate thread or email me directly and we
>>>>> will help you get set up.
>>>>>
>>>>> Campbell
>>>>>
>>>>>
>>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>> >(Collins & Campbell - please start new thread)
>>>>> >
>>>>> >
>>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> >> Hi Campbell,
>>>>> >>
>>>>> >> Please would you be able to share the steps on how to get Fineract
>>>>> 1.8
>>>>> >> deployed with Docker?
>>>>> >> I have tried, doing this and could not get it to work.
>>>>> >>
>>>>> >> Collins
>>>>> >>
>>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>>>>> >>
>>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the
>>>>> moment and
>>>>> >>> is readying for 1.9.
>>>>> >>>
>>>>> >>> We would offer our help if needed.
>>>>> >>>
>>>>> >>> Campbell
>>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>>> >>>
>>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here -
>>>>> not on
>>>>> >>> the project but willing to help out. He has offered some advice
>>>>> for the
>>>>> >>> project to get the Docker distro of Apache Fineract working
>>>>> again. I would
>>>>> >>> like to have either a push back or we should restore the docker
>>>>> file asap.
>>>>> >>>
>>>>> >>> To recap:
>>>>> >>> The DockerHub Image is two years old, and the process to pull
>>>>> from our
>>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>>> removed the
>>>>> >>> docker-build file with this ticket
>>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>>> >>>
>>>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>>>> version
>>>>> >>> has multiple CVEs (security issues), we should not be continuing
>>>>> to keep
>>>>> >>> that there.
>>>>> >>>
>>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>>> required
>>>>> >>> from infra.
>>>>> >>>
>>>>> >>> Todd's comments:
>>>>> >>>
>>>>> >>> Extended Summary
>>>>> >>>>
>>>>> >>>> The problem for the internal Fineract development pipeline is that
>>>>> >>>> changes were made to the build process that
>>>>> >>>> removed the expected Dockerfile
>>>>> >>>> added an external dependency to the code repo (mifos
>>>>> community-app web
>>>>> >>>> UI)
>>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>>> >>>>
>>>>> >>>> At first glance, the lack of a Dockerfile in the code might seem
>>>>> to be
>>>>> >>>> the reason that no containers have been pushed to Docker Hub. A
>>>>> Dockerfile
>>>>> >>>> is the standard way of creating images. This is very confusing
>>>>> for many
>>>>> >>>> people (including me), however this is not the actual problem
>>>>> because JIB
>>>>> >>>> (Java Image Builder) is set up to build the image during testing
>>>>> directly
>>>>> >>>> from java source code by Gradle in two places:
>>>>> >>>>
>>>>> >>>> build-docker-postgresql.yml
>>>>> >>>> build-docker-mariadb.yml
>>>>> >>>>
>>>>> >>>> The problem is that JIB does not seem to be configured to
>>>>> actually push
>>>>> >>>> the container image to Docker Hub. It only seems to be configured
>>>>> to build
>>>>> >>>> the image for testing.
>>>>> >>>>
>>>>> >>>> To solve this, two things need to be done:
>>>>> >>>>
>>>>> >>>>
>>>>> >>>> - It needs to be decided when to push the image (and possibly
>>>>> create
>>>>> >>>> a new GitHub Action to do it)
>>>>> >>>> - Code needs to be added to configure JIB to know where to
>>>>> push the
>>>>> >>>> image on Docker Hub (see this example)
>>>>> >>>> - Credentials need to be supplied to the GitHub Action to
>>>>> allow it
>>>>> >>>> actually push the image
>>>>> >>>>
>>>>> >>>>
>>>>> >>>> Additional Open Source Observations (Optics)
>>>>> >>>>
>>>>> >>>> Dockerfile
>>>>> >>>>
>>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>>> (especially
>>>>> >>>> coupled with the existence of a docker-compose.yml file) and also
>>>>> makes it
>>>>> >>>> harder for potential contributors to set up and run Fineract
>>>>> because now
>>>>> >>>> dependencies need to be installed locally, rather than running
>>>>> them all in
>>>>> >>>> containers.
>>>>> >>>>
>>>>> >>>> The lack of a Dockerfile in the repository is nonstandard from an
>>>>> Open
>>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>>> Fineract
>>>>> >>>> build process or not, most open source projects include a
>>>>> Dockerfile, and
>>>>> >>>> most open source users expect one to exist in the repo so they
>>>>> can easily
>>>>> >>>> build / run / test the project locally. Adding the Dockerfile
>>>>> back to the
>>>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>>>> >>>>
>>>>> >>>> General Setup
>>>>> >>>>
>>>>> >>>> The current Fineract process for building and running using
>>>>> containers
>>>>> >>>> makes it significantly harder for developers to get started with
>>>>> Fineract
>>>>> >>>> because a local Java environment needs to be installed. More
>>>>> disappointing,
>>>>> >>>> a completely different public set of instructions exist on Docker
>>>>> Hub .
>>>>> >>>> These instructions do not work because they are out of date, but
>>>>> are
>>>>> >>>> significantly easier for developers to use. Having two sets of
>>>>> different
>>>>> >>>> install instructions is confusing, but having the simpler set of
>>>>> >>>> instructions that do not work is a very bad developer experience.
>>>>> >>>>
>>>>> >>>>
>>>>> >>>>
>>>>> >>>>
>>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>>> >>>>
>>>>> >>>>> Hello,
>>>>> >>>>>
>>>>> >>>>> Another way to have the Docker Hub image published (just like
>>>>> Apache
>>>>> >>>>> Tomcat):
>>>>> >>>>>
>>>>> >>>>> https://github.com/docker-library/official-images
>>>>> >>>>>
>>>>> >>>>> https://github.com/docker-library/tomcat
>>>>> >>>>>
>>>>> >>>>> Regards
>>>>> >>>>>
>>>>> >>>>>
>>>>> >>>>>
>>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>>> jdailey@apache.org>)
>>>>> >>>>> escribió:
>>>>> >>>>>
>>>>> >>>>>> Is there an easy thing to request?
>>>>> >>>>>>
>>>>> >>>>>> ---------- Forwarded message ---------
>>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>> >>>>>> Subject: Re: Docker help
>>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>> Hi James.
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <
>>>>> jdailey@apache.org>
>>>>> >>>>>> wrote:
>>>>> >>>>>>
>>>>> >>>>>>> Infra -
>>>>> >>>>>>>
>>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>>> >>>>>>> apache DockerHUB?
>>>>> >>>>>>>
>>>>> >>>>>>
>>>>> >>>>>> Current supported methods are via Github Actions or Jenkins or
>>>>> locally
>>>>> >>>>>> via your own credentials.
>>>>> >>>>>>
>>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>>> secrets to
>>>>> >>>>>> your repository, or you
>>>>> >>>>>> can provide your own secrets for us to add to your repository
>>>>> >>>>>>
>>>>> >>>>>> For Jenkins we have a role account that we provide access to
>>>>> push to
>>>>> >>>>>> your repository.
>>>>> >>>>>>
>>>>> >>>>>> Committers could also use a settings.xml with this plugin and
>>>>> use
>>>>> >>>>>> their own credentials, we just need
>>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>>> >>>>>>
>>>>> >>>>>> There may also be other methods not explored.
>>>>> >>>>>>
>>>>> >>>>>> See also:
>>>>> >>>>>>
>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>> >>>>>>
>>>>> >>>>>> HTH
>>>>> >>>>>>
>>>>> >>>>>>>
>>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>>> dockerfile at
>>>>> >>>>>>> the root.
>>>>> >>>>>>>
>>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>>> Dockerhub". ?
>>>>> >>>>>>> Can we get credentials ?
>>>>> >>>>>>>
>>>>> >>>>>>> James
>>>>> >>>>>>>
>>>>> >>>>>>>
>>>>> >>>>>>> ---------- Forwarded message ---------
>>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>> >>>>>>> Subject: Re: Docker help
>>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>>> >>>>>>>
>>>>> >>>>>>>
>>>>> >>>>>>> James,
>>>>> >>>>>>>
>>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>>> definitely
>>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean it's
>>>>> the only way
>>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>>> >>>>>>>
>>>>> >>>>>>> Best,
>>>>> >>>>>>> Arnold
>>>>> >>>>>>>
>>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>>> jamespdailey@gmail.com>
>>>>> >>>>>>> wrote:
>>>>> >>>>>>>
>>>>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>> >>>>>>>>
>>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>>> infrastructure...
>>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host
>>>>> key for
>>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>>> 'origin/develop'.
>>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>> >>>>>>>>
>>>>> >>>>>>>>
>>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>>> >>>>>>>>
>>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to get
>>>>> this
>>>>> >>>>>>>> working.
>>>>> >>>>>>>>
>>>>> >>>>>>>>
>>>>> >>>>>>>>
>>>>> >>>>>>>>
>>>>> >>>>>>>>
>>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>>> arnold@apache.org>
>>>>> >>>>>>>> wrote:
>>>>> >>>>>>>>
>>>>> >>>>>>>>> Hi Zoltan, James,
>>>>> >>>>>>>>>
>>>>> >>>>>>>>> Just to reflect on your points:
>>>>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely
>>>>> need to
>>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>>>> already
>>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions (using
>>>>> their
>>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>> >>>>>>>>>
>>>>> >>>>>>>>> We need the credentials to be able to do a docker push,
>>>>> alter the
>>>>> >>>>>>>>> pipeline and that's all.
>>>>> >>>>>>>>>
>>>>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>>>>> asking
>>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>>>>> making such an
>>>>> >>>>>>>>> unnecessary change.
>>>>> >>>>>>>>>
>>>>> >>>>>>>>> Arnold
>>>>> >>>>>>>>>
>>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>> >>>>>>>>>
>>>>> >>>>>>>>>> Thanks Zoltan
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As
>>>>> this
>>>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>>>> Question!
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>> >>>>>>>>>>
>>>>> >>>>>>>>>>> Hi,
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>>> GoogleContainerTools's
>>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>>>> Dockerfile. And
>>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support
>>>>> building without
>>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> We have two ways to move forward:
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>>> change of how
>>>>> >>>>>>>>>>> Fineract is built and the consequences need to be explored
>>>>> - but it's
>>>>> >>>>>>>>>>> definitely doable.
>>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools
>>>>> like
>>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>>>>> could also work,
>>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will
>>>>> be
>>>>> >>>>>>>>>>> different from what Jib can produce, so this might lead to
>>>>> regressions.
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> Kind regards,
>>>>> >>>>>>>>>>> Zoltan
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>> >>>>>>>>>>>
>>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build
>>>>> rule “
>>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In fact
>>>>> that’s what is
>>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>>> >>>>>>>>>>>>
>>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>> >>>>>>>>>>>>
>>>>> >>>>>>>>>>>> Thanks
>>>>> >>>>>>>>>>>> James
>>>>> >>>>>>>>>>>>
>>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>>> RODRIGUEZ <
>>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>> >>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>>> following:
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>>> handling
>>>>> >>>>>>>>>>>>> the versions) on master branch
>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>> from the
>>>>> >>>>>>>>>>>>> master branch
>>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>>>>> branch everytime the
>>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub
>>>>> will publish it as
>>>>> >>>>>>>>>>>>> the latest version.
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it
>>>>> for
>>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>>> from the
>>>>> >>>>>>>>>>>>> master branch
>>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>>> dockerhub will
>>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> What do you think?
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> Regards
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>> >>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as
>>>>> that is
>>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>>> However, to add the key
>>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>>> controlled by Apache Infra.
>>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is
>>>>> what
>>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra
>>>>> has it setup a
>>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish to
>>>>> the Apache
>>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>> >>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>>> RODRIGUEZ <
>>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>> >>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the
>>>>> credentials of
>>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>> >>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github action
>>>>> can be
>>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>>> >>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>> Regards
>>>>> >>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>> >>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to
>>>>> work.
>>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that
>>>>> every
>>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running because
>>>>> we
>>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root.
>>>>> That is as far as I've
>>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at
>>>>> the time.
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>>>> Docker
>>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>>> standard is to only
>>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two
>>>>> releases. This build is really
>>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>>> large numbers. (no idea
>>>>> >>>>>>>>>>>>>>>> why)
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>> Thanks
>>>>> >>>>>>>>>>>>>>>> James
>>>>> >>>>>>>>>>>>>>>>
>>>>> >>>>>>>>>>>>>>>
>>>>> >>>>>>
>>>>> >>>>>> --
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>> *Gavin McDonald - *
>>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>>> >>>>>> V.P Travel Assistance Committee
>>>>> >>>>>>
>>>>> >>>>>> https://tac.apache.org - Applications now open for Community
>>>>> Over
>>>>> >>>>>> Code 2024
>>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>> >>>>>>
>>>>> >>>>>> --
>>>>> >>>
>>>>> >>> Herring BANCORP ®
>>>>> >>>
>>>>> >>>
>>>>> >>> *C. Campbell Burgess *President/CEO
>>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>>> >>>
>>>>> >>> ccb@herringbancorp.com
>>>>> >>>
>>>>> >>>
>>>>> >>> *Herring Bancorp*
>>>>> >>> 2201 Civic Circle, Suite 1000
>>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>>> >>> <
>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>> >
>>>>> >>> Amarillo, TX 79109
>>>>> >>> <
>>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>>> >
>>>>> >>>
>>>>> >>> www.herringbank.com
>>>>> >>>
>>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of
>>>>> the
>>>>> >>> individual or entity to which it is addressed and may contain
>>>>> information
>>>>> >>> that is privileged, confidential and exempt from disclosure under
>>>>> >>> applicable law. If the reader of this e-mail message is not the
>>>>> intended
>>>>> >>> recipient, or the employee or agent responsible for delivery of
>>>>> the message
>>>>> >>> to the intended recipient, you are hereby notified that any
>>>>> dissemination,
>>>>> >>> distribution or copying of this communication is prohibited. If
>>>>> you have
>>>>> >>> received this e-mail in error, please notify us immediately by
>>>>> telephone at
>>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>>
>>>>> >>
>>>>>
>>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
I have been working on this during this weekend, still pending the
linux/arm64. The linux/amd64 is ready.
El sáb, 25 may 2024 a las 22:15, James Dailey (<ja...@gmail.com>)
escribió:
> Victor - what’s the update on this? Can we deploy now ?
>
>
>
> Sent from Gmail Mobile
>
>
> On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> Arnold,
>>
>> Suggestion welcome, let me add both platforms.
>>
>> Regards
>>
>> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
>> galovicsarnold@gmail.com>) escribió:
>>
>>> Victor,
>>>
>>> I think we are missing one crucial thing in your PR, to build the image
>>> multi-platform, specifically for x86 and arm.
>>>
>>> Would it be possible for you to add it?
>>>
>>> Thanks.
>>> Best,
>>> Arnold
>>>
>>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>>
>>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>>
>>>> Collins, please set up a separate thread or email me directly and we
>>>> will help you get set up.
>>>>
>>>> Campbell
>>>>
>>>>
>>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>>> wrote:
>>>> >(Collins & Campbell - please start new thread)
>>>> >
>>>> >
>>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
>>>> wrote:
>>>> >
>>>> >> Hi Campbell,
>>>> >>
>>>> >> Please would you be able to share the steps on how to get Fineract
>>>> 1.8
>>>> >> deployed with Docker?
>>>> >> I have tried, doing this and could not get it to work.
>>>> >>
>>>> >> Collins
>>>> >>
>>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>>>> >>
>>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment
>>>> and
>>>> >>> is readying for 1.9.
>>>> >>>
>>>> >>> We would offer our help if needed.
>>>> >>>
>>>> >>> Campbell
>>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>> >>>
>>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here - not
>>>> on
>>>> >>> the project but willing to help out. He has offered some advice
>>>> for the
>>>> >>> project to get the Docker distro of Apache Fineract working again.
>>>> I would
>>>> >>> like to have either a push back or we should restore the docker
>>>> file asap.
>>>> >>>
>>>> >>> To recap:
>>>> >>> The DockerHub Image is two years old, and the process to pull from
>>>> our
>>>> >>> Dev branch has been broken that entire time. It broke when we
>>>> removed the
>>>> >>> docker-build file with this ticket
>>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>> >>>
>>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>>> version
>>>> >>> has multiple CVEs (security issues), we should not be continuing to
>>>> keep
>>>> >>> that there.
>>>> >>>
>>>> >>> So, we need to fix the docker pipeline. Credentials will be
>>>> required
>>>> >>> from infra.
>>>> >>>
>>>> >>> Todd's comments:
>>>> >>>
>>>> >>> Extended Summary
>>>> >>>>
>>>> >>>> The problem for the internal Fineract development pipeline is that
>>>> >>>> changes were made to the build process that
>>>> >>>> removed the expected Dockerfile
>>>> >>>> added an external dependency to the code repo (mifos community-app
>>>> web
>>>> >>>> UI)
>>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>>> >>>>
>>>> >>>> At first glance, the lack of a Dockerfile in the code might seem
>>>> to be
>>>> >>>> the reason that no containers have been pushed to Docker Hub. A
>>>> Dockerfile
>>>> >>>> is the standard way of creating images. This is very confusing for
>>>> many
>>>> >>>> people (including me), however this is not the actual problem
>>>> because JIB
>>>> >>>> (Java Image Builder) is set up to build the image during testing
>>>> directly
>>>> >>>> from java source code by Gradle in two places:
>>>> >>>>
>>>> >>>> build-docker-postgresql.yml
>>>> >>>> build-docker-mariadb.yml
>>>> >>>>
>>>> >>>> The problem is that JIB does not seem to be configured to actually
>>>> push
>>>> >>>> the container image to Docker Hub. It only seems to be configured
>>>> to build
>>>> >>>> the image for testing.
>>>> >>>>
>>>> >>>> To solve this, two things need to be done:
>>>> >>>>
>>>> >>>>
>>>> >>>> - It needs to be decided when to push the image (and possibly
>>>> create
>>>> >>>> a new GitHub Action to do it)
>>>> >>>> - Code needs to be added to configure JIB to know where to push
>>>> the
>>>> >>>> image on Docker Hub (see this example)
>>>> >>>> - Credentials need to be supplied to the GitHub Action to allow
>>>> it
>>>> >>>> actually push the image
>>>> >>>>
>>>> >>>>
>>>> >>>> Additional Open Source Observations (Optics)
>>>> >>>>
>>>> >>>> Dockerfile
>>>> >>>>
>>>> >>>> The removal of the Dockerfile from the repo is confusing
>>>> (especially
>>>> >>>> coupled with the existence of a docker-compose.yml file) and also
>>>> makes it
>>>> >>>> harder for potential contributors to set up and run Fineract
>>>> because now
>>>> >>>> dependencies need to be installed locally, rather than running
>>>> them all in
>>>> >>>> containers.
>>>> >>>>
>>>> >>>> The lack of a Dockerfile in the repository is nonstandard from an
>>>> Open
>>>> >>>> Source perspective. Regardless of whether it is needed by the
>>>> Fineract
>>>> >>>> build process or not, most open source projects include a
>>>> Dockerfile, and
>>>> >>>> most open source users expect one to exist in the repo so they can
>>>> easily
>>>> >>>> build / run / test the project locally. Adding the Dockerfile
>>>> back to the
>>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>>> >>>>
>>>> >>>> General Setup
>>>> >>>>
>>>> >>>> The current Fineract process for building and running using
>>>> containers
>>>> >>>> makes it significantly harder for developers to get started with
>>>> Fineract
>>>> >>>> because a local Java environment needs to be installed. More
>>>> disappointing,
>>>> >>>> a completely different public set of instructions exist on Docker
>>>> Hub .
>>>> >>>> These instructions do not work because they are out of date, but
>>>> are
>>>> >>>> significantly easier for developers to use. Having two sets of
>>>> different
>>>> >>>> install instructions is confusing, but having the simpler set of
>>>> >>>> instructions that do not work is a very bad developer experience.
>>>> >>>>
>>>> >>>>
>>>> >>>>
>>>> >>>>
>>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> >>>> victor.romero@fintecheando.mx> wrote:
>>>> >>>>
>>>> >>>>> Hello,
>>>> >>>>>
>>>> >>>>> Another way to have the Docker Hub image published (just like
>>>> Apache
>>>> >>>>> Tomcat):
>>>> >>>>>
>>>> >>>>> https://github.com/docker-library/official-images
>>>> >>>>>
>>>> >>>>> https://github.com/docker-library/tomcat
>>>> >>>>>
>>>> >>>>> Regards
>>>> >>>>>
>>>> >>>>>
>>>> >>>>>
>>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<
>>>> jdailey@apache.org>)
>>>> >>>>> escribió:
>>>> >>>>>
>>>> >>>>>> Is there an easy thing to request?
>>>> >>>>>>
>>>> >>>>>> ---------- Forwarded message ---------
>>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>> >>>>>> Subject: Re: Docker help
>>>> >>>>>> To: James Dailey <jd...@apache.org>
>>>> >>>>>> CC: Users <us...@infra.apache.org>
>>>> >>>>>>
>>>> >>>>>>
>>>> >>>>>> Hi James.
>>>> >>>>>>
>>>> >>>>>>
>>>> >>>>>>
>>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jdailey@apache.org
>>>> >
>>>> >>>>>> wrote:
>>>> >>>>>>
>>>> >>>>>>> Infra -
>>>> >>>>>>>
>>>> >>>>>>> Can you confirm that we can use other processes to push to
>>>> >>>>>>> apache DockerHUB?
>>>> >>>>>>>
>>>> >>>>>>
>>>> >>>>>> Current supported methods are via Github Actions or Jenkins or
>>>> locally
>>>> >>>>>> via your own credentials.
>>>> >>>>>>
>>>> >>>>>> For Github Actions we can use a role account and attach the
>>>> secrets to
>>>> >>>>>> your repository, or you
>>>> >>>>>> can provide your own secrets for us to add to your repository
>>>> >>>>>>
>>>> >>>>>> For Jenkins we have a role account that we provide access to
>>>> push to
>>>> >>>>>> your repository.
>>>> >>>>>>
>>>> >>>>>> Committers could also use a settings.xml with this plugin and use
>>>> >>>>>> their own credentials, we just need
>>>> >>>>>> to ensure they have push access to Dockerhub.
>>>> >>>>>>
>>>> >>>>>> There may also be other methods not explored.
>>>> >>>>>>
>>>> >>>>>> See also:
>>>> >>>>>>
>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>> >>>>>>
>>>> >>>>>> HTH
>>>> >>>>>>
>>>> >>>>>>>
>>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>>> dockerfile at
>>>> >>>>>>> the root.
>>>> >>>>>>>
>>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>>> Dockerhub". ?
>>>> >>>>>>> Can we get credentials ?
>>>> >>>>>>>
>>>> >>>>>>> James
>>>> >>>>>>>
>>>> >>>>>>>
>>>> >>>>>>> ---------- Forwarded message ---------
>>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>> >>>>>>> Subject: Re: Docker help
>>>> >>>>>>> To: <de...@fineract.apache.org>
>>>> >>>>>>>
>>>> >>>>>>>
>>>> >>>>>>> James,
>>>> >>>>>>>
>>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>>> definitely
>>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean it's
>>>> the only way
>>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>>> >>>>>>>
>>>> >>>>>>> Best,
>>>> >>>>>>> Arnold
>>>> >>>>>>>
>>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>>> jamespdailey@gmail.com>
>>>> >>>>>>> wrote:
>>>> >>>>>>>
>>>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>>> >>>>>>>>
>>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>>> infrastructure...
>>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host
>>>> key for
>>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>>> 'origin/develop'.
>>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>> >>>>>>>>
>>>> >>>>>>>>
>>>> >>>>>>>> Let's discuss on slack and revert back here.
>>>> >>>>>>>>
>>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to get
>>>> this
>>>> >>>>>>>> working.
>>>> >>>>>>>>
>>>> >>>>>>>>
>>>> >>>>>>>>
>>>> >>>>>>>>
>>>> >>>>>>>>
>>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>>> arnold@apache.org>
>>>> >>>>>>>> wrote:
>>>> >>>>>>>>
>>>> >>>>>>>>> Hi Zoltan, James,
>>>> >>>>>>>>>
>>>> >>>>>>>>> Just to reflect on your points:
>>>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely
>>>> need to
>>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>>> already
>>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions (using
>>>> their
>>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>>> >>>>>>>>>
>>>> >>>>>>>>> We need the credentials to be able to do a docker push, alter
>>>> the
>>>> >>>>>>>>> pipeline and that's all.
>>>> >>>>>>>>>
>>>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>>>> asking
>>>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>>>> making such an
>>>> >>>>>>>>> unnecessary change.
>>>> >>>>>>>>>
>>>> >>>>>>>>> Arnold
>>>> >>>>>>>>>
>>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>>> >>>>>>>>>
>>>> >>>>>>>>>> Thanks Zoltan
>>>> >>>>>>>>>>
>>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>>> Question!
>>>> >>>>>>>>>>
>>>> >>>>>>>>>>
>>>> >>>>>>>>>>
>>>> >>>>>>>>>>
>>>> >>>>>>>>>>
>>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>> >>>>>>>>>>
>>>> >>>>>>>>>>> Hi,
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> I think the real issue here is that we use
>>>> GoogleContainerTools's
>>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>>> Dockerfile. And
>>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support
>>>> building without
>>>> >>>>>>>>>>> a Dockerfile. :-(
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> We have two ways to move forward:
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>>> change of how
>>>> >>>>>>>>>>> Fineract is built and the consequences need to be explored
>>>> - but it's
>>>> >>>>>>>>>>> definitely doable.
>>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools
>>>> like
>>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>>>> could also work,
>>>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>> >>>>>>>>>>> different from what Jib can produce, so this might lead to
>>>> regressions.
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> Want me to try this approach next week?
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> Kind regards,
>>>> >>>>>>>>>>> Zoltan
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>> >>>>>>>>>>>
>>>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build
>>>> rule “
>>>> >>>>>>>>>>>> points to master or main but we can also use dev. In fact
>>>> that’s what is
>>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>>> >>>>>>>>>>>>
>>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>> >>>>>>>>>>>>
>>>> >>>>>>>>>>>> Thanks
>>>> >>>>>>>>>>>> James
>>>> >>>>>>>>>>>>
>>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>>> RODRIGUEZ <
>>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>> >>>>>>>>>>>>
>>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>>> following:
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>>> handling
>>>> >>>>>>>>>>>>> the versions) on master branch
>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>> from the
>>>> >>>>>>>>>>>>> master branch
>>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>>>> branch everytime the
>>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub
>>>> will publish it as
>>>> >>>>>>>>>>>>> the latest version.
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> Or... we can be more standard
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> 1. Rename develop to master
>>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>> >>>>>>>>>>>>> handling the versions) on master branch
>>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>>> from the
>>>> >>>>>>>>>>>>> master branch
>>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the
>>>> dockerhub will
>>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> What do you think?
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> Regards
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>> >>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as
>>>> that is
>>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>>> However, to add the key
>>>> >>>>>>>>>>>>>> to the git hub requires access and the git is
>>>> controlled by Apache Infra.
>>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra
>>>> has it setup a
>>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish to
>>>> the Apache
>>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>> >>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>>> RODRIGUEZ <
>>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>> >>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials
>>>> of
>>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>>> >>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github action
>>>> can be
>>>> >>>>>>>>>>>>>>> enabled for this task.
>>>> >>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>> Regards
>>>> >>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>> >>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> I've re-opened
>>>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to
>>>> work.
>>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That
>>>> is as far as I've
>>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the
>>>> time.
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>>> Docker
>>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>>> standard is to only
>>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two releases.
>>>> This build is really
>>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in
>>>> large numbers. (no idea
>>>> >>>>>>>>>>>>>>>> why)
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>> Thanks
>>>> >>>>>>>>>>>>>>>> James
>>>> >>>>>>>>>>>>>>>>
>>>> >>>>>>>>>>>>>>>
>>>> >>>>>>
>>>> >>>>>> --
>>>> >>>>>>
>>>> >>>>>>
>>>> >>>>>> *Gavin McDonald - *
>>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>>> >>>>>> V.P Travel Assistance Committee
>>>> >>>>>>
>>>> >>>>>> https://tac.apache.org - Applications now open for Community
>>>> Over
>>>> >>>>>> Code 2024
>>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>> >>>>>>
>>>> >>>>>> --
>>>> >>>
>>>> >>> Herring BANCORP ®
>>>> >>>
>>>> >>>
>>>> >>> *C. Campbell Burgess *President/CEO
>>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>> >>>
>>>> >>> ccb@herringbancorp.com
>>>> >>>
>>>> >>>
>>>> >>> *Herring Bancorp*
>>>> >>> 2201 Civic Circle, Suite 1000
>>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>>> >>> <
>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>> >
>>>> >>> Amarillo, TX 79109
>>>> >>> <
>>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>>> >
>>>> >>>
>>>> >>> www.herringbank.com
>>>> >>>
>>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of
>>>> the
>>>> >>> individual or entity to which it is addressed and may contain
>>>> information
>>>> >>> that is privileged, confidential and exempt from disclosure under
>>>> >>> applicable law. If the reader of this e-mail message is not the
>>>> intended
>>>> >>> recipient, or the employee or agent responsible for delivery of the
>>>> message
>>>> >>> to the intended recipient, you are hereby notified that any
>>>> dissemination,
>>>> >>> distribution or copying of this communication is prohibited. If you
>>>> have
>>>> >>> received this e-mail in error, please notify us immediately by
>>>> telephone at
>>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>
>>>>
>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Victor - what’s the update on this? Can we deploy now ?
Sent from Gmail Mobile
On Fri, May 10, 2024 at 12:36 PM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> Arnold,
>
> Suggestion welcome, let me add both platforms.
>
> Regards
>
> El vie, 10 may 2024 a las 13:29, Arnold Galovics (<
> galovicsarnold@gmail.com>) escribió:
>
>> Victor,
>>
>> I think we are missing one crucial thing in your PR, to build the image
>> multi-platform, specifically for x86 and arm.
>>
>> Would it be possible for you to add it?
>>
>> Thanks.
>> Best,
>> Arnold
>>
>> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>>
>>> Sure thing... we are glad to help while you guys sort out the kinks.
>>>
>>> Collins, please set up a separate thread or email me directly and we
>>> will help you get set up.
>>>
>>> Campbell
>>>
>>>
>>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>>> wrote:
>>> >(Collins & Campbell - please start new thread)
>>> >
>>> >
>>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
>>> wrote:
>>> >
>>> >> Hi Campbell,
>>> >>
>>> >> Please would you be able to share the steps on how to get Fineract 1.8
>>> >> deployed with Docker?
>>> >> I have tried, doing this and could not get it to work.
>>> >>
>>> >> Collins
>>> >>
>>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>>> >>
>>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment
>>> and
>>> >>> is readying for 1.9.
>>> >>>
>>> >>> We would offer our help if needed.
>>> >>>
>>> >>> Campbell
>>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>> >>>
>>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here - not
>>> on
>>> >>> the project but willing to help out. He has offered some advice for
>>> the
>>> >>> project to get the Docker distro of Apache Fineract working again.
>>> I would
>>> >>> like to have either a push back or we should restore the docker file
>>> asap.
>>> >>>
>>> >>> To recap:
>>> >>> The DockerHub Image is two years old, and the process to pull from
>>> our
>>> >>> Dev branch has been broken that entire time. It broke when we
>>> removed the
>>> >>> docker-build file with this ticket
>>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>> >>>
>>> >>> With a Million downloads of fineract from DockerHUB, where that
>>> version
>>> >>> has multiple CVEs (security issues), we should not be continuing to
>>> keep
>>> >>> that there.
>>> >>>
>>> >>> So, we need to fix the docker pipeline. Credentials will be required
>>> >>> from infra.
>>> >>>
>>> >>> Todd's comments:
>>> >>>
>>> >>> Extended Summary
>>> >>>>
>>> >>>> The problem for the internal Fineract development pipeline is that
>>> >>>> changes were made to the build process that
>>> >>>> removed the expected Dockerfile
>>> >>>> added an external dependency to the code repo (mifos community-app
>>> web
>>> >>>> UI)
>>> >>>> does not publish a public Fineract Docker image to Docker Hub
>>> >>>>
>>> >>>> At first glance, the lack of a Dockerfile in the code might seem to
>>> be
>>> >>>> the reason that no containers have been pushed to Docker Hub. A
>>> Dockerfile
>>> >>>> is the standard way of creating images. This is very confusing for
>>> many
>>> >>>> people (including me), however this is not the actual problem
>>> because JIB
>>> >>>> (Java Image Builder) is set up to build the image during testing
>>> directly
>>> >>>> from java source code by Gradle in two places:
>>> >>>>
>>> >>>> build-docker-postgresql.yml
>>> >>>> build-docker-mariadb.yml
>>> >>>>
>>> >>>> The problem is that JIB does not seem to be configured to actually
>>> push
>>> >>>> the container image to Docker Hub. It only seems to be configured
>>> to build
>>> >>>> the image for testing.
>>> >>>>
>>> >>>> To solve this, two things need to be done:
>>> >>>>
>>> >>>>
>>> >>>> - It needs to be decided when to push the image (and possibly
>>> create
>>> >>>> a new GitHub Action to do it)
>>> >>>> - Code needs to be added to configure JIB to know where to push
>>> the
>>> >>>> image on Docker Hub (see this example)
>>> >>>> - Credentials need to be supplied to the GitHub Action to allow
>>> it
>>> >>>> actually push the image
>>> >>>>
>>> >>>>
>>> >>>> Additional Open Source Observations (Optics)
>>> >>>>
>>> >>>> Dockerfile
>>> >>>>
>>> >>>> The removal of the Dockerfile from the repo is confusing (especially
>>> >>>> coupled with the existence of a docker-compose.yml file) and also
>>> makes it
>>> >>>> harder for potential contributors to set up and run Fineract
>>> because now
>>> >>>> dependencies need to be installed locally, rather than running them
>>> all in
>>> >>>> containers.
>>> >>>>
>>> >>>> The lack of a Dockerfile in the repository is nonstandard from an
>>> Open
>>> >>>> Source perspective. Regardless of whether it is needed by the
>>> Fineract
>>> >>>> build process or not, most open source projects include a
>>> Dockerfile, and
>>> >>>> most open source users expect one to exist in the repo so they can
>>> easily
>>> >>>> build / run / test the project locally. Adding the Dockerfile back
>>> to the
>>> >>>> repo should be trivial (and removes the need for JIB entirely).
>>> >>>>
>>> >>>> General Setup
>>> >>>>
>>> >>>> The current Fineract process for building and running using
>>> containers
>>> >>>> makes it significantly harder for developers to get started with
>>> Fineract
>>> >>>> because a local Java environment needs to be installed. More
>>> disappointing,
>>> >>>> a completely different public set of instructions exist on Docker
>>> Hub .
>>> >>>> These instructions do not work because they are out of date, but are
>>> >>>> significantly easier for developers to use. Having two sets of
>>> different
>>> >>>> install instructions is confusing, but having the simpler set of
>>> >>>> instructions that do not work is a very bad developer experience.
>>> >>>>
>>> >>>>
>>> >>>>
>>> >>>>
>>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> >>>> victor.romero@fintecheando.mx> wrote:
>>> >>>>
>>> >>>>> Hello,
>>> >>>>>
>>> >>>>> Another way to have the Docker Hub image published (just like
>>> Apache
>>> >>>>> Tomcat):
>>> >>>>>
>>> >>>>> https://github.com/docker-library/official-images
>>> >>>>>
>>> >>>>> https://github.com/docker-library/tomcat
>>> >>>>>
>>> >>>>> Regards
>>> >>>>>
>>> >>>>>
>>> >>>>>
>>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jdailey@apache.org
>>> >)
>>> >>>>> escribió:
>>> >>>>>
>>> >>>>>> Is there an easy thing to request?
>>> >>>>>>
>>> >>>>>> ---------- Forwarded message ---------
>>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>> >>>>>> Subject: Re: Docker help
>>> >>>>>> To: James Dailey <jd...@apache.org>
>>> >>>>>> CC: Users <us...@infra.apache.org>
>>> >>>>>>
>>> >>>>>>
>>> >>>>>> Hi James.
>>> >>>>>>
>>> >>>>>>
>>> >>>>>>
>>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>> >>>>>> wrote:
>>> >>>>>>
>>> >>>>>>> Infra -
>>> >>>>>>>
>>> >>>>>>> Can you confirm that we can use other processes to push to
>>> >>>>>>> apache DockerHUB?
>>> >>>>>>>
>>> >>>>>>
>>> >>>>>> Current supported methods are via Github Actions or Jenkins or
>>> locally
>>> >>>>>> via your own credentials.
>>> >>>>>>
>>> >>>>>> For Github Actions we can use a role account and attach the
>>> secrets to
>>> >>>>>> your repository, or you
>>> >>>>>> can provide your own secrets for us to add to your repository
>>> >>>>>>
>>> >>>>>> For Jenkins we have a role account that we provide access to push
>>> to
>>> >>>>>> your repository.
>>> >>>>>>
>>> >>>>>> Committers could also use a settings.xml with this plugin and use
>>> >>>>>> their own credentials, we just need
>>> >>>>>> to ensure they have push access to Dockerhub.
>>> >>>>>>
>>> >>>>>> There may also be other methods not explored.
>>> >>>>>>
>>> >>>>>> See also:
>>> >>>>>>
>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>> >>>>>>
>>> >>>>>> HTH
>>> >>>>>>
>>> >>>>>>>
>>> >>>>>>> When I opened a ticket about this, I was told we need a
>>> dockerfile at
>>> >>>>>>> the root.
>>> >>>>>>>
>>> >>>>>>> Can we use "jib-maven-plugin to publish the image to
>>> Dockerhub". ?
>>> >>>>>>> Can we get credentials ?
>>> >>>>>>>
>>> >>>>>>> James
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>> ---------- Forwarded message ---------
>>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>> >>>>>>> Subject: Re: Docker help
>>> >>>>>>> To: <de...@fineract.apache.org>
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>> James,
>>> >>>>>>>
>>> >>>>>>> This is the out-of-the box solution from DockerHub which
>>> definitely
>>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean it's
>>> the only way
>>> >>>>>>> to build a docker image; as I stated in my previous email.
>>> >>>>>>>
>>> >>>>>>> Best,
>>> >>>>>>> Arnold
>>> >>>>>>>
>>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>>> jamespdailey@gmail.com>
>>> >>>>>>> wrote:
>>> >>>>>>>
>>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>>> >>>>>>>>
>>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's
>>> infrastructure...
>>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host
>>> key for
>>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>>> 'origin/develop'.
>>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> Let's discuss on slack and revert back here.
>>> >>>>>>>>
>>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to get
>>> this
>>> >>>>>>>> working.
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>>> arnold@apache.org>
>>> >>>>>>>> wrote:
>>> >>>>>>>>
>>> >>>>>>>>> Hi Zoltan, James,
>>> >>>>>>>>>
>>> >>>>>>>>> Just to reflect on your points:
>>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely
>>> need to
>>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>>> already
>>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions (using
>>> their
>>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>>> >>>>>>>>>
>>> >>>>>>>>> We need the credentials to be able to do a docker push, alter
>>> the
>>> >>>>>>>>> pipeline and that's all.
>>> >>>>>>>>>
>>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>>> asking
>>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>>> making such an
>>> >>>>>>>>> unnecessary change.
>>> >>>>>>>>>
>>> >>>>>>>>> Arnold
>>> >>>>>>>>>
>>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>>> >>>>>>>>>
>>> >>>>>>>>>> Thanks Zoltan
>>> >>>>>>>>>>
>>> >>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>> >>>>>>>>>> relates to the Google deployment that you put in place?
>>> Question!
>>> >>>>>>>>>>
>>> >>>>>>>>>>
>>> >>>>>>>>>>
>>> >>>>>>>>>>
>>> >>>>>>>>>>
>>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>> >>>>>>>>>>
>>> >>>>>>>>>>> Hi,
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> I think the real issue here is that we use
>>> GoogleContainerTools's
>>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>>> Dockerfile. And
>>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support
>>> building without
>>> >>>>>>>>>>> a Dockerfile. :-(
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> We have two ways to move forward:
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large
>>> change of how
>>> >>>>>>>>>>> Fineract is built and the consequences need to be explored -
>>> but it's
>>> >>>>>>>>>>> definitely doable.
>>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>>> could also work,
>>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>> >>>>>>>>>>> different from what Jib can produce, so this might lead to
>>> regressions.
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> Want me to try this approach next week?
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> Kind regards,
>>> >>>>>>>>>>> Zoltan
>>> >>>>>>>>>>>
>>> >>>>>>>>>>>
>>> >>>>>>>>>>>
>>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>> >>>>>>>>>>>
>>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build
>>> rule “
>>> >>>>>>>>>>>> points to master or main but we can also use dev. In fact
>>> that’s what is
>>> >>>>>>>>>>>> already there in dockerHUB for our project.
>>> >>>>>>>>>>>>
>>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>> >>>>>>>>>>>>
>>> >>>>>>>>>>>> Thanks
>>> >>>>>>>>>>>> James
>>> >>>>>>>>>>>>
>>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>>> RODRIGUEZ <
>>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>> >>>>>>>>>>>>
>>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the
>>> following:
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for
>>> handling
>>> >>>>>>>>>>>>> the versions) on master branch
>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>> from the
>>> >>>>>>>>>>>>> master branch
>>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>>> branch everytime the
>>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will
>>> publish it as
>>> >>>>>>>>>>>>> the latest version.
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> Or... we can be more standard
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> 1. Rename develop to master
>>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>> >>>>>>>>>>>>> handling the versions) on master branch
>>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts)
>>> from the
>>> >>>>>>>>>>>>> master branch
>>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub
>>> will
>>> >>>>>>>>>>>>> publish it as the latest/specific version.
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> What do you think?
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> Dockerhub automated builds info:
>>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> Regards
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>> >>>>>>>>>>>>>
>>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as
>>> that is
>>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>>> However, to add the key
>>> >>>>>>>>>>>>>> to the git hub requires access and the git is controlled
>>> by Apache Infra.
>>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra
>>> has it setup a
>>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish to
>>> the Apache
>>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>> >>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>>> RODRIGUEZ <
>>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>> >>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials
>>> of
>>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>>> >>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>> If they are set in the git repository, a github action
>>> can be
>>> >>>>>>>>>>>>>>> enabled for this task.
>>> >>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>> Regards
>>> >>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>> >>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> I've re-opened
>>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>> >>>>>>>>>>>>>>>> project is responsible for the content.
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That
>>> is as far as I've
>>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the
>>> time.
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the
>>> Docker
>>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>>> standard is to only
>>> >>>>>>>>>>>>>>>> support and distribute publicly the last two releases.
>>> This build is really
>>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large
>>> numbers. (no idea
>>> >>>>>>>>>>>>>>>> why)
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>> Thanks
>>> >>>>>>>>>>>>>>>> James
>>> >>>>>>>>>>>>>>>>
>>> >>>>>>>>>>>>>>>
>>> >>>>>>
>>> >>>>>> --
>>> >>>>>>
>>> >>>>>>
>>> >>>>>> *Gavin McDonald - *
>>> >>>>>> Systems Administrator, ASF Infrastructure Team
>>> >>>>>> V.P Travel Assistance Committee
>>> >>>>>>
>>> >>>>>> https://tac.apache.org - Applications now open for Community Over
>>> >>>>>> Code 2024
>>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>> >>>>>>
>>> >>>>>> --
>>> >>>
>>> >>> Herring BANCORP ®
>>> >>>
>>> >>>
>>> >>> *C. Campbell Burgess *President/CEO
>>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>> >>>
>>> >>> ccb@herringbancorp.com
>>> >>>
>>> >>>
>>> >>> *Herring Bancorp*
>>> >>> 2201 Civic Circle, Suite 1000
>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000?entry=gmail&source=g>
>>> >>> <
>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>> >
>>> >>> Amarillo, TX 79109
>>> >>> <
>>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>>> >
>>> >>>
>>> >>> www.herringbank.com
>>> >>>
>>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
>>> >>> individual or entity to which it is addressed and may contain
>>> information
>>> >>> that is privileged, confidential and exempt from disclosure under
>>> >>> applicable law. If the reader of this e-mail message is not the
>>> intended
>>> >>> recipient, or the employee or agent responsible for delivery of the
>>> message
>>> >>> to the intended recipient, you are hereby notified that any
>>> dissemination,
>>> >>> distribution or copying of this communication is prohibited. If you
>>> have
>>> >>> received this e-mail in error, please notify us immediately by
>>> telephone at
>>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>>
>>> >>
>>>
>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Arnold,
Suggestion welcome, let me add both platforms.
Regards
El vie, 10 may 2024 a las 13:29, Arnold Galovics (<ga...@gmail.com>)
escribió:
> Victor,
>
> I think we are missing one crucial thing in your PR, to build the image
> multi-platform, specifically for x86 and arm.
>
> Would it be possible for you to add it?
>
> Thanks.
> Best,
> Arnold
>
> On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
>
>> Sure thing... we are glad to help while you guys sort out the kinks.
>>
>> Collins, please set up a separate thread or email me directly and we will
>> help you get set up.
>>
>> Campbell
>>
>>
>> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
>> wrote:
>> >(Collins & Campbell - please start new thread)
>> >
>> >
>> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
>> wrote:
>> >
>> >> Hi Campbell,
>> >>
>> >> Please would you be able to share the steps on how to get Fineract 1.8
>> >> deployed with Docker?
>> >> I have tried, doing this and could not get it to work.
>> >>
>> >> Collins
>> >>
>> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>> >>
>> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment
>> and
>> >>> is readying for 1.9.
>> >>>
>> >>> We would offer our help if needed.
>> >>>
>> >>> Campbell
>> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
>> >>>
>> >>> Dev - I had a conversation IRL with Todd recently, cc'd here - not on
>> >>> the project but willing to help out. He has offered some advice for
>> the
>> >>> project to get the Docker distro of Apache Fineract working again. I
>> would
>> >>> like to have either a push back or we should restore the docker file
>> asap.
>> >>>
>> >>> To recap:
>> >>> The DockerHub Image is two years old, and the process to pull from
>> our
>> >>> Dev branch has been broken that entire time. It broke when we
>> removed the
>> >>> docker-build file with this ticket
>> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
>> >>>
>> >>> With a Million downloads of fineract from DockerHUB, where that
>> version
>> >>> has multiple CVEs (security issues), we should not be continuing to
>> keep
>> >>> that there.
>> >>>
>> >>> So, we need to fix the docker pipeline. Credentials will be required
>> >>> from infra.
>> >>>
>> >>> Todd's comments:
>> >>>
>> >>> Extended Summary
>> >>>>
>> >>>> The problem for the internal Fineract development pipeline is that
>> >>>> changes were made to the build process that
>> >>>> removed the expected Dockerfile
>> >>>> added an external dependency to the code repo (mifos community-app
>> web
>> >>>> UI)
>> >>>> does not publish a public Fineract Docker image to Docker Hub
>> >>>>
>> >>>> At first glance, the lack of a Dockerfile in the code might seem to
>> be
>> >>>> the reason that no containers have been pushed to Docker Hub. A
>> Dockerfile
>> >>>> is the standard way of creating images. This is very confusing for
>> many
>> >>>> people (including me), however this is not the actual problem
>> because JIB
>> >>>> (Java Image Builder) is set up to build the image during testing
>> directly
>> >>>> from java source code by Gradle in two places:
>> >>>>
>> >>>> build-docker-postgresql.yml
>> >>>> build-docker-mariadb.yml
>> >>>>
>> >>>> The problem is that JIB does not seem to be configured to actually
>> push
>> >>>> the container image to Docker Hub. It only seems to be configured to
>> build
>> >>>> the image for testing.
>> >>>>
>> >>>> To solve this, two things need to be done:
>> >>>>
>> >>>>
>> >>>> - It needs to be decided when to push the image (and possibly
>> create
>> >>>> a new GitHub Action to do it)
>> >>>> - Code needs to be added to configure JIB to know where to push
>> the
>> >>>> image on Docker Hub (see this example)
>> >>>> - Credentials need to be supplied to the GitHub Action to allow it
>> >>>> actually push the image
>> >>>>
>> >>>>
>> >>>> Additional Open Source Observations (Optics)
>> >>>>
>> >>>> Dockerfile
>> >>>>
>> >>>> The removal of the Dockerfile from the repo is confusing (especially
>> >>>> coupled with the existence of a docker-compose.yml file) and also
>> makes it
>> >>>> harder for potential contributors to set up and run Fineract because
>> now
>> >>>> dependencies need to be installed locally, rather than running them
>> all in
>> >>>> containers.
>> >>>>
>> >>>> The lack of a Dockerfile in the repository is nonstandard from an
>> Open
>> >>>> Source perspective. Regardless of whether it is needed by the
>> Fineract
>> >>>> build process or not, most open source projects include a
>> Dockerfile, and
>> >>>> most open source users expect one to exist in the repo so they can
>> easily
>> >>>> build / run / test the project locally. Adding the Dockerfile back
>> to the
>> >>>> repo should be trivial (and removes the need for JIB entirely).
>> >>>>
>> >>>> General Setup
>> >>>>
>> >>>> The current Fineract process for building and running using
>> containers
>> >>>> makes it significantly harder for developers to get started with
>> Fineract
>> >>>> because a local Java environment needs to be installed. More
>> disappointing,
>> >>>> a completely different public set of instructions exist on Docker
>> Hub .
>> >>>> These instructions do not work because they are out of date, but are
>> >>>> significantly easier for developers to use. Having two sets of
>> different
>> >>>> install instructions is confusing, but having the simpler set of
>> >>>> instructions that do not work is a very bad developer experience.
>> >>>>
>> >>>>
>> >>>>
>> >>>>
>> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> >>>> victor.romero@fintecheando.mx> wrote:
>> >>>>
>> >>>>> Hello,
>> >>>>>
>> >>>>> Another way to have the Docker Hub image published (just like Apache
>> >>>>> Tomcat):
>> >>>>>
>> >>>>> https://github.com/docker-library/official-images
>> >>>>>
>> >>>>> https://github.com/docker-library/tomcat
>> >>>>>
>> >>>>> Regards
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jdailey@apache.org
>> >)
>> >>>>> escribió:
>> >>>>>
>> >>>>>> Is there an easy thing to request?
>> >>>>>>
>> >>>>>> ---------- Forwarded message ---------
>> >>>>>> From: Gavin McDonald <gm...@apache.org>
>> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>> >>>>>> Subject: Re: Docker help
>> >>>>>> To: James Dailey <jd...@apache.org>
>> >>>>>> CC: Users <us...@infra.apache.org>
>> >>>>>>
>> >>>>>>
>> >>>>>> Hi James.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>> >>>>>> wrote:
>> >>>>>>
>> >>>>>>> Infra -
>> >>>>>>>
>> >>>>>>> Can you confirm that we can use other processes to push to
>> >>>>>>> apache DockerHUB?
>> >>>>>>>
>> >>>>>>
>> >>>>>> Current supported methods are via Github Actions or Jenkins or
>> locally
>> >>>>>> via your own credentials.
>> >>>>>>
>> >>>>>> For Github Actions we can use a role account and attach the
>> secrets to
>> >>>>>> your repository, or you
>> >>>>>> can provide your own secrets for us to add to your repository
>> >>>>>>
>> >>>>>> For Jenkins we have a role account that we provide access to push
>> to
>> >>>>>> your repository.
>> >>>>>>
>> >>>>>> Committers could also use a settings.xml with this plugin and use
>> >>>>>> their own credentials, we just need
>> >>>>>> to ensure they have push access to Dockerhub.
>> >>>>>>
>> >>>>>> There may also be other methods not explored.
>> >>>>>>
>> >>>>>> See also:
>> >>>>>>
>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>> >>>>>>
>> >>>>>> HTH
>> >>>>>>
>> >>>>>>>
>> >>>>>>> When I opened a ticket about this, I was told we need a
>> dockerfile at
>> >>>>>>> the root.
>> >>>>>>>
>> >>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub".
>> ?
>> >>>>>>> Can we get credentials ?
>> >>>>>>>
>> >>>>>>> James
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> ---------- Forwarded message ---------
>> >>>>>>> From: Arnold Galovics <ar...@apache.org>
>> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>> >>>>>>> Subject: Re: Docker help
>> >>>>>>> To: <de...@fineract.apache.org>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> James,
>> >>>>>>>
>> >>>>>>> This is the out-of-the box solution from DockerHub which
>> definitely
>> >>>>>>> won't work without a Dockerfile. Though that doesn't mean it's
>> the only way
>> >>>>>>> to build a docker image; as I stated in my previous email.
>> >>>>>>>
>> >>>>>>> Best,
>> >>>>>>> Arnold
>> >>>>>>>
>> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
>> jamespdailey@gmail.com>
>> >>>>>>> wrote:
>> >>>>>>>
>> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>> >>>>>>>> https://hub.docker.com/r/apache/fineract
>> >>>>>>>>
>> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key
>> for
>> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
>> 'origin/develop'.
>> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> Let's discuss on slack and revert back here.
>> >>>>>>>>
>> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to get
>> this
>> >>>>>>>> working.
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
>> arnold@apache.org>
>> >>>>>>>> wrote:
>> >>>>>>>>
>> >>>>>>>>> Hi Zoltan, James,
>> >>>>>>>>>
>> >>>>>>>>> Just to reflect on your points:
>> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely need
>> to
>> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We
>> already
>> >>>>>>>>> have docker builds in our pipeline via GitHub Actions (using
>> their
>> >>>>>>>>> runners), the only missing piece is to do a docker push.
>> >>>>>>>>>
>> >>>>>>>>> We need the credentials to be able to do a docker push, alter
>> the
>> >>>>>>>>> pipeline and that's all.
>> >>>>>>>>>
>> >>>>>>>>> If the only thing preventing us from doing this is to keep
>> asking
>> >>>>>>>>> the infra team for the creds, let's pursue them instead of
>> making such an
>> >>>>>>>>> unnecessary change.
>> >>>>>>>>>
>> >>>>>>>>> Arnold
>> >>>>>>>>>
>> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>> >>>>>>>>> jamespdailey@gmail.com> wrote:
>> >>>>>>>>>
>> >>>>>>>>>> Thanks Zoltan
>> >>>>>>>>>>
>> >>>>>>>>>> Micheal - can you please comment on this discussion? As this
>> >>>>>>>>>> relates to the Google deployment that you put in place?
>> Question!
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>> >>>>>>>>>>
>> >>>>>>>>>>> Hi,
>> >>>>>>>>>>>
>> >>>>>>>>>>> I think the real issue here is that we use
>> GoogleContainerTools's
>> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
>> Dockerfile. And
>> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support
>> building without
>> >>>>>>>>>>> a Dockerfile. :-(
>> >>>>>>>>>>>
>> >>>>>>>>>>> We have two ways to move forward:
>> >>>>>>>>>>>
>> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large change
>> of how
>> >>>>>>>>>>> Fineract is built and the consequences need to be explored -
>> but it's
>> >>>>>>>>>>> definitely doable.
>> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This
>> could also work,
>> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
>> >>>>>>>>>>>
>> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>> >>>>>>>>>>> different from what Jib can produce, so this might lead to
>> regressions.
>> >>>>>>>>>>>
>> >>>>>>>>>>> Want me to try this approach next week?
>> >>>>>>>>>>>
>> >>>>>>>>>>> Kind regards,
>> >>>>>>>>>>> Zoltan
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
>> >>>>>>>>>>>
>> >>>>>>>>>>>> Victor - my read of the docs is that the default “build rule
>> “
>> >>>>>>>>>>>> points to master or main but we can also use dev. In fact
>> that’s what is
>> >>>>>>>>>>>> already there in dockerHUB for our project.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> Thanks
>> >>>>>>>>>>>> James
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO
>> RODRIGUEZ <
>> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> 1. Create a master branch from develop branch
>> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
>> >>>>>>>>>>>>> the versions) on master branch
>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
>> the
>> >>>>>>>>>>>>> master branch
>> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>> >>>>>>>>>>>>> master, so then it will push the changes to the master
>> branch everytime the
>> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will
>> publish it as
>> >>>>>>>>>>>>> the latest version.
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> Or... we can be more standard
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> 1. Rename develop to master
>> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>> >>>>>>>>>>>>> handling the versions) on master branch
>> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
>> the
>> >>>>>>>>>>>>> master branch
>> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub
>> will
>> >>>>>>>>>>>>> publish it as the latest/specific version.
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> What do you think?
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> Dockerhub automated builds info:
>> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> Regards
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as
>> that is
>> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB.
>> However, to add the key
>> >>>>>>>>>>>>>> to the git hub requires access and the git is controlled
>> by Apache Infra.
>> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra
>> has it setup a
>> >>>>>>>>>>>>>> specific way to allow all of the projects to publish to
>> the Apache
>> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
>> RODRIGUEZ <
>> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
>> >>>>>>>>>>>>>>> the docker hub account are requiered.
>> >>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>> If they are set in the git repository, a github action
>> can be
>> >>>>>>>>>>>>>>> enabled for this task.
>> >>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>> Regards
>> >>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>> >>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> I've re-opened
>> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>> >>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>> >>>>>>>>>>>>>>>> project is responsible for the content.
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> The build is actually failing or not running because we
>> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That
>> is as far as I've
>> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the
>> time.
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
>> standard is to only
>> >>>>>>>>>>>>>>>> support and distribute publicly the last two releases.
>> This build is really
>> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large
>> numbers. (no idea
>> >>>>>>>>>>>>>>>> why)
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>> Thanks
>> >>>>>>>>>>>>>>>> James
>> >>>>>>>>>>>>>>>>
>> >>>>>>>>>>>>>>>
>> >>>>>>
>> >>>>>> --
>> >>>>>>
>> >>>>>>
>> >>>>>> *Gavin McDonald - *
>> >>>>>> Systems Administrator, ASF Infrastructure Team
>> >>>>>> V.P Travel Assistance Committee
>> >>>>>>
>> >>>>>> https://tac.apache.org - Applications now open for Community Over
>> >>>>>> Code 2024
>> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>> >>>>>>
>> >>>>>> --
>> >>>
>> >>> Herring BANCORP ®
>> >>>
>> >>>
>> >>> *C. Campbell Burgess *President/CEO
>> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
>> >>>
>> >>> ccb@herringbancorp.com
>> >>>
>> >>>
>> >>> *Herring Bancorp*
>> >>> 2201 Civic Circle, Suite 1000
>> >>> <
>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>> >
>> >>> Amarillo, TX 79109
>> >>> <
>> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
>> >
>> >>>
>> >>> www.herringbank.com
>> >>>
>> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
>> >>> individual or entity to which it is addressed and may contain
>> information
>> >>> that is privileged, confidential and exempt from disclosure under
>> >>> applicable law. If the reader of this e-mail message is not the
>> intended
>> >>> recipient, or the employee or agent responsible for delivery of the
>> message
>> >>> to the intended recipient, you are hereby notified that any
>> dissemination,
>> >>> distribution or copying of this communication is prohibited. If you
>> have
>> >>> received this e-mail in error, please notify us immediately by
>> telephone at
>> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>
>>
>
Re: Docker help
Posted by Arnold Galovics <ga...@gmail.com>.
Victor,
I think we are missing one crucial thing in your PR, to build the image
multi-platform, specifically for x86 and arm.
Would it be possible for you to add it?
Thanks.
Best,
Arnold
On Fri, May 10, 2024 at 5:45 AM CCB <cc...@herringbancorp.com> wrote:
> Sure thing... we are glad to help while you guys sort out the kinks.
>
> Collins, please set up a separate thread or email me directly and we will
> help you get set up.
>
> Campbell
>
>
> On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com>
> wrote:
> >(Collins & Campbell - please start new thread)
> >
> >
> >On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com>
> wrote:
> >
> >> Hi Campbell,
> >>
> >> Please would you be able to share the steps on how to get Fineract 1.8
> >> deployed with Docker?
> >> I have tried, doing this and could not get it to work.
> >>
> >> Collins
> >>
> >> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
> >>
> >>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment and
> >>> is readying for 1.9.
> >>>
> >>> We would offer our help if needed.
> >>>
> >>> Campbell
> >>> On 5/2/2024 10:02 AM, James Dailey wrote:
> >>>
> >>> Dev - I had a conversation IRL with Todd recently, cc'd here - not on
> >>> the project but willing to help out. He has offered some advice for
> the
> >>> project to get the Docker distro of Apache Fineract working again. I
> would
> >>> like to have either a push back or we should restore the docker file
> asap.
> >>>
> >>> To recap:
> >>> The DockerHub Image is two years old, and the process to pull from our
> >>> Dev branch has been broken that entire time. It broke when we removed
> the
> >>> docker-build file with this ticket
> >>> https://issues.apache.org/jira/browse/FINERACT-1469.
> >>>
> >>> With a Million downloads of fineract from DockerHUB, where that version
> >>> has multiple CVEs (security issues), we should not be continuing to
> keep
> >>> that there.
> >>>
> >>> So, we need to fix the docker pipeline. Credentials will be required
> >>> from infra.
> >>>
> >>> Todd's comments:
> >>>
> >>> Extended Summary
> >>>>
> >>>> The problem for the internal Fineract development pipeline is that
> >>>> changes were made to the build process that
> >>>> removed the expected Dockerfile
> >>>> added an external dependency to the code repo (mifos community-app web
> >>>> UI)
> >>>> does not publish a public Fineract Docker image to Docker Hub
> >>>>
> >>>> At first glance, the lack of a Dockerfile in the code might seem to be
> >>>> the reason that no containers have been pushed to Docker Hub. A
> Dockerfile
> >>>> is the standard way of creating images. This is very confusing for
> many
> >>>> people (including me), however this is not the actual problem because
> JIB
> >>>> (Java Image Builder) is set up to build the image during testing
> directly
> >>>> from java source code by Gradle in two places:
> >>>>
> >>>> build-docker-postgresql.yml
> >>>> build-docker-mariadb.yml
> >>>>
> >>>> The problem is that JIB does not seem to be configured to actually
> push
> >>>> the container image to Docker Hub. It only seems to be configured to
> build
> >>>> the image for testing.
> >>>>
> >>>> To solve this, two things need to be done:
> >>>>
> >>>>
> >>>> - It needs to be decided when to push the image (and possibly
> create
> >>>> a new GitHub Action to do it)
> >>>> - Code needs to be added to configure JIB to know where to push the
> >>>> image on Docker Hub (see this example)
> >>>> - Credentials need to be supplied to the GitHub Action to allow it
> >>>> actually push the image
> >>>>
> >>>>
> >>>> Additional Open Source Observations (Optics)
> >>>>
> >>>> Dockerfile
> >>>>
> >>>> The removal of the Dockerfile from the repo is confusing (especially
> >>>> coupled with the existence of a docker-compose.yml file) and also
> makes it
> >>>> harder for potential contributors to set up and run Fineract because
> now
> >>>> dependencies need to be installed locally, rather than running them
> all in
> >>>> containers.
> >>>>
> >>>> The lack of a Dockerfile in the repository is nonstandard from an Open
> >>>> Source perspective. Regardless of whether it is needed by the Fineract
> >>>> build process or not, most open source projects include a Dockerfile,
> and
> >>>> most open source users expect one to exist in the repo so they can
> easily
> >>>> build / run / test the project locally. Adding the Dockerfile back
> to the
> >>>> repo should be trivial (and removes the need for JIB entirely).
> >>>>
> >>>> General Setup
> >>>>
> >>>> The current Fineract process for building and running using containers
> >>>> makes it significantly harder for developers to get started with
> Fineract
> >>>> because a local Java environment needs to be installed. More
> disappointing,
> >>>> a completely different public set of instructions exist on Docker Hub
> .
> >>>> These instructions do not work because they are out of date, but are
> >>>> significantly easier for developers to use. Having two sets of
> different
> >>>> install instructions is confusing, but having the simpler set of
> >>>> instructions that do not work is a very bad developer experience.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> >>>> victor.romero@fintecheando.mx> wrote:
> >>>>
> >>>>> Hello,
> >>>>>
> >>>>> Another way to have the Docker Hub image published (just like Apache
> >>>>> Tomcat):
> >>>>>
> >>>>> https://github.com/docker-library/official-images
> >>>>>
> >>>>> https://github.com/docker-library/tomcat
> >>>>>
> >>>>> Regards
> >>>>>
> >>>>>
> >>>>>
> >>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
> >>>>> escribió:
> >>>>>
> >>>>>> Is there an easy thing to request?
> >>>>>>
> >>>>>> ---------- Forwarded message ---------
> >>>>>> From: Gavin McDonald <gm...@apache.org>
> >>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
> >>>>>> Subject: Re: Docker help
> >>>>>> To: James Dailey <jd...@apache.org>
> >>>>>> CC: Users <us...@infra.apache.org>
> >>>>>>
> >>>>>>
> >>>>>> Hi James.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Infra -
> >>>>>>>
> >>>>>>> Can you confirm that we can use other processes to push to
> >>>>>>> apache DockerHUB?
> >>>>>>>
> >>>>>>
> >>>>>> Current supported methods are via Github Actions or Jenkins or
> locally
> >>>>>> via your own credentials.
> >>>>>>
> >>>>>> For Github Actions we can use a role account and attach the secrets
> to
> >>>>>> your repository, or you
> >>>>>> can provide your own secrets for us to add to your repository
> >>>>>>
> >>>>>> For Jenkins we have a role account that we provide access to push to
> >>>>>> your repository.
> >>>>>>
> >>>>>> Committers could also use a settings.xml with this plugin and use
> >>>>>> their own credentials, we just need
> >>>>>> to ensure they have push access to Dockerhub.
> >>>>>>
> >>>>>> There may also be other methods not explored.
> >>>>>>
> >>>>>> See also:
> >>>>>>
> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
> >>>>>>
> >>>>>> HTH
> >>>>>>
> >>>>>>>
> >>>>>>> When I opened a ticket about this, I was told we need a dockerfile
> at
> >>>>>>> the root.
> >>>>>>>
> >>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
> >>>>>>> Can we get credentials ?
> >>>>>>>
> >>>>>>> James
> >>>>>>>
> >>>>>>>
> >>>>>>> ---------- Forwarded message ---------
> >>>>>>> From: Arnold Galovics <ar...@apache.org>
> >>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
> >>>>>>> Subject: Re: Docker help
> >>>>>>> To: <de...@fineract.apache.org>
> >>>>>>>
> >>>>>>>
> >>>>>>> James,
> >>>>>>>
> >>>>>>> This is the out-of-the box solution from DockerHub which definitely
> >>>>>>> won't work without a Dockerfile. Though that doesn't mean it's the
> only way
> >>>>>>> to build a docker image; as I stated in my previous email.
> >>>>>>>
> >>>>>>> Best,
> >>>>>>> Arnold
> >>>>>>>
> >>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <
> jamespdailey@gmail.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> On DockerHUB the build fails because there is no dockerfile.
> >>>>>>>> https://hub.docker.com/r/apache/fineract
> >>>>>>>>
> >>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
> >>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
> >>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key
> for
> >>>>>>>> IP address '140.82.114.4' to the list of known hosts.
> >>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
> >>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with
> 'origin/develop'.
> >>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Let's discuss on slack and revert back here.
> >>>>>>>>
> >>>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
> >>>>>>>> working.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <
> arnold@apache.org>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hi Zoltan, James,
> >>>>>>>>>
> >>>>>>>>> Just to reflect on your points:
> >>>>>>>>> 1) Let's not do such a radical change unless we absolutely need
> to
> >>>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
> >>>>>>>>> have docker builds in our pipeline via GitHub Actions (using
> their
> >>>>>>>>> runners), the only missing piece is to do a docker push.
> >>>>>>>>>
> >>>>>>>>> We need the credentials to be able to do a docker push, alter the
> >>>>>>>>> pipeline and that's all.
> >>>>>>>>>
> >>>>>>>>> If the only thing preventing us from doing this is to keep asking
> >>>>>>>>> the infra team for the creds, let's pursue them instead of
> making such an
> >>>>>>>>> unnecessary change.
> >>>>>>>>>
> >>>>>>>>> Arnold
> >>>>>>>>>
> >>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
> >>>>>>>>> jamespdailey@gmail.com> wrote:
> >>>>>>>>>
> >>>>>>>>>> Thanks Zoltan
> >>>>>>>>>>
> >>>>>>>>>> Micheal - can you please comment on this discussion? As this
> >>>>>>>>>> relates to the Google deployment that you put in place?
> Question!
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
> >>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Hi,
> >>>>>>>>>>>
> >>>>>>>>>>> I think the real issue here is that we use
> GoogleContainerTools's
> >>>>>>>>>>> Jib as the build mechanism. It works entirely without a
> Dockerfile. And
> >>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support
> building without
> >>>>>>>>>>> a Dockerfile. :-(
> >>>>>>>>>>>
> >>>>>>>>>>> We have two ways to move forward:
> >>>>>>>>>>>
> >>>>>>>>>>> 1. Replace the Jib build with a more traditional,
> >>>>>>>>>>> Dockerfile-based approach. This would be a quite large change
> of how
> >>>>>>>>>>> Fineract is built and the consequences need to be explored -
> but it's
> >>>>>>>>>>> definitely doable.
> >>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
> >>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
> >>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could
> also work,
> >>>>>>>>>>> but it requires a build server that I'm not sure we have.
> >>>>>>>>>>>
> >>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
> >>>>>>>>>>> different from what Jib can produce, so this might lead to
> regressions.
> >>>>>>>>>>>
> >>>>>>>>>>> Want me to try this approach next week?
> >>>>>>>>>>>
> >>>>>>>>>>> Kind regards,
> >>>>>>>>>>> Zoltan
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
> >>>>>>>>>>> jamespdailey@gmail.com> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
> >>>>>>>>>>>> points to master or main but we can also use dev. In fact
> that’s what is
> >>>>>>>>>>>> already there in dockerHUB for our project.
> >>>>>>>>>>>>
> >>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Thanks
> >>>>>>>>>>>> James
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ
> <
> >>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> 1. Create a master branch from develop branch
> >>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
> >>>>>>>>>>>>> the versions) on master branch
> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
> the
> >>>>>>>>>>>>> master branch
> >>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
> >>>>>>>>>>>>> master, so then it will push the changes to the master
> branch everytime the
> >>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will
> publish it as
> >>>>>>>>>>>>> the latest version.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Or... we can be more standard
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> 1. Rename develop to master
> >>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
> >>>>>>>>>>>>> handling the versions) on master branch
> >>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from
> the
> >>>>>>>>>>>>> master branch
> >>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub
> will
> >>>>>>>>>>>>> publish it as the latest/specific version.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> What do you think?
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Dockerhub automated builds info:
> >>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Regards
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
> >>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that
> is
> >>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However,
> to add the key
> >>>>>>>>>>>>>> to the git hub requires access and the git is controlled
> by Apache Infra.
> >>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
> >>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has
> it setup a
> >>>>>>>>>>>>>> specific way to allow all of the projects to publish to the
> Apache
> >>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO
> RODRIGUEZ <
> >>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
> >>>>>>>>>>>>>>> the docker hub account are requiered.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> If they are set in the git repository, a github action can
> be
> >>>>>>>>>>>>>>> enabled for this task.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Regards
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
> >>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> I've re-opened
> >>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
> >>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
> >>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
> >>>>>>>>>>>>>>>> project is responsible for the content.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
> >>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> The build is actually failing or not running because we
> >>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is
> as far as I've
> >>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the
> time.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
> >>>>>>>>>>>>>>>> build to work THEN we should take this down. Our
> standard is to only
> >>>>>>>>>>>>>>>> support and distribute publicly the last two releases.
> This build is really
> >>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large
> numbers. (no idea
> >>>>>>>>>>>>>>>> why)
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Thanks
> >>>>>>>>>>>>>>>> James
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>>
> >>>>>>
> >>>>>> *Gavin McDonald - *
> >>>>>> Systems Administrator, ASF Infrastructure Team
> >>>>>> V.P Travel Assistance Committee
> >>>>>>
> >>>>>> https://tac.apache.org - Applications now open for Community Over
> >>>>>> Code 2024
> >>>>>> in Bratislava, Slovakia. Don't delay, apply today!
> >>>>>>
> >>>>>> --
> >>>
> >>> Herring BANCORP ®
> >>>
> >>>
> >>> *C. Campbell Burgess *President/CEO
> >>> Office: (806) 373-3921 | Direct: (806) 242-3704
> >>>
> >>> ccb@herringbancorp.com
> >>>
> >>>
> >>> *Herring Bancorp*
> >>> 2201 Civic Circle, Suite 1000
> >>> <
> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
> >
> >>> Amarillo, TX 79109
> >>> <
> https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g
> >
> >>>
> >>> www.herringbank.com
> >>>
> >>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
> >>> individual or entity to which it is addressed and may contain
> information
> >>> that is privileged, confidential and exempt from disclosure under
> >>> applicable law. If the reader of this e-mail message is not the
> intended
> >>> recipient, or the employee or agent responsible for delivery of the
> message
> >>> to the intended recipient, you are hereby notified that any
> dissemination,
> >>> distribution or copying of this communication is prohibited. If you
> have
> >>> received this e-mail in error, please notify us immediately by
> telephone at
> >>> (303) 565-7001 and also indicate the sender's name. Thank you.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
>
Re: Docker help
Posted by CCB <cc...@herringbancorp.com>.
Sure thing... we are glad to help while you guys sort out the kinks.
Collins, please set up a separate thread or email me directly and we will help you get set up.
Campbell
On May 8, 2024 8:24:53 PM CDT, James Dailey <ja...@gmail.com> wrote:
>(Collins & Campbell - please start new thread)
>
>
>On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com> wrote:
>
>> Hi Campbell,
>>
>> Please would you be able to share the steps on how to get Fineract 1.8
>> deployed with Docker?
>> I have tried, doing this and could not get it to work.
>>
>> Collins
>>
>> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>>
>>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment and
>>> is readying for 1.9.
>>>
>>> We would offer our help if needed.
>>>
>>> Campbell
>>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>>
>>> Dev - I had a conversation IRL with Todd recently, cc'd here - not on
>>> the project but willing to help out. He has offered some advice for the
>>> project to get the Docker distro of Apache Fineract working again. I would
>>> like to have either a push back or we should restore the docker file asap.
>>>
>>> To recap:
>>> The DockerHub Image is two years old, and the process to pull from our
>>> Dev branch has been broken that entire time. It broke when we removed the
>>> docker-build file with this ticket
>>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>>
>>> With a Million downloads of fineract from DockerHUB, where that version
>>> has multiple CVEs (security issues), we should not be continuing to keep
>>> that there.
>>>
>>> So, we need to fix the docker pipeline. Credentials will be required
>>> from infra.
>>>
>>> Todd's comments:
>>>
>>> Extended Summary
>>>>
>>>> The problem for the internal Fineract development pipeline is that
>>>> changes were made to the build process that
>>>> removed the expected Dockerfile
>>>> added an external dependency to the code repo (mifos community-app web
>>>> UI)
>>>> does not publish a public Fineract Docker image to Docker Hub
>>>>
>>>> At first glance, the lack of a Dockerfile in the code might seem to be
>>>> the reason that no containers have been pushed to Docker Hub. A Dockerfile
>>>> is the standard way of creating images. This is very confusing for many
>>>> people (including me), however this is not the actual problem because JIB
>>>> (Java Image Builder) is set up to build the image during testing directly
>>>> from java source code by Gradle in two places:
>>>>
>>>> build-docker-postgresql.yml
>>>> build-docker-mariadb.yml
>>>>
>>>> The problem is that JIB does not seem to be configured to actually push
>>>> the container image to Docker Hub. It only seems to be configured to build
>>>> the image for testing.
>>>>
>>>> To solve this, two things need to be done:
>>>>
>>>>
>>>> - It needs to be decided when to push the image (and possibly create
>>>> a new GitHub Action to do it)
>>>> - Code needs to be added to configure JIB to know where to push the
>>>> image on Docker Hub (see this example)
>>>> - Credentials need to be supplied to the GitHub Action to allow it
>>>> actually push the image
>>>>
>>>>
>>>> Additional Open Source Observations (Optics)
>>>>
>>>> Dockerfile
>>>>
>>>> The removal of the Dockerfile from the repo is confusing (especially
>>>> coupled with the existence of a docker-compose.yml file) and also makes it
>>>> harder for potential contributors to set up and run Fineract because now
>>>> dependencies need to be installed locally, rather than running them all in
>>>> containers.
>>>>
>>>> The lack of a Dockerfile in the repository is nonstandard from an Open
>>>> Source perspective. Regardless of whether it is needed by the Fineract
>>>> build process or not, most open source projects include a Dockerfile, and
>>>> most open source users expect one to exist in the repo so they can easily
>>>> build / run / test the project locally. Adding the Dockerfile back to the
>>>> repo should be trivial (and removes the need for JIB entirely).
>>>>
>>>> General Setup
>>>>
>>>> The current Fineract process for building and running using containers
>>>> makes it significantly harder for developers to get started with Fineract
>>>> because a local Java environment needs to be installed. More disappointing,
>>>> a completely different public set of instructions exist on Docker Hub .
>>>> These instructions do not work because they are out of date, but are
>>>> significantly easier for developers to use. Having two sets of different
>>>> install instructions is confusing, but having the simpler set of
>>>> instructions that do not work is a very bad developer experience.
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> victor.romero@fintecheando.mx> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> Another way to have the Docker Hub image published (just like Apache
>>>>> Tomcat):
>>>>>
>>>>> https://github.com/docker-library/official-images
>>>>>
>>>>> https://github.com/docker-library/tomcat
>>>>>
>>>>> Regards
>>>>>
>>>>>
>>>>>
>>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>>>>> escribió:
>>>>>
>>>>>> Is there an easy thing to request?
>>>>>>
>>>>>> ---------- Forwarded message ---------
>>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>>> Subject: Re: Docker help
>>>>>> To: James Dailey <jd...@apache.org>
>>>>>> CC: Users <us...@infra.apache.org>
>>>>>>
>>>>>>
>>>>>> Hi James.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Infra -
>>>>>>>
>>>>>>> Can you confirm that we can use other processes to push to
>>>>>>> apache DockerHUB?
>>>>>>>
>>>>>>
>>>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>>>> via your own credentials.
>>>>>>
>>>>>> For Github Actions we can use a role account and attach the secrets to
>>>>>> your repository, or you
>>>>>> can provide your own secrets for us to add to your repository
>>>>>>
>>>>>> For Jenkins we have a role account that we provide access to push to
>>>>>> your repository.
>>>>>>
>>>>>> Committers could also use a settings.xml with this plugin and use
>>>>>> their own credentials, we just need
>>>>>> to ensure they have push access to Dockerhub.
>>>>>>
>>>>>> There may also be other methods not explored.
>>>>>>
>>>>>> See also:
>>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>>
>>>>>> HTH
>>>>>>
>>>>>>>
>>>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>>>> the root.
>>>>>>>
>>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>>>> Can we get credentials ?
>>>>>>>
>>>>>>> James
>>>>>>>
>>>>>>>
>>>>>>> ---------- Forwarded message ---------
>>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>>> Subject: Re: Docker help
>>>>>>> To: <de...@fineract.apache.org>
>>>>>>>
>>>>>>>
>>>>>>> James,
>>>>>>>
>>>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>>
>>>>>>> Best,
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>
>>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>>
>>>>>>>>
>>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>>
>>>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>>>> working.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Zoltan, James,
>>>>>>>>>
>>>>>>>>> Just to reflect on your points:
>>>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>>
>>>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>>>> pipeline and that's all.
>>>>>>>>>
>>>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>>>> unnecessary change.
>>>>>>>>>
>>>>>>>>> Arnold
>>>>>>>>>
>>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Thanks Zoltan
>>>>>>>>>>
>>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>>>
>>>>>>>>>>> We have two ways to move forward:
>>>>>>>>>>>
>>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>>>> Dockerfile-based approach. This would be a quite large change of how
>>>>>>>>>>> Fineract is built and the consequences need to be explored - but it's
>>>>>>>>>>> definitely doable.
>>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>>>
>>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>>>
>>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>>>
>>>>>>>>>>> Kind regards,
>>>>>>>>>>> Zoltan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>>>
>>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>> James
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>>>
>>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
>>>>>>>>>>>>> the versions) on master branch
>>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>>> master branch
>>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>>>>>>>>>> master, so then it will push the changes to the master branch everytime the
>>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will publish it as
>>>>>>>>>>>>> the latest version.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>>>
>>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>>> master branch
>>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>>>
>>>>>>>>>>>>> What do you think?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
>>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>> *Gavin McDonald - *
>>>>>> Systems Administrator, ASF Infrastructure Team
>>>>>> V.P Travel Assistance Committee
>>>>>>
>>>>>> https://tac.apache.org - Applications now open for Community Over
>>>>>> Code 2024
>>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>>
>>>>>> --
>>>
>>> Herring BANCORP ®
>>>
>>>
>>> *C. Campbell Burgess *President/CEO
>>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>>
>>> ccb@herringbancorp.com
>>>
>>>
>>> *Herring Bancorp*
>>> 2201 Civic Circle, Suite 1000
>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g>
>>> Amarillo, TX 79109
>>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g>
>>>
>>> www.herringbank.com
>>>
>>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
>>> individual or entity to which it is addressed and may contain information
>>> that is privileged, confidential and exempt from disclosure under
>>> applicable law. If the reader of this e-mail message is not the intended
>>> recipient, or the employee or agent responsible for delivery of the message
>>> to the intended recipient, you are hereby notified that any dissemination,
>>> distribution or copying of this communication is prohibited. If you have
>>> received this e-mail in error, please notify us immediately by telephone at
>>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
Re: Docker help
Posted by CCB <cc...@herringbancorp.com>.
Sure thing.
On 5/3/2024 5:02 AM, John Otu wrote:
> Hello Campbell,
>
> Would you be able to share steps on how to get Fineract
> 1.8 deployed on docker? I've tried the instructions on Github README
> and Docker Hub and couldn't get it to work.
>
> John.
>
> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>
> Dev - Herring Bank has Fineract 1.8 running in docker at the
> moment and is readying for 1.9.
>
> We would offer our help if needed.
>
> Campbell
>
> On 5/2/2024 10:02 AM, James Dailey wrote:
>> Dev - I had a conversation IRL with Todd recently, cc'd here -
>> not on the project but willing to help out. He has offered some
>> advice for the project to get the Docker distro of Apache
>> Fineract working again. I would like to have either a push back
>> or we should restore the docker file asap.
>>
>> To recap:
>> The DockerHub Image is two years old, and the process to pull
>> from our Dev branch has been broken that entire time. It broke
>> when we removed the docker-build file with this ticket
>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>
>> With a Million downloads of fineract from DockerHUB, where that
>> version has multiple CVEs (security issues), we should not be
>> continuing to keep that there.
>>
>> So, we need to fix the docker pipeline. Credentials will be
>> required from infra.
>>
>> Todd's comments:
>>
>> Extended Summary
>>
>> The problem for the internal Fineract development pipeline is
>> that changes were made to the build process that
>> removed the expected Dockerfile
>> added an external dependency to the code repo (mifos
>> community-app web UI)
>> does not publish a public Fineract Docker image to Docker Hub
>>
>> At first glance, the lack of a Dockerfile in the code might
>> seem to be the reason that no containers have been pushed to
>> Docker Hub. A Dockerfile is the standard way of creating
>> images. This is very confusing for many people (including
>> me), however this is not the actual problem because JIB (Java
>> Image Builder) is set up to build the image during testing
>> directly from java source code by Gradle in two places:
>>
>> build-docker-postgresql.yml
>> build-docker-mariadb.yml
>>
>> The problem is that JIB does not seem to be configured to
>> actually push the container image to Docker Hub. It only
>> seems to be configured to build the image for testing.
>>
>> To solve this, two things need to be done:
>>
>> * It needs to be decided when to push the image (and
>> possibly create a new GitHub Action to do it)
>> * Code needs to be added to configure JIB to know where to
>> push the image on Docker Hub (see this example)
>> * Credentials need to be supplied to the GitHub Action to
>> allow it actually push the image
>>
>>
>> Additional Open Source Observations (Optics)
>>
>> Dockerfile
>>
>> The removal of the Dockerfile from the repo is confusing
>> (especially coupled with the existence of a
>> docker-compose.yml file) and also makes it harder for
>> potential contributors to set up and run Fineract because now
>> dependencies need to be installed locally, rather than
>> running them all in containers.
>>
>> The lack of a Dockerfile in the repository is nonstandard
>> from an Open Source perspective. Regardless of whether it is
>> needed by the Fineract build process or not, most open source
>> projects include a Dockerfile, and most open source users
>> expect one to exist in the repo so they can easily build /
>> run / test the project locally. Adding the Dockerfile back
>> to the repo should be trivial (and removes the need for JIB
>> entirely).
>>
>> General Setup
>>
>> The current Fineract process for building and running using
>> containers makes it significantly harder for developers to
>> get started with Fineract because a local Java environment
>> needs to be installed. More disappointing, a completely
>> different public set of instructions exist on Docker Hub .
>> These instructions do not work because they are out of date,
>> but are significantly easier for developers to use. Having
>> two sets of different install instructions is confusing, but
>> having the simpler set of instructions that do not work is a
>> very bad developer experience.
>>
>>
>>
>>
>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO
>> RODRIGUEZ <vi...@fintecheando.mx> wrote:
>>
>> Hello,
>>
>> Another way to have the Docker Hub image published (just
>> like Apache Tomcat):
>>
>> https://github.com/docker-library/official-images
>>
>> https://github.com/docker-library/tomcat
>>
>> Regards
>>
>>
>>
>> El dom, 18 feb 2024 a las 10:05, James Dailey
>> (<jd...@apache.org>) escribió:
>>
>> Is there an easy thing to request?
>>
>> ---------- Forwarded message ---------
>> From: *Gavin McDonald* <gm...@apache.org>
>> Date: Sun, Feb 18, 2024 at 12:24 AM
>> Subject: Re: Docker help
>> To: James Dailey <jd...@apache.org>
>> CC: Users <us...@infra.apache.org>
>>
>>
>> Hi James.
>>
>>
>>
>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey
>> <jd...@apache.org> wrote:
>>
>> Infra -
>>
>> Can you confirm that we can use other processes
>> to push to apache DockerHUB?
>>
>>
>> Current supported methods are via Github Actions or
>> Jenkins or locally via your own credentials.
>>
>> For Github Actions we can use a role account and
>> attach the secrets to your repository, or you
>> can provide your own secrets for us to add to your
>> repository
>>
>> For Jenkins we have a role account that we provide
>> access to push to your repository.
>>
>> Committers could also use a settings.xml with this
>> plugin and use their own credentials, we just need
>> to ensure they have push access to Dockerhub.
>>
>> There may also be other methods not explored.
>>
>> See also:
>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>
>> HTH
>>
>>
>> When I opened a ticket about this, I was told we
>> need a dockerfile at the root.
>>
>> Can we use "jib-maven-plugin to publish the image
>> to Dockerhub". ? Can we get credentials ?
>>
>> James
>>
>>
>> ---------- Forwarded message ---------
>> From: *Arnold Galovics* <ar...@apache.org>
>> Date: Sun, Feb 11, 2024 at 10:45 PM
>> Subject: Re: Docker help
>> To: <de...@fineract.apache.org>
>>
>>
>> James,
>>
>> This is the out-of-the box solution from
>> DockerHub which definitely won't work without a
>> Dockerfile. Though that doesn't mean it's the
>> only way to build a docker image; as I stated in
>> my previous email.
>>
>> Best,
>> Arnold
>>
>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey
>> <ja...@gmail.com> wrote:
>>
>> On DockerHUB the build fails because there is
>> no dockerfile.
>> https://hub.docker.com/r/apache/fineract
>>
>> 2024-02-08T13:12:27Z Building in Docker
>> Cloud's infrastructure...
>> 2024-02-08T13:12:28Z Cloning into '.'...
>> 2024-02-08T13:12:28Z Warning: Permanently
>> added the RSA host key for IP address
>> '140.82.114.4' to the list of known hosts.
>> 2024-02-08T13:12:48Z Reset branch 'develop'
>> 2024-02-08T13:12:48Z Your branch is up to
>> date with 'origin/develop'.
>> 2024-02-08T13:12:48Z Dockerfile not found at
>> ./Dockerfile
>>
>>
>> Let's discuss on slack and revert back here.
>>
>> My intention is to either DELETE the
>> DockerHUB repo or to get this working.
>>
>>
>>
>>
>>
>> On Sun, Feb 11, 2024 at 10:14 PM Arnold
>> Galovics <ar...@apache.org> wrote:
>>
>> Hi Zoltan, James,
>>
>> Just to reflect on your points:
>> 1) Let's not do such a radical change
>> unless we absolutely need to
>> 2) I'm not sure what's the issue
>> here, please explain. We already have
>> docker builds in our pipeline via GitHub
>> Actions (using their runners), the only
>> missing piece is to do a docker push.
>>
>> We need the credentials to be able to do
>> a docker push, alter the pipeline and
>> that's all.
>>
>> If the only thing preventing us from
>> doing this is to keep asking the infra
>> team for the creds, let's pursue them
>> instead of making such an unnecessary change.
>>
>> Arnold
>>
>> On Mon, Feb 12, 2024 at 3:30 AM James
>> Dailey <ja...@gmail.com> wrote:
>>
>> Thanks Zoltan
>>
>> Micheal - can you please comment on
>> this discussion? As this relates to
>> the Google deployment that you put in
>> place? Question!
>>
>>
>>
>>
>>
>> On Sun, Feb 11, 2024 at 6:27 PM
>> Zoltan Mezei <zo...@zz-it.hu>
>> wrote:
>>
>> Hi,
>>
>> I think the real issue here is
>> that we use
>> GoogleContainerTools's Jib as the
>> build mechanism. It works
>> entirely without a Dockerfile.
>> And unfortunately
>> Dockerhub's Automated Builds
>> doesn't support building without
>> a Dockerfile. :-(
>>
>> We have two ways to move forward:
>>
>> 1. Replace the Jib build with a
>> more traditional,
>> Dockerfile-based approach. This
>> would be a quite large change of
>> how Fineract is built and the
>> consequences need to be explored
>> - but it's definitely doable.
>> 2. Stick with the Jib build, but
>> don't rely on
>> Dockerhub's Automated Builds, but
>> some other build tools like
>> jib-maven-plugin to publish the
>> image to Dockerhub. This could
>> also work, but it requires a
>> build server that I'm not sure we
>> have.
>>
>> I can try to create a traditional
>> Dockerfile, but it will be
>> different from what Jib can
>> produce, so this might lead to
>> regressions.
>>
>> Want me to try this approach next
>> week?
>>
>> Kind regards,
>> Zoltan
>>
>>
>>
>> On Sun, Feb 11, 2024 at 8:16 AM
>> James Dailey
>> <ja...@gmail.com> wrote:
>>
>> Victor - my read of the docs
>> is that the default “build
>> rule “ points to master or
>> main but we can also use dev.
>> In fact that’s what is
>> already there in dockerHUB
>> for our project.
>>
>> I think a proper dockerfile
>> in dev branch should be fine.
>>
>> Thanks
>> James
>>
>> On Fri, Feb 9, 2024 at
>> 7:47 PM VICTOR MANUEL ROMERO
>> RODRIGUEZ
>> <vi...@fintecheando.mx>
>> wrote:
>>
>> Reading the
>> dockerhub docs, I think
>> we can do the following:
>>
>> 1. Create a master branch
>> from develop branch
>> 2. Add the Dockerfile
>> (and some scripting on it
>> for handling the
>> versions) on master branch
>> 3. Dockerhub will use the
>> dockerfile (and
>> its scripts) from the
>> master branch
>> 4. Create github action
>> for keeping in sync
>> develop with master, so
>> then it will push the
>> changes to the master
>> branch everytime the
>> develop branch has a
>> commit on it, then the
>> dockerhub will publish it
>> as the latest version.
>>
>> Or... we can be more standard
>>
>> 1. Rename develop to master
>> 2. Add a Dockerfile
>> template (and some
>> scripting on it for
>> handling the versions) on
>> master branch
>> 3. Dockerhub will use the
>> dockerfile (and
>> its scripts) from the
>> master branch
>> 4. Everytime a new commit
>> or tag is created, the
>> dockerhub will publish it
>> as the latest/specific
>> version.
>>
>> What do you think?
>>
>> Dockerhub automated
>> builds info:
>> https://docs.docker.com/docker-hub/builds
>>
>> Regards
>>
>>
>>
>> El vie, 9 feb 2024 a las
>> 20:34, James Dailey
>> (<ja...@gmail.com>)
>> escribió:
>>
>> Victor - I was trying
>> to go down that path
>> as well, as that is
>> the error thrown and
>> the suggestion at
>> DockerHUB. However,
>> to add the key to
>> the git hub requires
>> access and the git is
>> controlled by Apache
>> Infra. I asked
>> infra@a.o. about that
>> since, again, that is
>> what DockerHUB had
>> documented.
>> Unfortunately, I
>> think infra has it
>> setup a specific way
>> to allow all of the
>> projects to publish
>> to the Apache
>> DockerHUB so that
>> route would appear to
>> be blocked.
>>
>>
>>
>> On Fri, Feb 9, 2024
>> at 4:04 PM VICTOR
>> MANUEL ROMERO
>> RODRIGUEZ
>> <vi...@fintecheando.mx>
>> wrote:
>>
>> For making it
>> work without a
>> Dockerfile the
>> credentials of
>> the docker hub
>> account are
>> requiered.
>>
>> If they are set
>> in the git
>> repository, a
>> github action can
>> be enabled for
>> this task.
>>
>> Regards
>>
>> El vie., 9 de
>> febrero de 2024
>> 4:45 p. m.,
>> <ja...@gmail.com>
>> escribió:
>>
>> I've
>> re-opened
>> https://issues.apache.org/jira/browse/FINERACT-1164
>>
>>
>> This ticket
>> is to enable
>> the build at
>> DockerHUB to
>> work. For
>> the past two
>> years ++ the
>> Build has
>> failed.
>>
>> https://hub.docker.com/r/apache/fineract
>> This docker
>> account is
>> held by
>> Apache and
>> the Fineract
>> project is
>> responsible
>> for the content.
>>
>> The dockerHUB
>> has an "auto
>> build"
>> concept so
>> that every
>> committed
>> change on Dev
>> leads to a
>> new deployment.
>>
>> The build is
>> actually
>> failing or
>> not running
>> because we
>> have removed
>> the
>> dockerbuild
>> file
>> from the root.
>> That is as
>> far as I've
>> gotten. I
>> suspect we
>> had good
>> reasons for
>> that at the
>> time.
>>
>> Anyway, I
>> would also
>> say that if
>> we cannot get
>> the Docker
>> build to work
>> THEN we
>> should take
>> this down.
>> Our standard
>> is to only
>> support and
>> distribute
>> publicly the
>> last two
>> releases.
>> This build is
>> really old,
>> has unfixed
>> CVEs, and is
>> being
>> downloaded in
>> large
>> numbers. (no
>> idea why)
>>
>> Thanks
>> James
>>
>>
>>
>> --
>>
>> *Gavin McDonald -
>> *
>> Systems Administrator, ASF Infrastructure Team
>> V.P Travel Assistance Committee
>>
>> https://tac.apache.org - Applications now open for
>> Community Over Code 2024
>> in Bratislava, Slovakia. Don't delay, apply today!
>>
> --
>
> Herring BANCORP®
>
> *C. Campbell Burgess
> *President/CEO
> Office: (806) 373-3921 | Direct: (806) 242-3704
>
> ccb@herringbancorp.com
>
>
> *Herring Bancorp*
> 2201 Civic Circle, Suite 1000
> Amarillo, TX 79109
>
> www.herringbank.com <http://www.herringbank.com>
>
> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of
> the individual or entity to which it is addressed and may contain
> information that is privileged, confidential and exempt from
> disclosure under applicable law. If the reader of this e-mail
> message is not the intended recipient, or the employee or agent
> responsible for delivery of the message to the intended recipient,
> you are hereby notified that any dissemination, distribution or
> copying of this communication is prohibited. If you have received
> this e-mail in error, please notify us immediately by telephone at
> (303) 565-7001 and also indicate the sender's name. Thank you.
>
>
>
>
--
Herring BANCORP®
*C. Campbell Burgess
*President/CEO
Office: (806) 373-3921 | Direct: (806) 242-3704
ccb@herringbancorp.com
*Herring Bancorp*
2201 Civic Circle, Suite 1000
Amarillo, TX 79109
www.herringbank.com <http://www.herringbank.com>
CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
individual or entity to which it is addressed and may contain
information that is privileged, confidential and exempt from disclosure
under applicable law. If the reader of this e-mail message is not the
intended recipient, or the employee or agent responsible for delivery of
the message to the intended recipient, you are hereby notified that any
dissemination, distribution or copying of this communication is
prohibited. If you have received this e-mail in error, please notify us
immediately by telephone at (303) 565-7001 and also indicate the
sender's name. Thank you.
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
(Collins & Campbell - please start new thread)
On Wed, May 8, 2024 at 1:28 PM Collins Chuwa <co...@gmail.com> wrote:
> Hi Campbell,
>
> Please would you be able to share the steps on how to get Fineract 1.8
> deployed with Docker?
> I have tried, doing this and could not get it to work.
>
> Collins
>
> On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
>
>> Dev - Herring Bank has Fineract 1.8 running in docker at the moment and
>> is readying for 1.9.
>>
>> We would offer our help if needed.
>>
>> Campbell
>> On 5/2/2024 10:02 AM, James Dailey wrote:
>>
>> Dev - I had a conversation IRL with Todd recently, cc'd here - not on
>> the project but willing to help out. He has offered some advice for the
>> project to get the Docker distro of Apache Fineract working again. I would
>> like to have either a push back or we should restore the docker file asap.
>>
>> To recap:
>> The DockerHub Image is two years old, and the process to pull from our
>> Dev branch has been broken that entire time. It broke when we removed the
>> docker-build file with this ticket
>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>
>> With a Million downloads of fineract from DockerHUB, where that version
>> has multiple CVEs (security issues), we should not be continuing to keep
>> that there.
>>
>> So, we need to fix the docker pipeline. Credentials will be required
>> from infra.
>>
>> Todd's comments:
>>
>> Extended Summary
>>>
>>> The problem for the internal Fineract development pipeline is that
>>> changes were made to the build process that
>>> removed the expected Dockerfile
>>> added an external dependency to the code repo (mifos community-app web
>>> UI)
>>> does not publish a public Fineract Docker image to Docker Hub
>>>
>>> At first glance, the lack of a Dockerfile in the code might seem to be
>>> the reason that no containers have been pushed to Docker Hub. A Dockerfile
>>> is the standard way of creating images. This is very confusing for many
>>> people (including me), however this is not the actual problem because JIB
>>> (Java Image Builder) is set up to build the image during testing directly
>>> from java source code by Gradle in two places:
>>>
>>> build-docker-postgresql.yml
>>> build-docker-mariadb.yml
>>>
>>> The problem is that JIB does not seem to be configured to actually push
>>> the container image to Docker Hub. It only seems to be configured to build
>>> the image for testing.
>>>
>>> To solve this, two things need to be done:
>>>
>>>
>>> - It needs to be decided when to push the image (and possibly create
>>> a new GitHub Action to do it)
>>> - Code needs to be added to configure JIB to know where to push the
>>> image on Docker Hub (see this example)
>>> - Credentials need to be supplied to the GitHub Action to allow it
>>> actually push the image
>>>
>>>
>>> Additional Open Source Observations (Optics)
>>>
>>> Dockerfile
>>>
>>> The removal of the Dockerfile from the repo is confusing (especially
>>> coupled with the existence of a docker-compose.yml file) and also makes it
>>> harder for potential contributors to set up and run Fineract because now
>>> dependencies need to be installed locally, rather than running them all in
>>> containers.
>>>
>>> The lack of a Dockerfile in the repository is nonstandard from an Open
>>> Source perspective. Regardless of whether it is needed by the Fineract
>>> build process or not, most open source projects include a Dockerfile, and
>>> most open source users expect one to exist in the repo so they can easily
>>> build / run / test the project locally. Adding the Dockerfile back to the
>>> repo should be trivial (and removes the need for JIB entirely).
>>>
>>> General Setup
>>>
>>> The current Fineract process for building and running using containers
>>> makes it significantly harder for developers to get started with Fineract
>>> because a local Java environment needs to be installed. More disappointing,
>>> a completely different public set of instructions exist on Docker Hub .
>>> These instructions do not work because they are out of date, but are
>>> significantly easier for developers to use. Having two sets of different
>>> install instructions is confusing, but having the simpler set of
>>> instructions that do not work is a very bad developer experience.
>>>
>>>
>>>
>>>
>>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> Hello,
>>>>
>>>> Another way to have the Docker Hub image published (just like Apache
>>>> Tomcat):
>>>>
>>>> https://github.com/docker-library/official-images
>>>>
>>>> https://github.com/docker-library/tomcat
>>>>
>>>> Regards
>>>>
>>>>
>>>>
>>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>>>> escribió:
>>>>
>>>>> Is there an easy thing to request?
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Gavin McDonald <gm...@apache.org>
>>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>>> Subject: Re: Docker help
>>>>> To: James Dailey <jd...@apache.org>
>>>>> CC: Users <us...@infra.apache.org>
>>>>>
>>>>>
>>>>> Hi James.
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Infra -
>>>>>>
>>>>>> Can you confirm that we can use other processes to push to
>>>>>> apache DockerHUB?
>>>>>>
>>>>>
>>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>>> via your own credentials.
>>>>>
>>>>> For Github Actions we can use a role account and attach the secrets to
>>>>> your repository, or you
>>>>> can provide your own secrets for us to add to your repository
>>>>>
>>>>> For Jenkins we have a role account that we provide access to push to
>>>>> your repository.
>>>>>
>>>>> Committers could also use a settings.xml with this plugin and use
>>>>> their own credentials, we just need
>>>>> to ensure they have push access to Dockerhub.
>>>>>
>>>>> There may also be other methods not explored.
>>>>>
>>>>> See also:
>>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>>
>>>>> HTH
>>>>>
>>>>>>
>>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>>> the root.
>>>>>>
>>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>>> Can we get credentials ?
>>>>>>
>>>>>> James
>>>>>>
>>>>>>
>>>>>> ---------- Forwarded message ---------
>>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>>> Subject: Re: Docker help
>>>>>> To: <de...@fineract.apache.org>
>>>>>>
>>>>>>
>>>>>> James,
>>>>>>
>>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>>> to build a docker image; as I stated in my previous email.
>>>>>>
>>>>>> Best,
>>>>>> Arnold
>>>>>>
>>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>
>>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>>
>>>>>>>
>>>>>>> Let's discuss on slack and revert back here.
>>>>>>>
>>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>>> working.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Zoltan, James,
>>>>>>>>
>>>>>>>> Just to reflect on your points:
>>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>>
>>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>>> pipeline and that's all.
>>>>>>>>
>>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>>> unnecessary change.
>>>>>>>>
>>>>>>>> Arnold
>>>>>>>>
>>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <
>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Thanks Zoltan
>>>>>>>>>
>>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <
>>>>>>>>> zoltan.mezei@zz-it.hu> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>>
>>>>>>>>>> We have two ways to move forward:
>>>>>>>>>>
>>>>>>>>>> 1. Replace the Jib build with a more traditional,
>>>>>>>>>> Dockerfile-based approach. This would be a quite large change of how
>>>>>>>>>> Fineract is built and the consequences need to be explored - but it's
>>>>>>>>>> definitely doable.
>>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>>
>>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>>
>>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>>
>>>>>>>>>> Kind regards,
>>>>>>>>>> Zoltan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>>
>>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>> James
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>>
>>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling
>>>>>>>>>>>> the versions) on master branch
>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>> master branch
>>>>>>>>>>>> 4. Create github action for keeping in sync develop with
>>>>>>>>>>>> master, so then it will push the changes to the master branch everytime the
>>>>>>>>>>>> develop branch has a commit on it, then the dockerhub will publish it as
>>>>>>>>>>>> the latest version.
>>>>>>>>>>>>
>>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>>
>>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>>> master branch
>>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>>
>>>>>>>>>>>> What do you think?
>>>>>>>>>>>>
>>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>>
>>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of
>>>>>>>>>>>>>> the docker hub account are requiered.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work.
>>>>>>>>>>>>>>> For the past two years ++ the Build has failed.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>> *Gavin McDonald - *
>>>>> Systems Administrator, ASF Infrastructure Team
>>>>> V.P Travel Assistance Committee
>>>>>
>>>>> https://tac.apache.org - Applications now open for Community Over
>>>>> Code 2024
>>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>>
>>>>> --
>>
>> Herring BANCORP ®
>>
>>
>> *C. Campbell Burgess *President/CEO
>> Office: (806) 373-3921 | Direct: (806) 242-3704
>>
>> ccb@herringbancorp.com
>>
>>
>> *Herring Bancorp*
>> 2201 Civic Circle, Suite 1000
>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g>
>> Amarillo, TX 79109
>> <https://www.google.com/maps/search/2201+Civic+Circle,+Suite+1000+%0D%0A++++++++++++Amarillo,+TX+79109?entry=gmail&source=g>
>>
>> www.herringbank.com
>>
>> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
>> individual or entity to which it is addressed and may contain information
>> that is privileged, confidential and exempt from disclosure under
>> applicable law. If the reader of this e-mail message is not the intended
>> recipient, or the employee or agent responsible for delivery of the message
>> to the intended recipient, you are hereby notified that any dissemination,
>> distribution or copying of this communication is prohibited. If you have
>> received this e-mail in error, please notify us immediately by telephone at
>> (303) 565-7001 and also indicate the sender's name. Thank you.
>>
>>
>>
>>
>>
>>
>>
>>
>
Re: Docker help
Posted by Collins Chuwa <co...@gmail.com>.
Hi Campbell,
Please would you be able to share the steps on how to get Fineract 1.8
deployed with Docker?
I have tried, doing this and could not get it to work.
Collins
On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
> Dev - Herring Bank has Fineract 1.8 running in docker at the moment and is
> readying for 1.9.
>
> We would offer our help if needed.
>
> Campbell
> On 5/2/2024 10:02 AM, James Dailey wrote:
>
> Dev - I had a conversation IRL with Todd recently, cc'd here - not on the
> project but willing to help out. He has offered some advice for the
> project to get the Docker distro of Apache Fineract working again. I would
> like to have either a push back or we should restore the docker file asap.
>
> To recap:
> The DockerHub Image is two years old, and the process to pull from our
> Dev branch has been broken that entire time. It broke when we removed the
> docker-build file with this ticket
> https://issues.apache.org/jira/browse/FINERACT-1469.
>
> With a Million downloads of fineract from DockerHUB, where that version
> has multiple CVEs (security issues), we should not be continuing to keep
> that there.
>
> So, we need to fix the docker pipeline. Credentials will be required from
> infra.
>
> Todd's comments:
>
> Extended Summary
>>
>> The problem for the internal Fineract development pipeline is that
>> changes were made to the build process that
>> removed the expected Dockerfile
>> added an external dependency to the code repo (mifos community-app web UI)
>> does not publish a public Fineract Docker image to Docker Hub
>>
>> At first glance, the lack of a Dockerfile in the code might seem to be
>> the reason that no containers have been pushed to Docker Hub. A Dockerfile
>> is the standard way of creating images. This is very confusing for many
>> people (including me), however this is not the actual problem because JIB
>> (Java Image Builder) is set up to build the image during testing directly
>> from java source code by Gradle in two places:
>>
>> build-docker-postgresql.yml
>> build-docker-mariadb.yml
>>
>> The problem is that JIB does not seem to be configured to actually push
>> the container image to Docker Hub. It only seems to be configured to build
>> the image for testing.
>>
>> To solve this, two things need to be done:
>>
>>
>> - It needs to be decided when to push the image (and possibly create
>> a new GitHub Action to do it)
>> - Code needs to be added to configure JIB to know where to push the
>> image on Docker Hub (see this example)
>> - Credentials need to be supplied to the GitHub Action to allow it
>> actually push the image
>>
>>
>> Additional Open Source Observations (Optics)
>>
>> Dockerfile
>>
>> The removal of the Dockerfile from the repo is confusing (especially
>> coupled with the existence of a docker-compose.yml file) and also makes it
>> harder for potential contributors to set up and run Fineract because now
>> dependencies need to be installed locally, rather than running them all in
>> containers.
>>
>> The lack of a Dockerfile in the repository is nonstandard from an Open
>> Source perspective. Regardless of whether it is needed by the Fineract
>> build process or not, most open source projects include a Dockerfile, and
>> most open source users expect one to exist in the repo so they can easily
>> build / run / test the project locally. Adding the Dockerfile back to the
>> repo should be trivial (and removes the need for JIB entirely).
>>
>> General Setup
>>
>> The current Fineract process for building and running using containers
>> makes it significantly harder for developers to get started with Fineract
>> because a local Java environment needs to be installed. More disappointing,
>> a completely different public set of instructions exist on Docker Hub .
>> These instructions do not work because they are out of date, but are
>> significantly easier for developers to use. Having two sets of different
>> install instructions is confusing, but having the simpler set of
>> instructions that do not work is a very bad developer experience.
>>
>>
>>
>>
>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Hello,
>>>
>>> Another way to have the Docker Hub image published (just like Apache
>>> Tomcat):
>>>
>>> https://github.com/docker-library/official-images
>>>
>>> https://github.com/docker-library/tomcat
>>>
>>> Regards
>>>
>>>
>>>
>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>>> escribió:
>>>
>>>> Is there an easy thing to request?
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Gavin McDonald <gm...@apache.org>
>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>> Subject: Re: Docker help
>>>> To: James Dailey <jd...@apache.org>
>>>> CC: Users <us...@infra.apache.org>
>>>>
>>>>
>>>> Hi James.
>>>>
>>>>
>>>>
>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>> wrote:
>>>>
>>>>> Infra -
>>>>>
>>>>> Can you confirm that we can use other processes to push to
>>>>> apache DockerHUB?
>>>>>
>>>>
>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>> via your own credentials.
>>>>
>>>> For Github Actions we can use a role account and attach the secrets to
>>>> your repository, or you
>>>> can provide your own secrets for us to add to your repository
>>>>
>>>> For Jenkins we have a role account that we provide access to push to
>>>> your repository.
>>>>
>>>> Committers could also use a settings.xml with this plugin and use their
>>>> own credentials, we just need
>>>> to ensure they have push access to Dockerhub.
>>>>
>>>> There may also be other methods not explored.
>>>>
>>>> See also:
>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>
>>>> HTH
>>>>
>>>>>
>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>> the root.
>>>>>
>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>> Can we get credentials ?
>>>>>
>>>>> James
>>>>>
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>> Subject: Re: Docker help
>>>>> To: <de...@fineract.apache.org>
>>>>>
>>>>>
>>>>> James,
>>>>>
>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>> to build a docker image; as I stated in my previous email.
>>>>>
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>
>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>
>>>>>>
>>>>>> Let's discuss on slack and revert back here.
>>>>>>
>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>> working.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Zoltan, James,
>>>>>>>
>>>>>>> Just to reflect on your points:
>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>
>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>> pipeline and that's all.
>>>>>>>
>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>> unnecessary change.
>>>>>>>
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Thanks Zoltan
>>>>>>>>
>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>
>>>>>>>>> We have two ways to move forward:
>>>>>>>>>
>>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>
>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>
>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>
>>>>>>>>> Kind regards,
>>>>>>>>> Zoltan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>
>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> James
>>>>>>>>>>
>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>
>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>>> versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>>> version.
>>>>>>>>>>>
>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>
>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>
>>>>>>>>>>> What do you think?
>>>>>>>>>>>
>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> *Gavin McDonald - *
>>>> Systems Administrator, ASF Infrastructure Team
>>>> V.P Travel Assistance Committee
>>>>
>>>> https://tac.apache.org - Applications now open for Community Over Code
>>>> 2024
>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>
>>>> --
>
> Herring BANCORP ®
>
>
> *C. Campbell Burgess *President/CEO
> Office: (806) 373-3921 | Direct: (806) 242-3704
>
> ccb@herringbancorp.com
>
>
> *Herring Bancorp*
> 2201 Civic Circle, Suite 1000
> Amarillo, TX 79109
>
> www.herringbank.com
>
> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
> individual or entity to which it is addressed and may contain information
> that is privileged, confidential and exempt from disclosure under
> applicable law. If the reader of this e-mail message is not the intended
> recipient, or the employee or agent responsible for delivery of the message
> to the intended recipient, you are hereby notified that any dissemination,
> distribution or copying of this communication is prohibited. If you have
> received this e-mail in error, please notify us immediately by telephone at
> (303) 565-7001 and also indicate the sender's name. Thank you.
>
>
>
>
>
>
>
>
Re: Docker help
Posted by John Otu <jo...@gmail.com>.
Hello Campbell,
Would you be able to share steps on how to get Fineract 1.8 deployed on
docker? I've tried the instructions on Github README and Docker Hub and
couldn't get it to work.
John.
On Thu, May 2, 2024 at 4:45 PM CCB <cc...@herringbancorp.com> wrote:
> Dev - Herring Bank has Fineract 1.8 running in docker at the moment and is
> readying for 1.9.
>
> We would offer our help if needed.
>
> Campbell
> On 5/2/2024 10:02 AM, James Dailey wrote:
>
> Dev - I had a conversation IRL with Todd recently, cc'd here - not on the
> project but willing to help out. He has offered some advice for the
> project to get the Docker distro of Apache Fineract working again. I would
> like to have either a push back or we should restore the docker file asap.
>
> To recap:
> The DockerHub Image is two years old, and the process to pull from our
> Dev branch has been broken that entire time. It broke when we removed the
> docker-build file with this ticket
> https://issues.apache.org/jira/browse/FINERACT-1469.
>
> With a Million downloads of fineract from DockerHUB, where that version
> has multiple CVEs (security issues), we should not be continuing to keep
> that there.
>
> So, we need to fix the docker pipeline. Credentials will be required from
> infra.
>
> Todd's comments:
>
> Extended Summary
>>
>> The problem for the internal Fineract development pipeline is that
>> changes were made to the build process that
>> removed the expected Dockerfile
>> added an external dependency to the code repo (mifos community-app web UI)
>> does not publish a public Fineract Docker image to Docker Hub
>>
>> At first glance, the lack of a Dockerfile in the code might seem to be
>> the reason that no containers have been pushed to Docker Hub. A Dockerfile
>> is the standard way of creating images. This is very confusing for many
>> people (including me), however this is not the actual problem because JIB
>> (Java Image Builder) is set up to build the image during testing directly
>> from java source code by Gradle in two places:
>>
>> build-docker-postgresql.yml
>> build-docker-mariadb.yml
>>
>> The problem is that JIB does not seem to be configured to actually push
>> the container image to Docker Hub. It only seems to be configured to build
>> the image for testing.
>>
>> To solve this, two things need to be done:
>>
>>
>> - It needs to be decided when to push the image (and possibly create
>> a new GitHub Action to do it)
>> - Code needs to be added to configure JIB to know where to push the
>> image on Docker Hub (see this example)
>> - Credentials need to be supplied to the GitHub Action to allow it
>> actually push the image
>>
>>
>> Additional Open Source Observations (Optics)
>>
>> Dockerfile
>>
>> The removal of the Dockerfile from the repo is confusing (especially
>> coupled with the existence of a docker-compose.yml file) and also makes it
>> harder for potential contributors to set up and run Fineract because now
>> dependencies need to be installed locally, rather than running them all in
>> containers.
>>
>> The lack of a Dockerfile in the repository is nonstandard from an Open
>> Source perspective. Regardless of whether it is needed by the Fineract
>> build process or not, most open source projects include a Dockerfile, and
>> most open source users expect one to exist in the repo so they can easily
>> build / run / test the project locally. Adding the Dockerfile back to the
>> repo should be trivial (and removes the need for JIB entirely).
>>
>> General Setup
>>
>> The current Fineract process for building and running using containers
>> makes it significantly harder for developers to get started with Fineract
>> because a local Java environment needs to be installed. More disappointing,
>> a completely different public set of instructions exist on Docker Hub .
>> These instructions do not work because they are out of date, but are
>> significantly easier for developers to use. Having two sets of different
>> install instructions is confusing, but having the simpler set of
>> instructions that do not work is a very bad developer experience.
>>
>>
>>
>>
>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Hello,
>>>
>>> Another way to have the Docker Hub image published (just like Apache
>>> Tomcat):
>>>
>>> https://github.com/docker-library/official-images
>>>
>>> https://github.com/docker-library/tomcat
>>>
>>> Regards
>>>
>>>
>>>
>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>>> escribió:
>>>
>>>> Is there an easy thing to request?
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Gavin McDonald <gm...@apache.org>
>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>> Subject: Re: Docker help
>>>> To: James Dailey <jd...@apache.org>
>>>> CC: Users <us...@infra.apache.org>
>>>>
>>>>
>>>> Hi James.
>>>>
>>>>
>>>>
>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>> wrote:
>>>>
>>>>> Infra -
>>>>>
>>>>> Can you confirm that we can use other processes to push to
>>>>> apache DockerHUB?
>>>>>
>>>>
>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>> via your own credentials.
>>>>
>>>> For Github Actions we can use a role account and attach the secrets to
>>>> your repository, or you
>>>> can provide your own secrets for us to add to your repository
>>>>
>>>> For Jenkins we have a role account that we provide access to push to
>>>> your repository.
>>>>
>>>> Committers could also use a settings.xml with this plugin and use their
>>>> own credentials, we just need
>>>> to ensure they have push access to Dockerhub.
>>>>
>>>> There may also be other methods not explored.
>>>>
>>>> See also:
>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>
>>>> HTH
>>>>
>>>>>
>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>> the root.
>>>>>
>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>> Can we get credentials ?
>>>>>
>>>>> James
>>>>>
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>> Subject: Re: Docker help
>>>>> To: <de...@fineract.apache.org>
>>>>>
>>>>>
>>>>> James,
>>>>>
>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>> to build a docker image; as I stated in my previous email.
>>>>>
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>
>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>
>>>>>>
>>>>>> Let's discuss on slack and revert back here.
>>>>>>
>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>> working.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Zoltan, James,
>>>>>>>
>>>>>>> Just to reflect on your points:
>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>
>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>> pipeline and that's all.
>>>>>>>
>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>> unnecessary change.
>>>>>>>
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Thanks Zoltan
>>>>>>>>
>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>
>>>>>>>>> We have two ways to move forward:
>>>>>>>>>
>>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>
>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>
>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>
>>>>>>>>> Kind regards,
>>>>>>>>> Zoltan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>
>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> James
>>>>>>>>>>
>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>
>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>>> versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>>> version.
>>>>>>>>>>>
>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>
>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>
>>>>>>>>>>> What do you think?
>>>>>>>>>>>
>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> *Gavin McDonald - *
>>>> Systems Administrator, ASF Infrastructure Team
>>>> V.P Travel Assistance Committee
>>>>
>>>> https://tac.apache.org - Applications now open for Community Over Code
>>>> 2024
>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>
>>>> --
>
> Herring BANCORP ®
>
>
> *C. Campbell Burgess *President/CEO
> Office: (806) 373-3921 | Direct: (806) 242-3704
>
> ccb@herringbancorp.com
>
>
> *Herring Bancorp*
> 2201 Civic Circle, Suite 1000
> Amarillo, TX 79109
>
> www.herringbank.com
>
> CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
> individual or entity to which it is addressed and may contain information
> that is privileged, confidential and exempt from disclosure under
> applicable law. If the reader of this e-mail message is not the intended
> recipient, or the employee or agent responsible for delivery of the message
> to the intended recipient, you are hereby notified that any dissemination,
> distribution or copying of this communication is prohibited. If you have
> received this e-mail in error, please notify us immediately by telephone at
> (303) 565-7001 and also indicate the sender's name. Thank you.
>
>
>
>
>
>
>
>
Re: Docker help
Posted by CCB <cc...@herringbancorp.com>.
Dev - Herring Bank has Fineract 1.8 running in docker at the moment and
is readying for 1.9.
We would offer our help if needed.
Campbell
On 5/2/2024 10:02 AM, James Dailey wrote:
> Dev - I had a conversation IRL with Todd recently, cc'd here - not on
> the project but willing to help out. He has offered some advice for
> the project to get the Docker distro of Apache Fineract working
> again. I would like to have either a push back or we should restore
> the docker file asap.
>
> To recap:
> The DockerHub Image is two years old, and the process to pull from
> our Dev branch has been broken that entire time. It broke when we
> removed the docker-build file with this ticket
> https://issues.apache.org/jira/browse/FINERACT-1469.
>
> With a Million downloads of fineract from DockerHUB, where that
> version has multiple CVEs (security issues), we should not be
> continuing to keep that there.
>
> So, we need to fix the docker pipeline. Credentials will be required
> from infra.
>
> Todd's comments:
>
> Extended Summary
>
> The problem for the internal Fineract development pipeline is that
> changes were made to the build process that
> removed the expected Dockerfile
> added an external dependency to the code repo (mifos community-app
> web UI)
> does not publish a public Fineract Docker image to Docker Hub
>
> At first glance, the lack of a Dockerfile in the code might seem
> to be the reason that no containers have been pushed to Docker
> Hub. A Dockerfile is the standard way of creating images. This is
> very confusing for many people (including me), however this is not
> the actual problem because JIB (Java Image Builder) is set up to
> build the image during testing directly from java source code by
> Gradle in two places:
>
> build-docker-postgresql.yml
> build-docker-mariadb.yml
>
> The problem is that JIB does not seem to be configured to actually
> push the container image to Docker Hub. It only seems to be
> configured to build the image for testing.
>
> To solve this, two things need to be done:
>
> * It needs to be decided when to push the image (and possibly
> create a new GitHub Action to do it)
> * Code needs to be added to configure JIB to know where to push
> the image on Docker Hub (see this example)
> * Credentials need to be supplied to the GitHub Action to allow
> it actually push the image
>
>
> Additional Open Source Observations (Optics)
>
> Dockerfile
>
> The removal of the Dockerfile from the repo is confusing
> (especially coupled with the existence of a docker-compose.yml
> file) and also makes it harder for potential contributors to set
> up and run Fineract because now dependencies need to be installed
> locally, rather than running them all in containers.
>
> The lack of a Dockerfile in the repository is nonstandard from an
> Open Source perspective. Regardless of whether it is needed by the
> Fineract build process or not, most open source projects include a
> Dockerfile, and most open source users expect one to exist in the
> repo so they can easily build / run / test the project locally.
> Adding the Dockerfile back to the repo should be trivial (and
> removes the need for JIB entirely).
>
> General Setup
>
> The current Fineract process for building and running using
> containers makes it significantly harder for developers to get
> started with Fineract because a local Java environment needs to be
> installed. More disappointing, a completely different public set
> of instructions exist on Docker Hub . These instructions do not
> work because they are out of date, but are significantly easier
> for developers to use. Having two sets of different install
> instructions is confusing, but having the simpler set of
> instructions that do not work is a very bad developer experience.
>
>
>
>
> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ
> <vi...@fintecheando.mx> wrote:
>
> Hello,
>
> Another way to have the Docker Hub image published (just like
> Apache Tomcat):
>
> https://github.com/docker-library/official-images
>
> https://github.com/docker-library/tomcat
>
> Regards
>
>
>
> El dom, 18 feb 2024 a las 10:05, James Dailey
> (<jd...@apache.org>) escribió:
>
> Is there an easy thing to request?
>
> ---------- Forwarded message ---------
> From: *Gavin McDonald* <gm...@apache.org>
> Date: Sun, Feb 18, 2024 at 12:24 AM
> Subject: Re: Docker help
> To: James Dailey <jd...@apache.org>
> CC: Users <us...@infra.apache.org>
>
>
> Hi James.
>
>
>
> On Sun, Feb 18, 2024 at 3:00 AM James Dailey
> <jd...@apache.org> wrote:
>
> Infra -
>
> Can you confirm that we can use other processes to
> push to apache DockerHUB?
>
>
> Current supported methods are via Github Actions or
> Jenkins or locally via your own credentials.
>
> For Github Actions we can use a role account and attach
> the secrets to your repository, or you
> can provide your own secrets for us to add to your repository
>
> For Jenkins we have a role account that we provide access
> to push to your repository.
>
> Committers could also use a settings.xml with this plugin
> and use their own credentials, we just need
> to ensure they have push access to Dockerhub.
>
> There may also be other methods not explored.
>
> See also:
> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>
> HTH
>
>
> When I opened a ticket about this, I was told we need
> a dockerfile at the root.
>
> Can we use "jib-maven-plugin to publish the image to
> Dockerhub". ? Can we get credentials ?
>
> James
>
>
> ---------- Forwarded message ---------
> From: *Arnold Galovics* <ar...@apache.org>
> Date: Sun, Feb 11, 2024 at 10:45 PM
> Subject: Re: Docker help
> To: <de...@fineract.apache.org>
>
>
> James,
>
> This is the out-of-the box solution from DockerHub
> which definitely won't work without a Dockerfile.
> Though that doesn't mean it's the only way to build a
> docker image; as I stated in my previous email.
>
> Best,
> Arnold
>
> On Mon, Feb 12, 2024 at 7:43 AM James Dailey
> <ja...@gmail.com> wrote:
>
> On DockerHUB the build fails because there is no
> dockerfile. https://hub.docker.com/r/apache/fineract
>
> 2024-02-08T13:12:27Z Building in Docker Cloud's
> infrastructure...
> 2024-02-08T13:12:28Z Cloning into '.'...
> 2024-02-08T13:12:28Z Warning: Permanently added
> the RSA host key for IP address '140.82.114.4' to
> the list of known hosts.
> 2024-02-08T13:12:48Z Reset branch 'develop'
> 2024-02-08T13:12:48Z Your branch is up to date
> with 'origin/develop'.
> 2024-02-08T13:12:48Z Dockerfile not found at
> ./Dockerfile
>
>
> Let's discuss on slack and revert back here.
>
> My intention is to either DELETE the DockerHUB
> repo or to get this working.
>
>
>
>
>
> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics
> <ar...@apache.org> wrote:
>
> Hi Zoltan, James,
>
> Just to reflect on your points:
> 1) Let's not do such a radical change unless
> we absolutely need to
> 2) I'm not sure what's the issue here, please
> explain. We already have docker builds in our
> pipeline via GitHub Actions (using their
> runners), the only missing piece is to do a
> docker push.
>
> We need the credentials to be able to do a
> docker push, alter the pipeline and that's all.
>
> If the only thing preventing us from doing
> this is to keep asking the infra team for the
> creds, let's pursue them instead of making
> such an unnecessary change.
>
> Arnold
>
> On Mon, Feb 12, 2024 at 3:30 AM James Dailey
> <ja...@gmail.com> wrote:
>
> Thanks Zoltan
>
> Micheal - can you please comment on this
> discussion? As this relates to the Google
> deployment that you put in place? Question!
>
>
>
>
>
> On Sun, Feb 11, 2024 at 6:27 PM Zoltan
> Mezei <zo...@zz-it.hu> wrote:
>
> Hi,
>
> I think the real issue here is that we
> use GoogleContainerTools's Jib as the
> build mechanism. It works entirely
> without a Dockerfile. And
> unfortunately Dockerhub's Automated
> Builds doesn't support building
> without a Dockerfile. :-(
>
> We have two ways to move forward:
>
> 1. Replace the Jib build with a more
> traditional, Dockerfile-based
> approach. This would be a quite large
> change of how Fineract is built and
> the consequences need to be explored -
> but it's definitely doable.
> 2. Stick with the Jib build, but don't
> rely on Dockerhub's Automated Builds,
> but some other build tools like
> jib-maven-plugin to publish the image
> to Dockerhub. This could also work,
> but it requires a build server that
> I'm not sure we have.
>
> I can try to create a traditional
> Dockerfile, but it will be different
> from what Jib can produce, so this
> might lead to regressions.
>
> Want me to try this approach next week?
>
> Kind regards,
> Zoltan
>
>
>
> On Sun, Feb 11, 2024 at 8:16 AM James
> Dailey <ja...@gmail.com> wrote:
>
> Victor - my read of the docs is
> that the default “build rule “
> points to master or main but we
> can also use dev. In fact that’s
> what is already there in dockerHUB
> for our project.
>
> I think a proper dockerfile in dev
> branch should be fine.
>
> Thanks
> James
>
> On Fri, Feb 9, 2024 at 7:47 PM
> VICTOR MANUEL ROMERO RODRIGUEZ
> <vi...@fintecheando.mx> wrote:
>
> Reading the dockerhub docs, I
> think we can do the following:
>
> 1. Create a master branch from
> develop branch
> 2. Add the Dockerfile (and
> some scripting on it for
> handling the versions) on
> master branch
> 3. Dockerhub will use the
> dockerfile (and its scripts)
> from the master branch
> 4. Create github action for
> keeping in sync develop with
> master, so then it will push
> the changes to the master
> branch everytime the develop
> branch has a commit on it,
> then the dockerhub will
> publish it as the latest version.
>
> Or... we can be more standard
>
> 1. Rename develop to master
> 2. Add a Dockerfile template
> (and some scripting on it for
> handling the versions) on
> master branch
> 3. Dockerhub will use the
> dockerfile (and its scripts)
> from the master branch
> 4. Everytime a new commit or
> tag is created, the dockerhub
> will publish it as the
> latest/specific version.
>
> What do you think?
>
> Dockerhub automated builds
> info:
> https://docs.docker.com/docker-hub/builds
>
> Regards
>
>
>
> El vie, 9 feb 2024 a las
> 20:34, James Dailey
> (<ja...@gmail.com>)
> escribió:
>
> Victor - I was trying to
> go down that path as well,
> as that is the error
> thrown and the suggestion
> at DockerHUB. However, to
> add the key to the git
> hub requires access and
> the git is controlled by
> Apache Infra. I asked
> infra@a.o. about that
> since, again, that is what
> DockerHUB had documented.
> Unfortunately, I think
> infra has it setup a
> specific way to allow all
> of the projects to publish
> to the Apache DockerHUB so
> that route would appear to
> be blocked.
>
>
>
> On Fri, Feb 9, 2024 at
> 4:04 PM VICTOR MANUEL
> ROMERO RODRIGUEZ
> <vi...@fintecheando.mx>
> wrote:
>
> For making it work
> without a Dockerfile
> the credentials of the
> docker hub account are
> requiered.
>
> If they are set in the
> git repository, a
> github action can be
> enabled for this task.
>
> Regards
>
> El vie., 9 de febrero
> de 2024 4:45 p. m.,
> <ja...@gmail.com>
> escribió:
>
> I've re-opened
> https://issues.apache.org/jira/browse/FINERACT-1164
>
>
> This ticket is to
> enable the build
> at DockerHUB to
> work. For the
> past two years ++
> the Build has failed.
>
> https://hub.docker.com/r/apache/fineract
> This docker
> account is held by
> Apache and the
> Fineract project
> is responsible for
> the content.
>
> The dockerHUB has
> an "auto build"
> concept so that
> every committed
> change on Dev
> leads to a new
> deployment.
>
> The build is
> actually failing
> or not running
> because we
> have removed the
> dockerbuild file
> from the root.
> That is as far as
> I've gotten. I
> suspect we had
> good reasons for
> that at the time.
>
> Anyway, I would
> also say that if
> we cannot get the
> Docker build to
> work THEN we
> should take this
> down. Our standard
> is to only support
> and distribute
> publicly the last
> two releases. This
> build is really
> old, has unfixed
> CVEs, and is being
> downloaded in
> large numbers.
> (no idea why)
>
> Thanks
> James
>
>
>
> --
>
> *Gavin McDonald -
> *
> Systems Administrator, ASF Infrastructure Team
> V.P Travel Assistance Committee
>
> https://tac.apache.org - Applications now open for
> Community Over Code 2024
> in Bratislava, Slovakia. Don't delay, apply today!
>
--
Herring BANCORP®
*C. Campbell Burgess
*President/CEO
Office: (806) 373-3921 | Direct: (806) 242-3704
ccb@herringbancorp.com
*Herring Bancorp*
2201 Civic Circle, Suite 1000
Amarillo, TX 79109
www.herringbank.com <http://www.herringbank.com>
CONFIDENTIALITY NOTE: This e-mail is intended only for the use of the
individual or entity to which it is addressed and may contain
information that is privileged, confidential and exempt from disclosure
under applicable law. If the reader of this e-mail message is not the
intended recipient, or the employee or agent responsible for delivery of
the message to the intended recipient, you are hereby notified that any
dissemination, distribution or copying of this communication is
prohibited. If you have received this e-mail in error, please notify us
immediately by telephone at (303) 565-7001 and also indicate the
sender's name. Thank you.
Re: Docker help
Posted by James Dailey <jd...@apache.org>.
Dev - I had a conversation IRL with Todd recently, cc'd here - not on the
project but willing to help out. He has offered some advice for the
project to get the Docker distro of Apache Fineract working again. I would
like to have either a push back or we should restore the docker file asap.
To recap:
The DockerHub Image is two years old, and the process to pull from our Dev
branch has been broken that entire time. It broke when we removed the
docker-build file with this ticket
https://issues.apache.org/jira/browse/FINERACT-1469.
With a Million downloads of fineract from DockerHUB, where that version has
multiple CVEs (security issues), we should not be continuing to keep that
there.
So, we need to fix the docker pipeline. Credentials will be required from
infra.
Todd's comments:
Extended Summary
>
> The problem for the internal Fineract development pipeline is that changes
> were made to the build process that
> removed the expected Dockerfile
> added an external dependency to the code repo (mifos community-app web UI)
> does not publish a public Fineract Docker image to Docker Hub
>
> At first glance, the lack of a Dockerfile in the code might seem to be the
> reason that no containers have been pushed to Docker Hub. A Dockerfile is
> the standard way of creating images. This is very confusing for many people
> (including me), however this is not the actual problem because JIB (Java
> Image Builder) is set up to build the image during testing directly from
> java source code by Gradle in two places:
>
> build-docker-postgresql.yml
> build-docker-mariadb.yml
>
> The problem is that JIB does not seem to be configured to actually push
> the container image to Docker Hub. It only seems to be configured to build
> the image for testing.
>
> To solve this, two things need to be done:
>
>
> - It needs to be decided when to push the image (and possibly create a
> new GitHub Action to do it)
> - Code needs to be added to configure JIB to know where to push the
> image on Docker Hub (see this example)
> - Credentials need to be supplied to the GitHub Action to allow it
> actually push the image
>
>
> Additional Open Source Observations (Optics)
>
> Dockerfile
>
> The removal of the Dockerfile from the repo is confusing (especially
> coupled with the existence of a docker-compose.yml file) and also makes it
> harder for potential contributors to set up and run Fineract because now
> dependencies need to be installed locally, rather than running them all in
> containers.
>
> The lack of a Dockerfile in the repository is nonstandard from an Open
> Source perspective. Regardless of whether it is needed by the Fineract
> build process or not, most open source projects include a Dockerfile, and
> most open source users expect one to exist in the repo so they can easily
> build / run / test the project locally. Adding the Dockerfile back to the
> repo should be trivial (and removes the need for JIB entirely).
>
> General Setup
>
> The current Fineract process for building and running using containers
> makes it significantly harder for developers to get started with Fineract
> because a local Java environment needs to be installed. More disappointing,
> a completely different public set of instructions exist on Docker Hub .
> These instructions do not work because they are out of date, but are
> significantly easier for developers to use. Having two sets of different
> install instructions is confusing, but having the simpler set of
> instructions that do not work is a very bad developer experience.
>
>
>
>
> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> Hello,
>>
>> Another way to have the Docker Hub image published (just like Apache
>> Tomcat):
>>
>> https://github.com/docker-library/official-images
>>
>> https://github.com/docker-library/tomcat
>>
>> Regards
>>
>>
>>
>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>> escribió:
>>
>>> Is there an easy thing to request?
>>>
>>> ---------- Forwarded message ---------
>>> From: Gavin McDonald <gm...@apache.org>
>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>> Subject: Re: Docker help
>>> To: James Dailey <jd...@apache.org>
>>> CC: Users <us...@infra.apache.org>
>>>
>>>
>>> Hi James.
>>>
>>>
>>>
>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org> wrote:
>>>
>>>> Infra -
>>>>
>>>> Can you confirm that we can use other processes to push to
>>>> apache DockerHUB?
>>>>
>>>
>>> Current supported methods are via Github Actions or Jenkins or locally
>>> via your own credentials.
>>>
>>> For Github Actions we can use a role account and attach the secrets to
>>> your repository, or you
>>> can provide your own secrets for us to add to your repository
>>>
>>> For Jenkins we have a role account that we provide access to push to
>>> your repository.
>>>
>>> Committers could also use a settings.xml with this plugin and use their
>>> own credentials, we just need
>>> to ensure they have push access to Dockerhub.
>>>
>>> There may also be other methods not explored.
>>>
>>> See also:
>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>
>>> HTH
>>>
>>>>
>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>> the root.
>>>>
>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>> Can we get credentials ?
>>>>
>>>> James
>>>>
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Arnold Galovics <ar...@apache.org>
>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>> Subject: Re: Docker help
>>>> To: <de...@fineract.apache.org>
>>>>
>>>>
>>>> James,
>>>>
>>>> This is the out-of-the box solution from DockerHub which definitely
>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>> to build a docker image; as I stated in my previous email.
>>>>
>>>> Best,
>>>> Arnold
>>>>
>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>> wrote:
>>>>
>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>> https://hub.docker.com/r/apache/fineract
>>>>>
>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>
>>>>>
>>>>> Let's discuss on slack and revert back here.
>>>>>
>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>> working.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Hi Zoltan, James,
>>>>>>
>>>>>> Just to reflect on your points:
>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>
>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>> pipeline and that's all.
>>>>>>
>>>>>> If the only thing preventing us from doing this is to keep asking the
>>>>>> infra team for the creds, let's pursue them instead of making such an
>>>>>> unnecessary change.
>>>>>>
>>>>>> Arnold
>>>>>>
>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Thanks Zoltan
>>>>>>>
>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>> a Dockerfile. :-(
>>>>>>>>
>>>>>>>> We have two ways to move forward:
>>>>>>>>
>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>
>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>
>>>>>>>> Want me to try this approach next week?
>>>>>>>>
>>>>>>>> Kind regards,
>>>>>>>> Zoltan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>
>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>> James
>>>>>>>>>
>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>
>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>
>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>> versions) on master branch
>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>> master branch
>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>> version.
>>>>>>>>>>
>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>
>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>> master branch
>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>
>>>>>>>>>> What do you think?
>>>>>>>>>>
>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>
>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>
>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>>
>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>
>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>
>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>> This docker account is held by Apache and the Fineract project
>>>>>>>>>>>>> is responsible for the content.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>> why)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>> James
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>
>>> --
>>>
>>>
>>> *Gavin McDonald - *
>>> Systems Administrator, ASF Infrastructure Team
>>> V.P Travel Assistance Committee
>>>
>>> https://tac.apache.org - Applications now open for Community Over Code
>>> 2024
>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>
>>>
Re: Docker help
Posted by Arnold Galovics <ar...@apache.org>.
Hi Victor,
Thanks for raising the PR.
I'm not confident this is the way we should do it. This Dockerfile doesn't
exactly do the same thing as the JIB plugin for Gradle hence there could be
differences between the resulting image depending on which way it was built.
If we want a Dockerfile, I'd advise dropping the JIB plugin entirely
although I think in 2024 there should be a way to use the plugin properly
for publishing to Dockerhub even if it means some changes to the current
Apache infrastructure setup.
Best,
Arnold
On Fri, May 3, 2024 at 10:00 AM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> Hello,
>
> My 2 cents https://github.com/apache/fineract/pull/3879
>
> Please let me know your thoughts.
>
> Regards
>
> Victor
>
>
> El jue, 25 abr 2024 a las 12:28, James Dailey (<jd...@apache.org>)
> escribió:
>
>> Hi All -
>>
>> I'd like to resurface this issue. The DockerHub Image is two years old,
>> and the process to pull from our Dev branch is broken. It broke when we
>> removed the docker-build file with this ticket
>> https://issues.apache.org/jira/browse/FINERACT-1469.
>>
>> With a Million downloads of fineract from DockerHUB and of a version that
>> has multiple CVEs and security issues, we should not be continuing to keep
>> that there.
>>
>> So, we need to fix the docker pipeline. Here are some comments from
>> Todd who is not on the project but has agreed to help figure out what is
>> wrong with our setup.
>>
>> TL;DR
>> Credentials will be needed to push images to Docker Hub.
>> We should re-create the docker-build file.
>>
>> Extended Summary
>>
>> The problem for the internal Fineract development pipeline is that
>> changes were made to the build process that
>>
>> removed the expected Dockerfile
>> added an external dependency to the code repo (mifos community-app web UI)
>> does not publish a public Fineract Docker image to Docker Hub
>>
>> At first glance, the lack of a Dockerfile in the code might seem to be
>> the reason that no containers have been pushed to Docker Hub. A Dockerfile
>> is the standard way of creating images. This is very confusing for many
>> people (including me), however this is not the actual problem because JIB
>> (Java Image Builder) is set up to build the image during testing directly
>> from java source code by Gradle in two places:
>>
>> build-docker-postgresql.yml
>> build-docker-mariadb.yml
>>
>> The problem is that JIB does not seem to be configured to actually push
>> the container image to Docker Hub. It only seems to be configured to build
>> the image for testing.
>>
>> To solve this, two things need to be done:
>>
>>
>> - It needs to be decided when to push the image (and possibly create
>> a new GitHub Action to do it)
>> - Code needs to be added to configure JIB to know where to push the
>> image on Docker Hub (see this example)
>> - Credentials need to be supplied to the GitHub Action to allow it
>> actually push the image
>>
>>
>> Additional Open Source Observations (Optics)
>>
>> Dockerfile
>>
>> The removal of the Dockerfile from the repo is confusing (especially
>> coupled with the existence of a docker-compose.yml file) and also makes it
>> harder for potential contributors to set up and run Fineract because now
>> dependencies need to be installed locally, rather than running them all in
>> containers.
>>
>> The lack of a Dockerfile in the repository is nonstandard from an Open
>> Source perspective. Regardless of whether it is needed by the Fineract
>> build process or not, most open source projects include a Dockerfile, and
>> most open source users expect one to exist in the repo so they can easily
>> build / run / test the project locally. Adding the Dockerfile back to the
>> repo should be trivial (and removes the need for JIB entirely).
>>
>> General Setup
>>
>> The current Fineract process for building and running using containers
>> makes it significantly harder for developers to get started with Fineract
>> because a local Java environment needs to be installed. More disappointing,
>> a completely different public set of instructions exist on Docker Hub .
>> These instructions do not work because they are out of date, but are
>> significantly easier for developers to use. Having two sets of different
>> install instructions is confusing, but having the simpler set of
>> instructions that do not work is a very bad developer experience.
>>
>>
>>
>>
>> On Sun, Feb 18, 2024 at 8:46 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Hello,
>>>
>>> Another way to have the Docker Hub image published (just like Apache
>>> Tomcat):
>>>
>>> https://github.com/docker-library/official-images
>>>
>>> https://github.com/docker-library/tomcat
>>>
>>> Regards
>>>
>>>
>>>
>>> El dom, 18 feb 2024 a las 10:05, James Dailey (<jd...@apache.org>)
>>> escribió:
>>>
>>>> Is there an easy thing to request?
>>>>
>>>> ---------- Forwarded message ---------
>>>> From: Gavin McDonald <gm...@apache.org>
>>>> Date: Sun, Feb 18, 2024 at 12:24 AM
>>>> Subject: Re: Docker help
>>>> To: James Dailey <jd...@apache.org>
>>>> CC: Users <us...@infra.apache.org>
>>>>
>>>>
>>>> Hi James.
>>>>
>>>>
>>>>
>>>> On Sun, Feb 18, 2024 at 3:00 AM James Dailey <jd...@apache.org>
>>>> wrote:
>>>>
>>>>> Infra -
>>>>>
>>>>> Can you confirm that we can use other processes to push to
>>>>> apache DockerHUB?
>>>>>
>>>>
>>>> Current supported methods are via Github Actions or Jenkins or locally
>>>> via your own credentials.
>>>>
>>>> For Github Actions we can use a role account and attach the secrets to
>>>> your repository, or you
>>>> can provide your own secrets for us to add to your repository
>>>>
>>>> For Jenkins we have a role account that we provide access to push to
>>>> your repository.
>>>>
>>>> Committers could also use a settings.xml with this plugin and use their
>>>> own credentials, we just need
>>>> to ensure they have push access to Dockerhub.
>>>>
>>>> There may also be other methods not explored.
>>>>
>>>> See also:
>>>> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#authentication-methods
>>>>
>>>> HTH
>>>>
>>>>>
>>>>> When I opened a ticket about this, I was told we need a dockerfile at
>>>>> the root.
>>>>>
>>>>> Can we use "jib-maven-plugin to publish the image to Dockerhub". ?
>>>>> Can we get credentials ?
>>>>>
>>>>> James
>>>>>
>>>>>
>>>>> ---------- Forwarded message ---------
>>>>> From: Arnold Galovics <ar...@apache.org>
>>>>> Date: Sun, Feb 11, 2024 at 10:45 PM
>>>>> Subject: Re: Docker help
>>>>> To: <de...@fineract.apache.org>
>>>>>
>>>>>
>>>>> James,
>>>>>
>>>>> This is the out-of-the box solution from DockerHub which definitely
>>>>> won't work without a Dockerfile. Though that doesn't mean it's the only way
>>>>> to build a docker image; as I stated in my previous email.
>>>>>
>>>>> Best,
>>>>> Arnold
>>>>>
>>>>> On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> On DockerHUB the build fails because there is no dockerfile.
>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>
>>>>>> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
>>>>>> 2024-02-08T13:12:28Z Cloning into '.'...
>>>>>> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for
>>>>>> IP address '140.82.114.4' to the list of known hosts.
>>>>>> 2024-02-08T13:12:48Z Reset branch 'develop'
>>>>>> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
>>>>>> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>>>>>>
>>>>>>
>>>>>> Let's discuss on slack and revert back here.
>>>>>>
>>>>>> My intention is to either DELETE the DockerHUB repo or to get this
>>>>>> working.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Zoltan, James,
>>>>>>>
>>>>>>> Just to reflect on your points:
>>>>>>> 1) Let's not do such a radical change unless we absolutely need to
>>>>>>> 2) I'm not sure what's the issue here, please explain. We already
>>>>>>> have docker builds in our pipeline via GitHub Actions (using their
>>>>>>> runners), the only missing piece is to do a docker push.
>>>>>>>
>>>>>>> We need the credentials to be able to do a docker push, alter the
>>>>>>> pipeline and that's all.
>>>>>>>
>>>>>>> If the only thing preventing us from doing this is to keep asking
>>>>>>> the infra team for the creds, let's pursue them instead of making such an
>>>>>>> unnecessary change.
>>>>>>>
>>>>>>> Arnold
>>>>>>>
>>>>>>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Thanks Zoltan
>>>>>>>>
>>>>>>>> Micheal - can you please comment on this discussion? As this
>>>>>>>> relates to the Google deployment that you put in place? Question!
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I think the real issue here is that we use GoogleContainerTools's
>>>>>>>>> Jib as the build mechanism. It works entirely without a Dockerfile. And
>>>>>>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>>>>>>> a Dockerfile. :-(
>>>>>>>>>
>>>>>>>>> We have two ways to move forward:
>>>>>>>>>
>>>>>>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>>>>>>> approach. This would be a quite large change of how Fineract is built and
>>>>>>>>> the consequences need to be explored - but it's definitely doable.
>>>>>>>>> 2. Stick with the Jib build, but don't rely on
>>>>>>>>> Dockerhub's Automated Builds, but some other build tools like
>>>>>>>>> jib-maven-plugin to publish the image to Dockerhub. This could also work,
>>>>>>>>> but it requires a build server that I'm not sure we have.
>>>>>>>>>
>>>>>>>>> I can try to create a traditional Dockerfile, but it will be
>>>>>>>>> different from what Jib can produce, so this might lead to regressions.
>>>>>>>>>
>>>>>>>>> Want me to try this approach next week?
>>>>>>>>>
>>>>>>>>> Kind regards,
>>>>>>>>> Zoltan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <
>>>>>>>>> jamespdailey@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Victor - my read of the docs is that the default “build rule “
>>>>>>>>>> points to master or main but we can also use dev. In fact that’s what is
>>>>>>>>>> already there in dockerHUB for our project.
>>>>>>>>>>
>>>>>>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> James
>>>>>>>>>>
>>>>>>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>>>>>>
>>>>>>>>>>> 1. Create a master branch from develop branch
>>>>>>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>>>>>>> versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Create github action for keeping in sync develop with master,
>>>>>>>>>>> so then it will push the changes to the master branch everytime the develop
>>>>>>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>>>>>>> version.
>>>>>>>>>>>
>>>>>>>>>>> Or... we can be more standard
>>>>>>>>>>>
>>>>>>>>>>> 1. Rename develop to master
>>>>>>>>>>> 2. Add a Dockerfile template (and some scripting on it for
>>>>>>>>>>> handling the versions) on master branch
>>>>>>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>>>>>>> master branch
>>>>>>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>>>>>>> publish it as the latest/specific version.
>>>>>>>>>>>
>>>>>>>>>>> What do you think?
>>>>>>>>>>>
>>>>>>>>>>> Dockerhub automated builds info:
>>>>>>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<
>>>>>>>>>>> jamespdailey@gmail.com>) escribió:
>>>>>>>>>>>
>>>>>>>>>>>> Victor - I was trying to go down that path as well, as that is
>>>>>>>>>>>> the error thrown and the suggestion at DockerHUB. However, to add the key
>>>>>>>>>>>> to the git hub requires access and the git is controlled by Apache Infra.
>>>>>>>>>>>> I asked infra@a.o. about that since, again, that is what
>>>>>>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>>>>>>> docker hub account are requiered.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>>>>>>> enabled for this task.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>
>>>>>>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., <
>>>>>>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I've re-opened
>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For
>>>>>>>>>>>>>> the past two years ++ the Build has failed.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>>>>>>> This docker account is held by Apache and the Fineract
>>>>>>>>>>>>>> project is responsible for the content.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The dockerHUB has an "auto build" concept so that every
>>>>>>>>>>>>>> committed change on Dev leads to a new deployment.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Anyway, I would also say that if we cannot get the Docker
>>>>>>>>>>>>>> build to work THEN we should take this down. Our standard is to only
>>>>>>>>>>>>>> support and distribute publicly the last two releases. This build is really
>>>>>>>>>>>>>> old, has unfixed CVEs, and is being downloaded in large numbers. (no idea
>>>>>>>>>>>>>> why)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> James
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> *Gavin McDonald - *
>>>> Systems Administrator, ASF Infrastructure Team
>>>> V.P Travel Assistance Committee
>>>>
>>>> https://tac.apache.org - Applications now open for Community Over Code
>>>> 2024
>>>> in Bratislava, Slovakia. Don't delay, apply today!
>>>>
>>>>
Re: Docker help
Posted by Arnold Galovics <ar...@apache.org>.
James,
This is the out-of-the box solution from DockerHub which definitely won't
work without a Dockerfile. Though that doesn't mean it's the only way to
build a docker image; as I stated in my previous email.
Best,
Arnold
On Mon, Feb 12, 2024 at 7:43 AM James Dailey <ja...@gmail.com> wrote:
> On DockerHUB the build fails because there is no dockerfile.
> https://hub.docker.com/r/apache/fineract
>
> 2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
> 2024-02-08T13:12:28Z Cloning into '.'...
> 2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for IP
> address '140.82.114.4' to the list of known hosts.
> 2024-02-08T13:12:48Z Reset branch 'develop'
> 2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
> 2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
>
>
> Let's discuss on slack and revert back here.
>
> My intention is to either DELETE the DockerHUB repo or to get this
> working.
>
>
>
>
>
> On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org>
> wrote:
>
>> Hi Zoltan, James,
>>
>> Just to reflect on your points:
>> 1) Let's not do such a radical change unless we absolutely need to
>> 2) I'm not sure what's the issue here, please explain. We already have
>> docker builds in our pipeline via GitHub Actions (using their runners), the
>> only missing piece is to do a docker push.
>>
>> We need the credentials to be able to do a docker push, alter the
>> pipeline and that's all.
>>
>> If the only thing preventing us from doing this is to keep asking the
>> infra team for the creds, let's pursue them instead of making such an
>> unnecessary change.
>>
>> Arnold
>>
>> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
>> wrote:
>>
>>> Thanks Zoltan
>>>
>>> Micheal - can you please comment on this discussion? As this relates to
>>> the Google deployment that you put in place? Question!
>>>
>>>
>>>
>>>
>>>
>>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I think the real issue here is that we use GoogleContainerTools's Jib
>>>> as the build mechanism. It works entirely without a Dockerfile. And
>>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>>> a Dockerfile. :-(
>>>>
>>>> We have two ways to move forward:
>>>>
>>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>>> approach. This would be a quite large change of how Fineract is built and
>>>> the consequences need to be explored - but it's definitely doable.
>>>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>>>> Builds, but some other build tools like jib-maven-plugin to publish the
>>>> image to Dockerhub. This could also work, but it requires a build server
>>>> that I'm not sure we have.
>>>>
>>>> I can try to create a traditional Dockerfile, but it will be different
>>>> from what Jib can produce, so this might lead to regressions.
>>>>
>>>> Want me to try this approach next week?
>>>>
>>>> Kind regards,
>>>> Zoltan
>>>>
>>>>
>>>>
>>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>>>> wrote:
>>>>
>>>>> Victor - my read of the docs is that the default “build rule “ points
>>>>> to master or main but we can also use dev. In fact that’s what is already
>>>>> there in dockerHUB for our project.
>>>>>
>>>>> I think a proper dockerfile in dev branch should be fine.
>>>>>
>>>>> Thanks
>>>>> James
>>>>>
>>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>
>>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>>
>>>>>> 1. Create a master branch from develop branch
>>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>>> versions) on master branch
>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>> master branch
>>>>>> 4. Create github action for keeping in sync develop with master, so
>>>>>> then it will push the changes to the master branch everytime the develop
>>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>>> version.
>>>>>>
>>>>>> Or... we can be more standard
>>>>>>
>>>>>> 1. Rename develop to master
>>>>>> 2. Add a Dockerfile template (and some scripting on it for handling
>>>>>> the versions) on master branch
>>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the
>>>>>> master branch
>>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>>> publish it as the latest/specific version.
>>>>>>
>>>>>> What do you think?
>>>>>>
>>>>>> Dockerhub automated builds info:
>>>>>> https://docs.docker.com/docker-hub/builds
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>>
>>>>>>
>>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
>>>>>> escribió:
>>>>>>
>>>>>>> Victor - I was trying to go down that path as well, as that is the
>>>>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>>>>> asked infra@a.o. about that since, again, that is what
>>>>>>> DockerHUB had documented. Unfortunately, I think infra has it setup a
>>>>>>> specific way to allow all of the projects to publish to the Apache
>>>>>>> DockerHUB so that route would appear to be blocked.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>>
>>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>>> docker hub account are requiered.
>>>>>>>>
>>>>>>>> If they are set in the git repository, a github action can be
>>>>>>>> enabled for this task.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>>
>>>>>>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>>
>>>>>>>>> This ticket is to enable the build at DockerHUB to work. For the
>>>>>>>>> past two years ++ the Build has failed.
>>>>>>>>>
>>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>>> This docker account is held by Apache and the Fineract project is
>>>>>>>>> responsible for the content.
>>>>>>>>>
>>>>>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>>>>>> change on Dev leads to a new deployment.
>>>>>>>>>
>>>>>>>>> The build is actually failing or not running because we
>>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>>
>>>>>>>>> Anyway, I would also say that if we cannot get the Docker build to
>>>>>>>>> work THEN we should take this down. Our standard is to only support and
>>>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>> James
>>>>>>>>>
>>>>>>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
On DockerHUB the build fails because there is no dockerfile.
https://hub.docker.com/r/apache/fineract
2024-02-08T13:12:27Z Building in Docker Cloud's infrastructure...
2024-02-08T13:12:28Z Cloning into '.'...
2024-02-08T13:12:28Z Warning: Permanently added the RSA host key for IP
address '140.82.114.4' to the list of known hosts.
2024-02-08T13:12:48Z Reset branch 'develop'
2024-02-08T13:12:48Z Your branch is up to date with 'origin/develop'.
2024-02-08T13:12:48Z Dockerfile not found at ./Dockerfile
Let's discuss on slack and revert back here.
My intention is to either DELETE the DockerHUB repo or to get this working.
On Sun, Feb 11, 2024 at 10:14 PM Arnold Galovics <ar...@apache.org> wrote:
> Hi Zoltan, James,
>
> Just to reflect on your points:
> 1) Let's not do such a radical change unless we absolutely need to
> 2) I'm not sure what's the issue here, please explain. We already have
> docker builds in our pipeline via GitHub Actions (using their runners), the
> only missing piece is to do a docker push.
>
> We need the credentials to be able to do a docker push, alter the pipeline
> and that's all.
>
> If the only thing preventing us from doing this is to keep asking the
> infra team for the creds, let's pursue them instead of making such an
> unnecessary change.
>
> Arnold
>
> On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com>
> wrote:
>
>> Thanks Zoltan
>>
>> Micheal - can you please comment on this discussion? As this relates to
>> the Google deployment that you put in place? Question!
>>
>>
>>
>>
>>
>> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
>> wrote:
>>
>>> Hi,
>>>
>>> I think the real issue here is that we use GoogleContainerTools's Jib as
>>> the build mechanism. It works entirely without a Dockerfile. And
>>> unfortunately Dockerhub's Automated Builds doesn't support building without
>>> a Dockerfile. :-(
>>>
>>> We have two ways to move forward:
>>>
>>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>>> approach. This would be a quite large change of how Fineract is built and
>>> the consequences need to be explored - but it's definitely doable.
>>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>>> Builds, but some other build tools like jib-maven-plugin to publish the
>>> image to Dockerhub. This could also work, but it requires a build server
>>> that I'm not sure we have.
>>>
>>> I can try to create a traditional Dockerfile, but it will be different
>>> from what Jib can produce, so this might lead to regressions.
>>>
>>> Want me to try this approach next week?
>>>
>>> Kind regards,
>>> Zoltan
>>>
>>>
>>>
>>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>>> wrote:
>>>
>>>> Victor - my read of the docs is that the default “build rule “ points
>>>> to master or main but we can also use dev. In fact that’s what is already
>>>> there in dockerHUB for our project.
>>>>
>>>> I think a proper dockerfile in dev branch should be fine.
>>>>
>>>> Thanks
>>>> James
>>>>
>>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> victor.romero@fintecheando.mx> wrote:
>>>>
>>>>> Reading the dockerhub docs, I think we can do the following:
>>>>>
>>>>> 1. Create a master branch from develop branch
>>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>>> versions) on master branch
>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>>>> branch
>>>>> 4. Create github action for keeping in sync develop with master, so
>>>>> then it will push the changes to the master branch everytime the develop
>>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>>> version.
>>>>>
>>>>> Or... we can be more standard
>>>>>
>>>>> 1. Rename develop to master
>>>>> 2. Add a Dockerfile template (and some scripting on it for handling
>>>>> the versions) on master branch
>>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>>>> branch
>>>>> 4. Everytime a new commit or tag is created, the dockerhub will
>>>>> publish it as the latest/specific version.
>>>>>
>>>>> What do you think?
>>>>>
>>>>> Dockerhub automated builds info:
>>>>> https://docs.docker.com/docker-hub/builds
>>>>>
>>>>> Regards
>>>>>
>>>>>
>>>>>
>>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
>>>>> escribió:
>>>>>
>>>>>> Victor - I was trying to go down that path as well, as that is the
>>>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>>>> asked infra@a.o. about that since, again, that is what DockerHUB had
>>>>>> documented. Unfortunately, I think infra has it setup a specific way to
>>>>>> allow all of the projects to publish to the Apache DockerHUB so that route
>>>>>> would appear to be blocked.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>>
>>>>>>> For making it work without a Dockerfile the credentials of the
>>>>>>> docker hub account are requiered.
>>>>>>>
>>>>>>> If they are set in the git repository, a github action can be
>>>>>>> enabled for this task.
>>>>>>>
>>>>>>> Regards
>>>>>>>
>>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>>
>>>>>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>>
>>>>>>>> This ticket is to enable the build at DockerHUB to work. For the
>>>>>>>> past two years ++ the Build has failed.
>>>>>>>>
>>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>>> This docker account is held by Apache and the Fineract project is
>>>>>>>> responsible for the content.
>>>>>>>>
>>>>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>>>>> change on Dev leads to a new deployment.
>>>>>>>>
>>>>>>>> The build is actually failing or not running because we
>>>>>>>> have removed the dockerbuild file from the root. That is as far as I've
>>>>>>>> gotten. I suspect we had good reasons for that at the time.
>>>>>>>>
>>>>>>>> Anyway, I would also say that if we cannot get the Docker build to
>>>>>>>> work THEN we should take this down. Our standard is to only support and
>>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>> James
>>>>>>>>
>>>>>>>
Re: Docker help
Posted by Arnold Galovics <ar...@apache.org>.
Hi Zoltan, James,
Just to reflect on your points:
1) Let's not do such a radical change unless we absolutely need to
2) I'm not sure what's the issue here, please explain. We already have
docker builds in our pipeline via GitHub Actions (using their runners), the
only missing piece is to do a docker push.
We need the credentials to be able to do a docker push, alter the pipeline
and that's all.
If the only thing preventing us from doing this is to keep asking the infra
team for the creds, let's pursue them instead of making such an unnecessary
change.
Arnold
On Mon, Feb 12, 2024 at 3:30 AM James Dailey <ja...@gmail.com> wrote:
> Thanks Zoltan
>
> Micheal - can you please comment on this discussion? As this relates to
> the Google deployment that you put in place? Question!
>
>
>
>
>
> On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu>
> wrote:
>
>> Hi,
>>
>> I think the real issue here is that we use GoogleContainerTools's Jib as
>> the build mechanism. It works entirely without a Dockerfile. And
>> unfortunately Dockerhub's Automated Builds doesn't support building without
>> a Dockerfile. :-(
>>
>> We have two ways to move forward:
>>
>> 1. Replace the Jib build with a more traditional, Dockerfile-based
>> approach. This would be a quite large change of how Fineract is built and
>> the consequences need to be explored - but it's definitely doable.
>> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
>> Builds, but some other build tools like jib-maven-plugin to publish the
>> image to Dockerhub. This could also work, but it requires a build server
>> that I'm not sure we have.
>>
>> I can try to create a traditional Dockerfile, but it will be different
>> from what Jib can produce, so this might lead to regressions.
>>
>> Want me to try this approach next week?
>>
>> Kind regards,
>> Zoltan
>>
>>
>>
>> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
>> wrote:
>>
>>> Victor - my read of the docs is that the default “build rule “ points to
>>> master or main but we can also use dev. In fact that’s what is already
>>> there in dockerHUB for our project.
>>>
>>> I think a proper dockerfile in dev branch should be fine.
>>>
>>> Thanks
>>> James
>>>
>>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> Reading the dockerhub docs, I think we can do the following:
>>>>
>>>> 1. Create a master branch from develop branch
>>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>>> versions) on master branch
>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>>> branch
>>>> 4. Create github action for keeping in sync develop with master, so
>>>> then it will push the changes to the master branch everytime the develop
>>>> branch has a commit on it, then the dockerhub will publish it as the latest
>>>> version.
>>>>
>>>> Or... we can be more standard
>>>>
>>>> 1. Rename develop to master
>>>> 2. Add a Dockerfile template (and some scripting on it for handling the
>>>> versions) on master branch
>>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>>> branch
>>>> 4. Everytime a new commit or tag is created, the dockerhub will publish
>>>> it as the latest/specific version.
>>>>
>>>> What do you think?
>>>>
>>>> Dockerhub automated builds info:
>>>> https://docs.docker.com/docker-hub/builds
>>>>
>>>> Regards
>>>>
>>>>
>>>>
>>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
>>>> escribió:
>>>>
>>>>> Victor - I was trying to go down that path as well, as that is the
>>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>>> asked infra@a.o. about that since, again, that is what DockerHUB had
>>>>> documented. Unfortunately, I think infra has it setup a specific way to
>>>>> allow all of the projects to publish to the Apache DockerHUB so that route
>>>>> would appear to be blocked.
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>>> victor.romero@fintecheando.mx> wrote:
>>>>>
>>>>>> For making it work without a Dockerfile the credentials of the docker
>>>>>> hub account are requiered.
>>>>>>
>>>>>> If they are set in the git repository, a github action can be enabled
>>>>>> for this task.
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>>>>> jamespdailey@gmail.com> escribió:
>>>>>>
>>>>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>>
>>>>>>> This ticket is to enable the build at DockerHUB to work. For the
>>>>>>> past two years ++ the Build has failed.
>>>>>>>
>>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>>> This docker account is held by Apache and the Fineract project is
>>>>>>> responsible for the content.
>>>>>>>
>>>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>>>> change on Dev leads to a new deployment.
>>>>>>>
>>>>>>> The build is actually failing or not running because we have removed
>>>>>>> the dockerbuild file from the root. That is as far as I've gotten. I
>>>>>>> suspect we had good reasons for that at the time.
>>>>>>>
>>>>>>> Anyway, I would also say that if we cannot get the Docker build to
>>>>>>> work THEN we should take this down. Our standard is to only support and
>>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>>
>>>>>>> Thanks
>>>>>>> James
>>>>>>>
>>>>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Thanks Zoltan
Micheal - can you please comment on this discussion? As this relates to
the Google deployment that you put in place? Question!
On Sun, Feb 11, 2024 at 6:27 PM Zoltan Mezei <zo...@zz-it.hu> wrote:
> Hi,
>
> I think the real issue here is that we use GoogleContainerTools's Jib as
> the build mechanism. It works entirely without a Dockerfile. And
> unfortunately Dockerhub's Automated Builds doesn't support building without
> a Dockerfile. :-(
>
> We have two ways to move forward:
>
> 1. Replace the Jib build with a more traditional, Dockerfile-based
> approach. This would be a quite large change of how Fineract is built and
> the consequences need to be explored - but it's definitely doable.
> 2. Stick with the Jib build, but don't rely on Dockerhub's Automated
> Builds, but some other build tools like jib-maven-plugin to publish the
> image to Dockerhub. This could also work, but it requires a build server
> that I'm not sure we have.
>
> I can try to create a traditional Dockerfile, but it will be different
> from what Jib can produce, so this might lead to regressions.
>
> Want me to try this approach next week?
>
> Kind regards,
> Zoltan
>
>
>
> On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com>
> wrote:
>
>> Victor - my read of the docs is that the default “build rule “ points to
>> master or main but we can also use dev. In fact that’s what is already
>> there in dockerHUB for our project.
>>
>> I think a proper dockerfile in dev branch should be fine.
>>
>> Thanks
>> James
>>
>> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> Reading the dockerhub docs, I think we can do the following:
>>>
>>> 1. Create a master branch from develop branch
>>> 2. Add the Dockerfile (and some scripting on it for handling the
>>> versions) on master branch
>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>> branch
>>> 4. Create github action for keeping in sync develop with master, so then
>>> it will push the changes to the master branch everytime the develop branch
>>> has a commit on it, then the dockerhub will publish it as the latest
>>> version.
>>>
>>> Or... we can be more standard
>>>
>>> 1. Rename develop to master
>>> 2. Add a Dockerfile template (and some scripting on it for handling the
>>> versions) on master branch
>>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>>> branch
>>> 4. Everytime a new commit or tag is created, the dockerhub will publish
>>> it as the latest/specific version.
>>>
>>> What do you think?
>>>
>>> Dockerhub automated builds info:
>>> https://docs.docker.com/docker-hub/builds
>>>
>>> Regards
>>>
>>>
>>>
>>> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
>>> escribió:
>>>
>>>> Victor - I was trying to go down that path as well, as that is the
>>>> error thrown and the suggestion at DockerHUB. However, to add the key to
>>>> the git hub requires access and the git is controlled by Apache Infra. I
>>>> asked infra@a.o. about that since, again, that is what DockerHUB had
>>>> documented. Unfortunately, I think infra has it setup a specific way to
>>>> allow all of the projects to publish to the Apache DockerHUB so that route
>>>> would appear to be blocked.
>>>>
>>>>
>>>>
>>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>>> victor.romero@fintecheando.mx> wrote:
>>>>
>>>>> For making it work without a Dockerfile the credentials of the docker
>>>>> hub account are requiered.
>>>>>
>>>>> If they are set in the git repository, a github action can be enabled
>>>>> for this task.
>>>>>
>>>>> Regards
>>>>>
>>>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>>>> jamespdailey@gmail.com> escribió:
>>>>>
>>>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>>
>>>>>> This ticket is to enable the build at DockerHUB to work. For the
>>>>>> past two years ++ the Build has failed.
>>>>>>
>>>>>> https://hub.docker.com/r/apache/fineract
>>>>>> This docker account is held by Apache and the Fineract project is
>>>>>> responsible for the content.
>>>>>>
>>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>>> change on Dev leads to a new deployment.
>>>>>>
>>>>>> The build is actually failing or not running because we have removed
>>>>>> the dockerbuild file from the root. That is as far as I've gotten. I
>>>>>> suspect we had good reasons for that at the time.
>>>>>>
>>>>>> Anyway, I would also say that if we cannot get the Docker build to
>>>>>> work THEN we should take this down. Our standard is to only support and
>>>>>> distribute publicly the last two releases. This build is really old, has
>>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>>
>>>>>> Thanks
>>>>>> James
>>>>>>
>>>>>
Re: Docker help
Posted by Zoltan Mezei <zo...@zz-it.hu>.
Hi,
I think the real issue here is that we use GoogleContainerTools's Jib as
the build mechanism. It works entirely without a Dockerfile. And
unfortunately Dockerhub's Automated Builds doesn't support building without
a Dockerfile. :-(
We have two ways to move forward:
1. Replace the Jib build with a more traditional, Dockerfile-based
approach. This would be a quite large change of how Fineract is built and
the consequences need to be explored - but it's definitely doable.
2. Stick with the Jib build, but don't rely on Dockerhub's Automated
Builds, but some other build tools like jib-maven-plugin to publish the
image to Dockerhub. This could also work, but it requires a build server
that I'm not sure we have.
I can try to create a traditional Dockerfile, but it will be different from
what Jib can produce, so this might lead to regressions.
Want me to try this approach next week?
Kind regards,
Zoltan
On Sun, Feb 11, 2024 at 8:16 AM James Dailey <ja...@gmail.com> wrote:
> Victor - my read of the docs is that the default “build rule “ points to
> master or main but we can also use dev. In fact that’s what is already
> there in dockerHUB for our project.
>
> I think a proper dockerfile in dev branch should be fine.
>
> Thanks
> James
>
> On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> Reading the dockerhub docs, I think we can do the following:
>>
>> 1. Create a master branch from develop branch
>> 2. Add the Dockerfile (and some scripting on it for handling the
>> versions) on master branch
>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>> branch
>> 4. Create github action for keeping in sync develop with master, so then
>> it will push the changes to the master branch everytime the develop branch
>> has a commit on it, then the dockerhub will publish it as the latest
>> version.
>>
>> Or... we can be more standard
>>
>> 1. Rename develop to master
>> 2. Add a Dockerfile template (and some scripting on it for handling the
>> versions) on master branch
>> 3. Dockerhub will use the dockerfile (and its scripts) from the master
>> branch
>> 4. Everytime a new commit or tag is created, the dockerhub will publish
>> it as the latest/specific version.
>>
>> What do you think?
>>
>> Dockerhub automated builds info:
>> https://docs.docker.com/docker-hub/builds
>>
>> Regards
>>
>>
>>
>> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
>> escribió:
>>
>>> Victor - I was trying to go down that path as well, as that is the error
>>> thrown and the suggestion at DockerHUB. However, to add the key to the git
>>> hub requires access and the git is controlled by Apache Infra. I asked
>>> infra@a.o. about that since, again, that is what DockerHUB had
>>> documented. Unfortunately, I think infra has it setup a specific way to
>>> allow all of the projects to publish to the Apache DockerHUB so that route
>>> would appear to be blocked.
>>>
>>>
>>>
>>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>>> victor.romero@fintecheando.mx> wrote:
>>>
>>>> For making it work without a Dockerfile the credentials of the docker
>>>> hub account are requiered.
>>>>
>>>> If they are set in the git repository, a github action can be enabled
>>>> for this task.
>>>>
>>>> Regards
>>>>
>>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>>> jamespdailey@gmail.com> escribió:
>>>>
>>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>>
>>>>> This ticket is to enable the build at DockerHUB to work. For the past
>>>>> two years ++ the Build has failed.
>>>>>
>>>>> https://hub.docker.com/r/apache/fineract
>>>>> This docker account is held by Apache and the Fineract project is
>>>>> responsible for the content.
>>>>>
>>>>> The dockerHUB has an "auto build" concept so that every committed
>>>>> change on Dev leads to a new deployment.
>>>>>
>>>>> The build is actually failing or not running because we have removed
>>>>> the dockerbuild file from the root. That is as far as I've gotten. I
>>>>> suspect we had good reasons for that at the time.
>>>>>
>>>>> Anyway, I would also say that if we cannot get the Docker build to
>>>>> work THEN we should take this down. Our standard is to only support and
>>>>> distribute publicly the last two releases. This build is really old, has
>>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>>
>>>>> Thanks
>>>>> James
>>>>>
>>>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Victor - my read of the docs is that the default “build rule “ points to
master or main but we can also use dev. In fact that’s what is already
there in dockerHUB for our project.
I think a proper dockerfile in dev branch should be fine.
Thanks
James
On Fri, Feb 9, 2024 at 7:47 PM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> Reading the dockerhub docs, I think we can do the following:
>
> 1. Create a master branch from develop branch
> 2. Add the Dockerfile (and some scripting on it for handling the versions)
> on master branch
> 3. Dockerhub will use the dockerfile (and its scripts) from the master
> branch
> 4. Create github action for keeping in sync develop with master, so then
> it will push the changes to the master branch everytime the develop branch
> has a commit on it, then the dockerhub will publish it as the latest
> version.
>
> Or... we can be more standard
>
> 1. Rename develop to master
> 2. Add a Dockerfile template (and some scripting on it for handling the
> versions) on master branch
> 3. Dockerhub will use the dockerfile (and its scripts) from the master
> branch
> 4. Everytime a new commit or tag is created, the dockerhub will publish it
> as the latest/specific version.
>
> What do you think?
>
> Dockerhub automated builds info: https://docs.docker.com/docker-hub/builds
>
> Regards
>
>
>
> El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
> escribió:
>
>> Victor - I was trying to go down that path as well, as that is the error
>> thrown and the suggestion at DockerHUB. However, to add the key to the git
>> hub requires access and the git is controlled by Apache Infra. I asked
>> infra@a.o. about that since, again, that is what DockerHUB had
>> documented. Unfortunately, I think infra has it setup a specific way to
>> allow all of the projects to publish to the Apache DockerHUB so that route
>> would appear to be blocked.
>>
>>
>>
>> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
>> victor.romero@fintecheando.mx> wrote:
>>
>>> For making it work without a Dockerfile the credentials of the docker
>>> hub account are requiered.
>>>
>>> If they are set in the git repository, a github action can be enabled
>>> for this task.
>>>
>>> Regards
>>>
>>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>>> jamespdailey@gmail.com> escribió:
>>>
>>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>>
>>>> This ticket is to enable the build at DockerHUB to work. For the past
>>>> two years ++ the Build has failed.
>>>>
>>>> https://hub.docker.com/r/apache/fineract
>>>> This docker account is held by Apache and the Fineract project is
>>>> responsible for the content.
>>>>
>>>> The dockerHUB has an "auto build" concept so that every committed
>>>> change on Dev leads to a new deployment.
>>>>
>>>> The build is actually failing or not running because we have removed
>>>> the dockerbuild file from the root. That is as far as I've gotten. I
>>>> suspect we had good reasons for that at the time.
>>>>
>>>> Anyway, I would also say that if we cannot get the Docker build to work
>>>> THEN we should take this down. Our standard is to only support and
>>>> distribute publicly the last two releases. This build is really old, has
>>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>>
>>>> Thanks
>>>> James
>>>>
>>>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
Reading the dockerhub docs, I think we can do the following:
1. Create a master branch from develop branch
2. Add the Dockerfile (and some scripting on it for handling the versions)
on master branch
3. Dockerhub will use the dockerfile (and its scripts) from the master
branch
4. Create github action for keeping in sync develop with master, so then it
will push the changes to the master branch everytime the develop branch has
a commit on it, then the dockerhub will publish it as the latest version.
Or... we can be more standard
1. Rename develop to master
2. Add a Dockerfile template (and some scripting on it for handling the
versions) on master branch
3. Dockerhub will use the dockerfile (and its scripts) from the master
branch
4. Everytime a new commit or tag is created, the dockerhub will publish it
as the latest/specific version.
What do you think?
Dockerhub automated builds info: https://docs.docker.com/docker-hub/builds
Regards
El vie, 9 feb 2024 a las 20:34, James Dailey (<ja...@gmail.com>)
escribió:
> Victor - I was trying to go down that path as well, as that is the error
> thrown and the suggestion at DockerHUB. However, to add the key to the git
> hub requires access and the git is controlled by Apache Infra. I asked
> infra@a.o. about that since, again, that is what DockerHUB had
> documented. Unfortunately, I think infra has it setup a specific way to
> allow all of the projects to publish to the Apache DockerHUB so that route
> would appear to be blocked.
>
>
>
> On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
> victor.romero@fintecheando.mx> wrote:
>
>> For making it work without a Dockerfile the credentials of the docker hub
>> account are requiered.
>>
>> If they are set in the git repository, a github action can be enabled for
>> this task.
>>
>> Regards
>>
>> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
>> jamespdailey@gmail.com> escribió:
>>
>>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>>
>>> This ticket is to enable the build at DockerHUB to work. For the past
>>> two years ++ the Build has failed.
>>>
>>> https://hub.docker.com/r/apache/fineract
>>> This docker account is held by Apache and the Fineract project is
>>> responsible for the content.
>>>
>>> The dockerHUB has an "auto build" concept so that every committed change
>>> on Dev leads to a new deployment.
>>>
>>> The build is actually failing or not running because we have removed the
>>> dockerbuild file from the root. That is as far as I've gotten. I suspect
>>> we had good reasons for that at the time.
>>>
>>> Anyway, I would also say that if we cannot get the Docker build to work
>>> THEN we should take this down. Our standard is to only support and
>>> distribute publicly the last two releases. This build is really old, has
>>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>>
>>> Thanks
>>> James
>>>
>>
Re: Docker help
Posted by James Dailey <ja...@gmail.com>.
Victor - I was trying to go down that path as well, as that is the error
thrown and the suggestion at DockerHUB. However, to add the key to the git
hub requires access and the git is controlled by Apache Infra. I asked
infra@a.o. about that since, again, that is what DockerHUB had documented.
Unfortunately, I think infra has it setup a specific way to allow all of
the projects to publish to the Apache DockerHUB so that route would appear
to be blocked.
On Fri, Feb 9, 2024 at 4:04 PM VICTOR MANUEL ROMERO RODRIGUEZ <
victor.romero@fintecheando.mx> wrote:
> For making it work without a Dockerfile the credentials of the docker hub
> account are requiered.
>
> If they are set in the git repository, a github action can be enabled for
> this task.
>
> Regards
>
> El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
> jamespdailey@gmail.com> escribió:
>
>> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>>
>> This ticket is to enable the build at DockerHUB to work. For the past
>> two years ++ the Build has failed.
>>
>> https://hub.docker.com/r/apache/fineract
>> This docker account is held by Apache and the Fineract project is
>> responsible for the content.
>>
>> The dockerHUB has an "auto build" concept so that every committed change
>> on Dev leads to a new deployment.
>>
>> The build is actually failing or not running because we have removed the
>> dockerbuild file from the root. That is as far as I've gotten. I suspect
>> we had good reasons for that at the time.
>>
>> Anyway, I would also say that if we cannot get the Docker build to work
>> THEN we should take this down. Our standard is to only support and
>> distribute publicly the last two releases. This build is really old, has
>> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>>
>> Thanks
>> James
>>
>
Re: Docker help
Posted by VICTOR MANUEL ROMERO RODRIGUEZ <vi...@fintecheando.mx>.
For making it work without a Dockerfile the credentials of the docker hub
account are requiered.
If they are set in the git repository, a github action can be enabled for
this task.
Regards
El vie., 9 de febrero de 2024 4:45 p. m., James Dailey <
jamespdailey@gmail.com> escribió:
> I've re-opened https://issues.apache.org/jira/browse/FINERACT-1164
>
> This ticket is to enable the build at DockerHUB to work. For the past two
> years ++ the Build has failed.
>
> https://hub.docker.com/r/apache/fineract
> This docker account is held by Apache and the Fineract project is
> responsible for the content.
>
> The dockerHUB has an "auto build" concept so that every committed change
> on Dev leads to a new deployment.
>
> The build is actually failing or not running because we have removed the
> dockerbuild file from the root. That is as far as I've gotten. I suspect
> we had good reasons for that at the time.
>
> Anyway, I would also say that if we cannot get the Docker build to work
> THEN we should take this down. Our standard is to only support and
> distribute publicly the last two releases. This build is really old, has
> unfixed CVEs, and is being downloaded in large numbers. (no idea why)
>
> Thanks
> James
>