You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/29 23:05:36 UTC
[GitHub] [incubator-mxnet] zachgk commented on a change in pull request
#16654: [WIP] Multithreaded Inference Support
zachgk commented on a change in pull request #16654: [WIP] Multithreaded Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r340365798
##########
File path: include/mxnet/c_api.h
##########
@@ -1274,10 +1274,28 @@ MXNET_DLL int MXCreateCachedOpEx(SymbolHandle handle,
const char** keys,
const char** vals,
CachedOpHandle *out);
+
+/*!
+ * \brief create cached operator, allows to choose thread_safe version
+ * of cachedop
+ */
+MXNET_DLL int MXCreateCachedOpEX(SymbolHandle handle,
+ int num_flags,
+ const char** keys,
+ const char** vals,
+ CachedOpHandle *out,
+ bool thread_safe = false);
Review comment:
Aren't default arguments like this only supported in C++ and this file is just C?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services