You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/21 15:47:30 UTC
[GitHub] [maven] gnodet opened a new pull request #547: Refactoring
gnodet opened a new pull request #547:
URL: https://github.com/apache/maven/pull/547
A few refactoring commits....
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #547: Refactoring
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #547:
URL: https://github.com/apache/maven/pull/547#discussion_r713751633
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
##########
@@ -64,13 +64,13 @@ public LifecycleModuleBuilder(
MojoExecutor mojoExecutor,
BuilderCommon builderCommon,
ExecutionEventCatapult eventCatapult,
- ProjectExecutionListener projectExecutionListener,
+ List<ProjectExecutionListener> listeners,
Review comment:
Can you explain the purpose of this API change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas edited a comment on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component
Posted by GitBox <gi...@apache.org>.
cstamas edited a comment on pull request #547:
URL: https://github.com/apache/maven/pull/547#issuecomment-932718082
@gnodet please make sure you ingest all changes of this https://github.com/apache/maven/pull/440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are related: ServiceLocator prevents ctor injection, one cannot go without another).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #547: Refactoring
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #547:
URL: https://github.com/apache/maven/pull/547#discussion_r713761178
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
##########
@@ -64,13 +64,13 @@ public LifecycleModuleBuilder(
MojoExecutor mojoExecutor,
BuilderCommon builderCommon,
ExecutionEventCatapult eventCatapult,
- ProjectExecutionListener projectExecutionListener,
+ List<ProjectExecutionListener> listeners,
Review comment:
AH, maybe the commits are misleading. The 3 last commits (Fix xxx) should be merged into the "Use constructor injector" one, which would make things more clear. Those are problems in the refactoring and should not be reviewed per se, they only fix the previous commit. Let me fix that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #547: Refactoring
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #547:
URL: https://github.com/apache/maven/pull/547#discussion_r713759683
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
##########
@@ -64,13 +64,13 @@ public LifecycleModuleBuilder(
MojoExecutor mojoExecutor,
BuilderCommon builderCommon,
ExecutionEventCatapult eventCatapult,
- ProjectExecutionListener projectExecutionListener,
+ List<ProjectExecutionListener> listeners,
Review comment:
Could you be more precise ? Which API change are you talking about ? The change is mainly about switching to pure constructor injection and final fields whenever possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #547:
URL: https://github.com/apache/maven/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #547:
URL: https://github.com/apache/maven/pull/547#issuecomment-932725928
> @gnodet please make sure you ingest all changes of this #440 as then we have two 🪰 (issues) killed with one 👏 (change) (as they are related: ServiceLocator prevents ctor injection, one cannot go without another).
@cstamas The only real difference (beyond spaces) is that I kept the `DefaultArtifactDescriptorReader` constructor package protected instead of making it public. Otherwise, all the meaningful changes in #440 are included in the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #547: [MNG-5577] Use constructor injection and remove the use of @Component
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #547:
URL: https://github.com/apache/maven/pull/547#issuecomment-932718082
@gnodet please make sure you ingest all changes of this https://github.com/apache/maven/pull/440 as then we have two flies with one change (as they are related: ServiceLocator prevents ctor injection, one cannot go without another).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org