[GitHub] spark pull request #11994: [SPARK-14151] Expose metrics Source and Sink inte...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11994#discussion_r153024461
  
    --- Diff: external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala ---
    @@ -59,22 +61,22 @@ class GangliaSink(val property: Properties, val registry: MetricRegistry,
         throw new Exception("Ganglia sink requires 'port' property.")
       }
     
    -  val host = propertyToOption(GANGLIA_KEY_HOST).get
    -  val port = propertyToOption(GANGLIA_KEY_PORT).get.toInt
    -  val ttl = propertyToOption(GANGLIA_KEY_TTL).map(_.toInt).getOrElse(GANGLIA_DEFAULT_TTL)
    -  val dmax = propertyToOption(GANGLIA_KEY_DMAX).map(_.toInt).getOrElse(GANGLIA_DEFAULT_DMAX)
    -  val mode: UDPAddressingMode = propertyToOption(GANGLIA_KEY_MODE)
    -    .map(u => GMetric.UDPAddressingMode.valueOf(u.toUpperCase)).getOrElse(GANGLIA_DEFAULT_MODE)
    -  val pollPeriod = propertyToOption(GANGLIA_KEY_PERIOD).map(_.toInt)
    +  private val host = propertyToOption(GANGLIA_KEY_HOST).get
    +  private val port = propertyToOption(GANGLIA_KEY_PORT).get.toInt
    +  private val ttl = propertyToOption(GANGLIA_KEY_TTL).map(_.toInt).getOrElse(GANGLIA_DEFAULT_TTL)
    +  private val mode: UDPAddressingMode = propertyToOption(GANGLIA_KEY_MODE)
    --- End diff --
    
    `val dmax = propertyToOption(GANGLIA_KEY_DMAX).map(_.toInt).getOrElse(GANGLIA_DEFAULT_DMAX)` removed?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org