You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2008/05/07 06:43:55 UTC

[jira] Created: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Configuration should accept decimal and hexadecimal values
----------------------------------------------------------

                 Key: HADOOP-3355
                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
             Project: Hadoop Core
          Issue Type: Improvement
          Components: conf
            Reporter: Amareshwari Sriramadasu
            Assignee: Amareshwari Sriramadasu
             Fix For: 0.18.0


This issue is created after the discussions in HADOOP-2461.
To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Attachment: patch-3355.txt

Here is a patch accepting negative hex values also.

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Status: Patch Available  (was: Open)

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594972#action_12594972 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3355:
------------------------------------------------

Could we specify negative hex values?

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597121#action_12597121 ] 

Hudson commented on HADOOP-3355:
--------------------------------

Integrated in Hadoop-trunk #492 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/492/])

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-3355:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Amareshwari!

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Attachment: patch-3355.txt

Here is patch adding support for Hexadecimal values for configuration properties.

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Status: Patch Available  (was: Open)

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Status: Open  (was: Patch Available)

Cancelling patch as it doesnt work for negative hex digits.

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-3355:
--------------------------------------------

    Release Note: Added support for hexadecimal values in Configuration

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595037#action_12595037 ] 

Hadoop QA commented on HADOOP-3355:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12381579/patch-3355.txt
  against trunk revision 654128.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2419/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2419/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2419/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2419/console

This message is automatically generated.

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3355) Configuration should accept decimal and hexadecimal values

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595395#action_12595395 ] 

Hadoop QA commented on HADOOP-3355:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12381654/patch-3355.txt
  against trunk revision 654315.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2427/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2427/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2427/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2427/console

This message is automatically generated.

> Configuration should accept decimal and hexadecimal values
> ----------------------------------------------------------
>
>                 Key: HADOOP-3355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3355
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.18.0
>
>         Attachments: patch-3355.txt, patch-3355.txt
>
>
> This issue is created after the discussions in HADOOP-2461.
> To summarise, Configuration should also accept hexadecimal values such as 0x1000, in addition to decimal values. Octal representation is not supported, since it may confuse some users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.