You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/05/12 14:14:18 UTC

[GitHub] [tinkerpop] lyndonbauto commented on pull request #1650: Adjust export of enum traversal operations

lyndonbauto commented on PR #1650:
URL: https://github.com/apache/tinkerpop/pull/1650#issuecomment-1125048825

   Thanks for the change @simonz-bq. The actual change itself looks great, this will make our syntax more natural for users who are used to using things like `Scope.Local` (as opposed to our previous just `gremlingo.Local`).
   
   I noticed:
   
   ```
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:35: undefined: gremlingo.Any
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:36: undefined: gremlingo.None
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:41: undefined: gremlingo.None
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:44: undefined: gremlingo.None
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:47: undefined: gremlingo.Value
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:47: undefined: gremlingo.Asc
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:48: undefined: gremlingo.Label
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:48: undefined: gremlingo.Id
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:62: undefined: gremlingo.Id
   gremlin-go-integration-tests    | driver/cucumber/gremlin.go:65: undefined: gremlingo.Label
   ```
   
   So I think you will need to update the translator to have `gremlingo.T.Label` as opposed to `gremlingo.Label`.
   
   Let me know if you need help with this as that section of code is a kind of esoteric.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org