You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Dirk Frederickx <di...@gmail.com> on 2014/03/03 19:06:00 UTC

maven question

I notice that running this command:

mvn clean install -Dmaven.test.skip -Dminimize=false


still minimises all js and css.



Could anyone help to check why the variable minimize=false is not handled ?




dirk

Re: maven question

Posted by Dirk Frederickx <di...@gmail.com>.
Juan,

Great help -- txs !

dirk


On Mon, Mar 3, 2014 at 7:36 PM, Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:

> Hi Dirk,
>
> wro4j minimize <config/> value was hardcoded to true, so it would always
> perform the minimization (is that a word?). I've just made a quick commit
> so that value is readed from a maven property (which can be overriden via
> -D..), with a "true" default value. I've also moved wro4j plugin's common
> configuration to the parent pom, to get rid of a few lines of duplicated
> configuration.
>
> tl;dr: should work now with latest trunk
>
>
> br,
> juan pablo
>
>
>
> On Mon, Mar 3, 2014 at 7:06 PM, Dirk Frederickx
> <di...@gmail.com>wrote:
>
> > I notice that running this command:
> >
> > mvn clean install -Dmaven.test.skip -Dminimize=false
> >
> >
> > still minimises all js and css.
> >
> >
> >
> > Could anyone help to check why the variable minimize=false is not
> handled ?
> >
> >
> >
> >
> > dirk
> >
>

Re: maven question

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi Dirk,

wro4j minimize <config/> value was hardcoded to true, so it would always
perform the minimization (is that a word?). I've just made a quick commit
so that value is readed from a maven property (which can be overriden via
-D..), with a "true" default value. I've also moved wro4j plugin's common
configuration to the parent pom, to get rid of a few lines of duplicated
configuration.

tl;dr: should work now with latest trunk


br,
juan pablo



On Mon, Mar 3, 2014 at 7:06 PM, Dirk Frederickx
<di...@gmail.com>wrote:

> I notice that running this command:
>
> mvn clean install -Dmaven.test.skip -Dminimize=false
>
>
> still minimises all js and css.
>
>
>
> Could anyone help to check why the variable minimize=false is not handled ?
>
>
>
>
> dirk
>