You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Berin Loritsch <bl...@apache.org> on 2003/02/05 03:28:46 UTC
[VOTE] Release LogKit 1.2
The current LogKit 1.2 release candidate 3 distributed at
http://avalon.apache.org/~bloritsch/logkit-dist/
has been up and no problems reported for a couple of days.
There is only one potential obstacle in the way of a release:
and that is the LoggerListener functionality. The only way
to get this to rest is to make a vote on it.
* Keep current LoggerListener functionality AS IS (unicast).
- Allows for immediate release of LogKit 1.2
* Change LoggerListener functionality to multicast.
- Delays release, requires more validation
* Back out LoggerListener functionality for a future version.
- Allows for immediate release of LogKit 1.2
Here are the facts concerning the matter:
* LoggerListener has use as a way of validating the logging
framework (i.e. testing purposes)
* LoggerListener exposes functionality to containers, not
components.
- Logger is abstracted in Avalon Framework
- It is set in the Heirarchy
- No existing component will use it because it is new.
* We have no clear *need* for multicast LoggerListeners.
* Exceptions are messy in Logging frameworks because we
need to track them.
- Exceptions are only going to happen at setup time,
not at run time.
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
Stephen,
> In the meantime there are some code changes to logkit
As long as you're in there, please note the error report I just posted.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Stephen McConnell <mc...@apache.org>.
Berin - I'm assuming this isn't a vote for release (as per subject) but
is a vote on the issue relating the the listener (as per cmessage
content). Personally I havn't had a chance to check the code in
question and would like to do that before voting on the listener issue.
In the meantime there are some code changes to logkit (checkstyle
stuff) I would like to put in place - in fact I'm working on that at the
moment - should have updates though in a couple of hours.
Cheers, Steve.
Berin Loritsch wrote:
> The current LogKit 1.2 release candidate 3 distributed at
> http://avalon.apache.org/~bloritsch/logkit-dist/
>
> has been up and no problems reported for a couple of days.
>
> There is only one potential obstacle in the way of a release:
> and that is the LoggerListener functionality. The only way
> to get this to rest is to make a vote on it.
>
> * Keep current LoggerListener functionality AS IS (unicast).
> - Allows for immediate release of LogKit 1.2
>
> * Change LoggerListener functionality to multicast.
> - Delays release, requires more validation
>
> * Back out LoggerListener functionality for a future version.
> - Allows for immediate release of LogKit 1.2
>
>
> Here are the facts concerning the matter:
>
> * LoggerListener has use as a way of validating the logging
> framework (i.e. testing purposes)
>
> * LoggerListener exposes functionality to containers, not
> components.
> - Logger is abstracted in Avalon Framework
> - It is set in the Heirarchy
> - No existing component will use it because it is new.
>
> * We have no clear *need* for multicast LoggerListeners.
>
> * Exceptions are messy in Logging frameworks because we
> need to track them.
> - Exceptions are only going to happen at setup time,
> not at run time.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
>
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Leo Simons <le...@apache.org>.
Noel J. Bergman wrote:
> As for the other, I suggest that if it is kept unicast, that you change the
> code to declare the exception, and add the trivial if () throw statement.
> It is really improper to fail silently.
sounds reasonable.
- Leo
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
Leo,
You mean a test case OTHER than:
> <file id="smtpserver-target">
> <filename>${app.home}/logs/smtpserver</filename>
> <format> ... </format>
> <append>true</append>
> <rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
> <or>
> <date>dd</date>
> <size>10485760</size>
> </or>
> </rotation>
> </file>
Do you believe that this is unique to James? Download James v2.1.1a5.
Replace logkit with the new release candidate. Make sure that
apps/james/SAR-INF/environment.xml has the above logging rotation. In
SAR-INF/config.xml, find "<processor name="root">" and add the following
line immediately after:
<mailet match="All" class="Null" />
that will discard all e-mail, which is fine for this test. Alternatively, I
can post a pre-configured tar or zip for whomever wants to work on this
issue.
Then you can set the server time to sometime before midnight, start James,
and start sending messages. I use postal on linux for that purpose. As far
as I know, you could testing with telnet by hand would also exhibit the
problem.
My testing is limited to daily, because the test server hosts real-time
database replication backup for servers outside of our firewall, and they
are all NTP synched.
--- Noel
-----Original Message-----
From: news [mailto:news@main.gmane.org]On Behalf Of Leo Simons
Sent: Wednesday, February 05, 2003 13:38
To: avalon-dev@jakarta.apache.org
Subject: Re: [VOTE] Release LogKit 1.2
ok (not!). This is a showstopper IMO. Noel, you think you could provide
a testcase?
- Leo
Noel J. Bergman wrote:
> Bad news:
>
> 4-Feb-2003 22:07:06 10,485,809 smtpserver-2003-02-04-16-29.log
> 4-Feb-2003 22:56:58 10,485,792 smtpserver-2003-02-04-22-07.log
> 4-Feb-2003 23:46:56 10,485,838 smtpserver-2003-02-04-22-56.log
> 5-Feb-2003 00:00:00 2,755,351 smtpserver-2003-02-04-23-46.log
> 5-Feb-2003 00:01:00 173,256 smtpserver-2003-02-05-00-00.log
> 5-Feb-2003 00:02:00 174,152 smtpserver-2003-02-05-00-01.log
> 5-Feb-2003 00:03:00 176,001 smtpserver-2003-02-05-00-02.log
> 5-Feb-2003 00:04:00 183,289 smtpserver-2003-02-05-00-03.log
> 5-Feb-2003 00:04:02 5,382 smtpserver-2003-02-05-00-04.log
>
> This is using today's release candidate. Again, the file-target is:
>
> <file id="smtpserver-target">
> <filename>${app.home}/logs/smtpserver</filename>
> <format> ... </format>
> <append>true</append>
> <rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
> <or>
> <date>dd</date>
> <size>10485760</size>
> </or>
> </rotation>
> </file>
>
> Any ideas?
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by Leo Sutic <le...@inspireinfrastructure.com>.
>>From RotatingFileTarget:
/**
* Rote the file - ?? explination needed.
* @exception IOException if a file related error occurs
* @exception IOException if a file access or write related error
occurs
*/
protected synchronized void rotate()
throws IOException
{
close();
final File file = m_fileStrategy.nextFile();
setFile( file, m_append );
openFile();
}
/**
* Output the log message, and check if rotation is needed.
* @param data the date to write to the target
*/
protected synchronized void write( final String data )
{
// if rotation is needed, close old File, create new File
if( m_rotateStrategy.isRotationNeeded( data, getFile() ) )
{
try
{
rotate();
}
catch( final IOException ioe )
{
getErrorHandler().error( "Error rotating file", ioe,
null );
}
}
// write the log message
super.write( data );
}
m_rotateStrategy.reset() is never called. The RotateStrategyBySize is
self-resetting, so this bug never happens with it, but the
RotateStrategyByDate isn't.
/LS
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by Leo Sutic <le...@inspireinfrastructure.com>.
OrRotateStrategy doesn't reset all sub-strategies, see below. Only the
substrategy that signals gets reset. Thus:
OrRotateStrategy.java
/**
* reset.
*/
public void reset()
{
if( -1 != m_usedRotation )
{
m_strategies[ m_usedRotation ].reset();
m_usedRotation = -1;
}
}
should be:
/**
* reset.
*/
public void reset()
{
for (int i = 0; i < m_strategies.length; i++)
{
m_strategies[ i ].reset();
}
}
/LS
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Leo Simons <le...@apache.org>.
ok (not!). This is a showstopper IMO. Noel, you think you could provide
a testcase?
- Leo
Noel J. Bergman wrote:
> Bad news:
>
> 4-Feb-2003 22:07:06 10,485,809 smtpserver-2003-02-04-16-29.log
> 4-Feb-2003 22:56:58 10,485,792 smtpserver-2003-02-04-22-07.log
> 4-Feb-2003 23:46:56 10,485,838 smtpserver-2003-02-04-22-56.log
> 5-Feb-2003 00:00:00 2,755,351 smtpserver-2003-02-04-23-46.log
> 5-Feb-2003 00:01:00 173,256 smtpserver-2003-02-05-00-00.log
> 5-Feb-2003 00:02:00 174,152 smtpserver-2003-02-05-00-01.log
> 5-Feb-2003 00:03:00 176,001 smtpserver-2003-02-05-00-02.log
> 5-Feb-2003 00:04:00 183,289 smtpserver-2003-02-05-00-03.log
> 5-Feb-2003 00:04:02 5,382 smtpserver-2003-02-05-00-04.log
>
> This is using today's release candidate. Again, the file-target is:
>
> <file id="smtpserver-target">
> <filename>${app.home}/logs/smtpserver</filename>
> <format> ... </format>
> <append>true</append>
> <rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
> <or>
> <date>dd</date>
> <size>10485760</size>
> </or>
> </rotation>
> </file>
>
> Any ideas?
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Stephen McConnell <mc...@apache.org>.
Noel J. Bergman wrote:
>>can you post a not detailing which targets/strategies are involved
>>
>>
>
>What is missing from my message? I provided everything, as far as I know.
>Directory of files generated, and the full <file> element, with strategies.
>
> --- Noel
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
>
>
>
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
> I was wondering if you knew which rotation strategy was implied by the
> configuration. The configuration is actually part of Excalibur Logger
> package which is presumably pulling things together out of the LogKit
> log/output/io/rotate/ package.
<<shrug>> What do I know? I haven't read through the code. I had to find
the docs originally via google.
Here is the whole thing, again (inside of a <targets> element):
<file id="smtpserver-target">
<filename>${app.home}/logs/smtpserver</filename>
<format>%{time:dd/MM/yy HH:mm:ss} %5.5{priority} %{category}:
%{message}\n%{throwable}</format>
<append>true</append>
<rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
<or>
<date>dd</date>
<size>10485760</size>
</or>
</rotation>
</file>
It is what it is. AIUI, that uses the unique file code and the OrRotation
on top of the date and size rotations, but again I haven't tried to read the
code.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Stephen McConnell <mc...@apache.org>.
This time with a message!
I was wondering if you knew which rotation strategy was implied by the
configuration. The configuration is actually part of Excalibur Logger
package which is presumably pulling things together out of the LogKit
log/output/io/rotate/ package.
Cheers, Steve.
(who has been up a real long time and doesn't feel like doing a lot of
thinking)
Noel J. Bergman wrote:
>>can you post a not detailing which targets/strategies are involved
>>
>>
>
>What is missing from my message? I provided everything, as far as I know.
>Directory of files generated, and the full <file> element, with strategies.
>
> --- Noel
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
>
>
>
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
> can you post a not detailing which targets/strategies are involved
What is missing from my message? I provided everything, as far as I know.
Directory of files generated, and the full <file> element, with strategies.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: [VOTE] Release LogKit 1.2
Posted by Stephen McConnell <mc...@apache.org>.
Noel:
I figure I'm not the best person to check into this (LogKit knowlege is
limited to the root Hierachy) - but can you post a not detailing which
targets/strategies are involved - no promises though - in the meant 45
checkstyle errors eliminated, another 250 to go (but that's for tommorow).
Cheers, Steve.
Noel J. Bergman wrote:
>Bad news:
>
> 4-Feb-2003 22:07:06 10,485,809 smtpserver-2003-02-04-16-29.log
> 4-Feb-2003 22:56:58 10,485,792 smtpserver-2003-02-04-22-07.log
> 4-Feb-2003 23:46:56 10,485,838 smtpserver-2003-02-04-22-56.log
> 5-Feb-2003 00:00:00 2,755,351 smtpserver-2003-02-04-23-46.log
> 5-Feb-2003 00:01:00 173,256 smtpserver-2003-02-05-00-00.log
> 5-Feb-2003 00:02:00 174,152 smtpserver-2003-02-05-00-01.log
> 5-Feb-2003 00:03:00 176,001 smtpserver-2003-02-05-00-02.log
> 5-Feb-2003 00:04:00 183,289 smtpserver-2003-02-05-00-03.log
> 5-Feb-2003 00:04:02 5,382 smtpserver-2003-02-05-00-04.log
>
>This is using today's release candidate. Again, the file-target is:
>
> <file id="smtpserver-target">
> <filename>${app.home}/logs/smtpserver</filename>
> <format> ... </format>
> <append>true</append>
> <rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
> <or>
> <date>dd</date>
> <size>10485760</size>
> </or>
> </rotation>
> </file>
>
>Any ideas?
>
> --- Noel
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
>
>
>
>
>
--
Stephen J. McConnell
mailto:mcconnell@apache.org
http://www.osm.net
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
Bad news:
4-Feb-2003 22:07:06 10,485,809 smtpserver-2003-02-04-16-29.log
4-Feb-2003 22:56:58 10,485,792 smtpserver-2003-02-04-22-07.log
4-Feb-2003 23:46:56 10,485,838 smtpserver-2003-02-04-22-56.log
5-Feb-2003 00:00:00 2,755,351 smtpserver-2003-02-04-23-46.log
5-Feb-2003 00:01:00 173,256 smtpserver-2003-02-05-00-00.log
5-Feb-2003 00:02:00 174,152 smtpserver-2003-02-05-00-01.log
5-Feb-2003 00:03:00 176,001 smtpserver-2003-02-05-00-02.log
5-Feb-2003 00:04:00 183,289 smtpserver-2003-02-05-00-03.log
5-Feb-2003 00:04:02 5,382 smtpserver-2003-02-05-00-04.log
This is using today's release candidate. Again, the file-target is:
<file id="smtpserver-target">
<filename>${app.home}/logs/smtpserver</filename>
<format> ... </format>
<append>true</append>
<rotation type="unique" pattern="-yyyy-MM-dd-HH-mm" suffix=".log">
<or>
<date>dd</date>
<size>10485760</size>
</or>
</rotation>
</file>
Any ideas?
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
RE: [VOTE] Release LogKit 1.2
Posted by "Noel J. Bergman" <no...@devtech.com>.
Berin,
I should have an answer for the log rotate bug in another 60 minutes.
Earlier today, I pulled RC3 for the test.
As for the other, I suggest that if it is kept unicast, that you change the
code to declare the exception, and add the trivial if () throw statement.
It is really improper to fail silently.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org