You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "BruceWong96 (via GitHub)" <gi...@apache.org> on 2023/06/14 09:38:41 UTC
[GitHub] [kyuubi] BruceWong96 opened a new pull request, #4960: [DOC] Fix doc for pyhive client.
BruceWong96 opened a new pull request, #4960:
URL: https://github.com/apache/kyuubi/pull/4960
### _Why are the changes needed?_
Based on my actual tests and pyhive source code, the variable "user" should be "username".
[pyhive source code](https://github.com/dropbox/PyHive/blob/master/pyhive/hive.py#L115)
<img width="866" alt="图片" src="https://github.com/apache/kyuubi/assets/29974394/f5022f89-11d4-4d3b-af16-176ff2cd8068">
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4960:
URL: https://github.com/apache/kyuubi/pull/4960#issuecomment-1591006558
@BruceWong96 Please link your email to your GitHub account, `Bruce <we...@liulishuo.com>`, otherwise, your contribution will not be counted by GitHub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4960:
URL: https://github.com/apache/kyuubi/pull/4960#discussion_r1229325452
##########
docs/client/python/pyhive.md:
##########
@@ -64,7 +64,7 @@ If password is provided for connection, make sure the `auth` param set to either
```python
# open connection
-conn = hive.Connection(host=kyuubi_host,port=10009,
-user='user', password='password', auth='CUSTOM')
+conn = hive.Connection(host=kyuubi_host, port=10009,
+ username='user', password='password', auth='CUSTOM')
Review Comment:
```suggestion
conn = hive.Connection(host=kyuubi_host, port=10009,
username='user', password='password', auth='CUSTOM')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] BruceWong96 commented on pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "BruceWong96 (via GitHub)" <gi...@apache.org>.
BruceWong96 commented on PR #4960:
URL: https://github.com/apache/kyuubi/pull/4960#issuecomment-1591028906
> @BruceWong96 Please link your email to your GitHub account, `Bruce <we...@liulishuo.com>`, otherwise, your contribution will not be counted by GitHub
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4960:
URL: https://github.com/apache/kyuubi/pull/4960#issuecomment-1590999328
Thanks, merged to master/1.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4960: [DOC] Fix doc for pyhive client.
URL: https://github.com/apache/kyuubi/pull/4960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4960: [DOC] Fix doc for pyhive client.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4960:
URL: https://github.com/apache/kyuubi/pull/4960#issuecomment-1590991227
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/4960?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4960](https://app.codecov.io/gh/apache/kyuubi/pull/4960?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (db39786) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/768b8ff7cabe229418621f059de1ca0249bd71c4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (768b8ff) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4960 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 30964 30964
Branches 4035 4035
======================================
Misses 30964 30964
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org