You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2011/08/23 00:11:54 UTC

Wicket Weld into wicket 1.5?

Wicket Weld is a really nice to have for wicket 1.5 and would increase
the importance of our release pretty considerably. The issue with
wicket-weld is that it requires java 6, and it is late in the release
game for 1.5 final.

We have experience with building mixed java releases (see our 1.3
history), though the build process was not pretty.

In order to enable wicket-weld we need to do the following IMO:
 - create java5 and java6 modules in trunk, each configured with the
correct java version
 - commit wicket-weld as a submodule for the java 6 module
 - move wicket-examples to java 6 module
 - move all other wicket modules to the java 5 module
 - fix the wicket parent pom to have a java 5 profile and a java 6 profile
 - fix the build script to run different maven setups utilizing a java
5 home directory and a java 6 home directory
 - fix the build script to run java 5 compilation first and then only
java 6 for packaging (without clean) this will keep the java 5
compiled classes and re-package them during the java 6 run

This is some work, and as I said, we are late in the release game. If
1.5 final was this week I wouldn't propose to do this, but perhaps do
it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
might do this now. I'm open to suggestions on whether to include
wicket-weld or not.

Martijn

-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: Wicket Weld into wicket 1.5?

Posted by tetsuo <ro...@gmail.com>.
Why does it require java 6?



On Mon, Aug 22, 2011 at 7:38 PM, Igor Vaynberg <ig...@gmail.com>wrote:

> +1 for including it in rc6. we are tweaking poms anyways.
>
> the release of this is pending on jboss guys getting weld and seam
> artifacts into central, something im working with them on.
>
> -igor
>
>
> On Mon, Aug 22, 2011 at 3:11 PM, Martijn Dashorst
> <ma...@gmail.com> wrote:
> > Wicket Weld is a really nice to have for wicket 1.5 and would increase
> > the importance of our release pretty considerably. The issue with
> > wicket-weld is that it requires java 6, and it is late in the release
> > game for 1.5 final.
> >
> > We have experience with building mixed java releases (see our 1.3
> > history), though the build process was not pretty.
> >
> > In order to enable wicket-weld we need to do the following IMO:
> >  - create java5 and java6 modules in trunk, each configured with the
> > correct java version
> >  - commit wicket-weld as a submodule for the java 6 module
> >  - move wicket-examples to java 6 module
> >  - move all other wicket modules to the java 5 module
> >  - fix the wicket parent pom to have a java 5 profile and a java 6
> profile
> >  - fix the build script to run different maven setups utilizing a java
> > 5 home directory and a java 6 home directory
> >  - fix the build script to run java 5 compilation first and then only
> > java 6 for packaging (without clean) this will keep the java 5
> > compiled classes and re-package them during the java 6 run
> >
> > This is some work, and as I said, we are late in the release game. If
> > 1.5 final was this week I wouldn't propose to do this, but perhaps do
> > it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
> > might do this now. I'm open to suggestions on whether to include
> > wicket-weld or not.
> >
> > Martijn
> >
> > --
> > Become a Wicket expert, learn from the best: http://wicketinaction.com
> >
>

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
+1 for including it in rc6. we are tweaking poms anyways.

the release of this is pending on jboss guys getting weld and seam
artifacts into central, something im working with them on.

-igor


On Mon, Aug 22, 2011 at 3:11 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Wicket Weld is a really nice to have for wicket 1.5 and would increase
> the importance of our release pretty considerably. The issue with
> wicket-weld is that it requires java 6, and it is late in the release
> game for 1.5 final.
>
> We have experience with building mixed java releases (see our 1.3
> history), though the build process was not pretty.
>
> In order to enable wicket-weld we need to do the following IMO:
>  - create java5 and java6 modules in trunk, each configured with the
> correct java version
>  - commit wicket-weld as a submodule for the java 6 module
>  - move wicket-examples to java 6 module
>  - move all other wicket modules to the java 5 module
>  - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>  - fix the build script to run different maven setups utilizing a java
> 5 home directory and a java 6 home directory
>  - fix the build script to run java 5 compilation first and then only
> java 6 for packaging (without clean) this will keep the java 5
> compiled classes and re-package them during the java 6 run
>
> This is some work, and as I said, we are late in the release game. If
> 1.5 final was this week I wouldn't propose to do this, but perhaps do
> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
> might do this now. I'm open to suggestions on whether to include
> wicket-weld or not.
>
> Martijn
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: Wicket Weld into wicket 1.5?

Posted by Martin Grigorov <mg...@apache.org>.
Hi Brian,

On Tue, Aug 23, 2011 at 11:04 AM, Brian Topping <to...@codehaus.org> wrote:
> I agree with Martin's POV here, but with the additional caveat that API changes and module changes are the same thing, they break backwards compatibility and should be treated the same. Micro releases are bugfix releases.  Plain and simple.

What is bad with the module changes or more correctly said module additions ?
>From my POV it is just a new jar in the distro. For most of the users
there is no change until they decide to deploy in OSGi container or to
use Weld.

>
> Cleaning up the module structure so *anything* can be added should be a priority.  OSGi holds very little difference from the transition from C to C++ for people who were there for that.  It was a PITA to do it, but once it was done, life got so much better.
Anything *can* be added. Just the timing is not that good ATM.
>
> If 1.6 is going to happen fast, holding off on weld until then is no big deal.  If weld goes in to 1.5, it just looks like "business as usual" and the risk that OSGi never makes it in continues to grow.  If OSGi never makes it in, big waste of time, would have been easier to start anew today instead of play "kick the can" with everyone and end up empty handed.  I don't want any regrets, that just leads to frowns.
>
> Small releases, early and often.
>
> On Aug 23, 2011, at 3:46 AM, Martin Grigorov wrote:
>
>> -1 to add Weld now
>>
>> +1 to add Weld and OSGi in 1.5.(1|2) if they don't need API changes to
>> be able to work. If they need API changes then they'll have to wait
>> for 1.6.
>> I also hope 1.6.0 will need less time than 1.4->1.5.
>>
>> I'll revert WICKET-3976 soon.
>>
>> On Tue, Aug 23, 2011 at 10:37 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> bleh, this is turning into another prolonged discussion....
>>>
>>> why dont we just do this...release 1.5 and call it a day. weld can
>>> come in as a 1.5.1 or 1.5.2 addition - it doesnt touch any core code.
>>> osgi can wait for 1.6 where it can be implemented properly.
>>>
>>> i am changing my vote to -1 to include weld and -1 to include osgi.
>>> they all came in too late for 1.5 and i think i would rather push it
>>> out and worry about these things later.
>>>
>>> martin, revert the pom change you made for the osgi issue and i will
>>> build rc6 tomorrow. i think it has a good chance to become 1.5.0.
>>>
>>> -igor
>>>
>>> On Tue, Aug 23, 2011 at 12:23 AM, Brian Topping <to...@codehaus.org> wrote:
>>>> News flash:
>>>>
>>>> If you're going to include OSGi, go ahead and add Weld.  They are equally important.  Maybe not to you, but to some of us.
>>>>
>>>> Wicket 1.5 is not release candidate.  Features do not get added to release candidates.  Features do not even get added to alpha versions.  Read the Release Lifecycle 101 at http://en.wikipedia.org/wiki/Software_release_life_cycle.
>>>>
>>>> If Wicket is not RC, then the features Wicket needs to be a viable release should be added.  OSGi is one of them, regardless of whether it's one of your personal favorites or not (and your opinions are pretty clear in the public record).
>>>>
>>>> I pushed for OSGi in 1.5 knowing full well that the RC moniker was a charade and that I am just as uneasy of waiting for it as you guys appear to be uneasy of waiting for Weld integration.
>>>>
>>>> If 1.5 is released, the next opportunity to add features that would cause the modules to be restructured is 1.6, not 1.5.1.
>>>>
>>>> The reality is the RC fantasy should be aborted and the cycle set back to "development mode" so features like Weld can be added and the *proper* work done to add OSGi -- both with necessary module restructurings.
>>>>
>>>> Then when that is done, freeze features and start fixing bugs.  That's called "alpha".  Etc etc.
>>>>
>>>> I'll be clear, I think the Apache process has failed on Wicket and if preferential treatment is given to Weld without proper OSGi support also going in, it's going to be an unmitigated disaster that is worthy of a review by the Apache board.  It may be worthy of a review in any event.
>>>>
>>>> Back to the regularly scheduled programming....
>>>>
>>>> On Aug 22, 2011, at 6:11 PM, Martijn Dashorst wrote:
>>>>
>>>>> Wicket Weld is a really nice to have for wicket 1.5 and would increase
>>>>> the importance of our release pretty considerably. The issue with
>>>>> wicket-weld is that it requires java 6, and it is late in the release
>>>>> game for 1.5 final.
>>>>>
>>>>> We have experience with building mixed java releases (see our 1.3
>>>>> history), though the build process was not pretty.
>>>>>
>>>>> In order to enable wicket-weld we need to do the following IMO:
>>>>> - create java5 and java6 modules in trunk, each configured with the
>>>>> correct java version
>>>>> - commit wicket-weld as a submodule for the java 6 module
>>>>> - move wicket-examples to java 6 module
>>>>> - move all other wicket modules to the java 5 module
>>>>> - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>>>>> - fix the build script to run different maven setups utilizing a java
>>>>> 5 home directory and a java 6 home directory
>>>>> - fix the build script to run java 5 compilation first and then only
>>>>> java 6 for packaging (without clean) this will keep the java 5
>>>>> compiled classes and re-package them during the java 6 run
>>>>>
>>>>> This is some work, and as I said, we are late in the release game. If
>>>>> 1.5 final was this week I wouldn't propose to do this, but perhaps do
>>>>> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
>>>>> might do this now. I'm open to suggestions on whether to include
>>>>> wicket-weld or not.
>>>>>
>>>>> Martijn
>>>>>
>>>>> --
>>>>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>>>>
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: Wicket Weld into wicket 1.5?

Posted by Brian Topping <to...@codehaus.org>.
I agree with Martin's POV here, but with the additional caveat that API changes and module changes are the same thing, they break backwards compatibility and should be treated the same. Micro releases are bugfix releases.  Plain and simple.

Cleaning up the module structure so *anything* can be added should be a priority.  OSGi holds very little difference from the transition from C to C++ for people who were there for that.  It was a PITA to do it, but once it was done, life got so much better.

If 1.6 is going to happen fast, holding off on weld until then is no big deal.  If weld goes in to 1.5, it just looks like "business as usual" and the risk that OSGi never makes it in continues to grow.  If OSGi never makes it in, big waste of time, would have been easier to start anew today instead of play "kick the can" with everyone and end up empty handed.  I don't want any regrets, that just leads to frowns.  

Small releases, early and often.

On Aug 23, 2011, at 3:46 AM, Martin Grigorov wrote:

> -1 to add Weld now
> 
> +1 to add Weld and OSGi in 1.5.(1|2) if they don't need API changes to
> be able to work. If they need API changes then they'll have to wait
> for 1.6.
> I also hope 1.6.0 will need less time than 1.4->1.5.
> 
> I'll revert WICKET-3976 soon.
> 
> On Tue, Aug 23, 2011 at 10:37 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> bleh, this is turning into another prolonged discussion....
>> 
>> why dont we just do this...release 1.5 and call it a day. weld can
>> come in as a 1.5.1 or 1.5.2 addition - it doesnt touch any core code.
>> osgi can wait for 1.6 where it can be implemented properly.
>> 
>> i am changing my vote to -1 to include weld and -1 to include osgi.
>> they all came in too late for 1.5 and i think i would rather push it
>> out and worry about these things later.
>> 
>> martin, revert the pom change you made for the osgi issue and i will
>> build rc6 tomorrow. i think it has a good chance to become 1.5.0.
>> 
>> -igor
>> 
>> On Tue, Aug 23, 2011 at 12:23 AM, Brian Topping <to...@codehaus.org> wrote:
>>> News flash:
>>> 
>>> If you're going to include OSGi, go ahead and add Weld.  They are equally important.  Maybe not to you, but to some of us.
>>> 
>>> Wicket 1.5 is not release candidate.  Features do not get added to release candidates.  Features do not even get added to alpha versions.  Read the Release Lifecycle 101 at http://en.wikipedia.org/wiki/Software_release_life_cycle.
>>> 
>>> If Wicket is not RC, then the features Wicket needs to be a viable release should be added.  OSGi is one of them, regardless of whether it's one of your personal favorites or not (and your opinions are pretty clear in the public record).
>>> 
>>> I pushed for OSGi in 1.5 knowing full well that the RC moniker was a charade and that I am just as uneasy of waiting for it as you guys appear to be uneasy of waiting for Weld integration.
>>> 
>>> If 1.5 is released, the next opportunity to add features that would cause the modules to be restructured is 1.6, not 1.5.1.
>>> 
>>> The reality is the RC fantasy should be aborted and the cycle set back to "development mode" so features like Weld can be added and the *proper* work done to add OSGi -- both with necessary module restructurings.
>>> 
>>> Then when that is done, freeze features and start fixing bugs.  That's called "alpha".  Etc etc.
>>> 
>>> I'll be clear, I think the Apache process has failed on Wicket and if preferential treatment is given to Weld without proper OSGi support also going in, it's going to be an unmitigated disaster that is worthy of a review by the Apache board.  It may be worthy of a review in any event.
>>> 
>>> Back to the regularly scheduled programming....
>>> 
>>> On Aug 22, 2011, at 6:11 PM, Martijn Dashorst wrote:
>>> 
>>>> Wicket Weld is a really nice to have for wicket 1.5 and would increase
>>>> the importance of our release pretty considerably. The issue with
>>>> wicket-weld is that it requires java 6, and it is late in the release
>>>> game for 1.5 final.
>>>> 
>>>> We have experience with building mixed java releases (see our 1.3
>>>> history), though the build process was not pretty.
>>>> 
>>>> In order to enable wicket-weld we need to do the following IMO:
>>>> - create java5 and java6 modules in trunk, each configured with the
>>>> correct java version
>>>> - commit wicket-weld as a submodule for the java 6 module
>>>> - move wicket-examples to java 6 module
>>>> - move all other wicket modules to the java 5 module
>>>> - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>>>> - fix the build script to run different maven setups utilizing a java
>>>> 5 home directory and a java 6 home directory
>>>> - fix the build script to run java 5 compilation first and then only
>>>> java 6 for packaging (without clean) this will keep the java 5
>>>> compiled classes and re-package them during the java 6 run
>>>> 
>>>> This is some work, and as I said, we are late in the release game. If
>>>> 1.5 final was this week I wouldn't propose to do this, but perhaps do
>>>> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
>>>> might do this now. I'm open to suggestions on whether to include
>>>> wicket-weld or not.
>>>> 
>>>> Martijn
>>>> 
>>>> --
>>>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>>> 
>>> 
>>> 
>> 
> 
> 
> 
> -- 
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
> 


Re: Wicket Weld into wicket 1.5?

Posted by Martin Grigorov <mg...@apache.org>.
-1 to add Weld now

+1 to add Weld and OSGi in 1.5.(1|2) if they don't need API changes to
be able to work. If they need API changes then they'll have to wait
for 1.6.
I also hope 1.6.0 will need less time than 1.4->1.5.

I'll revert WICKET-3976 soon.

On Tue, Aug 23, 2011 at 10:37 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> bleh, this is turning into another prolonged discussion....
>
> why dont we just do this...release 1.5 and call it a day. weld can
> come in as a 1.5.1 or 1.5.2 addition - it doesnt touch any core code.
> osgi can wait for 1.6 where it can be implemented properly.
>
> i am changing my vote to -1 to include weld and -1 to include osgi.
> they all came in too late for 1.5 and i think i would rather push it
> out and worry about these things later.
>
> martin, revert the pom change you made for the osgi issue and i will
> build rc6 tomorrow. i think it has a good chance to become 1.5.0.
>
> -igor
>
> On Tue, Aug 23, 2011 at 12:23 AM, Brian Topping <to...@codehaus.org> wrote:
>> News flash:
>>
>> If you're going to include OSGi, go ahead and add Weld.  They are equally important.  Maybe not to you, but to some of us.
>>
>> Wicket 1.5 is not release candidate.  Features do not get added to release candidates.  Features do not even get added to alpha versions.  Read the Release Lifecycle 101 at http://en.wikipedia.org/wiki/Software_release_life_cycle.
>>
>> If Wicket is not RC, then the features Wicket needs to be a viable release should be added.  OSGi is one of them, regardless of whether it's one of your personal favorites or not (and your opinions are pretty clear in the public record).
>>
>> I pushed for OSGi in 1.5 knowing full well that the RC moniker was a charade and that I am just as uneasy of waiting for it as you guys appear to be uneasy of waiting for Weld integration.
>>
>> If 1.5 is released, the next opportunity to add features that would cause the modules to be restructured is 1.6, not 1.5.1.
>>
>> The reality is the RC fantasy should be aborted and the cycle set back to "development mode" so features like Weld can be added and the *proper* work done to add OSGi -- both with necessary module restructurings.
>>
>> Then when that is done, freeze features and start fixing bugs.  That's called "alpha".  Etc etc.
>>
>> I'll be clear, I think the Apache process has failed on Wicket and if preferential treatment is given to Weld without proper OSGi support also going in, it's going to be an unmitigated disaster that is worthy of a review by the Apache board.  It may be worthy of a review in any event.
>>
>> Back to the regularly scheduled programming....
>>
>> On Aug 22, 2011, at 6:11 PM, Martijn Dashorst wrote:
>>
>>> Wicket Weld is a really nice to have for wicket 1.5 and would increase
>>> the importance of our release pretty considerably. The issue with
>>> wicket-weld is that it requires java 6, and it is late in the release
>>> game for 1.5 final.
>>>
>>> We have experience with building mixed java releases (see our 1.3
>>> history), though the build process was not pretty.
>>>
>>> In order to enable wicket-weld we need to do the following IMO:
>>> - create java5 and java6 modules in trunk, each configured with the
>>> correct java version
>>> - commit wicket-weld as a submodule for the java 6 module
>>> - move wicket-examples to java 6 module
>>> - move all other wicket modules to the java 5 module
>>> - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>>> - fix the build script to run different maven setups utilizing a java
>>> 5 home directory and a java 6 home directory
>>> - fix the build script to run java 5 compilation first and then only
>>> java 6 for packaging (without clean) this will keep the java 5
>>> compiled classes and re-package them during the java 6 run
>>>
>>> This is some work, and as I said, we are late in the release game. If
>>> 1.5 final was this week I wouldn't propose to do this, but perhaps do
>>> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
>>> might do this now. I'm open to suggestions on whether to include
>>> wicket-weld or not.
>>>
>>> Martijn
>>>
>>> --
>>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>>
>>
>>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
bleh, this is turning into another prolonged discussion....

why dont we just do this...release 1.5 and call it a day. weld can
come in as a 1.5.1 or 1.5.2 addition - it doesnt touch any core code.
osgi can wait for 1.6 where it can be implemented properly.

i am changing my vote to -1 to include weld and -1 to include osgi.
they all came in too late for 1.5 and i think i would rather push it
out and worry about these things later.

martin, revert the pom change you made for the osgi issue and i will
build rc6 tomorrow. i think it has a good chance to become 1.5.0.

-igor

On Tue, Aug 23, 2011 at 12:23 AM, Brian Topping <to...@codehaus.org> wrote:
> News flash:
>
> If you're going to include OSGi, go ahead and add Weld.  They are equally important.  Maybe not to you, but to some of us.
>
> Wicket 1.5 is not release candidate.  Features do not get added to release candidates.  Features do not even get added to alpha versions.  Read the Release Lifecycle 101 at http://en.wikipedia.org/wiki/Software_release_life_cycle.
>
> If Wicket is not RC, then the features Wicket needs to be a viable release should be added.  OSGi is one of them, regardless of whether it's one of your personal favorites or not (and your opinions are pretty clear in the public record).
>
> I pushed for OSGi in 1.5 knowing full well that the RC moniker was a charade and that I am just as uneasy of waiting for it as you guys appear to be uneasy of waiting for Weld integration.
>
> If 1.5 is released, the next opportunity to add features that would cause the modules to be restructured is 1.6, not 1.5.1.
>
> The reality is the RC fantasy should be aborted and the cycle set back to "development mode" so features like Weld can be added and the *proper* work done to add OSGi -- both with necessary module restructurings.
>
> Then when that is done, freeze features and start fixing bugs.  That's called "alpha".  Etc etc.
>
> I'll be clear, I think the Apache process has failed on Wicket and if preferential treatment is given to Weld without proper OSGi support also going in, it's going to be an unmitigated disaster that is worthy of a review by the Apache board.  It may be worthy of a review in any event.
>
> Back to the regularly scheduled programming....
>
> On Aug 22, 2011, at 6:11 PM, Martijn Dashorst wrote:
>
>> Wicket Weld is a really nice to have for wicket 1.5 and would increase
>> the importance of our release pretty considerably. The issue with
>> wicket-weld is that it requires java 6, and it is late in the release
>> game for 1.5 final.
>>
>> We have experience with building mixed java releases (see our 1.3
>> history), though the build process was not pretty.
>>
>> In order to enable wicket-weld we need to do the following IMO:
>> - create java5 and java6 modules in trunk, each configured with the
>> correct java version
>> - commit wicket-weld as a submodule for the java 6 module
>> - move wicket-examples to java 6 module
>> - move all other wicket modules to the java 5 module
>> - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>> - fix the build script to run different maven setups utilizing a java
>> 5 home directory and a java 6 home directory
>> - fix the build script to run java 5 compilation first and then only
>> java 6 for packaging (without clean) this will keep the java 5
>> compiled classes and re-package them during the java 6 run
>>
>> This is some work, and as I said, we are late in the release game. If
>> 1.5 final was this week I wouldn't propose to do this, but perhaps do
>> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
>> might do this now. I'm open to suggestions on whether to include
>> wicket-weld or not.
>>
>> Martijn
>>
>> --
>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>
>
>

Re: Wicket Weld into wicket 1.5?

Posted by Brian Topping <to...@codehaus.org>.
News flash:

If you're going to include OSGi, go ahead and add Weld.  They are equally important.  Maybe not to you, but to some of us. 

Wicket 1.5 is not release candidate.  Features do not get added to release candidates.  Features do not even get added to alpha versions.  Read the Release Lifecycle 101 at http://en.wikipedia.org/wiki/Software_release_life_cycle.  

If Wicket is not RC, then the features Wicket needs to be a viable release should be added.  OSGi is one of them, regardless of whether it's one of your personal favorites or not (and your opinions are pretty clear in the public record).  

I pushed for OSGi in 1.5 knowing full well that the RC moniker was a charade and that I am just as uneasy of waiting for it as you guys appear to be uneasy of waiting for Weld integration.  

If 1.5 is released, the next opportunity to add features that would cause the modules to be restructured is 1.6, not 1.5.1.  

The reality is the RC fantasy should be aborted and the cycle set back to "development mode" so features like Weld can be added and the *proper* work done to add OSGi -- both with necessary module restructurings.  

Then when that is done, freeze features and start fixing bugs.  That's called "alpha".  Etc etc.

I'll be clear, I think the Apache process has failed on Wicket and if preferential treatment is given to Weld without proper OSGi support also going in, it's going to be an unmitigated disaster that is worthy of a review by the Apache board.  It may be worthy of a review in any event.

Back to the regularly scheduled programming....

On Aug 22, 2011, at 6:11 PM, Martijn Dashorst wrote:

> Wicket Weld is a really nice to have for wicket 1.5 and would increase
> the importance of our release pretty considerably. The issue with
> wicket-weld is that it requires java 6, and it is late in the release
> game for 1.5 final.
> 
> We have experience with building mixed java releases (see our 1.3
> history), though the build process was not pretty.
> 
> In order to enable wicket-weld we need to do the following IMO:
> - create java5 and java6 modules in trunk, each configured with the
> correct java version
> - commit wicket-weld as a submodule for the java 6 module
> - move wicket-examples to java 6 module
> - move all other wicket modules to the java 5 module
> - fix the wicket parent pom to have a java 5 profile and a java 6 profile
> - fix the build script to run different maven setups utilizing a java
> 5 home directory and a java 6 home directory
> - fix the build script to run java 5 compilation first and then only
> java 6 for packaging (without clean) this will keep the java 5
> compiled classes and re-package them during the java 6 run
> 
> This is some work, and as I said, we are late in the release game. If
> 1.5 final was this week I wouldn't propose to do this, but perhaps do
> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
> might do this now. I'm open to suggestions on whether to include
> wicket-weld or not.
> 
> Martijn
> 
> -- 
> Become a Wicket expert, learn from the best: http://wicketinaction.com
> 


Re: Wicket Weld into wicket 1.5?

Posted by Ron Smits <ro...@gmail.com>.
One way or the other weld will be used with wicket. Personally I should
think wicket-weld should have the same status and place as wicket-spring.
Placing it somewhere else would only be confusing.

just my 2 cts

Ron
I Haven't Lost My Mind - It's Backed Up On Disk Somewhere


On Tue, Aug 23, 2011 at 08:44, Emond Papegaaij
<em...@topicus.nl>wrote:

> Although I really like having Weld available, I'm against putting it in
> 1.5.
> The RC phase for 1.5 is already taking way too long and adding new
> functionallity will not make it go faster. Another thing is that the
> current
> wicket-weld is still immature. It does work, but the API is not yet
> crystallized. For example, objects managed by weld are not detached at the
> end
> of a request. Other things will probably pop up once we start using it
> more.
>
> I don't see any reason why Wicket Weld should be part of 1.5 right away.
> Why
> can't it be part of wicketstuff for the duration of 1.5 and moved to Wicket
> with 1.6? Wicketstuff already has the infrastructure for Java 6 and it
> gives a
> bit more freedom to change/improve the API in the next few months.
>
> Best regards,
> Emond
>
> On Tuesday 23 August 2011 00:11:54 Martijn Dashorst wrote:
> > Wicket Weld is a really nice to have for wicket 1.5 and would increase
> > the importance of our release pretty considerably. The issue with
> > wicket-weld is that it requires java 6, and it is late in the release
> > game for 1.5 final.
> >
> > We have experience with building mixed java releases (see our 1.3
> > history), though the build process was not pretty.
> >
> > In order to enable wicket-weld we need to do the following IMO:
> >  - create java5 and java6 modules in trunk, each configured with the
> > correct java version
> >  - commit wicket-weld as a submodule for the java 6 module
> >  - move wicket-examples to java 6 module
> >  - move all other wicket modules to the java 5 module
> >  - fix the wicket parent pom to have a java 5 profile and a java 6
> profile
> >  - fix the build script to run different maven setups utilizing a java
> > 5 home directory and a java 6 home directory
> >  - fix the build script to run java 5 compilation first and then only
> > java 6 for packaging (without clean) this will keep the java 5
> > compiled classes and re-package them during the java 6 run
> >
> > This is some work, and as I said, we are late in the release game. If
> > 1.5 final was this week I wouldn't propose to do this, but perhaps do
> > it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
> > might do this now. I'm open to suggestions on whether to include
> > wicket-weld or not.
> >
> > Martijn
>

Re: Wicket Weld into wicket 1.5?

Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Aug 23, 2011 at 9:13 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> On Tue, Aug 23, 2011 at 8:04 AM, Emond Papegaaij
> <em...@topicus.nl> wrote:
>> On Tuesday 23 August 2011 16:17:43 Igor Vaynberg wrote:
>>> On Tue, Aug 23, 2011 at 1:16 AM, Emond Papegaaij
>>>
>>> <em...@topicus.nl> wrote:
>>> > On Tuesday 23 August 2011 09:04:00 Igor Vaynberg wrote:
>>> >> On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
>>> >>
>>> >> <em...@topicus.nl> wrote:
>>> >> > For example, objects managed by weld are not detached at the end
>>> >> > of a request.
>>> >>
>>> >> erm? what is supposed to happen when?
>>> >>
>>> >> -igor
>>> >
>>> > That's something I'm not entirely sure of. The current implementation
>>> > makes it cumbersome to work with models inside scoped objects (requests
>>> > can share the same objects instances, causing multi-threading issues).
>>> > I'm aware of the fact that is inherent to the way the scopes work, but
>>> > it would be nice to have wicket-weld provide a way to cope with this.
>>> > Putting it in 1.5 leaves no time to (try to) develop an api to deal with
>>> > this.
>>>
>>> not entirely sure what you mean. requestsope and conversation scopes
>>> are threadsafe. session and application scopes are not, but that is
>>> something you have to be aware of and deal with just like with any
>>> other IOC framework...
>>
>> Are you sure that conversation scopes are threadsafe? The same conversation
>> can be shared across multiple requests. When some of these requests happen
>> simultaneously, I expect the conversation scoped objects to be accessed in a
>> multithreaded way.
>> I do not yet know how to cope with this, but it is something I will be
>> investigating in the next couple of days. Perhaps, wicket-weld (or cdi) needs
>> its own representation for the conversation scope, just as it has its own
>> applicatoin, session and request objects.
>
> from the spec
>
> """The container ensures that a long-running conversation may be
> associated with at most one request at a time, by blocking
> or rejecting concurrent requests. If the container rejects a request,
> it must associate the request with a new transient conversation
> and throw an exception of type
> javax.enterprise.context.BusyConversationException..."""
>
>>> > Igor:
>>> > Did you move your code for wicket-weld to another place, or did you
>>> > delete it? We are really interested in this code, and are currently
>>> > adding it to our project. For now I've resurrected it at
>>> > github.com/papegaaij/wicket-weld. It would be nice if it is placed
>>> > somewhere more central, where it could be developed further to be
>>> > included in Wicket at some later time.
>>>
>>> i will be moving it into 42lines github repo today. i was going to
>>> move it to wicketstuff but that is not possible because weld artifacts
>>> are not in central yet.
>>
>> Great. Could you post the location on this list when you placed it there, so I
>> can clone it? For now, we at Topicus will be maintaining or own clone, to
>> allow us to follow our own release management, but it would be great if we can
>> sync it with an 'upstream' repo.
>
> will do....
>
>>
>> I'm still quite new to CDI and Weld. Do you know any good resources (books?)
>> on this? I've found the Weld documentation very useful, but it's more of a
>> reference guide, rather than a book.
>
> i didnt use a book, so dont know of any good ones out there. sorry.
ivaynberg writes books, he don't read books!
>
> -igor
>
>>
>> Emond
>>
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
On Tue, Aug 23, 2011 at 8:04 AM, Emond Papegaaij
<em...@topicus.nl> wrote:
> On Tuesday 23 August 2011 16:17:43 Igor Vaynberg wrote:
>> On Tue, Aug 23, 2011 at 1:16 AM, Emond Papegaaij
>>
>> <em...@topicus.nl> wrote:
>> > On Tuesday 23 August 2011 09:04:00 Igor Vaynberg wrote:
>> >> On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
>> >>
>> >> <em...@topicus.nl> wrote:
>> >> > For example, objects managed by weld are not detached at the end
>> >> > of a request.
>> >>
>> >> erm? what is supposed to happen when?
>> >>
>> >> -igor
>> >
>> > That's something I'm not entirely sure of. The current implementation
>> > makes it cumbersome to work with models inside scoped objects (requests
>> > can share the same objects instances, causing multi-threading issues).
>> > I'm aware of the fact that is inherent to the way the scopes work, but
>> > it would be nice to have wicket-weld provide a way to cope with this.
>> > Putting it in 1.5 leaves no time to (try to) develop an api to deal with
>> > this.
>>
>> not entirely sure what you mean. requestsope and conversation scopes
>> are threadsafe. session and application scopes are not, but that is
>> something you have to be aware of and deal with just like with any
>> other IOC framework...
>
> Are you sure that conversation scopes are threadsafe? The same conversation
> can be shared across multiple requests. When some of these requests happen
> simultaneously, I expect the conversation scoped objects to be accessed in a
> multithreaded way.
> I do not yet know how to cope with this, but it is something I will be
> investigating in the next couple of days. Perhaps, wicket-weld (or cdi) needs
> its own representation for the conversation scope, just as it has its own
> applicatoin, session and request objects.

from the spec

"""The container ensures that a long-running conversation may be
associated with at most one request at a time, by blocking
or rejecting concurrent requests. If the container rejects a request,
it must associate the request with a new transient conversation
and throw an exception of type
javax.enterprise.context.BusyConversationException..."""

>> > Igor:
>> > Did you move your code for wicket-weld to another place, or did you
>> > delete it? We are really interested in this code, and are currently
>> > adding it to our project. For now I've resurrected it at
>> > github.com/papegaaij/wicket-weld. It would be nice if it is placed
>> > somewhere more central, where it could be developed further to be
>> > included in Wicket at some later time.
>>
>> i will be moving it into 42lines github repo today. i was going to
>> move it to wicketstuff but that is not possible because weld artifacts
>> are not in central yet.
>
> Great. Could you post the location on this list when you placed it there, so I
> can clone it? For now, we at Topicus will be maintaining or own clone, to
> allow us to follow our own release management, but it would be great if we can
> sync it with an 'upstream' repo.

will do....

>
> I'm still quite new to CDI and Weld. Do you know any good resources (books?)
> on this? I've found the Weld documentation very useful, but it's more of a
> reference guide, rather than a book.

i didnt use a book, so dont know of any good ones out there. sorry.

-igor

>
> Emond
>

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
On Tue, Aug 23, 2011 at 8:04 AM, Emond Papegaaij
<em...@topicus.nl> wrote:
>> > Did you move your code for wicket-weld to another place, or did you
>> > delete it? We are really interested in this code, and are currently
>> > adding it to our project. For now I've resurrected it at
>> > github.com/papegaaij/wicket-weld. It would be nice if it is placed
>> > somewhere more central, where it could be developed further to be
>> > included in Wicket at some later time.

https://github.com/42Lines/wicket-cdi

-igor

Re: Wicket Weld into wicket 1.5?

Posted by Emond Papegaaij <em...@topicus.nl>.
On Tuesday 23 August 2011 16:17:43 Igor Vaynberg wrote:
> On Tue, Aug 23, 2011 at 1:16 AM, Emond Papegaaij
> 
> <em...@topicus.nl> wrote:
> > On Tuesday 23 August 2011 09:04:00 Igor Vaynberg wrote:
> >> On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
> >> 
> >> <em...@topicus.nl> wrote:
> >> > For example, objects managed by weld are not detached at the end
> >> > of a request.
> >> 
> >> erm? what is supposed to happen when?
> >> 
> >> -igor
> > 
> > That's something I'm not entirely sure of. The current implementation
> > makes it cumbersome to work with models inside scoped objects (requests
> > can share the same objects instances, causing multi-threading issues).
> > I'm aware of the fact that is inherent to the way the scopes work, but
> > it would be nice to have wicket-weld provide a way to cope with this.
> > Putting it in 1.5 leaves no time to (try to) develop an api to deal with
> > this.
> 
> not entirely sure what you mean. requestsope and conversation scopes
> are threadsafe. session and application scopes are not, but that is
> something you have to be aware of and deal with just like with any
> other IOC framework...

Are you sure that conversation scopes are threadsafe? The same conversation 
can be shared across multiple requests. When some of these requests happen 
simultaneously, I expect the conversation scoped objects to be accessed in a 
multithreaded way.

I do not yet know how to cope with this, but it is something I will be 
investigating in the next couple of days. Perhaps, wicket-weld (or cdi) needs 
its own representation for the conversation scope, just as it has its own 
applicatoin, session and request objects.

> > Igor:
> > Did you move your code for wicket-weld to another place, or did you
> > delete it? We are really interested in this code, and are currently
> > adding it to our project. For now I've resurrected it at
> > github.com/papegaaij/wicket-weld. It would be nice if it is placed
> > somewhere more central, where it could be developed further to be
> > included in Wicket at some later time.
> 
> i will be moving it into 42lines github repo today. i was going to
> move it to wicketstuff but that is not possible because weld artifacts
> are not in central yet.

Great. Could you post the location on this list when you placed it there, so I 
can clone it? For now, we at Topicus will be maintaining or own clone, to 
allow us to follow our own release management, but it would be great if we can 
sync it with an 'upstream' repo.

I'm still quite new to CDI and Weld. Do you know any good resources (books?) 
on this? I've found the Weld documentation very useful, but it's more of a 
reference guide, rather than a book.

Emond

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
On Tue, Aug 23, 2011 at 1:16 AM, Emond Papegaaij
<em...@topicus.nl> wrote:
> On Tuesday 23 August 2011 09:04:00 Igor Vaynberg wrote:
>> On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
>>
>> <em...@topicus.nl> wrote:
>> > For example, objects managed by weld are not detached at the end
>> > of a request.
>>
>> erm? what is supposed to happen when?
>>
>> -igor
>
> That's something I'm not entirely sure of. The current implementation makes it
> cumbersome to work with models inside scoped objects (requests can share the
> same objects instances, causing multi-threading issues). I'm aware of the fact
> that is inherent to the way the scopes work, but it would be nice to have
> wicket-weld provide a way to cope with this. Putting it in 1.5 leaves no time
> to (try to) develop an api to deal with this.

not entirely sure what you mean. requestsope and conversation scopes
are threadsafe. session and application scopes are not, but that is
something you have to be aware of and deal with just like with any
other IOC framework...

> Igor:
> Did you move your code for wicket-weld to another place, or did you delete it?
> We are really interested in this code, and are currently adding it to our
> project. For now I've resurrected it at github.com/papegaaij/wicket-weld. It
> would be nice if it is placed somewhere more central, where it could be
> developed further to be included in Wicket at some later time.

i will be moving it into 42lines github repo today. i was going to
move it to wicketstuff but that is not possible because weld artifacts
are not in central yet.

-igor


>
> Best regards,
> Emond
>

Re: Wicket Weld into wicket 1.5?

Posted by Emond Papegaaij <em...@topicus.nl>.
On Tuesday 23 August 2011 09:04:00 Igor Vaynberg wrote:
> On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
> 
> <em...@topicus.nl> wrote:
> > For example, objects managed by weld are not detached at the end
> > of a request.
> 
> erm? what is supposed to happen when?
> 
> -igor

That's something I'm not entirely sure of. The current implementation makes it 
cumbersome to work with models inside scoped objects (requests can share the 
same objects instances, causing multi-threading issues). I'm aware of the fact 
that is inherent to the way the scopes work, but it would be nice to have 
wicket-weld provide a way to cope with this. Putting it in 1.5 leaves no time 
to (try to) develop an api to deal with this.

Igor:
Did you move your code for wicket-weld to another place, or did you delete it? 
We are really interested in this code, and are currently adding it to our 
project. For now I've resurrected it at github.com/papegaaij/wicket-weld. It 
would be nice if it is placed somewhere more central, where it could be 
developed further to be included in Wicket at some later time.

Best regards,
Emond

Re: Wicket Weld into wicket 1.5?

Posted by Igor Vaynberg <ig...@gmail.com>.
On Mon, Aug 22, 2011 at 11:44 PM, Emond Papegaaij
<em...@topicus.nl> wrote:

> For example, objects managed by weld are not detached at the end
> of a request.

erm? what is supposed to happen when?

-igor

Re: Wicket Weld into wicket 1.5?

Posted by Sven Meier <sv...@meiers.net>.
I'm +0 on integrating this into 1.5, it could equally well just be put into
wicketstuff. We can still "graduate" it into Wicket later on.

BTW why is this module named wicket-weld and not wicket-cdi?

Sven

--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-Weld-into-wicket-1-5-tp3761463p3762018.html
Sent from the Forum for Wicket Core developers mailing list archive at Nabble.com.

Re: Wicket Weld into wicket 1.5?

Posted by Emond Papegaaij <em...@topicus.nl>.
Although I really like having Weld available, I'm against putting it in 1.5. 
The RC phase for 1.5 is already taking way too long and adding new 
functionallity will not make it go faster. Another thing is that the current 
wicket-weld is still immature. It does work, but the API is not yet 
crystallized. For example, objects managed by weld are not detached at the end 
of a request. Other things will probably pop up once we start using it more.

I don't see any reason why Wicket Weld should be part of 1.5 right away. Why 
can't it be part of wicketstuff for the duration of 1.5 and moved to Wicket 
with 1.6? Wicketstuff already has the infrastructure for Java 6 and it gives a 
bit more freedom to change/improve the API in the next few months.

Best regards,
Emond

On Tuesday 23 August 2011 00:11:54 Martijn Dashorst wrote:
> Wicket Weld is a really nice to have for wicket 1.5 and would increase
> the importance of our release pretty considerably. The issue with
> wicket-weld is that it requires java 6, and it is late in the release
> game for 1.5 final.
> 
> We have experience with building mixed java releases (see our 1.3
> history), though the build process was not pretty.
> 
> In order to enable wicket-weld we need to do the following IMO:
>  - create java5 and java6 modules in trunk, each configured with the
> correct java version
>  - commit wicket-weld as a submodule for the java 6 module
>  - move wicket-examples to java 6 module
>  - move all other wicket modules to the java 5 module
>  - fix the wicket parent pom to have a java 5 profile and a java 6 profile
>  - fix the build script to run different maven setups utilizing a java
> 5 home directory and a java 6 home directory
>  - fix the build script to run java 5 compilation first and then only
> java 6 for packaging (without clean) this will keep the java 5
> compiled classes and re-package them during the java 6 run
> 
> This is some work, and as I said, we are late in the release game. If
> 1.5 final was this week I wouldn't propose to do this, but perhaps do
> it in 1.5.1 or 1.5.2. However, since 1.5-rc6 is still not complete we
> might do this now. I'm open to suggestions on whether to include
> wicket-weld or not.
> 
> Martijn