You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/04 18:45:09 UTC
[GitHub] [phoenix] mihir6692 opened a new pull request #722: PHOENIX-5756
Remove Thread.sleep usage from QueryLoggerIT
mihir6692 opened a new pull request #722: PHOENIX-5756 Remove Thread.sleep usage from QueryLoggerIT
URL: https://github.com/apache/phoenix/pull/722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] mihir6692 commented on issue #722: PHOENIX-5756 Remove
Thread.sleep usage from QueryLoggerIT
Posted by GitBox <gi...@apache.org>.
mihir6692 commented on issue #722: PHOENIX-5756 Remove Thread.sleep usage from QueryLoggerIT
URL: https://github.com/apache/phoenix/pull/722#issuecomment-595095879
Yes, i would take a deeper look at it as this test fails in PreCommit but passes in local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] ankitsinghal commented on issue #722: PHOENIX-5756 Remove
Thread.sleep usage from QueryLoggerIT
Posted by GitBox <gi...@apache.org>.
ankitsinghal commented on issue #722: PHOENIX-5756 Remove Thread.sleep usage from QueryLoggerIT
URL: https://github.com/apache/phoenix/pull/722#issuecomment-594762030
Thanks @mihir6692 for the pull request, do we know what change we did in async logging that we don't require sleep now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services