You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by cheng xu <ch...@intel.com> on 2014/08/01 04:32:08 UTC
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 2:32 a.m.)
Review request for hive.
Changes
-------
(1) get rid of creating csv preference for each row and only update it when delimiter changed in DSV mode
(2) fix some other minor issues according to Lars comments
Bugs: HIVE-7390
https://issues.apache.org/jira/browse/HIVE-7390
Repository: hive-git
Description
-------
HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
Diffs (updated)
-----
beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
beeline/src/java/org/apache/hive/beeline/BeeLine.java 528a98e29c23421f9352bdf7c5edd3a9fae0e3ea
beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 75f7d38cb97fb753a8f39c19488b9ce0a8d77590
beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
beeline/src/main/resources/BeeLine.properties 390d062b8dc52dfa790c7351f3db44c1e0dd7e37
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
-------
Thanks,
cheng xu
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by Lars Francke <as...@lars-francke.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49325
-----------------------------------------------------------
Ship it!
Two last minor nit-picks. Apart from that it looks good! Thank you for taking care of all my comments.
beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/23799/#comment86303>
space missing
beeline/src/main/resources/BeeLine.properties
<https://reviews.apache.org/r/23799/#comment86305>
I suggest
specify the delimiter for delimiter-separated values output format (default: |)\n \
instead
- Lars Francke
On Aug. 1, 2014, 2:32 a.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23799/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 2:32 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7390
> https://issues.apache.org/jira/browse/HIVE-7390
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
>
>
> Diffs
> -----
>
> beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 528a98e29c23421f9352bdf7c5edd3a9fae0e3ea
> beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 75f7d38cb97fb753a8f39c19488b9ce0a8d77590
> beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
> beeline/src/main/resources/BeeLine.properties 390d062b8dc52dfa790c7351f3db44c1e0dd7e37
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
> pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
>
> Diff: https://reviews.apache.org/r/23799/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by cheng xu <ch...@intel.com>.
> On Aug. 6, 2014, 5:50 a.m., Lars Francke wrote:
> > I don't think this latest patch is the one you wanted to upload?
I rebased the code to the latest and it has some difference comparing to the v6.
- cheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49698
-----------------------------------------------------------
On Aug. 6, 2014, 5:41 a.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23799/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:41 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7390
> https://issues.apache.org/jira/browse/HIVE-7390
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
>
>
> Diffs
> -----
>
> beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad
> beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java a1e07a090c222be42a381fa2052f0bda97867432
> beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
> beeline/src/main/resources/BeeLine.properties ddb0ba74d4bd3f0255eeb7d791eb28108c474ae1
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
> pom.xml b3216e1ea4abcf692a933024d415754322210d59
>
> Diff: https://reviews.apache.org/r/23799/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by Lars Francke <as...@lars-francke.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49698
-----------------------------------------------------------
I don't think this latest patch is the one you wanted to upload?
- Lars Francke
On Aug. 6, 2014, 5:41 a.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23799/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:41 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7390
> https://issues.apache.org/jira/browse/HIVE-7390
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
>
>
> Diffs
> -----
>
> beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad
> beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java a1e07a090c222be42a381fa2052f0bda97867432
> beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
> beeline/src/main/resources/BeeLine.properties ddb0ba74d4bd3f0255eeb7d791eb28108c474ae1
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
> pom.xml b3216e1ea4abcf692a933024d415754322210d59
>
> Diff: https://reviews.apache.org/r/23799/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 5:41 a.m.)
Review request for hive.
Changes
-------
add related help to the beeline.properties file about the new option "delimiterForDSV"
Bugs: HIVE-7390
https://issues.apache.org/jira/browse/HIVE-7390
Repository: hive-git
Description
-------
HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
Diffs (updated)
-----
beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
beeline/src/java/org/apache/hive/beeline/BeeLine.java 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad
beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java a1e07a090c222be42a381fa2052f0bda97867432
beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
beeline/src/main/resources/BeeLine.properties ddb0ba74d4bd3f0255eeb7d791eb28108c474ae1
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b3216e1ea4abcf692a933024d415754322210d59
Diff: https://reviews.apache.org/r/23799/diff/
Testing
-------
Thanks,
cheng xu
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/#review49673
-----------------------------------------------------------
Just one minor comment
beeline/src/main/resources/BeeLine.properties
<https://reviews.apache.org/r/23799/#comment86956>
Do we need to put a help for 'delimiterForDSV'?
- Szehon Ho
On Aug. 1, 2014, 4:15 p.m., cheng xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23799/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 4:15 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7390
> https://issues.apache.org/jira/browse/HIVE-7390
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
>
>
> Diffs
> -----
>
> beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 528a98e29c23421f9352bdf7c5edd3a9fae0e3ea
> beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 75f7d38cb97fb753a8f39c19488b9ce0a8d77590
> beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
> beeline/src/main/resources/BeeLine.properties 390d062b8dc52dfa790c7351f3db44c1e0dd7e37
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
> pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
>
> Diff: https://reviews.apache.org/r/23799/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cheng xu
>
>
Re: Review Request 23799: HIVE-7390: refactor csv output format with in RFC
mode and add one more option to support formatting as the csv format in
hive cli
Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23799/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 4:15 p.m.)
Review request for hive.
Changes
-------
deal with some format issues and thanks again for Lars's comments.
Bugs: HIVE-7390
https://issues.apache.org/jira/browse/HIVE-7390
Repository: hive-git
Description
-------
HIVE-7390: refactor csv output format with in RFC mode and add one more option to support formatting as the csv format in hive cli
Diffs (updated)
-----
beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1
beeline/src/java/org/apache/hive/beeline/BeeLine.java 528a98e29c23421f9352bdf7c5edd3a9fae0e3ea
beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 75f7d38cb97fb753a8f39c19488b9ce0a8d77590
beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053
beeline/src/main/resources/BeeLine.properties 390d062b8dc52dfa790c7351f3db44c1e0dd7e37
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d
Diff: https://reviews.apache.org/r/23799/diff/
Testing
-------
Thanks,
cheng xu