[GitHub] [kibble] turbaszek commented on issue #27: Tests Needs

[GitBox <gi...@apache.org>]

turbaszek commented on issue #27:
URL: https://github.com/apache/kibble/issues/27#issuecomment-704392461


   +1 for introducing pre-commit. It will allow us to assert code quality as a first step and then we can add tests that can also be run using this tool (+ pytest). 
   
   If someone is not familiar with this framework - it's a simple tool that allows users to share and install git hooks that are run before commit. In this way the code quality (and more) is checked even before making a contribution. Of course - it's not necessary but it helps a lot. We use this in Apache Airflow to automatically verify multiple things such as code style, language style (no black and white lists and so on) and formatting of documentation 👍 
   
   Probably it would be good to consider using some CI to avoid regression in the future. WDYT @Humbedooh @sharanf @michalslowikowski00 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org