[GitHub] [flink] PatrickRen commented on a change in pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

[GitBox <gi...@apache.org>]

PatrickRen commented on a change in pull request #18137:
URL: https://github.com/apache/flink/pull/18137#discussion_r783783851



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerWithPulsarEnvironment.java
##########
@@ -43,12 +44,10 @@ private static String resourcePath(String jarName) {
         return TestUtils.getResource(jarName).toAbsolutePath().toString();
     }
 
-    @Override
-    protected Configuration flinkConfiguration() {
-        Configuration configuration = super.flinkConfiguration();
+    protected static Configuration getClusterConfiguration() {
+        Configuration configuration = new Configuration();
         // Increase the off heap memory for avoiding direct buffer memory error on Pulsar e2e tests.
         configuration.set(TASK_OFF_HEAP_MEMORY, MemorySize.ofMebiBytes(100));

Review comment:
       Actually we can remove this class. I think the initial purpose of this is for passing additional Flink configuration to FlnkContainersTestEnvironment. I added a constructor for supporting this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org