You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:23:47 UTC
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #591: Fix: Nacos client logDir path seperator
codecov-commenter edited a comment on pull request #591:
URL: https://github.com/apache/dubbo-go/pull/591#issuecomment-640994669
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=h1) Report
> Merging [#591](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/106040d53d8e0f799615fd3f4796fb2c9008d9fc&el=desc) will **increase** coverage by `0.59%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #591 +/- ##
===========================================
+ Coverage 66.80% 67.39% +0.59%
===========================================
Files 185 188 +3
Lines 9749 9858 +109
===========================================
+ Hits 6513 6644 +131
+ Misses 2600 2560 -40
- Partials 636 654 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `74.79% <66.66%> (+19.24%)` | :arrow_up: |
| [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `56.81% <0.00%> (-9.10%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0.00%> (-5.38%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `70.83% <0.00%> (-1.64%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [cluster/cluster\_impl/failover\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbG92ZXJfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.15% <0.00%> (-1.19%)` | :arrow_down: |
| [cluster/cluster\_impl/forking\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZm9ya2luZ19jbHVzdGVyX2ludm9rZXIuZ28=) | `58.33% <0.00%> (-0.21%)` | :arrow_down: |
| [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <0.00%> (ø)` | |
| [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <0.00%> (ø)` | |
| [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <0.00%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/dubbo-go/pull/591/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=footer). Last update [106040d...c698284](https://codecov.io/gh/apache/dubbo-go/pull/591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org