You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2022/07/31 14:40:14 UTC
[rocketmq] branch develop updated: [ISSUE #4741] Optimize ReplicasManager constructor, remove redundant code (#4743)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 58c3af964 [ISSUE #4741] Optimize ReplicasManager constructor, remove redundant code (#4743)
58c3af964 is described below
commit 58c3af96451b39512eaa3f96f7b35bb0118e648d
Author: mxsm <lj...@gmail.com>
AuthorDate: Sun Jul 31 22:39:55 2022 +0800
[ISSUE #4741] Optimize ReplicasManager constructor, remove redundant code (#4743)
---
.../java/org/apache/rocketmq/broker/controller/ReplicasManager.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java b/broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
index 4e0517940..374fedfb3 100644
--- a/broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
+++ b/broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java
@@ -81,8 +81,7 @@ public class ReplicasManager {
this.executorService = Executors.newFixedThreadPool(3, new ThreadFactoryImpl("ReplicasManager_ExecutorService_", brokerController.getBrokerIdentity()));
this.haService = (AutoSwitchHAService) brokerController.getMessageStore().getHaService();
this.brokerConfig = brokerController.getBrokerConfig();
- final BrokerConfig brokerConfig = brokerController.getBrokerConfig();
- final String controllerPaths = brokerConfig.getControllerAddr();
+ final String controllerPaths = this.brokerConfig.getControllerAddr();
final String[] controllers = controllerPaths.split(";");
assert controllers.length > 0;
this.controllerAddresses = new ArrayList<>(Arrays.asList(controllers));
@@ -111,8 +110,7 @@ public class ReplicasManager {
}
retryTimes++;
LOGGER.warn("Failed to start replicasManager, retry times:{}, current state:{}, try it again", retryTimes, this.state);
- }
- while (!startBasicService());
+ } while (!startBasicService());
LOGGER.info("Start replicasManager success, retry times:{}", retryTimes);
});