You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by atrbgithub <gi...@git.apache.org> on 2015/10/12 19:18:58 UTC
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
GitHub user atrbgithub opened a pull request:
https://github.com/apache/cloudstack/pull/925
Fix for CLOUDSTACK-8937 - XenServer migrations with storage failing i…
…n clustered management server environment
This pull request relates to the following Jira bug report:
https://issues.apache.org/jira/browse/CLOUDSTACK-8937
This has been tested by checking out the tagged 4.5.2 release, making the changes detailed, compiling and then copying the webapps/client/WEB-INF/lib/cloud-plugin-hypervisor-xenserver-4.5.2.jar file into a 4.5.2 cluster of 4 management servers. The cluster is running two xenserver pods, the hosts of which are running Xenserver 6.5.
Live migrations have then been tested with vm's which have single and multiple disks on local storage. Tests have only been performed on live migrations within the same pod.
Prior to this fix, migrations would intermittently fail (details in the above jira link). With this fix in place, no further issues have been seen.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/autotraderuk/cloudstack 4.5-CS-8937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/925.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #925
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-150836810
Hi @atrbgithub Thanks for your response. We indeed need to reimplement your fix on current master. Once that is in place and tested, we merge it on master (that will soon become 4.6.0). Then we can merge this PR (with the same functionality) to 4.5 and it will be in 4.5.3. It cannot go into 4.5.3 before it is also in master. Let me know if you need help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-154042688
Fix for master branch has been proposed here https://github.com/apache/cloudstack/pull/1037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-150595815
Hi Remi, I've forced-pushed the commit (amended the commit message and re-pushed) and it looks like the tests are running once more. I had a look at making a similar change to the 4.6 branch however it looks like a lot of refactoring has taken place between the 4.5 branch and master. Please see https://github.com/apache/cloudstack/commit/30e72e4a156a224f109f67b277e1e439bdcc9158 for example.
We're currently running with 4.5.2 (live and test) internally and this change appears to have fixed the issues we were seeing. Perhaps if there is ever a 4.5.3 release, this could be included with it.
It's possible we could upgrade our internal test environment to master to see how the migrations are working now with the refactored code, but I won't get chance to do this for another few weeks unfortunately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-158860647
Anyone tested this patch yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/925#issuecomment-150550247
Hi @atrbgithub thanks for the patch! Can you supply this patch also to master? We can only merge it, if it enters master first (will change soon, but right now this is it). Otherwise this will break when upgrading from 4.5 to 4.6 etc.
Please force-push to trigger another Jenkins build. if it fails, please check why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #925: Fix for CLOUDSTACK-8937 - XenServer migrations with s...
Posted by atrbgithub <gi...@git.apache.org>.
Github user atrbgithub commented on the issue:
https://github.com/apache/cloudstack/pull/925
I believe this can be closed now. https://github.com/apache/cloudstack/pull/1336 and https://github.com/apache/cloudstack/pull/1596 address this problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---