You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Marcus Eagan (Jira)" <ji...@apache.org> on 2020/08/12 06:00:00 UTC
[jira] [Commented] (SOLR-13998) Add thread safety annotation to
classes
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176031#comment-17176031 ]
Marcus Eagan commented on SOLR-13998:
-------------------------------------
Hi [~anshum] I'm working on some janitorial work in the project, and I noticed that you added annotations, but did not implement them. Thus, this title is misleading, and one of the annotations added here has only been used once since you added this PR in December.
I'm curious what you had in mind for the SolrSingleThreaded annotation and why didn't you actually add the annotation anywhere.
Futhermore, would you like help to expand the usage of this class, or do you feel it was hastily added and is a waste of time? I doubt the latter because there should be quite a few obvious uses for this code. However, I will defer to you since you added it. I'm looking through all the PRs of this year to create an inventory of the sort of code and behavior (in code) that I'd hope to steward the community away from. I have a few items so far, but this is one I was not totally sure about because of its sparsity and how long it had been just sitting in the repo (7 months before any usage at all).
I also don't know if the way Solr operates is, we just throw tools into the toolbox and if someone uses them one day, great. If not, someone will one day. Ideally, if we bring something to the project we ourselves would at least use it because we see value in it. I'm an outsider, learning everyday, and hoping to improve the project.
> Add thread safety annotation to classes
> ---------------------------------------
>
> Key: SOLR-13998
> URL: https://issues.apache.org/jira/browse/SOLR-13998
> Project: Solr
> Issue Type: Improvement
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Major
> Fix For: master (9.0), 8.4
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add annotations that can be used to mark classes as thread safe / single threaded in Solr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org