[GitHub] eric-haibin-lin closed pull request #9551: add three pretrained english fasttext embedding

[GitBox <gi...@apache.org>]

eric-haibin-lin closed pull request #9551: add three pretrained english fasttext embedding
URL: https://github.com/apache/incubator-mxnet/pull/9551
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/mxnet/contrib/text/_constants.py b/python/mxnet/contrib/text/_constants.py
index b69e5d966e..77c0d97a9b 100644
--- a/python/mxnet/contrib/text/_constants.py
+++ b/python/mxnet/contrib/text/_constants.py
@@ -341,4 +341,7 @@
      'wiki.diq.vec': '77f3c370d1d77806fafe368cf788af550ff607dd',
      'wiki.zea.vec': 'ee12db26aab3f2b3b2745a298ef414e7aeb5a058',
      'wiki.za.vec': 'e3a0e58bd2e5b1891c71f1f7e37ff71997a20361',
-     'wiki.zu.vec': '4b244b9697a8280e6646842c5fc81bb3a6bc8ec7'}
+     'wiki.zu.vec': '4b244b9697a8280e6646842c5fc81bb3a6bc8ec7',
+     'wiki-news-300d-1M.vec': '11cac9efe6f599e659be182f5766d6fbd5b1cab9',
+     'wiki-news-300d-1M-subword.vec': '717a3058e0ba5ef3cde52c3df0d4f0f60b0a113a',
+     'crawl-300d-2M.vec': '9b556504d099a6c01f3dd76b88775d02cb2f1946'}
diff --git a/tests/python/unittest/test_contrib_text.py b/tests/python/unittest/test_contrib_text.py
index 673f975544..5b897c5dcb 100644
--- a/tests/python/unittest/test_contrib_text.py
+++ b/tests/python/unittest/test_contrib_text.py
@@ -781,14 +781,14 @@ def test_composite_embedding_with_two_embeddings():
 
 def test_get_and_pretrain_file_names():
     assert len(text.embedding.get_pretrained_file_names(
-        embedding_name='fasttext')) == 294
+        embedding_name='fasttext')) == 297
 
     assert len(text.embedding.get_pretrained_file_names(embedding_name='glove')) == 10
 
     reg = text.embedding.get_pretrained_file_names(embedding_name=None)
 
     assert len(reg['glove']) == 10
-    assert len(reg['fasttext']) == 294
+    assert len(reg['fasttext']) == 297
 
     assertRaises(KeyError, text.embedding.get_pretrained_file_names, 'unknown$$')
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services