[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3992: Refine tls_info_s and task_info_s

[GitBox <gi...@apache.org>]

yamt commented on a change in pull request #3992:
URL: https://github.com/apache/incubator-nuttx/pull/3992#discussion_r662033896



##########
File path: sched/group/group_create.c
##########
@@ -138,6 +139,9 @@ int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype)
       return -ENOMEM;
     }
 
+  group->tg_info = (FAR struct task_info_s *)
+    group_zalloc(group, sizeof(struct task_info_s));

Review comment:
       group_malloc looks at the GROUP_FLAG_PRIVILEGED bit, which has not been set yet here. is it intended?
   
   is task_info_s planned to be used for GROUP_FLAG_PRIVILEGED at all?
   
   i'm still not sure how this can work for CONFIG_BUILD_KERNEL. (i'm just asking here because i dunno.)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org