You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Duncan Jones <dj...@apache.org> on 2014/09/11 14:54:28 UTC

[lang] Any objections to implementing LANG-1037?

Hi,

I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
which would add support to StringUtils for joining lists of strings
with a different end separator. The idea is to support use cases such
as:

join(["a", "b", "c"], ", ", " and ") = "a, b and c".

Does anyone have any objections to me implementing this? My Jira issue
lists the three methods I would propose to add.

Kind regards,

Duncan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [lang] Any objections to implementing LANG-1037?

Posted by Benedikt Ritter <br...@apache.org>.
Commons Text could also be a host for the string metrics we have
implemented recently...

2014-09-11 15:58 GMT+02:00 Duncan Jones <du...@wortharead.com>:

> On 11 September 2014 14:49, Gary Gregory <ga...@gmail.com> wrote:
> > On Thu, Sep 11, 2014 at 9:45 AM, sebb <se...@gmail.com> wrote:
> >
> >> On 11 September 2014 14:41, Gary Gregory <ga...@gmail.com>
> wrote:
> >> > To me, it feels out of scope for [lang]. I would never expect this to
> be
> >> in
> >> > java.lang for example.
> >>
> >> Agreed.
> >>
> >
> > I see room in Commons for a [text] component for this kind of work.
> >
> > I would -1 this change and +1 [text].
> >
> > Gary
>
> Ok, this sounds like a better idea. Thanks for the input.
>
> >
> >
> >>
> >> > Gary
> >> >
> >> > On Thu, Sep 11, 2014 at 8:54 AM, Duncan Jones <dj...@apache.org>
> wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
> >> >> which would add support to StringUtils for joining lists of strings
> >> >> with a different end separator. The idea is to support use cases such
> >> >> as:
> >> >>
> >> >> join(["a", "b", "c"], ", ", " and ") = "a, b and c".
> >> >>
> >> >> Does anyone have any objections to me implementing this? My Jira
> issue
> >> >> lists the three methods I would propose to add.
> >> >>
> >> >> Kind regards,
> >> >>
> >> >> Duncan
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> > Java Persistence with Hibernate, Second Edition
> >> > <http://www.manning.com/bauer3/>
> >> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> >> > Spring Batch in Action <http://www.manning.com/templier/>
> >> > Blog: http://garygregory.wordpress.com
> >> > Home: http://garygregory.com/
> >> > Tweet! http://twitter.com/GaryGregory
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Re: [lang] Any objections to implementing LANG-1037?

Posted by Duncan Jones <du...@wortharead.com>.
On 11 September 2014 14:49, Gary Gregory <ga...@gmail.com> wrote:
> On Thu, Sep 11, 2014 at 9:45 AM, sebb <se...@gmail.com> wrote:
>
>> On 11 September 2014 14:41, Gary Gregory <ga...@gmail.com> wrote:
>> > To me, it feels out of scope for [lang]. I would never expect this to be
>> in
>> > java.lang for example.
>>
>> Agreed.
>>
>
> I see room in Commons for a [text] component for this kind of work.
>
> I would -1 this change and +1 [text].
>
> Gary

Ok, this sounds like a better idea. Thanks for the input.

>
>
>>
>> > Gary
>> >
>> > On Thu, Sep 11, 2014 at 8:54 AM, Duncan Jones <dj...@apache.org> wrote:
>> >
>> >> Hi,
>> >>
>> >> I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
>> >> which would add support to StringUtils for joining lists of strings
>> >> with a different end separator. The idea is to support use cases such
>> >> as:
>> >>
>> >> join(["a", "b", "c"], ", ", " and ") = "a, b and c".
>> >>
>> >> Does anyone have any objections to me implementing this? My Jira issue
>> >> lists the three methods I would propose to add.
>> >>
>> >> Kind regards,
>> >>
>> >> Duncan
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > Java Persistence with Hibernate, Second Edition
>> > <http://www.manning.com/bauer3/>
>> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> > Spring Batch in Action <http://www.manning.com/templier/>
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [lang] Any objections to implementing LANG-1037?

Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Sep 11, 2014 at 9:45 AM, sebb <se...@gmail.com> wrote:

> On 11 September 2014 14:41, Gary Gregory <ga...@gmail.com> wrote:
> > To me, it feels out of scope for [lang]. I would never expect this to be
> in
> > java.lang for example.
>
> Agreed.
>

I see room in Commons for a [text] component for this kind of work.

I would -1 this change and +1 [text].

Gary


>
> > Gary
> >
> > On Thu, Sep 11, 2014 at 8:54 AM, Duncan Jones <dj...@apache.org> wrote:
> >
> >> Hi,
> >>
> >> I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
> >> which would add support to StringUtils for joining lists of strings
> >> with a different end separator. The idea is to support use cases such
> >> as:
> >>
> >> join(["a", "b", "c"], ", ", " and ") = "a, b and c".
> >>
> >> Does anyone have any objections to me implementing this? My Jira issue
> >> lists the three methods I would propose to add.
> >>
> >> Kind regards,
> >>
> >> Duncan
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition
> > <http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [lang] Any objections to implementing LANG-1037?

Posted by sebb <se...@gmail.com>.
On 11 September 2014 14:41, Gary Gregory <ga...@gmail.com> wrote:
> To me, it feels out of scope for [lang]. I would never expect this to be in
> java.lang for example.

Agreed.

> Gary
>
> On Thu, Sep 11, 2014 at 8:54 AM, Duncan Jones <dj...@apache.org> wrote:
>
>> Hi,
>>
>> I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
>> which would add support to StringUtils for joining lists of strings
>> with a different end separator. The idea is to support use cases such
>> as:
>>
>> join(["a", "b", "c"], ", ", " and ") = "a, b and c".
>>
>> Does anyone have any objections to me implementing this? My Jira issue
>> lists the three methods I would propose to add.
>>
>> Kind regards,
>>
>> Duncan
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [lang] Any objections to implementing LANG-1037?

Posted by Gary Gregory <ga...@gmail.com>.
To me, it feels out of scope for [lang]. I would never expect this to be in
java.lang for example.

Gary

On Thu, Sep 11, 2014 at 8:54 AM, Duncan Jones <dj...@apache.org> wrote:

> Hi,
>
> I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
> which would add support to StringUtils for joining lists of strings
> with a different end separator. The idea is to support use cases such
> as:
>
> join(["a", "b", "c"], ", ", " and ") = "a, b and c".
>
> Does anyone have any objections to me implementing this? My Jira issue
> lists the three methods I would propose to add.
>
> Kind regards,
>
> Duncan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [lang] Any objections to implementing LANG-1037?

Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
Hi Duncan, 

I have already implemented such method before, not sure if I wrote any tests to it though :)

+1 looks useful to me

Bruno


>________________________________
> From: Duncan Jones <dj...@apache.org>
>To: Commons Developers List <de...@commons.apache.org> 
>Sent: Thursday, September 11, 2014 9:54 AM
>Subject: [lang] Any objections to implementing LANG-1037?
> 
>
>Hi,
>
>I raised https://issues.apache.org/jira/browse/LANG-1037 recently,
>which would add support to StringUtils for joining lists of strings
>with a different end separator. The idea is to support use cases such
>as:
>
>join(["a", "b", "c"], ", ", " and ") = "a, b and c".
>
>Does anyone have any objections to me implementing this? My Jira issue
>lists the three methods I would propose to add.
>
>Kind regards,
>
>Duncan
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>