[GitHub] [spark] attilapiros commented on a change in pull request #31829: [WIP][SPARK-34736][K8S][TESTS] Kubernetes and Minikube version upgrade for integration tests

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #31829:
URL: https://github.com/apache/spark/pull/31829#discussion_r609529325



##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -176,4 +180,4 @@ properties+=(
   -Dlog4j.logger.org.apache.spark=DEBUG
 )
 
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}

Review comment:
       The `install` phase is after `integration-test`, see default lifecycle at the [maven doc](https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html):
   
   
   Phase | Description
   -- | --
   ... | ...
   package | take the compiled code and package it in its distributable format, such as a JAR.
   pre-integration-test | perform actions required before integration tests are executed. This may involve things such as setting up the required environment.
   **integration-test** | process and deploy the package if necessary into an environment where integration tests can be run.
   post-integration-test | perform actions required after integration tests have been executed. This may including cleaning up the environment.
   verify | run any checks to verify the package is valid and meets quality criteria.
   **install** | install the package into the local repository, for use as a dependency in other projects locally.
   ...|...
   
   
   With `install` the local repo will be updated with the fresh jars and in case of `--skip-building-dependencies` the build will reuse those.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org