You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/21 06:46:20 UTC

[GitHub] [spark] HeartSaVioR commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

HeartSaVioR commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.
URL: https://github.com/apache/spark/pull/24647#issuecomment-494261818
 
 
   > I'm not sure about the contract here, whether providers are required to be stateless. If they're not then this would be a problem for another instance that has state, or if these acquire state at some point.
   
   While agreeing this point, extracting these calls into method would help readability. I'm not sure Spark community is open to allow minor refactor patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org