You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/06/17 22:30:29 UTC
Review Request 35573: DRILL-3304: improve
org.apache.drill.exec.expr.TypeHelper error messages when
UnsupportedOprationException is thrown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/
-----------------------------------------------------------
Review request for drill and Hanifi Gunes.
Bugs: DRILL-3304
https://issues.apache.org/jira/browse/DRILL-3304
Repository: drill-git
Description
-------
Made some changes to TypeHelper template to display the failed "operation" and minor-type + data-mode when an UnsupportedOperationException is thrown
Diffs
-----
common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67
exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
Diff: https://reviews.apache.org/r/35573/diff/
Testing
-------
all unit tests are passing along with functional/tpch100
Thanks,
abdelhakim deneche
Re: Review Request 35573: DRILL-3304: improve
org.apache.drill.exec.expr.TypeHelper error messages when
UnsupportedOprationException is thrown
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/#review89028
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On June 18, 2015, 3:56 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35573/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 3:56 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3304
> https://issues.apache.org/jira/browse/DRILL-3304
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made some changes to TypeHelper template to display the failed "operation" and minor-type + data-mode when an UnsupportedOperationException is thrown
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67
> exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
>
> Diff: https://reviews.apache.org/r/35573/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional/tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35573: DRILL-3304: improve
org.apache.drill.exec.expr.TypeHelper error messages when
UnsupportedOprationException is thrown
Posted by abdelhakim deneche <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/
-----------------------------------------------------------
(Updated June 18, 2015, 3:56 p.m.)
Review request for drill and Hanifi Gunes.
Changes
-------
used buildErrorMessage() in more places, not all of them though, I left the ones that give a more meaningful error message
Bugs: DRILL-3304
https://issues.apache.org/jira/browse/DRILL-3304
Repository: drill-git
Description
-------
Made some changes to TypeHelper template to display the failed "operation" and minor-type + data-mode when an UnsupportedOperationException is thrown
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67
exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
Diff: https://reviews.apache.org/r/35573/diff/
Testing
-------
all unit tests are passing along with functional/tpch100
Thanks,
abdelhakim deneche
Re: Review Request 35573: DRILL-3304: improve
org.apache.drill.exec.expr.TypeHelper error messages when
UnsupportedOprationException is thrown
Posted by abdelhakim deneche <ad...@gmail.com>.
> On June 17, 2015, 9:54 p.m., Hanifi Gunes wrote:
> > exec/java-exec/src/main/codegen/templates/TypeHelper.java, line 474
> > <https://reviews.apache.org/r/35573/diff/1/?file=986539#file986539line474>
> >
> > Would you use buildErrMsg here as well?
I originally didn't want to change these as they already display a "good enough" error message. I will make the change and update the patch
- abdelhakim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/#review88285
-----------------------------------------------------------
On June 17, 2015, 8:30 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35573/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 8:30 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3304
> https://issues.apache.org/jira/browse/DRILL-3304
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made some changes to TypeHelper template to display the failed "operation" and minor-type + data-mode when an UnsupportedOperationException is thrown
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67
> exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
>
> Diff: https://reviews.apache.org/r/35573/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional/tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
Re: Review Request 35573: DRILL-3304: improve
org.apache.drill.exec.expr.TypeHelper error messages when
UnsupportedOprationException is thrown
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35573/#review88285
-----------------------------------------------------------
Ship it!
Ship it once comments are addressed.
exec/java-exec/src/main/codegen/templates/TypeHelper.java (line 471)
<https://reviews.apache.org/r/35573/#comment140728>
Would you use buildErrMsg here as well?
exec/java-exec/src/main/codegen/templates/TypeHelper.java (line 494)
<https://reviews.apache.org/r/35573/#comment140729>
as well as all others that follow
- Hanifi Gunes
On June 17, 2015, 8:30 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35573/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 8:30 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Bugs: DRILL-3304
> https://issues.apache.org/jira/browse/DRILL-3304
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made some changes to TypeHelper template to display the failed "operation" and minor-type + data-mode when an UnsupportedOperationException is thrown
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/exceptions/ErrorHelper.java 5dd9b67
> exec/java-exec/src/main/codegen/templates/TypeHelper.java ad818bd
>
> Diff: https://reviews.apache.org/r/35573/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional/tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>