You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juddi.apache.org by Steve Viens <sv...@attbi.com> on 2003/05/08 23:22:03 UTC

[juddi-Developers] RE: [juddi-Users] PublisherAssertionHandler parse bug

Andy, I've checked the fix into CVS already but an entry into the bug
tracker by you (the source) would be appreciated.

Good catch.

Steve

Steve Viens
jUDDI Developer
sviens@users.sourceforge.net
http://www.juddi.org
 

-----Original Message-----
From: juddi-users-admin@lists.sourceforge.net
[mailto:juddi-users-admin@lists.sourceforge.net] On Behalf Of Steve
Viens
Sent: Thursday, May 08, 2003 11:45 PM
To: 'Andy Cutright'; 'juddi-users'
Subject: RE: [juddi-Users] PublisherAssertionHandler parse bug


Andy, this is definitely a bug. Would you mind entering it into jUDDI's
bug tracker?

 https://sourceforge.net/tracker/?func=add&group_id=42875&atid=434422

Steve

Steve Viens
jUDDI Developer
sviens@users.sourceforge.net
http://www.juddi.org
 
-----Original Message-----
From: juddi-users-admin@lists.sourceforge.net
[mailto:juddi-users-admin@lists.sourceforge.net] On Behalf Of Andy
Cutright
Sent: Thursday, May 08, 2003 2:17 PM
To: 'juddi-users'
Subject: [juddi-Users] PublisherAssertionHandler parse bug


hi,

i'm not sure what diff format the project is using. also, i'm not 
certain this is a bug. using UDDI4J to exersize the UDDI 
add_publisherAssertion interface, 
org.juddi.parsers.PublisherAssertionHandler does not marshal the fromKey

and toKey elements (?) out of the SOAP body. my reading of the UDDI 2.x 
spec (4.4.1.1) is the fromKey and toKey elements are not attributes of 
the of the publisherAssertion element, but are child elements.

please excuse my loose use of the term element; my skill with XML,SGML, 
etc. is limited. i'm trying to master the definitions.

basically, the jUDDI java code assumes this structure i think:

<add_publisherAssertions generic="2.0" xmlns="urn:uddi-org:api_v2">
<authInfo>authToken:66CF2BE0-817C-11D7-ABE0-B938A488CC1E</authInfo>
<publisherAssertion fromKey="67275E00-817C-11D7-9E00-A5BC371098C8" 
toKey="A8743420-817A-11D7-B420-E6FD9DD956B7">
<keyedReference tModelKey="UUID:807A2C6A-EE22-470D-ADC7-E0424A337C03" 
keyName="Holding Company" keyValue="peer-peer"/> </publisherAssertion>
</add_publisherAssertions>

whereas the UDDI4J is sending :

<add_publisherAssertions generic="2.0" 
xmlns="urn:uddi-org:api_v2"><authInfo>authToken:66CF2BE0-817C-11D7-ABE0-
B938A488CC1E</authInfo><publisherAssertion><fromKey>67275E00-817C-11D7-9
E00-A5BC371098C8</fromKey><toKey>A8743420-817A-11D7-B420-E6FD9DD956B7</t
oKey><keyedReference
tModelKey="UUID:807A2C6A-EE22-470D-ADC7-E0424A337C03" keyName="Holding 
Company" 
keyValue="peer-peer"/></publisherAssertion></add_publisherAssertions>

this is my diff to handle that issue. i'm not finished with the work, 
since i've yet to get the example to work fully. this is just a starting

point for discussion. we use cleartool for source control, so that's the

diff format. if a standard format is preferred, let me know.

********************************
<<< file 1: 
/WEB\src\juddi\WEB-INF\src\org\juddi\parser\PublisherAssertionHandler.ja
va@@\main\acutright_bes_dev\1
 >>> file 2: PublisherAssertionHandler.java
********************************
-----[43-46 changed to 43-78]-----
<
<     // Attributes
<     obj.setFromKey(element.getAttribute("fromKey"));
<     obj.setToKey(element.getAttribute("toKey"));
---
 >     // Attributes
 >    if (element.hasChildNodes()) {
 >      System.out.println("haschildNodes");
 >    }
 >     nodeList = getChildElementsByTagName(element,"fromKey");
 >    // shouldn't need to iterate, should only be one..
 >    if (nodeList.size() > 0 ) {
 >      for (int index = 0; index < nodeList.size(); index++) {
 >        Element child = (Element)nodeList.elementAt(index);
 >        if  (child.getNodeType() == Element.TEXT_NODE || 
child.getNodeType() == Element.CDATA_SECTION_NODE) {
 >          obj.setFromKey(child.getNodeValue());
 >        }
 >        else if (child.hasChildNodes()) {
 >          if (child.getFirstChild().getNodeType() == Element.TEXT_NODE
) {
 >            obj.setFromKey(child.getFirstChild().getNodeValue());
 >          }
 >        }
 >      }
 >    }
 > //  obj.setFromKey(element.getAttribute("fromKey"));
 > //     obj.setToKey(element.getAttribute("toKey"));
 >    nodeList = getChildElementsByTagName(element,"toKey");
 >    // shouldn't need to iterate, should only be one..
 >    if (nodeList.size() > 0 ) {
 >      for (int index = 0; index < nodeList.size(); index++) {
 >        Element child = (Element)nodeList.elementAt(index);
 >        if  (child.getNodeType() == Element.TEXT_NODE || 
child.getNodeType() == Element.CDATA_SECTION_NODE) {
 >          obj.setToKey(child.getFirstChild().getNodeValue());
 >        }
 >        else if (child.hasChildNodes()) {
 >          if (child.getFirstChild().getNodeType() == Element.TEXT_NODE
) {
 >            obj.setToKey(child.getNodeValue());
 >          }
 >        }
 >      }
 >    }





-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com

_______________________________________________
juddi-users mailing list
juddi-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/juddi-users




-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com

_______________________________________________
juddi-users mailing list
juddi-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/juddi-users





[juddi-Developers] Re: [juddi-Users] PublisherAssertionHandler parse bug

Posted by Andy Cutright <ac...@borland.com>.
yeah, i'm actually going to provide another cleaner fix. i wasn't sure 
this was a bug, which is why i ddn't file a bug. i will file a bug now.

it looks like there are other problems in that file. the main() driver 
makes the keys attributes of an element too. since i haven't run that 
code path, i'm not yet filing a bug.

cheers,
andy

Steve Viens wrote:

>Andy, I've checked the fix into CVS already but an entry into the bug
>tracker by you (the source) would be appreciated.
>
>Good catch.
>
>Steve
>
>Steve Viens
>jUDDI Developer
>sviens@users.sourceforge.net
>http://www.juddi.org
> 
>
>-----Original Message-----
>From: juddi-users-admin@lists.sourceforge.net
>[mailto:juddi-users-admin@lists.sourceforge.net] On Behalf Of Steve
>Viens
>Sent: Thursday, May 08, 2003 11:45 PM
>To: 'Andy Cutright'; 'juddi-users'
>Subject: RE: [juddi-Users] PublisherAssertionHandler parse bug
>
>
>Andy, this is definitely a bug. Would you mind entering it into jUDDI's
>bug tracker?
>
> https://sourceforge.net/tracker/?func=add&group_id=42875&atid=434422
>
>Steve
>
>Steve Viens
>jUDDI Developer
>sviens@users.sourceforge.net
>http://www.juddi.org
> 
>-----Original Message-----
>From: juddi-users-admin@lists.sourceforge.net
>[mailto:juddi-users-admin@lists.sourceforge.net] On Behalf Of Andy
>Cutright
>Sent: Thursday, May 08, 2003 2:17 PM
>To: 'juddi-users'
>Subject: [juddi-Users] PublisherAssertionHandler parse bug
>
>
>hi,
>
>i'm not sure what diff format the project is using. also, i'm not 
>certain this is a bug. using UDDI4J to exersize the UDDI 
>add_publisherAssertion interface, 
>org.juddi.parsers.PublisherAssertionHandler does not marshal the fromKey
>
>and toKey elements (?) out of the SOAP body. my reading of the UDDI 2.x 
>spec (4.4.1.1) is the fromKey and toKey elements are not attributes of 
>the of the publisherAssertion element, but are child elements.
>
>please excuse my loose use of the term element; my skill with XML,SGML, 
>etc. is limited. i'm trying to master the definitions.
>
>basically, the jUDDI java code assumes this structure i think:
>
><add_publisherAssertions generic="2.0" xmlns="urn:uddi-org:api_v2">
><authInfo>authToken:66CF2BE0-817C-11D7-ABE0-B938A488CC1E</authInfo>
><publisherAssertion fromKey="67275E00-817C-11D7-9E00-A5BC371098C8" 
>toKey="A8743420-817A-11D7-B420-E6FD9DD956B7">
><keyedReference tModelKey="UUID:807A2C6A-EE22-470D-ADC7-E0424A337C03" 
>keyName="Holding Company" keyValue="peer-peer"/> </publisherAssertion>
></add_publisherAssertions>
>
>whereas the UDDI4J is sending :
>
><add_publisherAssertions generic="2.0" 
>xmlns="urn:uddi-org:api_v2"><authInfo>authToken:66CF2BE0-817C-11D7-ABE0-
>B938A488CC1E</authInfo><publisherAssertion><fromKey>67275E00-817C-11D7-9
>E00-A5BC371098C8</fromKey><toKey>A8743420-817A-11D7-B420-E6FD9DD956B7</t
>oKey><keyedReference
>tModelKey="UUID:807A2C6A-EE22-470D-ADC7-E0424A337C03" keyName="Holding 
>Company" 
>keyValue="peer-peer"/></publisherAssertion></add_publisherAssertions>
>
>this is my diff to handle that issue. i'm not finished with the work, 
>since i've yet to get the example to work fully. this is just a starting
>
>point for discussion. we use cleartool for source control, so that's the
>
>diff format. if a standard format is preferred, let me know.
>
>********************************
><<< file 1: 
>/WEB\src\juddi\WEB-INF\src\org\juddi\parser\PublisherAssertionHandler.ja
>va@@\main\acutright_bes_dev\1
> >>> file 2: PublisherAssertionHandler.java
>********************************
>-----[43-46 changed to 43-78]-----
><
><     // Attributes
><     obj.setFromKey(element.getAttribute("fromKey"));
><     obj.setToKey(element.getAttribute("toKey"));
>---
> >     // Attributes
> >    if (element.hasChildNodes()) {
> >      System.out.println("haschildNodes");
> >    }
> >     nodeList = getChildElementsByTagName(element,"fromKey");
> >    // shouldn't need to iterate, should only be one..
> >    if (nodeList.size() > 0 ) {
> >      for (int index = 0; index < nodeList.size(); index++) {
> >        Element child = (Element)nodeList.elementAt(index);
> >        if  (child.getNodeType() == Element.TEXT_NODE || 
>child.getNodeType() == Element.CDATA_SECTION_NODE) {
> >          obj.setFromKey(child.getNodeValue());
> >        }
> >        else if (child.hasChildNodes()) {
> >          if (child.getFirstChild().getNodeType() == Element.TEXT_NODE
>) {
> >            obj.setFromKey(child.getFirstChild().getNodeValue());
> >          }
> >        }
> >      }
> >    }
> > //  obj.setFromKey(element.getAttribute("fromKey"));
> > //     obj.setToKey(element.getAttribute("toKey"));
> >    nodeList = getChildElementsByTagName(element,"toKey");
> >    // shouldn't need to iterate, should only be one..
> >    if (nodeList.size() > 0 ) {
> >      for (int index = 0; index < nodeList.size(); index++) {
> >        Element child = (Element)nodeList.elementAt(index);
> >        if  (child.getNodeType() == Element.TEXT_NODE || 
>child.getNodeType() == Element.CDATA_SECTION_NODE) {
> >          obj.setToKey(child.getFirstChild().getNodeValue());
> >        }
> >        else if (child.hasChildNodes()) {
> >          if (child.getFirstChild().getNodeType() == Element.TEXT_NODE
>) {
> >            obj.setToKey(child.getNodeValue());
> >          }
> >        }
> >      }
> >    }
>
>
>
>
>
>-------------------------------------------------------
>Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
>The only event dedicated to issues related to Linux enterprise solutions
>www.enterpriselinuxforum.com
>
>_______________________________________________
>juddi-users mailing list
>juddi-users@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/juddi-users
>
>
>
>
>-------------------------------------------------------
>Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
>The only event dedicated to issues related to Linux enterprise solutions
>www.enterpriselinuxforum.com
>
>_______________________________________________
>juddi-users mailing list
>juddi-users@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/juddi-users
>
>
>  
>