[GitHub] activemq-artemis pull request #2069: NO-JIRA Adding checks for spawned serve...

[clebertsuconic <gi...@git.apache.org>]

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2069

    NO-JIRA Adding checks for spawned servers on the testsuite

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis spawn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2069.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2069
    
----
commit 9ee073fb26629b2abc139da0ff44d07e08fdda76
Author: Clebert Suconic <cl...@...>
Date:   2018-05-03T01:04:29Z

    NO-JIRA Adding checks for spawned servers on the testsuite

----


---

[GitHub] activemq-artemis issue #2069: NO-JIRA Adding checks for spawned servers on t...

[clebertsuconic <gi...@git.apache.org>]

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2069
  
    Yeah. It’s a typo. Will fix it. 


---

[GitHub] activemq-artemis pull request #2069: NO-JIRA Adding checks for spawned serve...

[jbertram <gi...@git.apache.org>]

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2069#discussion_r185966600
  
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedTestBased.java ---
    @@ -0,0 +1,26 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.activemq.artemis.tests.util;
    +
    +import org.junit.Rule;
    +
    +public class SpawnedTestBased extends ActiveMQTestBase {
    --- End diff --
    
    A bit of a nit-pick, but shouldn't this be `SpawnedTestBase` (i.e. no "d" on the end)?


---

[GitHub] activemq-artemis pull request #2069: NO-JIRA Adding checks for spawned serve...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2069


---