You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/02/14 17:14:46 UTC

[Impala-ASF-CR] IMPALA-4920: custom cluster tests: fix generation of py.test options

Hello David Knupp, Jim Apple,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5978

to look at the new patch set (#2).

Change subject: IMPALA-4920: custom cluster tests: fix generation of py.test options
......................................................................

IMPALA-4920: custom cluster tests: fix generation of py.test options

This patch fixes a problem in which unnecessary quote characters were
part of some impala-py.test arguments for running the custom cluster
tests. The bug was causing py.test metadata files as described by the
py.test options --junit-xml and --result-log to end up outside the
intended path for such artifacts. By removing the unnecessary escaped
quotes, custom cluster py.test metadata artifacts will now be in the
proper location. I doubly made sure it was safe to remove these quotes
by adding a space in the RESULTS_DIR. The space isn't expanded but is
instead properly treated as part of RESULTS_DIR.

Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6
---
M tests/run-custom-cluster-tests.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/5978/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>