You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yu-iskw <gi...@git.apache.org> on 2015/03/04 03:46:34 UTC
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/4883
[SPARK-6150][mllib] Validate indices before constructing a SparseVector
We should validate indices for arguments before constructing a SparseVector.
https://issues.apache.org/jira/browse/SPARK-6150
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/spark branch-1.3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4883
----
commit 662941fe26449a6977501ba51b5cb2a6e85c2593
Author: Yu Ishikawa <yu...@gmail.com>
Date: 2015-03-04T02:43:40Z
[SPARK-6150][mllib] Validate indices before constructing a SparseVector
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4883#issuecomment-77098581
This was already discussed in SPARK-4956. It increases the complexity from O(1) to O(nnz), which will hurt the performance. Do you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw closed the pull request at:
https://github.com/apache/spark/pull/4883
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4883#issuecomment-77095744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28250/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4883#issuecomment-77095734
[Test build #28250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28250/consoleFull) for PR 4883 at commit [`662941f`](https://github.com/apache/spark/commit/662941fe26449a6977501ba51b5cb2a6e85c2593).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/4883#issuecomment-77101399
@mengxr I'm sorry. I didn't know that. I close this PR. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6150][mllib] Validate indices before co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4883#issuecomment-77087652
[Test build #28250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28250/consoleFull) for PR 4883 at commit [`662941f`](https://github.com/apache/spark/commit/662941fe26449a6977501ba51b5cb2a6e85c2593).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org