[GitHub] [hadoop] elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool
URL: https://github.com/apache/hadoop/pull/1255#discussion_r316019985
 
 

 ##########
 File path: hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/List.java
 ##########
 @@ -0,0 +1,38 @@
+package org.apache.hadoop.ozone.insight;
+
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+
+import picocli.CommandLine;
+
+import java.util.Map;
+import java.util.concurrent.Callable;
+
+/**
+ * Subcommand to list of the available insight points.
+ */
+@CommandLine.Command(
+    name = "list",
+    description = "Show available insight points.",
+    mixinStandardHelpOptions = true,
+    versionProvider = HddsVersionProvider.class)
+public class List extends BaseInsightSubcommand implements Callable<Void> {
+
+  @CommandLine.Parameters(defaultValue = "")
+  private String selection;
 
 Review comment:
   Yes, originally I used a tree like insight point structure and it helped to list only a subtree. When I switched to use a flat structure it was no longer supported.
   
   I fixed it and restored this functionality. `ozone insight log scm` can list the scm related insight points from now...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org