[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2636: heron-merge

[GitBox <gi...@apache.org>]

lucky-chen commented on a change in pull request #2636: heron-merge
URL: https://github.com/apache/incubator-weex/pull/2636#discussion_r299337784
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##########
 @@ -1006,19 +1006,6 @@ public void onCallback(Object result) {
     }
   }
 
-  public void loadJsBundleInPreInitMode(final String instanceId, final String js){
-    post(new Runnable() {
-      @Override
-      public void run() {
-        invokeExecJSOnInstance(instanceId, js, -1);
-        WXSDKInstance instance = WXSDKManager.getInstance().getAllInstanceMap().get(instanceId);
-        if (null != instance && instance.isPreInitMode()){
-          instance.getApmForInstance().onStage(WXInstanceApm.KEY_PAGE_STAGES_LOAD_BUNDLE_END);
-        }
-      }
-    });
-  }
-
 
 Review comment:
   shouldn't delete, use for preinit 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services