You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/28 04:51:23 UTC

[GitHub] [trafficcontrol] srijeet0406 commented on pull request #5450: When adding multiple interfaces on a server, a router host and router description should also be created per interface

srijeet0406 commented on pull request #5450:
URL: https://github.com/apache/trafficcontrol/pull/5450#issuecomment-768797916


   > Everything seems to be working fine. There are, unfortunately, more docs problems, though. These ones didn't get caught earlier because they're in those extra v4 copies you just made:
   > 
   > * `cache_stats-get-request-example`
   > * `deliveryservice_stats-get-request-example`
   > * `response-structure`
   > 
   > All appear in the v3 and v4 docs, making them duplicates. They aren't prefixed with `to-api` which is probably why they didn't get caught in the find/replace.
   > 
   > Also, in `v3/deliveryserviceserver.rst` line 58 this label doesn't exist: `to-api-v3-response-structure`. I think it's supposed to be just `to-api-response-structure` - which is fine because it references the "Response Structure" section of the _main_ API docs page and therefore isn't versioned.
   
   Good eye, I've fixed them now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org