You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2024/11/08 18:44:06 UTC
[PR] Don't pin to latest tag [beam]
damccorm opened a new pull request, #33058:
URL: https://github.com/apache/beam/pull/33058
Its usually better to suggest a custom tag to avoid overwriting containers from old jobs
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't pin to latest tag [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33058:
URL: https://github.com/apache/beam/pull/33058#issuecomment-2465520937
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't pin to latest tag [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #33058:
URL: https://github.com/apache/beam/pull/33058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't pin to latest tag [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #33058:
URL: https://github.com/apache/beam/pull/33058#issuecomment-2465519079
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't pin to latest tag [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #33058:
URL: https://github.com/apache/beam/pull/33058#discussion_r1834930504
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -373,7 +373,7 @@
"First, define the pipeline options that you want to use to launch the Dataflow job. Before running the next cell, replace the following variables:\n",
"\n",
"- `<BUCKET_NAME>`: the name of a valid [Google Cloud Storage](https://cloud.google.com/storage?e=48754805&hl=en) bucket. Don't include a `gs://` prefix or trailing slashes.\n",
- "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry repository that you used in the previous step. Don't include the `latest` tag, because this tag is automatically appended as part of the cell.\n",
+ "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry repository that you used in the previous step. \n",
Review Comment:
Thanks, missed this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't pin to latest tag [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #33058:
URL: https://github.com/apache/beam/pull/33058#discussion_r1834898317
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -428,7 +428,7 @@
"# Choose a machine type compatible with GPU type\n",
"options.view_as(WorkerOptions).machine_type = \"n1-standard-4\"\n",
"\n",
- "options.view_as(WorkerOptions).worker_harness_container_image = '%s:latest' % CONTAINER_LOCATION"
+ "options.view_as(WorkerOptions).worker_harness_container_image = CONTAINER_LOCATION"
Review Comment:
```suggestion
"options.view_as(WorkerOptions).sdk_container_image = CONTAINER_IMAGE"
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -396,7 +396,7 @@
"options = PipelineOptions()\n",
"\n",
"BUCKET_NAME = '<BUCKET_NAME>' # Replace with your bucket name.\n",
- "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your container location (<your_gar_repository> from the previous step)\n",
+ "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your container location (<REPOSITORY_NAME>:<TAG> from the previous step)\n",
Review Comment:
```suggestion
"CONTAINER_IMAGE = '<REPOSITORY_NAME>:<TAG>' # Replace with the image repository and tag from the previous step.\n",
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -396,7 +396,7 @@
"options = PipelineOptions()\n",
"\n",
"BUCKET_NAME = '<BUCKET_NAME>' # Replace with your bucket name.\n",
- "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your container location (<your_gar_repository> from the previous step)\n",
+ "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your container location (<REPOSITORY_NAME>:<TAG> from the previous step)\n",
Review Comment:
One option is to also define this earlier.
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -352,11 +352,11 @@
"\n",
"1. In the sidebar, click **Files** to open the **Files** pane.\n",
"2. In an environment with Docker installed, download the file **VllmDockerfile** file to an empty folder.\n",
- "3. Run the following commands. Replace `<REPOSITORY_NAME>` with a valid [Artifact Registry](https://cloud.google.com/artifact-registry/docs/overview) repository.\n",
+ "3. Run the following commands. Replace `<REPOSITORY_NAME>:<TAG>` with a valid [Artifact Registry](https://cloud.google.com/artifact-registry/docs/overview) repository and tag.\n",
Review Comment:
```suggestion
"3. Run the following commands. Replace `<REPOSITORY_NAME>:<TAG>` with a valid [Artifact Registry](https://cloud.google.com/artifact-registry/docs/overview) repository and tag.\n",
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -373,7 +373,7 @@
"First, define the pipeline options that you want to use to launch the Dataflow job. Before running the next cell, replace the following variables:\n",
"\n",
"- `<BUCKET_NAME>`: the name of a valid [Google Cloud Storage](https://cloud.google.com/storage?e=48754805&hl=en) bucket. Don't include a `gs://` prefix or trailing slashes.\n",
- "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry repository that you used in the previous step. Don't include the `latest` tag, because this tag is automatically appended as part of the cell.\n",
+ "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry repository that you used in the previous step. \n",
Review Comment:
```suggestion
"- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry repository that you used in the previous step. \n",
"- `<IMAGE_TAG>`: image tag used in the previous step. Prefer a versioned tag or SHA instead of :latest tag or mutable tags.\n",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org