You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "yuweizzz (via GitHub)" <gi...@apache.org> on 2023/10/17 09:38:30 UTC
[PR] chore: change the base image to distroless [apisix-ingress-controller]
yuweizzz opened a new pull request, #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [ ] Documentation
- [x] Refactor
- [ ] Chore
- [ ] CI/CD or Tests
### What this PR does / why we need it:
Related: #1934
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "yuweizzz (via GitHub)" <gi...@apache.org>.
yuweizzz commented on PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#issuecomment-1767914463
Got it, I will try to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot merged PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "yuweizzz (via GitHub)" <gi...@apache.org>.
yuweizzz commented on PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#issuecomment-1767527790
I think this may cause by static image doesn't contains shell, can we try debug image and fix ci failed first ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on code in PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#discussion_r1367257463
##########
Dockerfile:
##########
@@ -31,15 +27,11 @@ RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w GOPROXY=https://goproxy.cn,
COPY . .
RUN --mount=type=cache,target=/root/.cache/go-build make build
-FROM centos:centos7
+FROM gcr.io/distroless/static-debian12:debug
Review Comment:
`debug`? Why not use `nonroot`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on code in PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#discussion_r1367277566
##########
Dockerfile:
##########
@@ -31,15 +27,11 @@ RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w GOPROXY=https://goproxy.cn,
COPY . .
RUN --mount=type=cache,target=/root/.cache/go-build make build
-FROM centos:centos7
+FROM gcr.io/distroless/static-debian12:debug
Review Comment:
To enable successful execution of E2E CI, passing the `debug` parameter during E2E image build can be done, but the default should be `nonroot`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "yuweizzz (via GitHub)" <gi...@apache.org>.
yuweizzz commented on code in PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#discussion_r1367587285
##########
Dockerfile:
##########
@@ -31,15 +27,11 @@ RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w GOPROXY=https://goproxy.cn,
COPY . .
RUN --mount=type=cache,target=/root/.cache/go-build make build
-FROM centos:centos7
+FROM gcr.io/distroless/static-debian12:debug
Review Comment:
you are right, let me adjust it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "lingsamuel (via GitHub)" <gi...@apache.org>.
lingsamuel commented on PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#issuecomment-1767903722
CI failed again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: change the base image to distroless [apisix-ingress-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2011:
URL: https://github.com/apache/apisix-ingress-controller/pull/2011#issuecomment-1766186359
## [Codecov](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/2011?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2011](https://app.codecov.io/gh/apache/apisix-ingress-controller/pull/2011?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c0cd18) into [master](https://app.codecov.io/gh/apache/apisix-ingress-controller/commit/5177b5fe6a3976a71484d06575bd31a910c48176?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5177b5f) will **not change** coverage.
> Report is 3 commits behind head on master.
> The diff coverage is `n/a`.
> :exclamation: Current head 3c0cd18 differs from pull request most recent head b7184a0. Consider uploading reports for the commit b7184a0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2011 +/- ##
=======================================
Coverage 36.81% 36.81%
=======================================
Files 93 93
Lines 7863 7863
=======================================
Hits 2895 2895
Misses 4580 4580
Partials 388 388
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org