You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2023/12/20 08:15:42 UTC
[PR] [core] remove Dynamic Bucket Row [incubator-paimon]
leaves12138 opened a new pull request, #2541:
URL: https://github.com/apache/incubator-paimon/pull/2541
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Remove DynamicBucketRow, add another interfacre `write(row, bucket)` in replace
Reason:
* DynamicBucketRow wrapper now is a per-record action, it has a poor performance, per-record `new DynamicBucketRow(row)` will slow down inserting
* DynamicBucketRow is an intrusion of current InternalRow system. The sub-class of InternalRow should not hide information itself. After serialize and deserialize, the bucket information in DynamicBucketRow will lose.
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] remove Dynamic Bucket Row [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2541:
URL: https://github.com/apache/incubator-paimon/pull/2541#discussion_r1432448058
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/TableWriteImpl.java:
##########
@@ -139,6 +150,15 @@ private SinkRecord toSinkRecord(InternalRow row) {
row);
}
+ private SinkRecord toSinkRecord(InternalRow row, int bucket) {
Review Comment:
`private SinkRecord toSinkRecord(InternalRow row)` should use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] remove Dynamic Bucket Row [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #2541:
URL: https://github.com/apache/incubator-paimon/pull/2541#discussion_r1432448058
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/TableWriteImpl.java:
##########
@@ -139,6 +150,15 @@ private SinkRecord toSinkRecord(InternalRow row) {
row);
}
+ private SinkRecord toSinkRecord(InternalRow row, int bucket) {
Review Comment:
`private SinkRecord toSinkRecord(InternalRow row)` should use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] remove Dynamic Bucket Row [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2541:
URL: https://github.com/apache/incubator-paimon/pull/2541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org