You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2017/02/20 05:43:46 UTC
Review Request 56838: GEODE-2029 Trimming unused parts of Lucene from
binary NOTICE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56838/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Mark Bretl.
Repository: geode
Description
-------
The lucene section of our NOTICE included some elements for jars that we
are not redistributing like some language specific analyzers and
stemmers. To reduce the burden on downstream projects, removing these
components from our NOTICE.
I did leave in the section on servlet-api, which appeared to come from
lucene, but in fact we do include servlet-api.jar in our binary
distribution.
Here are the specific notes on where stuff in the notice comes from
icu4j - this is in lucene-analyzers-icu.jar (we don't include) WordBreakTestUnicode... is part of this.
junit - we're not distributing this jar
stempel - this is in lucene-analyzers-stempel (we don't include)
smartcn - this is in lucene-analyzers-smartcn (we don't include)
kuromoji - this in in lucene-analyzers-kuromoji (we don't include)
Morfologik - this in in lucene-analyzers-morfologik (we don't include)
Diffs
-----
geode-assembly/src/main/dist/NOTICE 2fccd7a507426830c751d3628e4fd983d68aef03
Diff: https://reviews.apache.org/r/56838/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 56838: GEODE-2029 Trimming unused parts of Lucene
from binary NOTICE
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56838/#review166095
-----------------------------------------------------------
Ship it!
3> !!!!
Nice job Dan.
- Anthony Baker
On Feb. 20, 2017, 5:43 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56838/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 5:43 a.m.)
>
>
> Review request for geode, Anthony Baker and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The lucene section of our NOTICE included some elements for jars that we
> are not redistributing like some language specific analyzers and
> stemmers. To reduce the burden on downstream projects, removing these
> components from our NOTICE.
>
> I did leave in the section on servlet-api, which appeared to come from
> lucene, but in fact we do include servlet-api.jar in our binary
> distribution.
>
> Here are the specific notes on where stuff in the notice comes from
>
> icu4j - this is in lucene-analyzers-icu.jar (we don't include) WordBreakTestUnicode... is part of this.
> junit - we're not distributing this jar
> stempel - this is in lucene-analyzers-stempel (we don't include)
> smartcn - this is in lucene-analyzers-smartcn (we don't include)
> kuromoji - this in in lucene-analyzers-kuromoji (we don't include)
> Morfologik - this in in lucene-analyzers-morfologik (we don't include)
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/NOTICE 2fccd7a507426830c751d3628e4fd983d68aef03
>
> Diff: https://reviews.apache.org/r/56838/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>